From unknown Tue Jun 17 20:28:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11447 <11447@debbugs.gnu.org> To: bug#11447 <11447@debbugs.gnu.org> Subject: Status: 24.1.50; notifications-notify eats keystrokes Reply-To: bug#11447 <11447@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:28:56 +0000 retitle 11447 24.1.50; notifications-notify eats keystrokes reassign 11447 emacs submitter 11447 Peter M=C3=BCnster severity 11447 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 10 16:45:27 2012 Received: (at submit) by debbugs.gnu.org; 10 May 2012 20:45:27 +0000 Received: from localhost ([127.0.0.1]:47167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSaEo-0007uB-SY for submit@debbugs.gnu.org; Thu, 10 May 2012 16:45:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33170) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSaEn-0007u0-AF for submit@debbugs.gnu.org; Thu, 10 May 2012 16:45:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSaEf-0002tn-Oo for submit@debbugs.gnu.org; Thu, 10 May 2012 16:45:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSaEf-0002th-LR for submit@debbugs.gnu.org; Thu, 10 May 2012 16:45:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSaEe-0003Pl-1T for bug-gnu-emacs@gnu.org; Thu, 10 May 2012 16:45:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSaEc-0002tL-2H for bug-gnu-emacs@gnu.org; Thu, 10 May 2012 16:45:15 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:59030 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSaEb-0002tB-Sj for bug-gnu-emacs@gnu.org; Thu, 10 May 2012 16:45:13 -0400 Received: from micropit.couberia.bzh ([2.2.55.89]) by mwinf5d03 with ME id 8LlB1j0021vVXSy03LlBjd; Thu, 10 May 2012 22:45:11 +0200 Received: by micropit.couberia.bzh (Postfix, from userid 1000) id E0DCF50076A; Thu, 10 May 2012 22:45:10 +0200 (CEST) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: bug-gnu-emacs@gnu.org Subject: 24.1.50; notifications-notify eats keystrokes Date: Thu, 10 May 2012 22:45:10 +0200 Message-ID: <87likzrcix.fsf@micropit.couberia.bzh> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Hello, Please try the following code: --8<---------------cut here---------------start------------->8--- (require 'notifications) (defun test-func () (notifications-notify :title "Test" :timeout 1000)) (run-with-timer 2 2 'test-func) --8<---------------cut here---------------end--------------->8--- with "emacs -Q" (latest version from trunk). Then just type some text and you'll see, that some of the letters, that you type, will be missing in the buffer. Cheers, Peter In GNU Emacs 24.1.50.2 (x86_64-suse-linux-gnu, GTK+ Version 2.22.1) of 2012-05-10 on micropit Bzr revision: 108190 lekktu@gmail.com-20120510143443-msjlhoy2181m22rf Windowing system distributor `The X.Org Foundation', version 11.0.10903000 Configured using: `configure '--without-toolkit-scroll-bars'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: en_GB.utf8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: @im=local locale-coding-system: utf-8-unix default enable-multibyte-characters: t -- Peter From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 04:07:30 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 08:07:30 +0000 Received: from localhost ([127.0.0.1]:47533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSksr-0006xS-SR for submit@debbugs.gnu.org; Fri, 11 May 2012 04:07:30 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:55977) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SSksp-0006xF-AI for 11447@debbugs.gnu.org; Fri, 11 May 2012 04:07:28 -0400 Received: (qmail invoked by alias); 11 May 2012 08:07:15 -0000 Received: from p57BB9408.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.148.8] by mail.gmx.net (mp032) with SMTP; 11 May 2012 10:07:15 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/48qZyboL4Xno7sQJLs+EDEeciVNIz6buAfx7DBV 5CT4F4uQcVv6DJ From: Michael Albinus To: Peter =?utf-8?Q?M=C3=BCnster?= Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> Date: Fri, 11 May 2012 10:07:10 +0200 In-Reply-To: <87likzrcix.fsf@micropit.couberia.bzh> ("Peter \=\?utf-8\?Q\?M\?\= \=\?utf-8\?Q\?\=C3\=BCnster\=22's\?\= message of "Thu, 10 May 2012 22:45:10 +0200") Message-ID: <87vck3qgy9.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Peter M=C3=BCnster writes: > Hello, Hi Peter, > Then just type some text and you'll see, that some of the letters, that > you type, will be missing in the buffer. Could you, please, check the following patch: --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/emacs/lisp/net/dbus.el.~108190~ --- /home/albinus/src/emacs/lisp/net/dbus.el *************** *** 263,274 **** (apply 'dbus-message-internal dbus-message-type-method-call bus service path interface method 'dbus-call-method-handler args))) ;; Wait until `dbus-call-method-handler' has put the result into ;; `dbus-return-values-table'. If no timeout is given, use the ! ;; default 25". (with-timeout ((if timeout (/ timeout 1000.0) 25)) (while (eq (gethash key dbus-return-values-table :ignore) :ignore) ! (read-event nil nil 0.1))) =20=20 ;; Cleanup `dbus-return-values-table'. Return the result. (prog1 --- 263,278 ---- (apply 'dbus-message-internal dbus-message-type-method-call bus service path interface method 'dbus-call-method-handler args))) +=20 ;; Wait until `dbus-call-method-handler' has put the result into ;; `dbus-return-values-table'. If no timeout is given, use the ! ;; default 25". Events which are not from D-Bus must be restored. (with-timeout ((if timeout (/ timeout 1000.0) 25)) (while (eq (gethash key dbus-return-values-table :ignore) :ignore) ! (let ((event (let (unread-command-events) (read-event nil nil 0.1)))) ! (when (and event (not (ignore-errors (dbus-check-event event)))) ! (setq unread-command-events ! (append unread-command-events (list event))))))) =20=20 ;; Cleanup `dbus-return-values-table'. Return the result. (prog1 --8<---------------cut here---------------end--------------->8--- > Cheers, Peter Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 07:22:34 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 11:22:34 +0000 Received: from localhost ([127.0.0.1]:48271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSnve-0003Jp-0i for submit@debbugs.gnu.org; Fri, 11 May 2012 07:22:34 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:60967 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSnvc-0003Jd-F9 for 11447@debbugs.gnu.org; Fri, 11 May 2012 07:22:33 -0400 Received: from micropit.couberia.bzh ([2.2.79.101]) by mwinf5d17 with ME id 8bNM1j0042B8sQa03bNMbN; Fri, 11 May 2012 13:22:21 +0200 Received: by micropit.couberia.bzh (Postfix, from userid 1000) id B499B50076A; Fri, 11 May 2012 13:22:20 +0200 (CEST) From: =?utf-8?Q?Peter_M=C3=BCnster?= To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> Date: Fri, 11 May 2012 13:22:20 +0200 In-Reply-To: <87vck3qgy9.fsf@gmx.de> (Michael Albinus's message of "Fri, 11 May 2012 10:07:10 +0200") Message-ID: <87d36bq7wz.fsf@micropit.couberia.bzh> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On Fri, May 11 2012, Michael Albinus wrote: > Could you, please, check the following patch: It solves the problem. Thanks! -- Peter From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 09:25:28 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 13:25:28 +0000 Received: from localhost ([127.0.0.1]:48417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSpqX-0006yN-7S for submit@debbugs.gnu.org; Fri, 11 May 2012 09:25:26 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:28436) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSpqD-0006xg-5E for 11447@debbugs.gnu.org; Fri, 11 May 2012 09:25:21 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjEKACxOgk9FpYsJ/2dsb2JhbABDtheCDAOBDIEIggoBBVYhAhALNBIUGA0kiCG2MothhHkEpEWBXYMD X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="179616228" Received: from 69-165-139-9.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.9]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 May 2012 09:24:53 -0400 Received: by pastel.home (Postfix, from userid 20848) id 941F8590CF; Fri, 11 May 2012 09:24:53 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes Message-ID: References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> Date: Fri, 11 May 2012 09:24:52 -0400 In-Reply-To: <87vck3qgy9.fsf@gmx.de> (Michael Albinus's message of "Fri, 11 May 2012 10:07:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?iso-8859-1?Q?M=FCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > (with-timeout ((if timeout (/ timeout 1000.0) 25)) > (while (eq (gethash key dbus-return-values-table :ignore) :ignore) > ! (let ((event (let (unread-command-events) (read-event nil nil 0.1)))) > ! (when (and event (not (ignore-errors (dbus-check-event event)))) > ! (setq unread-command-events > ! (append unread-command-events (list event))))))) Shouldn't this code use input-pending-p instead? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 10:11:12 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 14:11:12 +0000 Received: from localhost ([127.0.0.1]:49195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSqYp-0008AF-S8 for submit@debbugs.gnu.org; Fri, 11 May 2012 10:11:12 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:43783) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SSqYn-00089z-36 for 11447@debbugs.gnu.org; Fri, 11 May 2012 10:11:10 -0400 Received: (qmail invoked by alias); 11 May 2012 14:10:57 -0000 Received: from p57BB9408.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.148.8] by mail.gmx.net (mp017) with SMTP; 11 May 2012 16:10:57 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18UiblTRE8UPROVg+ObePC/AMQ6VzVFzXEt8GUjQz wO4tdfkj7ChBpo From: Michael Albinus To: Stefan Monnier Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> Date: Fri, 11 May 2012 16:10:54 +0200 Message-ID: <87ipg2reoh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?utf-8?Q?M=C3=BCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: >> (with-timeout ((if timeout (/ timeout 1000.0) 25)) >> (while (eq (gethash key dbus-return-values-table :ignore) :ignore) >> ! (let ((event (let (unread-command-events) (read-event nil nil 0.1)))) >> ! (when (and event (not (ignore-errors (dbus-check-event event)))) >> ! (setq unread-command-events >> ! (append unread-command-events (list event))))))) > > Shouldn't this code use input-pending-p instead? Maybe, but I don't know how. I've tried this: (with-timeout ((if timeout (/ timeout 1000.0) 25)) (while (eq (gethash key dbus-return-values-table :ignore) :ignore) (or (input-pending-p) (sit-for 0.1 'nodisp)))) With the example in this bug report, I get blocked then. A key might be placed in `unread-command-events', and I still must handle it. What do I miss? > Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 11:20:38 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 15:20:39 +0000 Received: from localhost ([127.0.0.1]:49276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSre2-0001MF-0y for submit@debbugs.gnu.org; Fri, 11 May 2012 11:20:38 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:22979) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSrdy-0001M1-RF for 11447@debbugs.gnu.org; Fri, 11 May 2012 11:20:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjIKACxOgk9FpYsJ/2dsb2JhbABDtheCDAOBDIEIggkBAQQBViECBQsLNBIUGA0kiBwFtjKLYYR5BKRFgV2DAw X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="179631855" Received: from 69-165-139-9.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.9]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 May 2012 11:20:23 -0400 Received: by pastel.home (Postfix, from userid 20848) id 35B44590CF; Fri, 11 May 2012 11:20:22 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes Message-ID: References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> Date: Fri, 11 May 2012 11:20:22 -0400 In-Reply-To: <87ipg2reoh.fsf@gmx.de> (Michael Albinus's message of "Fri, 11 May 2012 16:10:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?iso-8859-1?Q?M=FCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >>> (with-timeout ((if timeout (/ timeout 1000.0) 25)) >>> (while (eq (gethash key dbus-return-values-table :ignore) :ignore) >>> ! (let ((event (let (unread-command-events) (read-event nil nil 0.1)))) >>> ! (when (and event (not (ignore-errors (dbus-check-event event)))) >>> ! (setq unread-command-events >>> ! (append unread-command-events (list event))))))) >> >> Shouldn't this code use input-pending-p instead? > Maybe, but I don't know how. I've tried this: > (with-timeout ((if timeout (/ timeout 1000.0) 25)) > (while (eq (gethash key dbus-return-values-table :ignore) :ignore) > (or (input-pending-p) (sit-for 0.1 'nodisp)))) Well, actually if you use sit-for you don't need input-pending-p. > With the example in this bug report, I get blocked then. What do you mean by "blocked"? > A key might be placed in `unread-command-events', and I still must > handle it. What do you mean by "handle it"? Could let-binding unread-command-events around the call to sit-for address the issue? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 11:28:12 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 15:28:12 +0000 Received: from localhost ([127.0.0.1]:49286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSrlL-0001XD-Vb for submit@debbugs.gnu.org; Fri, 11 May 2012 11:28:12 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:47634) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SSrlJ-0001Wz-89 for 11447@debbugs.gnu.org; Fri, 11 May 2012 11:28:10 -0400 Received: (qmail invoked by alias); 11 May 2012 15:27:57 -0000 Received: from p57BB9408.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.148.8] by mail.gmx.net (mp034) with SMTP; 11 May 2012 17:27:57 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX189cqNAwOE9GhLNSadeR4OiIfZOlsyk/6/tSEJq9u 5mEUzS+1CQ/Pp/ From: Michael Albinus To: Stefan Monnier Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> Date: Fri, 11 May 2012 17:27:54 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 11 May 2012 11:20:22 -0400") Message-ID: <87ehqqrb45.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?utf-8?Q?M=C3=BCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: >> Maybe, but I don't know how. I've tried this: > >> (with-timeout ((if timeout (/ timeout 1000.0) 25)) >> (while (eq (gethash key dbus-return-values-table :ignore) :ignore) >> (or (input-pending-p) (sit-for 0.1 'nodisp)))) > > Well, actually if you use sit-for you don't need input-pending-p. OK. >> With the example in this bug report, I get blocked then. > > What do you mean by "blocked"? An input char goes into unread-command-event. Since nobody handles it, the while-loop runs forever. >> A key might be placed in `unread-command-events', and I still must >> handle it. > > What do you mean by "handle it"? The char event shall be taken from unread-command-event, and (for example) inserted into the current buffer. > Could let-binding unread-command-events around the call to sit-for > address the issue? Then we have the initial situation, as reported by Peter. The char is put into the let-bound unread-command-events, and it is lost when the let-clause ends. I simply don't know, who shall be responsible to move an event from unread-command-events. In the example I've shown above, it is not done. > Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 13:29:03 2012 Received: (at 11447) by debbugs.gnu.org; 11 May 2012 17:29:03 +0000 Received: from localhost ([127.0.0.1]:49367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSteJ-0004LK-0o for submit@debbugs.gnu.org; Fri, 11 May 2012 13:29:03 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:36238) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSteH-0004Kp-Ix for 11447@debbugs.gnu.org; Fri, 11 May 2012 13:29:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjIKACxOgk9FpYsJ/2dsb2JhbABDtheCDAOBDIEIggkBAQQBViECBQsLNBIUGA0kiBwFtjKLYYR5BKRFgV2DAw X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="179670304" Received: from 69-165-139-9.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.9]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 May 2012 13:28:49 -0400 Received: by pastel.home (Postfix, from userid 20848) id 54570590CF; Fri, 11 May 2012 13:28:49 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes Message-ID: References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> Date: Fri, 11 May 2012 13:28:49 -0400 In-Reply-To: <87ehqqrb45.fsf@gmx.de> (Michael Albinus's message of "Fri, 11 May 2012 17:27:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?iso-8859-1?Q?M=FCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >>> (with-timeout ((if timeout (/ timeout 1000.0) 25)) >>> (while (eq (gethash key dbus-return-values-table :ignore) :ignore) >>> (or (input-pending-p) (sit-for 0.1 'nodisp)))) >> Well, actually if you use sit-for you don't need input-pending-p. > OK. >>> With the example in this bug report, I get blocked then. >> What do you mean by "blocked"? > An input char goes into unread-command-event. Why? Who puts it there? > Since nobody handles it, the while-loop runs forever. I think I understand what you mean: you mean that while you do `sit-for' you actually want to run the code associated with the incoming events, since that code might be the one which changes dbus-return-values-table. So, indeed sit-for and input-pending-p won't cut it. Your code looks OK, then, though you don't need to use a 0.1 timeout, AFAICT. And in order to avoid the (let (unread-command-events) ...), I'd do something like: (let ((seen ())) (unwind-protect (let ((event (read-event))) (when (and event (not (ignore-errors (dbus-check-event event)))) (push event seen))) (setq unread-command-events (append unread-command-events (nreverse seen))))) -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 05:12:11 2012 Received: (at 11447-done) by debbugs.gnu.org; 13 May 2012 09:12:11 +0000 Received: from localhost ([127.0.0.1]:51097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STUqY-0004gV-QB for submit@debbugs.gnu.org; Sun, 13 May 2012 05:12:11 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:44834) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1STUqW-0004gH-8K for 11447-done@debbugs.gnu.org; Sun, 13 May 2012 05:12:09 -0400 Received: (qmail invoked by alias); 13 May 2012 09:11:45 -0000 Received: from p57BB829B.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.130.155] by mail.gmx.net (mp032) with SMTP; 13 May 2012 11:11:45 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19U5JM8pHlUVAytYk4+XMvJoeoTJJLoJtmZimB5jQ QDJnae/g7QjbYR From: Michael Albinus To: Stefan Monnier Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> Date: Sun, 13 May 2012 11:11:43 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 11 May 2012 13:28:49 -0400") Message-ID: <87ehqoqwc0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447-done Cc: Peter =?utf-8?Q?M=C3=BCnster?= , 11447-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: > I think I understand what you mean: you mean that while you do `sit-for' > you actually want to run the code associated with the incoming events, > since that code might be the one which changes dbus-return-values-table. Yes. > So, indeed sit-for and input-pending-p won't cut it. Your code looks > OK, then, though you don't need to use a 0.1 timeout, AFAICT. OK, I remove the timeout. > And in order to avoid the (let (unread-command-events) ...), I'd do > something like: > > (let ((seen ())) > (unwind-protect > (let ((event (read-event))) > (when (and event (not (ignore-errors (dbus-check-event event)))) > (push event seen))) > (setq unread-command-events > (append unread-command-events (nreverse seen))))) Unfortunately, it doesn't work either. When unread-command-events is non-nil, read-event takes the events from there instead of reading them from the input streams. This happens after the first time a character has been read in the loop, before the awaited D-Bus event did arrive. I've committed my original patch (minus the read-event timeout). Bug is closed. > -- Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 09:14:53 2012 Received: (at 11447-done) by debbugs.gnu.org; 13 May 2012 13:14:53 +0000 Received: from localhost ([127.0.0.1]:51159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STYdQ-0003Jf-7k for submit@debbugs.gnu.org; Sun, 13 May 2012 09:14:52 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:38423) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STYdN-0003JS-RJ for 11447-done@debbugs.gnu.org; Sun, 13 May 2012 09:14:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjIKACxOgk9Ld/zG/2dsb2JhbABDtheCDAOBDIEIggkBAQQBViECBQsLNBIUGA0kiBwFtjKLYYR5BKRFgV2DAw X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="179919840" Received: from 75-119-252-198.dsl.teksavvy.com (HELO ceviche.home) ([75.119.252.198]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 May 2012 09:14:27 -0400 Received: by ceviche.home (Postfix, from userid 20848) id E8E68660E0; Sun, 13 May 2012 09:14:24 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes Message-ID: References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> <87ehqoqwc0.fsf@gmx.de> Date: Sun, 13 May 2012 09:14:24 -0400 In-Reply-To: <87ehqoqwc0.fsf@gmx.de> (Michael Albinus's message of "Sun, 13 May 2012 11:11:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447-done Cc: Peter =?iso-8859-1?Q?M=FCnster?= , 11447-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> (let ((seen ())) >> (unwind-protect >> (let ((event (read-event))) >> (when (and event (not (ignore-errors (dbus-check-event event)))) >> (push event seen))) >> (setq unread-command-events >> (append unread-command-events (nreverse seen))))) > Unfortunately, it doesn't work either. When unread-command-events is > non-nil, read-event takes the events from there instead of reading them > from the input streams. You mean, if unread-command-events is already non-nil when entering the loop? Yes, I guess it's a problem. > This happens after the first time a character has been read in the > loop, That shouldn't be the case unless *you* put that char (well, event) on unread-command-events. > I've committed my original patch (minus the read-event timeout). Bug is > closed. OK, thank you, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 10:19:56 2012 Received: (at 11447) by debbugs.gnu.org; 13 May 2012 14:19:56 +0000 Received: from localhost ([127.0.0.1]:51555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STZeN-0004qQ-6h for submit@debbugs.gnu.org; Sun, 13 May 2012 10:19:55 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:47353) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1STZeL-0004qD-3P for 11447@debbugs.gnu.org; Sun, 13 May 2012 10:19:54 -0400 Received: (qmail invoked by alias); 13 May 2012 14:19:29 -0000 Received: from p57BB829B.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.130.155] by mail.gmx.net (mp020) with SMTP; 13 May 2012 16:19:29 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18e6RIqRPgewQUeS5kNX/aJHzXPZWCEntIRdyhhfP WVlfouzU4qqO7R From: Michael Albinus To: Stefan Monnier Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> <87ehqoqwc0.fsf@gmx.de> Date: Sun, 13 May 2012 16:19:26 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 13 May 2012 09:14:24 -0400") Message-ID: <877gwgqi35.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?utf-8?Q?M=C3=BCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: >>> (let ((seen ())) >>> (unwind-protect >>> (let ((event (read-event))) >>> (when (and event (not (ignore-errors (dbus-check-event event)))) >>> (push event seen))) >>> (setq unread-command-events >>> (append unread-command-events (nreverse seen))))) > >> Unfortunately, it doesn't work either. When unread-command-events is >> non-nil, read-event takes the events from there instead of reading them >> from the input streams. > > You mean, if unread-command-events is already non-nil when entering > the loop? Yes, I guess it's a problem. That I don't know. Its is rather ... >> This happens after the first time a character has been read in the >> loop, > > That shouldn't be the case unless *you* put that char (well, event) on > unread-command-events. Yes, that happens with your proposed (setq unread-command-events (append unread-command-events (nreverse seen))))) That's why my patch lets unread-command-events be nil, when calling read-event. >> I've committed my original patch (minus the read-event timeout). Bug is >> closed. > > OK, thank you, > Stefan Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 10:47:37 2012 Received: (at 11447) by debbugs.gnu.org; 13 May 2012 14:47:37 +0000 Received: from localhost ([127.0.0.1]:51572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STa5B-0006IL-3m for submit@debbugs.gnu.org; Sun, 13 May 2012 10:47:37 -0400 Received: from ironport-out.teksavvy.com ([206.248.143.162]:37487) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STa4q-0006Hm-Je for 11447@debbugs.gnu.org; Sun, 13 May 2012 10:47:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjIKACxOgk9Ld/zG/2dsb2JhbABDtheCDAOBDIEIggkBAQQBViECBQsLNBIUGA0kiBwFtjKLYYR5BKRFgV2DAw X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="179922362" Received: from 75-119-252-198.dsl.teksavvy.com (HELO ceviche.home) ([75.119.252.198]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 May 2012 10:46:53 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 7BA3A66108; Sun, 13 May 2012 10:46:52 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes Message-ID: References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> <87ehqoqwc0.fsf@gmx.de> <877gwgqi35.fsf@gmx.de> Date: Sun, 13 May 2012 10:46:52 -0400 In-Reply-To: <877gwgqi35.fsf@gmx.de> (Michael Albinus's message of "Sun, 13 May 2012 16:19:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?iso-8859-1?Q?M=FCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Yes, that happens with your proposed > (setq unread-command-events > (append unread-command-events (nreverse seen))))) Note that I only do it at the end of the loop, so it shouldn't affect the sit-for. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 11:16:08 2012 Received: (at 11447) by debbugs.gnu.org; 13 May 2012 15:16:08 +0000 Received: from localhost ([127.0.0.1]:51621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STaWl-0006wV-Ac for submit@debbugs.gnu.org; Sun, 13 May 2012 11:16:07 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:42235) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1STaWj-0006vz-68 for 11447@debbugs.gnu.org; Sun, 13 May 2012 11:16:05 -0400 Received: (qmail invoked by alias); 13 May 2012 15:15:41 -0000 Received: from p57BB829B.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.130.155] by mail.gmx.net (mp038) with SMTP; 13 May 2012 17:15:41 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19QDSorYJhQOfFM7dxkEuzZAarbVZ4rbx/6bwcY9F +Ng0sktKBbiH0E From: Michael Albinus To: Stefan Monnier Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> <87ehqoqwc0.fsf@gmx.de> <877gwgqi35.fsf@gmx.de> Date: Sun, 13 May 2012 17:15:37 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 13 May 2012 10:46:52 -0400") Message-ID: <873974qfhi.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11447 Cc: Peter =?utf-8?Q?M=C3=BCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: >> Yes, that happens with your proposed > >> (setq unread-command-events >> (append unread-command-events (nreverse seen))))) > > Note that I only do it at the end of the loop, so it shouldn't affect > the sit-for. You do it inside the loop, every next loop cycle unread-command-events could be non-nil, which confuses read-event. Maybe you wanted to cumulate the read events in seen inside the loop, and you wanted to append all events from seen to unread-command-events outside the loop. That might work. (Likely it isn't that important which version of the patch we use ...) > Stefan Best regards, Michael.. From debbugs-submit-bounces@debbugs.gnu.org Sun May 13 11:45:43 2012 Received: (at 11447) by debbugs.gnu.org; 13 May 2012 15:45:44 +0000 Received: from localhost ([127.0.0.1]:51634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STazP-0007cN-MD for submit@debbugs.gnu.org; Sun, 13 May 2012 11:45:43 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50479) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STaz5-0007bx-Cq for 11447@debbugs.gnu.org; Sun, 13 May 2012 11:45:42 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q4DFiweG010759; Sun, 13 May 2012 11:45:01 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 18A38AE27F; Sun, 13 May 2012 11:44:56 -0400 (EDT) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#11447: 24.1.50; notifications-notify eats keystrokes Message-ID: References: <87likzrcix.fsf@micropit.couberia.bzh> <87vck3qgy9.fsf@gmx.de> <87ipg2reoh.fsf@gmx.de> <87ehqqrb45.fsf@gmx.de> <87ehqoqwc0.fsf@gmx.de> <877gwgqi35.fsf@gmx.de> <873974qfhi.fsf@gmx.de> Date: Sun, 13 May 2012 11:44:55 -0400 In-Reply-To: <873974qfhi.fsf@gmx.de> (Michael Albinus's message of "Sun, 13 May 2012 17:15:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4221=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4221> : streams <755562> : uri <1111145> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 11447 Cc: Peter =?iso-8859-1?Q?M=FCnster?= , 11447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > You do it inside the loop, every next loop cycle unread-command-events > could be non-nil, which confuses read-event. Oh, indeed, I didn't write what I intended. The intention was to do it outside of the while loop, of course. > Maybe you wanted to cumulate the read events in seen inside the loop, > and you wanted to append all events from seen to unread-command-events > outside the loop. That might work. Yes, that was the intention. > (Likely it isn't that important which version of the patch we use ...) Indeed, Stefan From unknown Tue Jun 17 20:28:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 11 Jun 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator