From unknown Sat Aug 16 19:20:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11375: [PATCH] simplify/clarify xfns.c, replacing 4 lines with one Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Apr 2012 22:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11375 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 11375@debbugs.gnu.org X-Debbugs-Original-To: bug-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13356506136114 (code B ref -1); Sat, 28 Apr 2012 22:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Apr 2012 22:03:33 +0000 Received: from localhost ([127.0.0.1]:57216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOFjo-0001aZ-Ui for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:03:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59035) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOFjm-0001aM-GF for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFiV-0000wO-VV for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:02:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFiV-0000wK-SU for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:02:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFiU-0006bV-Ae for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:02:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFiS-0000w5-Lt for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:02:09 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:33661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFiS-0000w0-IV for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:02:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54128) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1SOFiR-0005SE-Ut for bug-emacs@gnu.org; Sat, 28 Apr 2012 18:02:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOFiP-0000vd-HJ for bug-emacs@gnu.org; Sat, 28 Apr 2012 18:02:07 -0400 Received: from mx.meyering.net ([88.168.87.75]:54336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOFiP-0000vF-6T for bug-emacs@gnu.org; Sat, 28 Apr 2012 18:02:05 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 92D356025C for ; Sun, 29 Apr 2012 00:02:03 +0200 (CEST) From: Jim Meyering Date: Sun, 29 Apr 2012 00:02:03 +0200 Message-ID: <87ehr7ms6c.fsf@rho.meyering.net> Lines: 39 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) 2012-04-28 Jim Meyering simplify/clarify xfns.c, replacing 4 lines with one * src/xfns.c (x_window): Replace strlen+xmalloc+strncpy with xstrdup. --- src/xfns.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/xfns.c b/src/xfns.c index 6f08ada..f7a80ce 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -2439,7 +2439,6 @@ x_window (struct frame *f, long window_prompting, int minibuffer_only) /* Do some needed geometry management. */ { - ptrdiff_t len; char *tem, shell_position[sizeof "=x++" + 4 * INT_STRLEN_BOUND (int)]; Arg gal[10]; int gac = 0; @@ -2508,13 +2507,11 @@ x_window (struct frame *f, long window_prompting, int minibuffer_only) } } - len = strlen (shell_position) + 1; /* We don't free this because we don't know whether it is safe to free it while the frame exists. It isn't worth the trouble of arranging to free it when the frame is deleted. */ - tem = (char *) xmalloc (len); - strncpy (tem, shell_position, len); + tem = (char *) xstrdup (shell_position); XtSetArg (gal[gac], XtNgeometry, tem); gac++; XtSetValues (shell_widget, gal, gac); } -- 1.7.10.382.g62bc8 From unknown Sat Aug 16 19:20:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11375: [PATCH] simplify/clarify xfns.c, replacing 4 lines with one Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 May 2012 10:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11375 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Meyering Cc: 11375@debbugs.gnu.org Received: via spool by 11375-submit@debbugs.gnu.org id=B11375.133595414218918 (code B ref 11375); Wed, 02 May 2012 10:23:02 +0000 Received: (at 11375) by debbugs.gnu.org; 2 May 2012 10:22:22 +0000 Received: from localhost ([127.0.0.1]:33304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPWhS-0004v4-G9 for submit@debbugs.gnu.org; Wed, 02 May 2012 06:22:22 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:51241 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPWhQ-0004ux-Fi for 11375@debbugs.gnu.org; Wed, 02 May 2012 06:22:21 -0400 Received: from [155.69.18.200] (port=42104 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SPWfv-0005E2-9J; Wed, 02 May 2012 06:20:47 -0400 From: Chong Yidong References: <87ehr7ms6c.fsf@rho.meyering.net> Date: Wed, 02 May 2012 18:20:41 +0800 In-Reply-To: <87ehr7ms6c.fsf@rho.meyering.net> (Jim Meyering's message of "Sun, 29 Apr 2012 00:02:03 +0200") Message-ID: <871un2opdy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Jim Meyering writes: > 2012-04-28 Jim Meyering > > simplify/clarify xfns.c, replacing 4 lines with one > * src/xfns.c (x_window): Replace strlen+xmalloc+strncpy with xstrdup. Thanks, committed to trunk. From debbugs-submit-bounces@debbugs.gnu.org Wed May 02 06:22:39 2012 Received: (at control) by debbugs.gnu.org; 2 May 2012 10:22:39 +0000 Received: from localhost ([127.0.0.1]:33307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPWhi-0004vg-Mx for submit@debbugs.gnu.org; Wed, 02 May 2012 06:22:39 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:51250 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPWhg-0004vZ-GR for control@debbugs.gnu.org; Wed, 02 May 2012 06:22:36 -0400 Received: from [155.69.18.200] (port=42105 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SPWgB-0005EW-Ls for control@debbugs.gnu.org; Wed, 02 May 2012 06:21:04 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11375 Date: Wed, 02 May 2012 18:20:58 +0800 Message-ID: <87txzyyjcl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 11375 thanks