GNU bug report logs - #11369
2 test failures in Automake-1.12

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11369 in the body.
You can then email your comments to 11369 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Burgess <matthew <at> linuxfromscratch.org>
To: bug-automake <at> gnu.org
Subject: 2 test failures in Automake-1.12
Date: Sat, 28 Apr 2012 10:29:22 +0100

[Message part 1 (text/plain, inline)]

Hi,

Testing the latest release of Automake, I see test failures in
dist-readonly and lex-clean.  I've attached the relevant sections of
test-suite.log.

Thanks,

Matt.

[test-suite.log (text/x-log, attachment)]

Message #8 received at 11369 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Matt Burgess <matthew <at> linuxfromscratch.org>
Cc: 11369 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#11369: 2 test failures in Automake-1.12
Date: Sat, 28 Apr 2012 21:37:01 +0200

[Message part 1 (text/plain, inline)]

Hi Matt, thanks for the report.

On 04/28/2012 11:29 AM, Matt Burgess wrote:
> Hi,
> 
> Testing the latest release of Automake, I see test failures in
> dist-readonly and lex-clean.  I've attached the relevant sections of
> test-suite.log.
> 

Let's see to the lex failure first:

FAIL: t/lex-clean
=================

Running from installcheck: no
Using TAP: no
PATH = /sources/automake-1.12/t/ax:/sources/automake-1.12/t/wrap:/bin:/usr/bin:/sbin:/usr/sbin:/tools/bin:/usr/sbin
++ pwd
/sources/automake-1.12/t/lex-clean.dir
+ cat
+ cat
+ cat
+ cat
+ aclocal-1.12 -Werror
+ autoconf
+ automake-1.12 --foreign -Werror -Wall -a
configure.ac: installing './ylwrap'
+ ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for flex... no
checking for lex... no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: executing depfiles commands
+ cp config.status config.sav
+ make
gcc -DPACKAGE_NAME=\"lex-clean\" -DPACKAGE_TARNAME=\"lex-clean\" -DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"lex-clean\ 1.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"lex-clean\" -DVERSION=\"1.0\" -I.     -g -O2 -MT main.o -MD -MP -MF .deps/main.Tpo -c -o main.o main.c
mv -f .deps/main.Tpo .deps/main.Po
/bin/sh ./ylwrap lexer.l .c lexer.c -- :
make: *** [lexer.c] Error 1

Oops, you have no 'lex' program installed on your machine, still this
test was not skipped because it was mistakenly requiring 'yacc' instead
of 'lex'.  Fixed by the attached patch (for maint).

Regards,
  Stefano

[0001-tests-require-lex-not-yacc-in-a-lex-test-case.patch (text/x-diff, attachment)]

Message #11 received at 11369 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Matt Burgess <matthew <at> linuxfromscratch.org>
Cc: 11369 <at> debbugs.gnu.org
Subject: Re: bug#11369: 2 test failures in Automake-1.12
Date: Sat, 28 Apr 2012 21:57:27 +0200

tags 11369 moreinfo
thanks

On 04/28/2012 11:29 AM, Matt Burgess wrote:

> FAIL: t/dist-readonly
> =====================
>
> Running from installcheck: no
> Using TAP: no
> PATH = /sources/automake-1.12/t/ax:/sources/automake-1.12/t/wrap:/bin:/usr/bin:/sbin:/usr/sbin:/tools/bin:/usr/sbin
> ++ pwd
> /sources/automake-1.12/t/dist-readonly.dir
> + cat
> + cat
> + echo 'int main (void) { return 0; }'
> + echo To be, or not to be ...
> + chmod a-w foo.c bar.txt
> + aclocal-1.12 -Werror
> + autoconf
> + automake-1.12 --foreign -Werror -Wall
> + ./configure
> + ...
> + make distdir
> if test -d "dist-readonly-1.0"; then find "dist-readonly-1.0" -type d ! \
>   -perm -200 -exec chmod u+w {} ';' && rm -rf "dist-readonly-1.0" || \
>  { sleep 5 && rm -rf "dist-readonly-1.0"; }; else :; fi
> test -d "dist-readonly-1.0" || mkdir "dist-readonly-1.0"
> test -n "" \
> || find "dist-readonly-1.0" -type d ! -perm -755 \
>        -exec chmod u+rwx,go+rx {} \; -o \
>  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
>  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
>  ! -type d ! -perm -444 -exec /bin/sh \
>     /sources/automake-1.12/t/dist-readonly.dir/install-sh \
>     -c -m a+r {} {} \; \
> || chmod -R a+r "dist-readonly-1.0"
> + ls -l dist-readonly-1.0
> total 264
> -rw-r--r-- 1 root root    405 Apr 27 21:07 Makefile.am
> -rw-r--r-- 1 root root  21384 Apr 27 21:07 Makefile.in
> -rw-r--r-- 1 root root  35135 Apr 27 21:07 aclocal.m4
> -r--r--r-- 1 root root     24 Apr 27 21:07 bar.txt
> -rwxr-xr-x 1 root root 135560 Apr 27 21:07 configure
> -rw-r--r-- 1 root root     98 Apr 27 21:07 configure.ac
> -rwxr-xr-x 1 root root  20842 Apr 27 21:07 depcomp
> -r--r--r-- 1 root root     30 Apr 27 21:07 foo.c
>
Weird, according to this, foo.c is not writable (as we expect ...)

> -rwxr-xr-x 1 root root  13997 Apr 27 21:07 install-sh
> -rwxr-xr-x 1 root root  10179 Apr 27 21:07 missing
> + test -f foo.c
> + test '!' -w foo.c
> + Exit 1
>
... but according to the 'test' builtin, foo.c *is* writable!

What system are you on exactly?  Please send us the contents of the
't/get-sysconf.log' file, that should report all the relevant (to
us) information and details about your system.

Also, what happens if you do this on your system?

  $ echo x > foo
  $ chmod a-w foo
  $ test ! -w foo || echo still writable
  $ (echo y > foo) && echo can write to unwritable
  $ cat foo

Thanks,
  Stefano

Message #16 received at 11369 <at> debbugs.gnu.org (full text, mbox):

From: Matt Burgess <matthew <at> linuxfromscratch.org>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11369 <at> debbugs.gnu.org
Subject: Re: bug#11369: 2 test failures in Automake-1.12
Date: Sat, 28 Apr 2012 21:27:08 +0100

[Message part 1 (text/plain, inline)]

On Sat, 2012-04-28 at 21:57 +0200, Stefano Lattarini wrote:

> What system are you on exactly?

I've reproduced this on a Fedora 16 x86_64 host.

> Please send us the contents of the
> 't/get-sysconf.log' file, that should report all the relevant (to
> us) information and details about your system.

OK, attached.

> Also, what happens if you do this on your system?
> 
>   $ echo x > foo
>   $ chmod a-w foo
>   $ test ! -w foo || echo still writable
>   $ (echo y > foo) && echo can write to unwritable
>   $ cat foo

As root I see:

# echo x > foo
# chmod a-w foo
# test ! -w foo || echo still writable
still writable
# (echo y > foo) && echo can write to unwritable
can write to unwritable
# cat foo
y

As a regular user, I see:

$ echo x > foo
$ chmod a-w foo
$ test ! -w foo || echo still writable
$ (echo y > foo) && echo can write to unwritable
bash: foo: Permission denied
$ cat foo
x

This is as I'd expect, as root can always write to a file, regardless of
permissions.  Due to our particular build environment, automake is built
and tested as the root user in a chroot environment.

Regards,

Matt.

[get-sysconf.log (text/x-log, attachment)]

Message #19 received at 11369 <at> debbugs.gnu.org (full text, mbox):

From: Matt Burgess <matthew <at> linuxfromscratch.org>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11369 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#11369: 2 test failures in Automake-1.12
Date: Sat, 28 Apr 2012 22:06:45 +0100

On Sat, 2012-04-28 at 21:37 +0200, Stefano Lattarini wrote:

> Oops, you have no 'lex' program installed on your machine, still this
> test was not skipped because it was mistakenly requiring 'yacc' instead
> of 'lex'.  Fixed by the attached patch (for maint).

Thanks, Stefano.  FWIW, I can confirm the patch changes the test from
failing to being skipped as expected on my build system.

Regards,

Matt.

Message #22 received at 11369 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Matt Burgess <matthew <at> linuxfromscratch.org>
Cc: 11369 <at> debbugs.gnu.org
Subject: Re: bug#11369: 2 test failures in Automake-1.12
Date: Sat, 28 Apr 2012 23:20:30 +0200

[Message part 1 (text/plain, inline)]

severity 11369 minor
tags 11369 - moreinfo
tags 11369 + patch
close 11369
thanks

On 04/28/2012 10:27 PM, Matt Burgess wrote:
>
> Due to our particular build environment, automake is built and tested
> as the root user in a chroot environment.
> 
Ah, this explain it all.  So this error was due to another testsuite weakness,
that is solved by the attached patch.  All the two failures explained ad fixed,
I'm closing this bug report.

Thanks again for your help,
  Stefano

[0001-tests-root-can-write-on-files-without-write-perms-ca.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.