GNU bug report logs -
#11356
automake 1.12 and (C) 2011
Previous Next
Reported by: Peter Johansson <trojkan <at> gmail.com>
Date: Fri, 27 Apr 2012 03:33:02 UTC
Severity: minor
Tags: patch
Done: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11356 in the body.
You can then email your comments to 11356 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Fri, 27 Apr 2012 03:33:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Peter Johansson <trojkan <at> gmail.com>:
New bug report received and forwarded. Copy sent to
bug-automake <at> gnu.org.
(Fri, 27 Apr 2012 03:33:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Hello,
Just a tiny nit. After installing the new version (1.12) of automake I
noticed that 'automake --version' outputs:
automake (GNU automake) 1.12
Copyright (C) 2011 Free Software Foundation, Inc.
whereas I expected it to say 'Copyright (C) 2012...'
Cheers,
Peter
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Fri, 27 Apr 2012 09:21:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 11356 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
tags 11356 + patch
severity 11356 minor
close 11356
thanks
On 04/27/2012 05:30 AM, Peter Johansson wrote:
> Hello,
>
Hi Peter, thanks for the report.
> Just a tiny nit. After installing the new version (1.12) of
> automake I noticed that 'automake --version' outputs:
>
> automake (GNU automake) 1.12
> Copyright (C) 2011 Free Software Foundation, Inc.
>
> whereas I expected it to say 'Copyright (C) 2012...'
>
Fixed with the attached patch (pushed to maint).
Regards,
Stefano
[0001-automake-aclocal-update-copyright-year-in-output.patch (text/x-diff, attachment)]
Added tag(s) patch.
Request was from
Stefano Lattarini <stefano.lattarini <at> gmail.com>
to
control <at> debbugs.gnu.org.
(Fri, 27 Apr 2012 09:21:02 GMT)
Full text and
rfc822 format available.
Severity set to 'minor' from 'normal'
Request was from
Stefano Lattarini <stefano.lattarini <at> gmail.com>
to
control <at> debbugs.gnu.org.
(Fri, 27 Apr 2012 09:21:02 GMT)
Full text and
rfc822 format available.
bug closed, send any further explanations to
11356 <at> debbugs.gnu.org and Peter Johansson <trojkan <at> gmail.com>
Request was from
Stefano Lattarini <stefano.lattarini <at> gmail.com>
to
control <at> debbugs.gnu.org.
(Fri, 27 Apr 2012 09:21:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Fri, 27 Apr 2012 12:07:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 11356 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 04/27/2012 03:18 AM, Stefano Lattarini wrote:
> tags 11356 + patch
> severity 11356 minor
> close 11356
> thanks
>
> On 04/27/2012 05:30 AM, Peter Johansson wrote:
>> > Hello,
>> >
> Hi Peter, thanks for the report.
>
>> > Just a tiny nit. After installing the new version (1.12) of
>> > automake I noticed that 'automake --version' outputs:
>> >
>> > automake (GNU automake) 1.12
>> > Copyright (C) 2011 Free Software Foundation, Inc.
>> >
>> > whereas I expected it to say 'Copyright (C) 2012...'
>> >
> Fixed with the attached patch (pushed to maint).
>
> Regards,
> Stefano
>
> +++ b/aclocal.in
> @@ -840,9 +840,8 @@ $output";
> # name in the header.
> $output = "# generated automatically by aclocal $VERSION -*- Autoconf -*-
>
> -# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
> -# 2005, 2006, 2007, 2008, 2009, 2010, 2011 Free Software Foundation,
> -# Inc.
> +# Copyright (C) 1996-2012 Free Software Foundation, Inc.
This makes sense,
> +
> # This file is free software; the Free Software Foundation
> # gives unlimited permission to copy and/or distribute it,
> # with or without modifications, as long as this notice is preserved.
> @@ -936,7 +935,7 @@ sub version()
> {
> print <<EOF;
> aclocal (GNU $PACKAGE) $VERSION
> -Copyright (C) 2011 Free Software Foundation, Inc.
> +Copyright (C) 2012 Free Software Foundation, Inc.
But this is still prone to error next year. Since this is already a .in
file, and will be further processed by config.status and/or Makefile to
create the real aclocal executable, I suggest a more permanent solution,
by borrowing the same trick used by Autoconf. Make this @RELEASE_YEAR@,
which is set by an AC_SUBST'd string that auto-updates itself at
configure time, instead of manually changing it each time a year rolls
around.
--
Eric Blake eblake <at> redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[signature.asc (application/pgp-signature, attachment)]
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Fri, 27 Apr 2012 14:36:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 11356 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Eric, thanks for the suggestion.
On 04/27/2012 02:05 PM, Eric Blake wrote:
>
>> aclocal (GNU $PACKAGE) $VERSION
>> -Copyright (C) 2011 Free Software Foundation, Inc.
>> +Copyright (C) 2012 Free Software Foundation, Inc.
>
> But this is still prone to error next year. Since this is already a .in
> file, and will be further processed by config.status and/or Makefile to
> create the real aclocal executable, I suggest a more permanent solution,
> by borrowing the same trick used by Autoconf. Make this @RELEASE_YEAR@,
> which is set by an AC_SUBST'd string that auto-updates itself at
> configure time, instead of manually changing it each time a year rolls
> around.
>
I agree. What about the attached patch? I will push by tomorrow if there
is no objection.
Regards,
Stefano
[0001-build-ensure-release-year-in-copyright-notice-is-up-.patch (text/x-diff, attachment)]
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Fri, 27 Apr 2012 22:38:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 11356 <at> debbugs.gnu.org (full text, mbox):
On Fri, Apr 27, 2012 at 10:05 PM, Eric Blake <eblake <at> redhat.com> wrote:
> On 04/27/2012 03:18 AM, Stefano Lattarini wrote:
>> On 04/27/2012 05:30 AM, Peter Johansson wrote:
>> +++ b/aclocal.in
>> @@ -840,9 +840,8 @@ $output";
>> # name in the header.
>> $output = "# generated automatically by aclocal $VERSION -*- Autoconf -*-
>>
>> -# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
>> -# 2005, 2006, 2007, 2008, 2009, 2010, 2011 Free Software Foundation,
>> -# Inc.
>> +# Copyright (C) 1996-2012 Free Software Foundation, Inc.
>
> This makes sense,
This took me by surprise, because it wasn't the case previously. It is
now acceptable usage according to GNU standards, see
http://savannah.gnu.org/forum/forum.php?forum_id=6576 and
http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
""""
You can use a range (‘2008-2010’) instead of listing individual years
(‘2008, 2009, 2010’) if and only if: 1) every year in the range,
inclusive, really is a “copyrightable” year that would be listed
individually; and 2) you make an explicit statement in a ‘README’ file
about this usage.
"""
I suggest you update README to follow the guidelines. The guidelines
don't say what exactly should be in the notice, but I presume it's a
statement to the effect that 1) above holds.
-- Jack
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Fri, 27 Apr 2012 22:53:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 11356 <at> debbugs.gnu.org (full text, mbox):
On 04/28/2012 12:36 AM, Jack Kelly wrote:
> On Fri, Apr 27, 2012 at 10:05 PM, Eric Blake <eblake <at> redhat.com> wrote:
>> On 04/27/2012 03:18 AM, Stefano Lattarini wrote:
>>> On 04/27/2012 05:30 AM, Peter Johansson wrote:
>>> +++ b/aclocal.in
>>> @@ -840,9 +840,8 @@ $output";
>>> # name in the header.
>>> $output = "# generated automatically by aclocal $VERSION -*- Autoconf -*-
>>>
>>> -# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
>>> -# 2005, 2006, 2007, 2008, 2009, 2010, 2011 Free Software Foundation,
>>> -# Inc.
>>> +# Copyright (C) 1996-2012 Free Software Foundation, Inc.
>>
>> This makes sense,
>
> This took me by surprise, because it wasn't the case previously. It is
> now acceptable usage according to GNU standards, see
> http://savannah.gnu.org/forum/forum.php?forum_id=6576 and
> http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
>
> """"
> You can use a range (‘2008-2010’) instead of listing individual years
> (‘2008, 2009, 2010’) if and only if: 1) every year in the range,
> inclusive, really is a “copyrightable” year that would be listed
> individually; and 2) you make an explicit statement in a ‘README’ file
> about this usage.
> """
>
> I suggest you update README to follow the guidelines.
>
Good catch, I wasn't aware of such a requirement.
> The guidelines
> don't say what exactly should be in the notice, but I presume it's a
> statement to the effect that 1) above holds.
>
I think I'll steal the wording from coreutils' README:
For any copyright year range specified as YYYY-ZZZZ in this package
note that the range specifies every single year in that closed interval.
Patch coming up tomorrow (unless someone beats me ;-)
Regards,
Stefano
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Sat, 28 Apr 2012 07:32:01 GMT)
Full text and
rfc822 format available.
Message #29 received at 11356 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 04/28/2012 12:51 AM, Stefano Lattarini wrote:
>
> I think I'll steal the wording from coreutils' README:
>
> For any copyright year range specified as YYYY-ZZZZ in this package
> note that the range specifies every single year in that closed interval.
>
> Patch coming up tomorrow (unless someone beats me ;-)
>
Done, see attachment.
Thanks,
Stefano
[0001-readme-explicitly-state-we-use-ranges-in-copyright-y.patch (text/x-diff, attachment)]
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Sat, 28 Apr 2012 08:04:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 11356 <at> debbugs.gnu.org (full text, mbox):
On 04/27/2012 04:34 PM, Stefano Lattarini wrote:
> Hi Eric, thanks for the suggestion.
>
> On 04/27/2012 02:05 PM, Eric Blake wrote:
>>
>>> aclocal (GNU $PACKAGE) $VERSION
>>> -Copyright (C) 2011 Free Software Foundation, Inc.
>>> +Copyright (C) 2012 Free Software Foundation, Inc.
>>
>> But this is still prone to error next year. Since this is already a .in
>> file, and will be further processed by config.status and/or Makefile to
>> create the real aclocal executable, I suggest a more permanent solution,
>> by borrowing the same trick used by Autoconf. Make this @RELEASE_YEAR@,
>> which is set by an AC_SUBST'd string that auto-updates itself at
>> configure time, instead of manually changing it each time a year rolls
>> around.
>>
> I agree. What about the attached patch? I will push by tomorrow if there
> is no objection.
>
Pushed now.
Regards,
Stefano
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Sat, 28 Apr 2012 09:44:01 GMT)
Full text and
rfc822 format available.
Message #35 received at 11356 <at> debbugs.gnu.org (full text, mbox):
On 2012-04-27 16:34, Stefano Lattarini wrote:
> -# Copyright (C) 1996-2012 Free Software Foundation, Inc.
> +# Copyright (C) 1996-$RELEASE_YEAR Free Software Foundation, Inc.
Isn't a paradigm like that "risky" for the case of a late maintenance
release a couple of years after the last release on some resurrected
branch?
Cheers,
Peter
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Sat, 28 Apr 2012 10:40:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 11356 <at> debbugs.gnu.org (full text, mbox):
Hi Peter.
On 04/28/2012 11:42 AM, Peter Rosin wrote:
> On 2012-04-27 16:34, Stefano Lattarini wrote:
>> -# Copyright (C) 1996-2012 Free Software Foundation, Inc.
>> +# Copyright (C) 1996-$RELEASE_YEAR Free Software Foundation, Inc.
>
> Isn't a paradigm like that "risky" for the case of a late maintenance
> release a couple of years after the last release on some resurrected
> branch?
>
Possibly yes, but is that situation really worth worrying about?
Of course, if you have an idea on how to avoid that possibility without
further complications, I'd be happy to hear it (and likely apply it).
Update: maybe updating HACKING to tell the maintainer to run
"make update-copyright" before a release would be enough ...
WDYT?
Thanks,
Stefano
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Tue, 01 May 2012 00:26:02 GMT)
Full text and
rfc822 format available.
Message #41 received at 11356 <at> debbugs.gnu.org (full text, mbox):
Hi Stefano,
Sorry about this late reply.
On 04/28/2012 12:34 AM, Stefano Lattarini wrote:
--- a/bootstrap
+++ b/bootstrap
@@ -77,6 +77,8 @@ dosubst ()
{
rm -f $2
in=`echo $1 | sed 's,^.*/,,'`
+ current_year=`date +%Y`&& test -n "$current_year" \
+ || { echo "$me: cannot get current year">&2; exit 1; }
sed -e "s%@APIVERSION@%$APIVERSION%g" \
-e "s%@PACKAGE@%$PACKAGE%g" \
-e "s%@PERL@%$PERL%g" \
@@ -84,6 +86,7 @@ dosubst ()
-e "s%@SHELL@%$BOOTSTRAP_SHELL%g" \
-e "s%@VERSION@%$VERSION%g" \
-e "s%@datadir@%$datadir%g" \
+ -e "s%@RELEASE_YEAR@%$current_year%g" \
-e"s%@configure_input@%Generated from $in; do not edit by hand.%g" \
$1> $2
chmod a-w $2
diff --git a/configure.ac b/configure.ac
index 22a158f..2829fd4 100644
IIUC, this implies that if I choose to boostrap Automake 1.12.1, in say,
five years, $RELEASE_YEAR will be set to 2017. I'm not an expert on what
these copyright years mean [legally], but I find this a bit odd as
nothing has changed the last five four years (depending on when 1.12.1
will be released). In my projects, I've used an approach that updates
the copyright year only when something is modified according to the VCS.
With subversion this is trivial and I suspect it wouldn't be harder with
git. I store this information in a separate file, '.release_year', which
is extracted at configure time although, in theory, it could be done at
autoconf time, I guess.
Cheers,
Peter
Information forwarded
to
bug-automake <at> gnu.org:
bug#11356; Package
automake.
(Tue, 01 May 2012 10:49:01 GMT)
Full text and
rfc822 format available.
Message #44 received at 11356 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Peter, thanks for the feedback.
On 05/01/2012 02:23 AM, Peter Johansson wrote:
> Hi Stefano,
>
> Sorry about this late reply.
>
> On 04/28/2012 12:34 AM, Stefano Lattarini wrote:
>
> --- a/bootstrap
> +++ b/bootstrap
> @@ -77,6 +77,8 @@ dosubst ()
> {
> rm -f $2
> in=`echo $1 | sed 's,^.*/,,'`
> + current_year=`date +%Y`&& test -n "$current_year" \
> + || { echo "$me: cannot get current year">&2; exit 1; }
> sed -e "s%@APIVERSION@%$APIVERSION%g" \
> -e "s%@PACKAGE@%$PACKAGE%g" \
> -e "s%@PERL@%$PERL%g" \
> @@ -84,6 +86,7 @@ dosubst ()
> -e "s%@SHELL@%$BOOTSTRAP_SHELL%g" \
> -e "s%@VERSION@%$VERSION%g" \
> -e "s%@datadir@%$datadir%g" \
> + -e "s%@RELEASE_YEAR@%$current_year%g" \
> -e"s%@configure_input@%Generated from $in; do not edit by hand.%g" \
> $1> $2
> chmod a-w $2
> diff --git a/configure.ac b/configure.ac
> index 22a158f..2829fd4 100644
>
>
> IIUC, this implies that if I choose to boostrap Automake 1.12.1, in say,
> five years, $RELEASE_YEAR will be set to 2017.
>
True, but it will be later be reset to 2012 when you run
"./configure && make && make dist", so no big deal.
Though, we might be even nicer, and make bootstrap.sh pre-processed
by "make update-copyright" so that the value of $RELEASE_YEAR will
always be correct, even in the bootstrap phase. This is what I've
done with the attached patch (pushed to maint).
> I'm not an expert on what these copyright years mean [legally], but I
> find this a bit odd as nothing has changed the last five four years
> (depending on when 1.12.1 will be released). In my projects, I've used
> an approach that updates the copyright year only when something is
> modified according to the VCS. With subversion this is trivial and I
> suspect it wouldn't be harder with git. I store this information in
> a separate file, '.release_year', which is extracted at configure time
> although, in theory, it could be done at autoconf time, I guess.
>
> Cheers,
> Peter
Thanks,
Stefano
[0001-bootstrap-consistently-use-correct-copyright-year.patch (text/x-diff, attachment)]
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Tue, 29 May 2012 11:24:03 GMT)
Full text and
rfc822 format available.
This bug report was last modified 13 years and 80 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.