GNU bug report logs - #11348
24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows

Previous Next

Full log

View this message in rfc822 format

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Stefan Monnier'" <monnier <at> IRO.UMontreal.CA>, "'Eli Zaretskii'" <eliz <at> gnu.org>
Cc: 11348 <at> debbugs.gnu.org
Subject: bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows
Date: Mon, 7 May 2012 08:44:53 -0700

> > (Btw, what's the purpose of using eval-when-compile here?)
> 
> To avoid calling `concat' at run-time (especially within the loop).
> In older Emacsen, `concat' was marked as pure so the 
> byte-compiler would evaluate it at compile-time, but someone
> complained that it's not strictly correct because he wanted that
> (concat <foo>) is not `eq' to (concat <foo>).  I actually think
> this change was a mistake and would rather mark `concat' as pure again.

That sounds like the kind of explanation that would help readers as a comment in
the code.  If someone as attentive as Eli has to ask this then it might not hurt
to inform readers generally.

(Ignore my suggestion if inappropriate - I'm not following the thread etc.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.