From unknown Sat Aug 16 10:46:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11347 <11347@debbugs.gnu.org> To: bug#11347 <11347@debbugs.gnu.org> Subject: Status: the remake rules in the automake test suite are too greedy Reply-To: bug#11347 <11347@debbugs.gnu.org> Date: Sat, 16 Aug 2025 17:46:42 +0000 retitle 11347 the remake rules in the automake test suite are too greedy reassign 11347 automake submitter 11347 Bruno Haible severity 11347 minor tag 11347 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 26 06:11:42 2012 Received: (at submit) by debbugs.gnu.org; 26 Apr 2012 10:11:42 +0000 Received: from localhost ([127.0.0.1]:53601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNLfq-00019o-6l for submit@debbugs.gnu.org; Thu, 26 Apr 2012 06:11:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43710) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNLfn-00019Q-L4 for submit@debbugs.gnu.org; Thu, 26 Apr 2012 06:11:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SNLeg-0002Su-KL for submit@debbugs.gnu.org; Thu, 26 Apr 2012 06:10:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNLeg-0002Sp-Ct for submit@debbugs.gnu.org; Thu, 26 Apr 2012 06:10:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNLea-0007Ct-5o for bug-automake@gnu.org; Thu, 26 Apr 2012 06:10:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SNLeO-0002NS-EY for bug-automake@gnu.org; Thu, 26 Apr 2012 06:10:23 -0400 Received: from mail-bk0-f41.google.com ([209.85.214.41]:64975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SNLeO-0002Mf-4I for bug-automake@gnu.org; Thu, 26 Apr 2012 06:10:12 -0400 Received: by bkvi17 with SMTP id i17so991052bkv.0 for ; Thu, 26 Apr 2012 03:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=Jryzj2FXxRLzHytEOkcnGrGEb6PptU1bHwS3LQKsR6M=; b=bxQDMp42AFK8fPbgBIPXOd5GIDtoo1FIM7Rf7w/kIjhH+BkAG29uKFEc2v3cil0+IU foehI3ou71LFojrpl/K8HgYhCn/1ycRmpO+tfraKhgt+1GJC68sdIOE81UW/1d9G9V5c TSR4JI6N6QF40XivkNLleFc8e23w7Lwn9TqbkdZHTp+RtRVRFzZ9S6K0v+wgtts0m9n4 6TCgMy8wmof6hogqDYQiRhYNTQdqgMsGizgw/ofFhTGwoaXY0BOfPJooQggy7g3Kmj+f IBOlhgAVtGx5Kj04ZtFQ/9jsyVDOp2TuMyxcJ4fFz47I5woQJn/Sverm8zEr7hM0oSTh MsZA== Received: by 10.205.133.13 with SMTP id hw13mr2067001bkc.30.1335435009938; Thu, 26 Apr 2012 03:10:09 -0700 (PDT) Received: from [87.5.99.161] (host161-99-dynamic.5-87-r.retail.telecomitalia.it. [87.5.99.161]) by mx.google.com with ESMTPS id jr13sm4476888bkb.14.2012.04.26.03.10.08 (version=SSLv3 cipher=OTHER); Thu, 26 Apr 2012 03:10:08 -0700 (PDT) Message-ID: <4F991EFE.80705@gmail.com> Date: Thu, 26 Apr 2012 12:10:06 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: bug-automake@gnu.org Subject: the remake rules in the automake test suite are too greedy Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit Cc: Bruno Haible X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Severity: minor Reference: On 04/22/2012 08:10 PM, Bruno Haible wrote: > > [SNIP] > > Modifying a test apparently requires me to have the same exact Autoconf > version (2.68) as you did. What an annoyance! I have to proceed like this: > > 1. On a machine with autoconf 2.68: > - Unpack a fresh automake-1.11d directory. > $ ./configure; make # This is necessary to build 'automake'. > - Then only! change t/lex-libobj.sh > $ make # This uses the built 'automake'. > $ make distclean > 2. Copy this directory to the target machine (without autoconf 2.68). > 3. $ ./configure; make > $ make check TESTS=t/lex-libobj > I agree this situation is suboptimal and can hinder on-field testing by the users that are not automake developers. I will fix this soonish. Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 26 06:15:53 2012 Received: (at control) by debbugs.gnu.org; 26 Apr 2012 10:15:53 +0000 Received: from localhost ([127.0.0.1]:53614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNLjt-0001GE-5P for submit@debbugs.gnu.org; Thu, 26 Apr 2012 06:15:53 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:57847) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNLjr-0001G3-3T for control@debbugs.gnu.org; Thu, 26 Apr 2012 06:15:51 -0400 Received: by bkuw5 with SMTP id w5so792624bku.3 for ; Thu, 26 Apr 2012 03:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=2khCc4iu2dePoleaG0FHdyDlE3t/J+HqHP/x8+vizpA=; b=Pcukol2CSmG8Cd5m+cCpbhD9F6DiYQLNqTg/s2gbpKWny85l3WGX2WNBT5yuAVUnWJ mvGrMhj6lD2/OKS8aZCMsQP9QhwRqnVTR53g3IhEk1u6RYhyQkECuLkTgXOc5Q13kJeH ZO69aeC2S40RPoGN/pAMw/OeTRp8YfsRfECfZBa4BR9j6GGQyKckmQcW9AXueegGV69v 7Z1AgrTiVcHqpx+pSsp692IW/2TqpIktKcbhobozXPvxu00RcgtvPHX18T4N3mjiZomI QIeSBWMsURSz7E4ALU7V71NojbarzcmOfejf50sMY4O7xvno+mjsDbeK0K/yptd7e5P5 KOaA== Received: by 10.205.130.12 with SMTP id hk12mr2155380bkc.76.1335435286038; Thu, 26 Apr 2012 03:14:46 -0700 (PDT) Received: from [87.5.99.161] (host161-99-dynamic.5-87-r.retail.telecomitalia.it. [87.5.99.161]) by mx.google.com with ESMTPS id g5sm4217239bkt.9.2012.04.26.03.14.44 (version=SSLv3 cipher=OTHER); Thu, 26 Apr 2012 03:14:44 -0700 (PDT) Message-ID: <4F992012.5080809@gmail.com> Date: Thu, 26 Apr 2012 12:14:42 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: 11347 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) submitter 11347 Bruno Haible thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 26 09:12:01 2012 Received: (at 11347) by debbugs.gnu.org; 26 Apr 2012 13:12:01 +0000 Received: from localhost ([127.0.0.1]:53869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNOUK-0006uK-P5 for submit@debbugs.gnu.org; Thu, 26 Apr 2012 09:12:01 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:50958) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNOUH-0006u7-Ka for 11347@debbugs.gnu.org; Thu, 26 Apr 2012 09:11:59 -0400 Received: by bkuw5 with SMTP id w5so922344bku.3 for <11347@debbugs.gnu.org>; Thu, 26 Apr 2012 06:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=0XxlcWlgvPcLlIAAnYIXAWxWy8cpKQAbdvT5VdEnvig=; b=OFoRg+nHi2//AXhb1inYI62QoNhMom6gsGf2JQ5Kk/+uHB+HrQMx5UzQfqc5KG/7um Tkp1xUo9WCO0rmoLhYHeABLT79fvyGWnXfD9MIWinK9eXjTSfE2t2P17L4iR4iiv09kI Kvnt3y/DWX7cbZ45/g3+QnLwbEIKP5DNfUOMIZa9X4ZiOCf3axtfS81Kxn9EShcXLqtI ryaBf+qIMx2w3oEopEqn/pIDWZWLN5AUUZKJ2IBsrGXmmUy8EbLVjugMZGVcln2s84Oi jMEjJMP1UJrB/stlLeOhVoxh7DafzBSE/MJU6aJqz62fASHci8weTTEAGw5Tzb9mqrMt MEOA== Received: by 10.204.133.200 with SMTP id g8mr933970bkt.110.1335445851938; Thu, 26 Apr 2012 06:10:51 -0700 (PDT) Received: from [82.58.49.222] (host222-49-dynamic.58-82-r.retail.telecomitalia.it. [82.58.49.222]) by mx.google.com with ESMTPS id g5sm5298825bkt.9.2012.04.26.06.10.49 (version=SSLv3 cipher=OTHER); Thu, 26 Apr 2012 06:10:50 -0700 (PDT) Message-ID: <4F994958.3040707@gmail.com> Date: Thu, 26 Apr 2012 15:10:48 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: 11347@debbugs.gnu.org Subject: Re: bug#11347: the remake rules in the automake test suite are too greedy References: <4F991EFE.80705@gmail.com> In-Reply-To: <4F991EFE.80705@gmail.com> Content-Type: multipart/mixed; boundary="------------040806030306060308090705" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11347 Cc: Bruno Haible , "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------040806030306060308090705 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/26/2012 12:10 PM, Stefano Lattarini wrote: > Severity: minor > > Reference: > > On 04/22/2012 08:10 PM, Bruno Haible wrote: >> >> [SNIP] >> >> Modifying a test apparently requires me to have the same exact Autoconf >> version (2.68) as you did. What an annoyance! I have to proceed like this: >> >> 1. On a machine with autoconf 2.68: >> - Unpack a fresh automake-1.11d directory. >> $ ./configure; make # This is necessary to build 'automake'. >> - Then only! change t/lex-libobj.sh >> $ make # This uses the built 'automake'. >> $ make distclean >> 2. Copy this directory to the target machine (without autoconf 2.68). >> 3. $ ./configure; make >> $ make check TESTS=t/lex-libobj >> > I agree this situation is suboptimal and can hinder on-field testing by > the users that are not automake developers. I will fix this soonish. > > Thanks, > Stefano > And here is a patch. The change itself is obvious, but I'd like a review on the long-winded commit message. I will push by tomorrow if there is no review by then. Regards, Stefano --------------040806030306060308090705 Content-Type: text/x-diff; name="0001-build-avoid-too-greedy-rebuilds-in-the-testsuite.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-build-avoid-too-greedy-rebuilds-in-the-testsuite.patch" >From bc7013f1d87a3da468c90a43b0136a7ef88cbdbf Mon Sep 17 00:00:00 2001 Message-Id: From: Stefano Lattarini Date: Thu, 26 Apr 2012 15:05:05 +0200 Subject: [PATCH] build: avoid too greedy rebuilds in the testsuite The autogenerated makefile fragment 't/testsuite-part.am' used to depend on the list of *all* the hand-written files. This was technically correct, since that makefile fragment was (and still is) generated by the script 'gen-testsuite-part', which scans all the hand-written files to detect implicit dependencies and to decide for which tests a further wrapper test should be generated. However, the presence of such a dependency implied that, whenever *any* test case was modified (no matter how slightly), the 't/testsuite-part.am' file was rebuilt, and since that is included by our 'Makefile.am', the 'Makefile.in' file was rebuilt as well by automake. In order to do so, automake scanned our 'configure.ac' file, which requires the latest Autoconf version (2.69 at the time of writing), and the casual user can easily lack that on his machine (and that should be allowed, as automake currently supports any autoconf version >= 2.62). The described situation could hinder hinder on-field testing or debugging by users (even experienced ones) that are not automake developers; see for example automake bug#11347. So we drop the explicit dependency of 't/testsuite-part.am' on the hand-written test cases. (As an aside, note that this has already been done in Automake-NG, albeit for other reasons; see the commit 'v1.11b-129-g1690aca' of 23-40-2012, "[ng] build: define $(TESTS) through a wildcard"). This is not a serious regression in the faithfulness of the Automake build systems, since it that already had several undeclared dependencies unfortunately; e.g., 'Makefile.in' should depend on the automake script, and 'aclocal.m4' should depend on the aclocal script (but this isn't possible, as it would mean that distributed files depend on ones generated at make time). Similarly, 'Makefile.in' should depend on some of the 'lib/am/*.am' files, but does not. Currently, the workaround to get a faithful and correct rebuild is to run ./bootstrap && ./config.status --recheck && make clean all and the present commit does not change that. * Makefile.am ($(srcdir)/t/testsuite-part.am): Don't depend on 't/list-of-tests.mk' nor on '$(handwritten_TESTS)' anymore. ($(generated_TESTS)): Likewise, and don't depend on 'Makefile.am' either. Signed-off-by: Stefano Lattarini --- Makefile.am | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index dc8932d..419c152 100644 --- a/Makefile.am +++ b/Makefile.am @@ -379,11 +379,11 @@ $(srcdir)/t/testsuite-part.am: $(AM_V_at)mv -f t/testsuite-part.tmp $@ EXTRA_DIST += gen-testsuite-part -$(generated_TESTS) $(srcdir)/t/testsuite-part.am: \ - $(srcdir)/gen-testsuite-part \ - t/list-of-tests.mk \ - Makefile.am \ - $(handwritten_TESTS) +## The dependnecies declared here are not truly complete, but such a +## completeness would cause more issues than it would solve. See +## automake bug#11347. +$(generated_TESTS): $(srcdir)/gen-testsuite-part +$(srcdir)/t/testsuite-part.am: $(srcdir)/gen-testsuite-part Makefile.am # Static dependencies valid for each test case. check_SCRIPTS = t/wrap/aclocal-$(APIVERSION) t/wrap/automake-$(APIVERSION) -- 1.7.9.5 --------------040806030306060308090705-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 26 10:29:43 2012 Received: (at 11347) by debbugs.gnu.org; 26 Apr 2012 14:29:43 +0000 Received: from localhost ([127.0.0.1]:54291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNPhW-0000HC-B7 for submit@debbugs.gnu.org; Thu, 26 Apr 2012 10:29:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25324) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNPhS-0000Gw-8K for 11347@debbugs.gnu.org; Thu, 26 Apr 2012 10:29:40 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3QESXNx026523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Apr 2012 10:28:33 -0400 Received: from [10.3.113.99] (ovpn-113-99.phx2.redhat.com [10.3.113.99]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3QESWcf024294; Thu, 26 Apr 2012 10:28:32 -0400 Message-ID: <4F995B90.4080907@redhat.com> Date: Thu, 26 Apr 2012 08:28:32 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#11347: the remake rules in the automake test suite are too greedy References: <4F991EFE.80705@gmail.com> <4F994958.3040707@gmail.com> In-Reply-To: <4F994958.3040707@gmail.com> X-Enigmail-Version: 1.4.1 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig93550F2CF3C05538246A8C93" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11347 Cc: 11347@debbugs.gnu.org, Bruno Haible , "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig93550F2CF3C05538246A8C93 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/26/2012 07:10 AM, Stefano Lattarini wrote: >> >=20 > And here is a patch. The change itself is obvious, but I'd like a revi= ew > on the long-winded commit message. I will push by tomorrow if there is= no > review by then. >=20 >=20 > The described situation could hinder hinder on-field testing or debuggi= ng s/hinder hinder on-field/hinder in-field/ > by users (even experienced ones) that are not automake developers; see > for example automake bug#11347. >=20 > So we drop the explicit dependency of 't/testsuite-part.am' on the > hand-written test cases. (As an aside, note that this has already > been done in Automake-NG, albeit for other reasons; see the commit > 'v1.11b-129-g1690aca' of 23-40-2012, "[ng] build: define $(TESTS) s/23-40-2012/2012-04-23/ (typo, plus day/month/year can be ambiguous with month/day/year, whereas the ISO ordering of year/month/day tends to be unambiguous). > through a wildcard"). >=20 > This is not a serious regression in the faithfulness of the Automake > build systems, since it that already had several undeclared dependencie= s s/that /unfortunately / > unfortunately; e.g., 'Makefile.in' should depend on the automake script= , s/unfortunately// > and 'aclocal.m4' should depend on the aclocal script (but this isn't > possible, as it would mean that distributed files depend on ones genera= ted > at make time). Similarly, 'Makefile.in' should depend on some of the > 'lib/am/*.am' files, but does not. >=20 > Currently, the workaround to get a faithful and correct rebuild is to r= un >=20 > ./bootstrap && ./config.status --recheck && make clean all >=20 > and the present commit does not change that. > -$(generated_TESTS) $(srcdir)/t/testsuite-part.am: \ > - $(srcdir)/gen-testsuite-part \ > - t/list-of-tests.mk \ > - Makefile.am \ > - $(handwritten_TESTS) > +## The dependnecies declared here are not truly complete, but such a s/dependnecies/dependencies/; s/such a/such/ > +## completeness would cause more issues than it would solve. See > +## automake bug#11347. > +$(generated_TESTS): $(srcdir)/gen-testsuite-part > +$(srcdir)/t/testsuite-part.am: $(srcdir)/gen-testsuite-part Makefile.a= m > =20 > # Static dependencies valid for each test case. > check_SCRIPTS =3D t/wrap/aclocal-$(APIVERSION) t/wrap/automake-$(APIVE= RSION) > -- 1.7.9.5 >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig93550F2CF3C05538246A8C93 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPmVuQAAoJEKeha0olJ0NqweIIAJ0W6eEtGMXfK0rEJK955LRy PuwIQsiP7a4RKy7t7kT+nSjjZuKWEJX70X8yofZwqjXEgUZbet4KAON3+7BHbMo7 Y1rgP+axHyxbv7dgjabxzV2FjKsJHv+6MfPQk7VlzEbDqP1/FDqyWpUzu0Xn0c98 PWqobNDkBphaB1iLc0xr8F1F1CUwkn6U201UqTrsc/uNq0jcuZKAI2UyOFmsLd3/ EA0cGxhcz1KlObnBoiyX7nS0EXOSUkW3DPYAnWUwP/p/bhjpqMc8l55zrlfpU+9e VyLJzMFWS0BFYkdbM+fi1Wu93KjQzBJXfaMV3Ewl/LJQAOW2KxQ5hkAotATwTIA= =awsQ -----END PGP SIGNATURE----- --------------enig93550F2CF3C05538246A8C93-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 26 11:50:39 2012 Received: (at 11347) by debbugs.gnu.org; 26 Apr 2012 15:50:40 +0000 Received: from localhost ([127.0.0.1]:54442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNQxq-0002zN-D0 for submit@debbugs.gnu.org; Thu, 26 Apr 2012 11:50:39 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:52530) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SNQxn-0002z8-Cf; Thu, 26 Apr 2012 11:50:36 -0400 Received: by bkuw5 with SMTP id w5so1074671bku.3 for ; Thu, 26 Apr 2012 08:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=U9aBsiE+7unuDflBe6V0iyfFeLfZLdz3cSwjdkNem60=; b=N0fOcB75iBM1TE4xp17o7qta62F4YpXpEr6IJVCbI5miQNpGSwIKdSpO4KgU/Uhnk+ Ett6UwM3oVvKUEAG3t/YH/8dNNuRkj6pwhygb+SyfIb/fACJgmtW0KD8tIeyl4X0Z6p6 /wCzu+8nfoBK3pjdNa8NWcO/urooFExxoeaTzBZyIk5BXKnTY8KEFb5DDd2NfFulPcid LwozpkdGgrxat8Ijv5831ICynJOFc2IrjU1+mkVt5NOIui9ALQ6kaqJGLJ74s7BratCx YA8H96ZJobBWzsKFe4nS5P8CGhS6fI2LbNRAIVTnn3ycVzu2ncWJVqeo/YWoppk0aRmT LnSA== Received: by 10.204.133.210 with SMTP id g18mr2618841bkt.107.1335455370221; Thu, 26 Apr 2012 08:49:30 -0700 (PDT) Received: from [87.2.97.159] (host159-97-dynamic.2-87-r.retail.telecomitalia.it. [87.2.97.159]) by mx.google.com with ESMTPS id r14sm6542820bkv.11.2012.04.26.08.49.27 (version=SSLv3 cipher=OTHER); Thu, 26 Apr 2012 08:49:29 -0700 (PDT) Message-ID: <4F996E86.8000106@gmail.com> Date: Thu, 26 Apr 2012 17:49:26 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Eric Blake Subject: Re: bug#11347: the remake rules in the automake test suite are too greedy References: <4F991EFE.80705@gmail.com> <4F994958.3040707@gmail.com> <4F995B90.4080907@redhat.com> In-Reply-To: <4F995B90.4080907@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11347 Cc: 11347@debbugs.gnu.org, Bruno Haible , "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 11347 + patch close 11347 thanks On 04/26/2012 04:28 PM, Eric Blake wrote: > On 04/26/2012 07:10 AM, Stefano Lattarini wrote: >> And here is a patch. The change itself is obvious, but I'd like a review >> on the long-winded commit message. >> > [SNIP] useful review > I've addressed all you nits, and pushed. I'm thus closing this bug report. Thanks for the feedback, Stefano From unknown Sat Aug 16 10:46:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 May 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator