GNU bug report logs - #11346
automake-1.12 - one test fails (due to truncated timestamp)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11346 in the body.
You can then email your comments to 11346 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Breitenlohner <peb <at> mppmu.mpg.de>
To: bug-automake <at> gnu.org
Subject: automake-1.12 - one test fails (due to truncated timestamp)
Date: Thu, 26 Apr 2012 10:26:10 +0200 (CEST)

Hi,

I just fetched automake-1.12, built it on our no-distro x86-linux-gnu
system

  uname -r: 2.6.28.6-x86_64 (most binaries are 32-bit)
  /lib/libc-2.3.6.so
  /lib64/libc-2.3.6.so

and got one test suite failure.

  FAIL: t/self-check-is_newest.tap 19 - is_newest u x

It seems that 'touch -r x u' (on jfs) has truncated the timestamp, but I
have also seen timestamps rounded upwards to the next second (I think).

Therefore I would suggest to replace
  touch -r x u
in self-check-is_newest.tap by
  touch -r x x; touch -r x u
such that x's time first gets rounded (up or down) to the next second and
then transferred to u.

Regards
Peter Breitenlohner <peb <at> mppmu.mpg.de>

Message #8 received at 11346 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Breitenlohner <peb <at> mppmu.mpg.de>
Cc: 11346 <at> debbugs.gnu.org
Subject: Re: bug#11346: automake-1.12 - one test fails (due to truncated
	timestamp)
Date: Thu, 26 Apr 2012 10:59:50 +0200

[Message part 1 (text/plain, inline)]

On 04/26/2012 10:26 AM, Peter Breitenlohner wrote:
> Hi,
>
Hi Peter, thanks for the report (and the fix ;-)

> I just fetched automake-1.12, built it on our no-distro x86-linux-gnu
> system
> 
>   uname -r: 2.6.28.6-x86_64 (most binaries are 32-bit)
>   /lib/libc-2.3.6.so
>   /lib64/libc-2.3.6.so
> 
> and got one test suite failure.
> 
>   FAIL: t/self-check-is_newest.tap 19 - is_newest u x
> 
> It seems that 'touch -r x u' (on jfs) has truncated the timestamp, but I
> have also seen timestamps rounded upwards to the next second (I think).
> 
> Therefore I would suggest to replace
>   touch -r x u
> in self-check-is_newest.tap by
>   touch -r x x; touch -r x u
> such that x's time first gets rounded (up or down) to the next second and
> then transferred to u.
>
Good idea.  Can you confirm that the attached patch solves your problem?

Thanks,
  Stefano

[0001-tests-fix-a-spurious-failure-due-to-truncated-timest.patch (text/x-diff, attachment)]

Message #11 received at 11346 <at> debbugs.gnu.org (full text, mbox):

From: Peter Breitenlohner <peb <at> mppmu.mpg.de>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11346 <at> debbugs.gnu.org
Subject: Re: bug#11346: automake-1.12 - one test fails (due to truncated
	timestamp)
Date: Thu, 26 Apr 2012 11:32:11 +0200 (CEST)

On Thu, 26 Apr 2012, Stefano Lattarini wrote:

> Good idea.  Can you confirm that the attached patch solves your problem?

Hi Stefano,

it does indeed.

BTW: The "Copyright-paperwork-exempt: yes" should be unnecessary because you
should still have the paperwork from the ObjC++ integration.

Regards
Peter

Message #14 received at 11346 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Breitenlohner <peb <at> mppmu.mpg.de>
Cc: 11346 <at> debbugs.gnu.org
Subject: Re: bug#11346: automake-1.12 - one test fails (due to truncated
	timestamp)
Date: Thu, 26 Apr 2012 11:38:31 +0200

tags 11346 + patch
thanks

On 04/26/2012 11:32 AM, Peter Breitenlohner wrote:
> On Thu, 26 Apr 2012, Stefano Lattarini wrote:
> 
>> Good idea.  Can you confirm that the attached patch solves your problem?
> 
> Hi Stefano,
> 
> it does indeed.
>
Good.  Will push shortly then.

> BTW: The "Copyright-paperwork-exempt: yes" should be unnecessary
>
Will remove it then.

> because you should still have the paperwork from the ObjC++ integration.
>
I wasn't involved in the project yet back then, so I wasn't aware you had
the paperwork in place already.  Now I am :-)

Thanks,
  Stefano

Message #21 received at 11346-done <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Peter Breitenlohner <peb <at> mppmu.mpg.de>
Cc: 11346-done <at> debbugs.gnu.org
Subject: Re: bug#11346: automake-1.12 - one test fails (due to truncated
	timestamp)
Date: Thu, 26 Apr 2012 12:40:15 +0200

On 04/26/2012 11:38 AM, Stefano Lattarini wrote:
>  Will push shortly then.
> 
Pushed now.  I'm thus closing this bug report.

Thanks,
  Stefano

Message #24 received at 11346 <at> debbugs.gnu.org (full text, mbox):

From: Peter Breitenlohner <peb <at> mppmu.mpg.de>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11346 <at> debbugs.gnu.org
Subject: Re: bug#11346: automake-1.12 - one test fails (due to truncated
	timestamp)
Date: Thu, 26 Apr 2012 13:56:07 +0200 (CEST)

On Thu, 26 Apr 2012, Stefano Lattarini wrote:

>> because you should still have the paperwork from the ObjC++ integration.
>>
> I wasn't involved in the project yet back then, so I wasn't aware you had
> the paperwork in place already.  Now I am :-)

Hi Stefano,

and the whole ObjC++ integration (one of two reasons I was waiting for 1.12)
somehow got lost.

I still have the old patches 0001-2009-07-22-Support-for-Objective-C.patch
from 2009-07-22 etc, but could also apply them to the current git version
and send you these.  I may, however, have problem to modernize the test
cases.

Regards
Peter

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.