From unknown Fri Jun 20 07:11:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11332 <11332@debbugs.gnu.org> To: bug#11332 <11332@debbugs.gnu.org> Subject: Status: 24.1.50; doc of `dired-make-relative' Reply-To: bug#11332 <11332@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:41 +0000 retitle 11332 24.1.50; doc of `dired-make-relative' reassign 11332 emacs submitter 11332 "Drew Adams" severity 11332 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 24 15:45:40 2012 Received: (at submit) by debbugs.gnu.org; 24 Apr 2012 19:45:40 +0000 Received: from localhost ([127.0.0.1]:51129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMlgB-00067D-J5 for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:45:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49621) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMlg8-000670-Qn for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMlfF-0008DO-Dw for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:44:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfF-0008DG-Aa for submit@debbugs.gnu.org; Tue, 24 Apr 2012 15:44:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfD-0006ec-I1 for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:44:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMlfB-00089l-8q for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:44:38 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:20185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMlfB-00088G-2J for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 15:44:37 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q3OJiW1E015666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 19:44:33 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q3OJiVRl013498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 24 Apr 2012 19:44:32 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q3OJiViC021784 for ; Tue, 24 Apr 2012 14:44:31 -0500 Received: from dradamslap1 (/10.159.223.238) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Apr 2012 12:44:30 -0700 From: "Drew Adams" To: Subject: 24.1.50; doc of `dired-make-relative' Date: Tue, 24 Apr 2012 12:44:25 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0iUqdsY1SKUvnKRTiIriaVUT4d9w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) 1. The doc string does not say what happens when DIR is nil, which means that it does not even document the default behavior! The first line of the doc string should stand alone, to some extent. Here, it says that the name is relative to DIR, which by default is nil. So the first line is meaningless. Worse, the doc says that DIR *MUST BE* a directory name. The default value is nil, which is not a directory name. It is so simple to say that DIR defaults to the value of `default-directory'. 2. I cannot imagine what is meant by it being impossible to convert FILE. What is really meant here - what case are you referring to? 3. The doc says that arg FILE is an absolute file name, but it does not say what happens if it is not. Is that case treated like the case where FILE cannot be converted - return FILE? 4. Argument IGNORE is not documented. Can it be removed? Why not? Add a comment to the code about that. (Presumably it is because `dired-make-relative' must be usable as a function parameter that accepts a second arg.) In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-04-23 on MARVIN Bzr revision: 108006 agustin.martin@hispalinux.es-20120423103325-xmra3329elgzhmpc Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 03:45:32 2012 Received: (at 11332) by debbugs.gnu.org; 22 Jun 2012 07:45:32 +0000 Received: from localhost ([127.0.0.1]:52454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ShyYd-000696-CZ for submit@debbugs.gnu.org; Fri, 22 Jun 2012 03:45:32 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37918) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ShyYb-00066m-1J for 11332@debbugs.gnu.org; Fri, 22 Jun 2012 03:45:29 -0400 Received: from cyd by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1ShyV4-0000OP-M7; Fri, 22 Jun 2012 03:41:50 -0400 From: Chong Yidong To: "Drew Adams" Subject: Re: 24.1.50; doc of `dired-make-relative' Date: Fri, 22 Jun 2012 03:41:50 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11332 Cc: 11332@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > The doc string does not say what happens when DIR is nil, which means > that it does not even document the default behavior! Fixed in trunk. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 03:45:41 2012 Received: (at control) by debbugs.gnu.org; 22 Jun 2012 07:45:41 +0000 Received: from localhost ([127.0.0.1]:52457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ShyYl-0006Em-GS for submit@debbugs.gnu.org; Fri, 22 Jun 2012 03:45:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37919) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ShyYi-0006D0-5m for control@debbugs.gnu.org; Fri, 22 Jun 2012 03:45:36 -0400 Received: from cyd by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1ShyVC-0000OU-QZ for control@debbugs.gnu.org; Fri, 22 Jun 2012 03:41:58 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11332 Date: Fri, 22 Jun 2012 03:41:58 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 11332 thanks From unknown Fri Jun 20 07:11:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 20 Jul 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator