GNU bug report logs - #11324
24.0.95; Remove interactive for makefile-browse

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11324: closed (24.0.95; Remove interactive for makefile-browse)
Date: Tue, 08 May 2012 01:29:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 07 May 2012 21:26:25 -0400
with message-id <aok40npiny.fsf <at> fencepost.gnu.org>
and subject line Re: bug#11324: 24.0.95; Remove interactive for makefile-browse
has caused the debbugs.gnu.org bug report #11324,
regarding 24.0.95; Remove interactive for makefile-browse
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11324: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11324
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.95; Remove interactive for makefile-browse
Date: Tue, 24 Apr 2012 09:59:24 -0400

In Makefile Mode, C-c C-b runs the command makefile-switch-to-browser.
 This in turn calls `makefile-browse'.  There's no need for the latter
to be a command.  The interactive spec is invalid for the function
arguments, anyway.

Thanks for Emacs,
aaron

2012-04-24  Aaron S. Hawley  <aaron.s.hawley <at> gmail.com>

        * make-mode.el (makefile-browse): Remove unnecessary interactive.

--- make-mode.el	2012-04-23 15:51:58.830057300 -0400
+++ make-mode.el	2012-04-24 08:40:07.221045900 -0400
@@ -1493,7 +1493,6 @@
   (setq buffer-read-only t))

 (defun makefile-browse (targets macros)
-  (interactive)
   (if (zerop (+ (length targets) (length macros)))
       (progn
 	(beep)

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 11324-done <at> debbugs.gnu.org
Subject: Re: bug#11324: 24.0.95; Remove interactive for makefile-browse
Date: Mon, 07 May 2012 21:26:25 -0400

Version: 24.2

OK; applied, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.