GNU bug report logs - #11281
DST has not effect on windows XP when system DST adjustment is disabled

Previous Next

Package: emacs;

Reported by: Shuguang Sun <shuguang <at> gmail.com>

Date: Thu, 19 Apr 2012 16:46:01 UTC

Severity: minor

Done: Stefan Kangas <stefan <at> marxist.se>

Full log


View this message in rfc822 format

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 11281 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: bug#11281: DST has not effect on windows XP when system DST adjustment is disabled
Date: Tue, 27 May 2025 00:02:41 +0900
> > See above: I think I changed my mind, and we should set _dstbias
> > according to the actual value of TZ, and only if TZ is indeed set
> > (because I think if TZ is not set, MSVCRT gets the correct value from
> > GetTimeZoneInformation).  Can you try that and see if it improves the
> > current situation?
> 
> Please see attached patch.  I think we don't need to re-parse TZ value
> because it is already parsed by tzset and the result is set to
> _daylight variable.

I posted it before reading your patch, so please ignore it

> In addition, I noticed there is a code that calls
> tztest and needs the same workaoround on Windows in lib/time_rz.c,
> however I don't know how to apply the change only on Windows.  Please
> see the second patch.

I can't reproduce the problem with your patch.  I think I was somewhat
confused.  However I'm not sure tzset call in lib/time_rz.c is really
safe.  I'll post if I found the problem not fixed.  Sorry for noise.

-- 
Kazuhiro Ito




This bug report was last modified 18 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.