GNU bug report logs - #11242
24.1.50; Switching to rmai view buffer

Previous Next

Package: emacs;

Reported by: rms <at> gnu.org

Date: Sat, 14 Apr 2012 04:19:01 UTC

Severity: minor

Merged with 11219

Found in version 24.1.50

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Chong Yidong <cyd <at> gnu.org>
To: rms <at> gnu.org
Cc: martin rudalics <rudalics <at> gmx.at>, 11242 <at> debbugs.gnu.org
Subject: bug#11242: 24.1.50; Switching to rmai view buffer
Date: Mon, 16 Apr 2012 18:18:09 +0800
Richard Stallman <rms <at> gnu.org> writes:

> It's neither one.  It's done by this code.
>
>     ;; If there is an Rmail buffer, return to it nicely
>     ;; even if this message was not started by an Rmail command.
>     (unless return-action
>       (dolist (buffer (buffer-list))
> 	(if (eq (buffer-local-value 'major-mode buffer) 'rmail-mode)
> 	    (setq return-action `(rmail-mail-return ,newbuf)))))

This code is wrong; the NEWBUF should not be passed to
rmail-mail-return, it should be the BUFFER variable in the loop.  I've
committed a fix.


BTW, having code in mail-bury to specially handle Rmail buffers is kinda
ugly.  This probably needs to be folded into the quit-window mechanism,
somehow.  In the first place, I'm not even sure it's appropriate to
redirect the user to an Rmail buffer if the mail command was not started
from Rmail.




This bug report was last modified 13 years and 132 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.