Subject: automake-1.11.4 regression

From: "Dmitry V. Levin" <[email-masked]>
Date: Fri, 13 Apr 2012 02:04:13 +0400

Hi,

Commit v1.11-759-g368f1c4 (git describe --contain v1.11-759-g368f1c4 says
it is v1.11.3b~3^2~1) introduced a regression.  GNU automake used to
support shell commands in installation directories, but it seems to be
inadvertently broken now because of the change in shell quoting.
In 3 of 24 places where MKDIR_P commands are generated, automake uses
single quotes, while in other 21 places it still uses double quotes:

$ git grep "^[[:space:]]*\$(MKDIR_P) '" v1.11-759-g368f1c4^:lib | wc -l
0
$ git grep "^[[:space:]]*\$(MKDIR_P) '" v1.11-759-g368f1c4:lib
v1.11-759-g368f1c4:lib:am/data.am:	  $(MKDIR_P) '$(DESTDIR)$(%NDIR%dir)' || exit 1; \
v1.11-759-g368f1c4:lib:am/libs.am:	  $(MKDIR_P) '$(DESTDIR)$(%NDIR%dir)' || exit 1; \
v1.11-759-g368f1c4:lib:am/ltlib.am:	  $(MKDIR_P) '$(DESTDIR)$(%NDIR%dir)' || exit 1; \
$ git grep "^[[:space:]]*\$(MKDIR_P) \"" v1.11-759-g368f1c4:lib
v1.11-759-g368f1c4:lib:am/data.am:	  $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/data.am:	      $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)/$$dir"; }; \
v1.11-759-g368f1c4:lib:am/java.am:	$(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)"; \
v1.11-759-g368f1c4:lib:am/libs.am:	  $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/libs.am:	      $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)/$$dir"; }; \
v1.11-759-g368f1c4:lib:am/lisp.am:	    $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/ltlib.am:	    $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/ltlib.am:	      $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)/$$dir"; }; \
v1.11-759-g368f1c4:lib:am/mans.am:	$(MKDIR_P) "$(DESTDIR)$(man%SECTION%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/mans.am:	$(MKDIR_P) "$(DESTDIR)$(man%SECTION%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/progs.am:	  $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/python.am:	  $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/python.am:	  $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/python.am:	      $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)/$$dir"; }; \
v1.11-759-g368f1c4:lib:am/scripts.am:	  $(MKDIR_P) "$(DESTDIR)$(%NDIR%dir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/texinfos.am:	  $(MKDIR_P) "$(DESTDIR)$(dvidir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/texinfos.am:	  $(MKDIR_P) "$(DESTDIR)$(htmldir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/texinfos.am:	    $(MKDIR_P) "$(DESTDIR)$(htmldir)/$$f" || exit 1; \
v1.11-759-g368f1c4:lib:am/texinfos.am:	  $(MKDIR_P) "$(DESTDIR)$(infodir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/texinfos.am:	  $(MKDIR_P) "$(DESTDIR)$(pdfdir)" || exit 1; \
v1.11-759-g368f1c4:lib:am/texinfos.am:	  $(MKDIR_P) "$(DESTDIR)$(psdir)" || exit 1; \

The patch containing the fix with test case will follow shortly.

-- 
ldv