GNU bug report logs - #11221
cua-mode activates the mark for shifted bindings

Previous Next

Package: emacs;

Reported by: Brian Tannahill <bjt1230 <at> gmail.com>

Date: Wed, 11 Apr 2012 16:05:01 UTC

Severity: normal

Fixed in version 24.2

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Kim Storm <storm <at> cua.dk>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Glenn Morris <rgm <at> gnu.org>, 11221 <at> debbugs.gnu.org, Brian Tannahill <bjt1230 <at> gmail.com>
Subject: bug#11221: cua-mode activates the mark for shifted bindings
Date: Thu, 12 Apr 2012 23:28:41 +0200
On 04/12/2012 08:53 PM, Stefan Monnier wrote:
>
> The shift-select-mode we added in Emacs-23 was careful to get this
> right, so I think it's at least a misfeature of cua-mode.
> The code in cua--pre-command-handler-1 does not try to catch
> this situation, currently.
>
> Kim, WDYT about the patch below, which makes cua-mode use the same
> mechanism as shift-select-mode?
>
>
>          Stefan
>
>
> +   (this-command-keys-shift-translated
>
Hi Stefan

This looks much cleaner indeed.
I haven't tried your patch thorughly, but it seems to work just fine, so 
let's go with it.

Thank you for working on cua bugs!

Kim






This bug report was last modified 13 years and 135 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.