GNU bug report logs - #11186
24.0.92; ERC: Better names for the different log file name formats

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11186: closed (24.0.92; ERC: Better names for the different
 log file name formats)
Date: Sun, 07 Oct 2012 02:07:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 06 Oct 2012 22:05:53 -0400
with message-id <comwzz11fi.fsf <at> fencepost.gnu.org>
and subject line Re: bug#11186: 24.0.92; ERC: Better names for the different log file name formats
has caused the debbugs.gnu.org bug report #11186,
regarding 24.0.92; ERC: Better names for the different log file name formats
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11186: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11186
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Deniz Dogan <deniz <at> dogan.se>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.92; ERC: Better names for the different log file name formats
Date: Thu, 05 Apr 2012 19:56:30 +0200

[Message part 3 (text/plain, inline)]

I think the names of the different log file name formats could be
improved a lot.  There's basically nothing that tells the ordinary user
what the different log formats imply.  Attached is a patch which changes
the name to be more verbose about what the formats mean.

Note that I have used #channel instead of "target" or "buffer" in this
patch, because the ordinary user will most likely understand that
#channel could very well be an IRC user as well.

[Message part 4 (text/plain, inline)]

=== modified file 'lisp/erc/erc-log.el'
--- lisp/erc/erc-log.el	2012-01-19 07:21:25 +0000
+++ lisp/erc/erc-log.el	2012-04-05 17:53:30 +0000
@@ -113,9 +113,9 @@
 custom function which returns the directory part and set
 `erc-log-channels-directory' to its name."
   :group 'erc-log
-  :type '(choice (const :tag "Long style" erc-generate-log-file-name-long)
-		 (const :tag "Long, but with network name rather than server"
+  :type '(choice (const :tag "#channel!nick <at> server:port.txt" erc-generate-log-file-name-long)
+		 (const :tag "#channel!nick <at> network.txt"
 			erc-generate-log-file-name-network)
-		 (const :tag "Short" erc-generate-log-file-name-short)
-		 (const :tag "With date" erc-generate-log-file-name-with-date)
+		 (const :tag "#channel.txt" erc-generate-log-file-name-short)
+		 (const :tag "#channel <at> date.txt" erc-generate-log-file-name-with-date)
 		 (function :tag "Other function")))

 (defcustom erc-truncate-buffer-on-save nil

[Message part 5 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 11186-done <at> debbugs.gnu.org
Subject: Re: bug#11186: 24.0.92;
	ERC: Better names for the different log file name formats
Date: Sat, 06 Oct 2012 22:05:53 -0400

Version: 24.3

Thanks; applied to trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.