Subject: bug#11186: closed (Re: bug#11186: 24.0.92; ERC: Better names for the different log file name formats)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 07 Oct 2012 02:07:02 +0000

Your bug report

#11186: 24.0.92; ERC: Better names for the different log file name formats

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
11186: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11186
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#11186: 24.0.92; ERC: Better names for the different log file name formats
From: Glenn Morris <[email-masked]>
To: [email-masked]
Date: Sat, 06 Oct 2012 22:05:53 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.3

Thanks; applied to trunk.

Subject: 24.0.92; ERC: Better names for the different log file name formats
From: Deniz Dogan <[email-masked]>
To: [email-masked]
Date: Thu, 05 Apr 2012 19:56:30 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

I think the names of the different log file name formats could be
improved a lot.  There's basically nothing that tells the ordinary user
what the different log formats imply.  Attached is a patch which changes
the name to be more verbose about what the formats mean.

Note that I have used #channel instead of "target" or "buffer" in this
patch, because the ordinary user will most likely understand that
#channel could very well be an IRC user as well.
=== modified file 'lisp/erc/erc-log.el'
--- lisp/erc/erc-log.el	2012-01-19 07:21:25 +0000
+++ lisp/erc/erc-log.el	2012-04-05 17:53:30 +0000
@@ -113,9 +113,9 @@
 custom function which returns the directory part and set
 `erc-log-channels-directory' to its name."
   :group 'erc-log
-  :type '(choice (const :tag "Long style" erc-generate-log-file-name-long)
-		 (const :tag "Long, but with network name rather than server"
+  :type '(choice (const :tag "#channel!nick@server:port.txt" erc-generate-log-file-name-long)
+		 (const :tag "[email-masked]"
 			erc-generate-log-file-name-network)
-		 (const :tag "Short" erc-generate-log-file-name-short)
-		 (const :tag "With date" erc-generate-log-file-name-with-date)
+		 (const :tag "#channel.txt" erc-generate-log-file-name-short)
+		 (const :tag "[email-masked]" erc-generate-log-file-name-with-date)
 		 (function :tag "Other function")))

 (defcustom erc-truncate-buffer-on-save nil