From unknown Sun Sep 07 03:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11186: 24.0.92; ERC: Better names for the different log file name formats Resent-From: Deniz Dogan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Apr 2012 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11186@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133364868430867 (code B ref -1); Thu, 05 Apr 2012 17:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Apr 2012 17:58:04 +0000 Received: from localhost ([127.0.0.1]:41723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SFqwd-00081o-St for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:58:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48788) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SFqwc-00081h-3u for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:58:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFqvy-00075h-1v for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:57:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:35100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFqvx-00075U-V2 for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:57:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFqvp-0007nh-FP for bug-gnu-emacs@gnu.org; Thu, 05 Apr 2012 13:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFqvi-0006uW-KX for bug-gnu-emacs@gnu.org; Thu, 05 Apr 2012 13:57:12 -0400 Received: from mxf4.bahnhof.se ([213.80.101.28]:51492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFqvi-0006s9-Ct for bug-gnu-emacs@gnu.org; Thu, 05 Apr 2012 13:57:06 -0400 Received: from localhost (mxf4.local [127.0.0.1]) by mxf4-reinject (Postfix) with ESMTP id E2FB85F98F9 for ; Thu, 5 Apr 2012 19:56:58 +0200 (CEST) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MXF2) Received: from mxf4.bahnhof.se ([127.0.0.1]) by localhost (mxf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4gts2iTNbAxn for ; Thu, 5 Apr 2012 19:56:55 +0200 (CEST) Received: from EKATERINA (h-99-230.a336.priv.bahnhof.se [46.59.99.230]) by mxf4.bahnhof.se (Postfix) with ESMTP id 9FAEB5F98EA for ; Thu, 5 Apr 2012 19:56:55 +0200 (CEST) From: Deniz Dogan Date: Thu, 05 Apr 2012 19:56:30 +0200 Message-ID: <86398i2hbl.fsf@dogan.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain I think the names of the different log file name formats could be improved a lot. There's basically nothing that tells the ordinary user what the different log formats imply. Attached is a patch which changes the name to be more verbose about what the formats mean. Note that I have used #channel instead of "target" or "buffer" in this patch, because the ordinary user will most likely understand that #channel could very well be an IRC user as well. --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: Patch === modified file 'lisp/erc/erc-log.el' --- lisp/erc/erc-log.el 2012-01-19 07:21:25 +0000 +++ lisp/erc/erc-log.el 2012-04-05 17:53:30 +0000 @@ -113,9 +113,9 @@ custom function which returns the directory part and set `erc-log-channels-directory' to its name." :group 'erc-log - :type '(choice (const :tag "Long style" erc-generate-log-file-name-long) - (const :tag "Long, but with network name rather than server" + :type '(choice (const :tag "#channel!nick@server:port.txt" erc-generate-log-file-name-long) + (const :tag "#channel!nick@network.txt" erc-generate-log-file-name-network) - (const :tag "Short" erc-generate-log-file-name-short) - (const :tag "With date" erc-generate-log-file-name-with-date) + (const :tag "#channel.txt" erc-generate-log-file-name-short) + (const :tag "#channel@date.txt" erc-generate-log-file-name-with-date) (function :tag "Other function"))) (defcustom erc-truncate-buffer-on-save nil --=-=-=-- From unknown Sun Sep 07 03:08:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Deniz Dogan Subject: bug#11186: closed (Re: bug#11186: 24.0.92; ERC: Better names for the different log file name formats) Message-ID: References: <86398i2hbl.fsf@dogan.se> X-Gnu-PR-Message: they-closed 11186 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 11186@debbugs.gnu.org Date: Sun, 07 Oct 2012 02:07:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1349575622-28890-1" This is a multi-part message in MIME format... ------------=_1349575622-28890-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11186: 24.0.92; ERC: Better names for the different log file name formats which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11186@debbugs.gnu.org. --=20 11186: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11186 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1349575622-28890-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11186-done) by debbugs.gnu.org; 7 Oct 2012 02:06:15 +0000 Received: from localhost ([127.0.0.1]:58826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKgFz-0007V1-DJ for submit@debbugs.gnu.org; Sat, 06 Oct 2012 22:06:15 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39386 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKgFy-0007Uv-0G for 11186-done@debbugs.gnu.org; Sat, 06 Oct 2012 22:06:14 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TKgFd-0002VA-SL; Sat, 06 Oct 2012 22:05:53 -0400 From: Glenn Morris To: 11186-done@debbugs.gnu.org Subject: Re: bug#11186: 24.0.92; ERC: Better names for the different log file name formats References: <86398i2hbl.fsf@dogan.se> X-Spook: ANZUS advisors Arnett SRI Taiwan Downing Street Peking X-Ran: O9\),u|v-C_DR:0f5gS[&FVjuQF%hTJW;Q2M_:2x4]AS~#C)yNgCo^a*$PIN-r,/V3Xg3J X-Hue: cyan X-Attribution: GM Date: Sat, 06 Oct 2012 22:05:53 -0400 In-Reply-To: <86398i2hbl.fsf@dogan.se> (Deniz Dogan's message of "Thu, 05 Apr 2012 19:56:30 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 11186-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.3 Thanks; applied to trunk. ------------=_1349575622-28890-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Apr 2012 17:58:04 +0000 Received: from localhost ([127.0.0.1]:41723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SFqwd-00081o-St for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:58:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48788) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SFqwc-00081h-3u for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:58:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFqvy-00075h-1v for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:57:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:35100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFqvx-00075U-V2 for submit@debbugs.gnu.org; Thu, 05 Apr 2012 13:57:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFqvp-0007nh-FP for bug-gnu-emacs@gnu.org; Thu, 05 Apr 2012 13:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFqvi-0006uW-KX for bug-gnu-emacs@gnu.org; Thu, 05 Apr 2012 13:57:12 -0400 Received: from mxf4.bahnhof.se ([213.80.101.28]:51492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFqvi-0006s9-Ct for bug-gnu-emacs@gnu.org; Thu, 05 Apr 2012 13:57:06 -0400 Received: from localhost (mxf4.local [127.0.0.1]) by mxf4-reinject (Postfix) with ESMTP id E2FB85F98F9 for ; Thu, 5 Apr 2012 19:56:58 +0200 (CEST) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MXF2) Received: from mxf4.bahnhof.se ([127.0.0.1]) by localhost (mxf4.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4gts2iTNbAxn for ; Thu, 5 Apr 2012 19:56:55 +0200 (CEST) Received: from EKATERINA (h-99-230.a336.priv.bahnhof.se [46.59.99.230]) by mxf4.bahnhof.se (Postfix) with ESMTP id 9FAEB5F98EA for ; Thu, 5 Apr 2012 19:56:55 +0200 (CEST) From: Deniz Dogan To: bug-gnu-emacs@gnu.org Subject: 24.0.92; ERC: Better names for the different log file name formats Date: Thu, 05 Apr 2012 19:56:30 +0200 Message-ID: <86398i2hbl.fsf@dogan.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain I think the names of the different log file name formats could be improved a lot. There's basically nothing that tells the ordinary user what the different log formats imply. Attached is a patch which changes the name to be more verbose about what the formats mean. Note that I have used #channel instead of "target" or "buffer" in this patch, because the ordinary user will most likely understand that #channel could very well be an IRC user as well. --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: Patch === modified file 'lisp/erc/erc-log.el' --- lisp/erc/erc-log.el 2012-01-19 07:21:25 +0000 +++ lisp/erc/erc-log.el 2012-04-05 17:53:30 +0000 @@ -113,9 +113,9 @@ custom function which returns the directory part and set `erc-log-channels-directory' to its name." :group 'erc-log - :type '(choice (const :tag "Long style" erc-generate-log-file-name-long) - (const :tag "Long, but with network name rather than server" + :type '(choice (const :tag "#channel!nick@server:port.txt" erc-generate-log-file-name-long) + (const :tag "#channel!nick@network.txt" erc-generate-log-file-name-network) - (const :tag "Short" erc-generate-log-file-name-short) - (const :tag "With date" erc-generate-log-file-name-with-date) + (const :tag "#channel.txt" erc-generate-log-file-name-short) + (const :tag "#channel@date.txt" erc-generate-log-file-name-with-date) (function :tag "Other function"))) (defcustom erc-truncate-buffer-on-save nil --=-=-=-- ------------=_1349575622-28890-1--