From unknown Sun Aug 17 22:01:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11156 <11156@debbugs.gnu.org> To: bug#11156 <11156@debbugs.gnu.org> Subject: Status: 24.0.95; require-final-newline and read-only files Reply-To: bug#11156 <11156@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:01:38 +0000 retitle 11156 24.0.95; require-final-newline and read-only files reassign 11156 emacs submitter 11156 Christopher Schmidt severity 11156 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 02 17:52:41 2012 Received: (at submit) by debbugs.gnu.org; 2 Apr 2012 21:52:41 +0000 Received: from localhost ([127.0.0.1]:37047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEpB3-0003q3-9o for submit@debbugs.gnu.org; Mon, 02 Apr 2012 17:52:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60548) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEpB0-0003pu-Ss for submit@debbugs.gnu.org; Mon, 02 Apr 2012 17:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEpAh-0003k5-3L for submit@debbugs.gnu.org; Mon, 02 Apr 2012 17:52:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEpAg-0003k1-Tm for submit@debbugs.gnu.org; Mon, 02 Apr 2012 17:52:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEpAf-0004pw-6d for bug-gnu-emacs@gnu.org; Mon, 02 Apr 2012 17:52:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEpAd-0003hf-8d for bug-gnu-emacs@gnu.org; Mon, 02 Apr 2012 17:52:16 -0400 Received: from ristopher.com ([146.185.21.93]:46271 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEpAc-0003fg-Qd for bug-gnu-emacs@gnu.org; Mon, 02 Apr 2012 17:52:15 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 3718F201C8; Mon, 2 Apr 2012 22:52:10 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1333403530; bh=ZFUhFF9l5irny0ckOlPiqjc2iHqJz3NCF3YCWyhKFvo=; h=From:To:Subject:Date:MIME-Version:Content-Type:Message-Id; b=vYlaHVU12dMwp1QMVMl9J4k1vgWfMszTFea8sv1F4KilxBQBeSX1GC2462Yb2+Rei Jw4/YfL+oyFvgQXu/JoGbAXEW/bfYbKSWbFTE0k/XU2l0O5Wu3MB/m4WhZK48P0Nw2 NaMJo7IT9eYdcvR9FjEEV/G5oWR54ieeYT2EyOyk= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: 24.0.95; require-final-newline and read-only files Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Mon, 02 Apr 2012 23:52:11 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Message-Id: <20120402215210.3718F201C8@saturn.ch.ristopher.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Hi, I think I hit on a bug in GNU Emacs 24.0.95.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2012-04-02. Recipe: cd /tmp echo -n rms > rms chmod u=r rms emacs -q eval: (setq require-final-newline 'visit) C-x C-f /tmp/rms RET There is a new buffer but no window displays it. The *Messages*-buffer contains `find-file-noselect-1: Buffer is read-only: #' Emacs tries to add a newline to the (read-only) buffer. Here's a quick fix: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=patch.diff === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-04-02 16:32:06 +0000 +++ lisp/ChangeLog 2012-04-02 21:28:06 +0000 @@ -1,3 +1,8 @@ +2012-04-02 Christopher Schmidt + + * files.el (after-find-file): Do not add a newline at the end when + buffer is read-only. + 2012-04-02 Glenn Morris * emacs-lisp/authors.el (authors-aliases): Another addition. === modified file 'lisp/files.el' --- lisp/files.el 2012-04-01 02:44:24 +0000 +++ lisp/files.el 2012-04-02 21:45:36 +0000 @@ -2152,6 +2152,7 @@ (/= (char-after (1- (point-max))) ?\n) (not (and (eq selective-display t) (= (char-after (1- (point-max))) ?\r))) + (not buffer-read-only) (save-excursion (goto-char (point-max)) (insert "\n"))) --=-=-= Content-Type: text/plain Christopher --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 09:51:02 2012 Received: (at submit) by debbugs.gnu.org; 14 Apr 2012 13:51:02 +0000 Received: from localhost ([127.0.0.1]:58249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJ3NW-0005tu-5c for submit@debbugs.gnu.org; Sat, 14 Apr 2012 09:51:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39345) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJ3NU-0005tg-9q for submit@debbugs.gnu.org; Sat, 14 Apr 2012 09:51:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJ3M6-0000y8-Pi for submit@debbugs.gnu.org; Sat, 14 Apr 2012 09:49:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJ3M6-0000xo-KR for submit@debbugs.gnu.org; Sat, 14 Apr 2012 09:49:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJ3M4-0007EJ-Ns for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2012 09:49:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJ3M2-0000wu-SB for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2012 09:49:32 -0400 Received: from ristopher.com ([146.185.21.93]:48762 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJ3M2-0000wO-ES for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2012 09:49:30 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id D1D9B20217; Sat, 14 Apr 2012 14:49:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1334411365; bh=QDCP15JF4DYuaVDXKAm1aUGmzVQ4IoegUHjipYgScnw=; h=From:To:Subject:In-Reply-To:References:Date:MIME-Version: Content-Type:Message-Id; b=Xl7Hl9sqr6AXQtiPs/zB9NMoQgV7/6uqLlJrJdpqALM6BrBAFDnYE2Wyi/hsIT/1I hSH6e3/dMQ1PS/8KNWUDz8k0lAp2QLZ5eEnT45LElcihvUILg1r1rBRqEQC8R51UXN c4r0N83lB0tbqWhy9lzs8InMQ9iHBYUbnVbJyCDs= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: Re: bug#11156: 24.0.95; require-final-newline and read-only files In-Reply-To: <20120402215210.3718F201C8@saturn.ch.ristopher.com> (Christopher Schmidt's message of "Mon, 02 Apr 2012 23:52:11 +0200") References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Sat, 14 Apr 2012 15:49:28 +0200 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <20120414134925.D1D9B20217@saturn.ch.ristopher.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Christopher Schmidt writes: > I think I hit on a bug in GNU Emacs 24.0.95.1 > (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2012-04-02. > > Recipe: > cd /tmp > echo -n rms > rms > chmod u=r rms > emacs -q > eval: (setq require-final-newline 'visit) > C-x C-f /tmp/rms RET > > There is a new buffer but no window displays it. The > *Messages*-buffer contains `find-file-noselect-1: Buffer is read-only: > #' It is annoying that one needs to manually switch to the buffer after finding a read-only file. But, more important, find-file-hook is not run. This breaks lots of packages and makes this issue a severe one for me. Christopher From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 14:58:47 2012 Received: (at submit) by debbugs.gnu.org; 14 Apr 2012 18:58:47 +0000 Received: from localhost ([127.0.0.1]:58966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJ8BL-0004iQ-Eo for submit@debbugs.gnu.org; Sat, 14 Apr 2012 14:58:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38463) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJ8BI-0004iI-Fj for submit@debbugs.gnu.org; Sat, 14 Apr 2012 14:58:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJ89t-0004j3-Mo for submit@debbugs.gnu.org; Sat, 14 Apr 2012 14:57:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJ89t-0004iz-JR for submit@debbugs.gnu.org; Sat, 14 Apr 2012 14:57:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJ89r-0002UW-Uq for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2012 14:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJ89q-0004ik-44 for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2012 14:57:15 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:36161) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1SJ89p-0004ie-Pd for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2012 14:57:14 -0400 Received: (qmail invoked by alias); 14 Apr 2012 18:57:11 -0000 Received: from 62-47-32-159.adsl.highway.telekom.at (EHLO [62.47.32.159]) [62.47.32.159] by mail.gmx.net (mp002) with SMTP; 14 Apr 2012 20:57:11 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+duNUCUhOdfMLG2lL2M8glkLr01ZMn1TgSkA2iCj ThxR6K179XlIKa Message-ID: <4F89C879.6070209@gmx.at> Date: Sat, 14 Apr 2012 20:56:57 +0200 From: martin rudalics MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Re: bug#11156: 24.0.95; require-final-newline and read-only files References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> In-Reply-To: <20120414134925.D1D9B20217@saturn.ch.ristopher.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) >> cd /tmp >> echo -n rms > rms >> chmod u=r rms >> emacs -q >> eval: (setq require-final-newline 'visit) >> C-x C-f /tmp/rms RET >> >> There is a new buffer but no window displays it. The >> *Messages*-buffer contains `find-file-noselect-1: Buffer is read-only: >> #' > > It is annoying that one needs to manually switch to the buffer after > finding a read-only file. But, more important, find-file-hook is not > run. This breaks lots of packages and makes this issue a severe one for > me. `after-find-file' shouldn't try adding a newline if `buffer-read-only' is non-nil. And the values 'visit and 'visit-save should be documented in the Elisp manual. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 15 11:43:24 2012 Received: (at submit) by debbugs.gnu.org; 15 Apr 2012 15:43:24 +0000 Received: from localhost ([127.0.0.1]:59751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJRbn-0003I4-RM for submit@debbugs.gnu.org; Sun, 15 Apr 2012 11:43:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52007) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJRbl-0003Hp-AZ for submit@debbugs.gnu.org; Sun, 15 Apr 2012 11:43:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJRaH-0001LG-Be for submit@debbugs.gnu.org; Sun, 15 Apr 2012 11:41:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJRaG-0001LA-V9 for submit@debbugs.gnu.org; Sun, 15 Apr 2012 11:41:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJPoZ-0002ck-If for bug-gnu-emacs@gnu.org; Sun, 15 Apr 2012 09:48:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJPoX-0000SH-Bu for bug-gnu-emacs@gnu.org; Sun, 15 Apr 2012 09:48:26 -0400 Received: from ristopher.com ([146.185.21.93]:49000 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJPoW-0000S4-RQ for bug-gnu-emacs@gnu.org; Sun, 15 Apr 2012 09:48:25 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 0001E20235; Sun, 15 Apr 2012 14:48:20 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1334497701; bh=N9hB9N5hwiD1z5MUjMyNHq+5s9hkHVWnjB7LOhaqYHA=; h=From:To:Subject:In-Reply-To:References:Date:MIME-Version: Content-Type:Message-Id; b=blAoLqwKQargTI1vyQoCFz8lb8VkY228lLY8edjVnY7gSB6E/5aaGZVLxEBmfyaWY GzqD8UuFToC7xeeNQnAcIz+xMWqj0x3xL4VHBU9J4yBHiNW25Q1w/XGQFwfFm4LF2T sFQDYtpDmCPFXosIkvRkHDNCccNy+c5fnK01ISqI= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: Re: bug#11156: 24.0.95; require-final-newline and read-only files In-Reply-To: <4F89C879.6070209@gmx.at> (martin rudalics's message of "Sat, 14 Apr 2012 20:56:57 +0200") References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Sun, 15 Apr 2012 15:48:24 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Message-Id: <20120415134821.0001E20235@saturn.ch.ristopher.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain martin rudalics writes: > `after-find-file' shouldn't try adding a newline if `buffer-read-only' > is non-nil. And the values 'visit and 'visit-save should be > documented in the Elisp manual. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=require-final-newline.diff === modified file 'doc/lispref/ChangeLog' --- doc/lispref/ChangeLog 2012-04-15 07:28:01 +0000 +++ doc/lispref/ChangeLog 2012-04-15 13:37:35 +0000 @@ -1,3 +1,8 @@ +2012-04-15 Christopher Schmidt + + * files.texi (Saving Buffers): Document the values visit and + visit-save for require-final-newline. + 2012-04-15 Glenn Morris * processes.texi (Processes, Subprocess Creation, Shell Arguments): === modified file 'doc/lispref/files.texi' --- doc/lispref/files.texi 2012-04-14 01:59:01 +0000 +++ doc/lispref/files.texi 2012-04-15 13:47:26 +0000 @@ -489,11 +489,13 @@ @defopt require-final-newline This variable determines whether files may be written out that do @emph{not} end with a newline. If the value of the variable is -@code{t}, then @code{save-buffer} silently adds a newline at the end of -the file whenever the buffer being saved does not already end in one. -If the value of the variable is non-@code{nil}, but not @code{t}, then -@code{save-buffer} asks the user whether to add a newline each time the -case arises. +@code{t}, then @code{save-buffer} silently adds a newline at the end +of the buffer whenever it does not already end in one. If the value +is @code{visit}, a newline is added at the end of buffer that doesn't +have one, just after the file is visited. If the value is +@code{visit-save}, a newline is added both on visiting and on saving. +For every other non-@code{nil} value, @code{save-buffer} asks the user +whether to add a newline each time the case arises. If the value of the variable is @code{nil}, then @code{save-buffer} doesn't add newlines at all. @code{nil} is the default value, but a few === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-04-15 09:16:50 +0000 +++ lisp/ChangeLog 2012-04-15 13:17:00 +0000 @@ -445,6 +445,11 @@ * notifications.el (notifications-notify): Fix docstring. +2012-04-02 Christopher Schmidt + + * files.el (after-find-file): Do not add a newline at the end when + buffer is read-only. + 2012-04-02 Glenn Morris * emacs-lisp/authors.el (authors-aliases): Another addition. === modified file 'lisp/files.el' --- lisp/files.el 2012-04-14 01:46:06 +0000 +++ lisp/files.el 2012-04-15 13:15:13 +0000 @@ -2152,6 +2152,7 @@ (/= (char-after (1- (point-max))) ?\n) (not (and (eq selective-display t) (= (char-after (1- (point-max))) ?\r))) + (not buffer-read-only) (save-excursion (goto-char (point-max)) (insert "\n"))) --=-=-= Content-Type: text/plain Christopher --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 18 02:25:58 2012 Received: (at control) by debbugs.gnu.org; 18 Apr 2012 06:25:58 +0000 Received: from localhost ([127.0.0.1]:39165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKOKw-0005TQ-8T for submit@debbugs.gnu.org; Wed, 18 Apr 2012 02:25:56 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:34837 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKOKs-0005TF-6f for control@debbugs.gnu.org; Wed, 18 Apr 2012 02:25:51 -0400 Received: from [155.69.17.204] (port=56091 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SKOKf-00065Z-BB for control@debbugs.gnu.org; Wed, 18 Apr 2012 02:25:37 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11156 Date: Wed, 18 Apr 2012 14:25:31 +0800 Message-ID: <87vckxk144.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 11156 thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 18 02:26:15 2012 Received: (at submit) by debbugs.gnu.org; 18 Apr 2012 06:26:15 +0000 Received: from localhost ([127.0.0.1]:39170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKOL8-0005UK-DY for submit@debbugs.gnu.org; Wed, 18 Apr 2012 02:26:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60594) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SKOL1-0005TP-8D for submit@debbugs.gnu.org; Wed, 18 Apr 2012 02:26:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKOKg-00053D-1q for submit@debbugs.gnu.org; Wed, 18 Apr 2012 02:25:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKOKf-000539-Ug for submit@debbugs.gnu.org; Wed, 18 Apr 2012 02:25:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKOKa-0001CP-Vo for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2012 02:25:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SKOKW-0004yR-3Q for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2012 02:25:32 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SKOKW-0004y8-00 for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2012 02:25:28 -0400 Received: from [155.69.17.204] (port=56090 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SKOKU-000659-R0 for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2012 02:25:27 -0400 From: Chong Yidong To: bug-gnu-emacs@gnu.org Subject: Re: bug#11156: 24.0.95; require-final-newline and read-only files References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> <20120415134821.0001E20235@saturn.ch.ristopher.com> Date: Wed, 18 Apr 2012 14:25:20 +0800 In-Reply-To: <20120415134821.0001E20235@saturn.ch.ristopher.com> (Christopher Schmidt's message of "Sun, 15 Apr 2012 15:48:24 +0200") Message-ID: <87k41d4kvj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Christopher Schmidt writes: >> `after-find-file' shouldn't try adding a newline if `buffer-read-only' >> is non-nil. And the values 'visit and 'visit-save should be >> documented in the Elisp manual. > > === modified file 'doc/lispref/ChangeLog' > ... Thanks, committed to the repository. From debbugs-submit-bounces@debbugs.gnu.org Tue May 01 13:04:37 2012 Received: (at submit) by debbugs.gnu.org; 1 May 2012 17:04:37 +0000 Received: from localhost ([127.0.0.1]:32776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPGVA-0002xL-NZ for submit@debbugs.gnu.org; Tue, 01 May 2012 13:04:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SPGV9-0002x8-6v for submit@debbugs.gnu.org; Tue, 01 May 2012 13:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPGTc-00010b-Ud for submit@debbugs.gnu.org; Tue, 01 May 2012 13:03:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPGTc-00010X-Ok for submit@debbugs.gnu.org; Tue, 01 May 2012 13:03:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPGTb-0006Mf-7v for bug-gnu-emacs@gnu.org; Tue, 01 May 2012 13:03:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SPGTZ-000109-8y for bug-gnu-emacs@gnu.org; Tue, 01 May 2012 13:02:58 -0400 Received: from ristopher.com ([146.185.21.93]:54236 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SPGTY-0000zt-RQ for bug-gnu-emacs@gnu.org; Tue, 01 May 2012 13:02:57 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 64A6B20269; Tue, 1 May 2012 18:02:52 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1335891772; bh=Cmht7o0ld0vwDtVHBEdExi3GZay+2IiJXenkPw0sYKE=; h=From:To:Subject:In-Reply-To:References:Date:MIME-Version: Content-Type:Message-Id; b=zsO+v/VGI64OYYnSEs/hx3irb2NXGAshFwm5kz58Vd/yYV16U1CGwU0+rtvjn//8d eFRfcvMwC9rRsL9yNZnf7ydVPYF2Bu+Mu5FEYQfT7QCPlfkk+toicg1BCd+41jkSj9 ysMJ7ySy9y38dW4O3lTB8bkSjO9QpLE7Nd2PovuI= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: Re: bug#11156: 24.0.95; require-final-newline and read-only files In-Reply-To: <87k41d4kvj.fsf@gnu.org> (Chong Yidong's message of "Wed, 18 Apr 2012 14:25:20 +0800") References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> <20120415134821.0001E20235@saturn.ch.ristopher.com> <87k41d4kvj.fsf@gnu.org> Mail-Followup-To: bug-gnu-emacs@gnu.org Date: Tue, 01 May 2012 19:02:46 +0200 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <20120501170252.64A6B20269@saturn.ch.ristopher.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Chong Yidong writes: > Thanks, committed to the repository. Thank you. Could the patch also be applied to the emacs-24 branch? Christopher From debbugs-submit-bounces@debbugs.gnu.org Sun May 06 01:03:09 2012 Received: (at 11156) by debbugs.gnu.org; 6 May 2012 05:03:09 +0000 Received: from localhost ([127.0.0.1]:37641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SQtci-0002Ps-1P for submit@debbugs.gnu.org; Sun, 06 May 2012 01:03:08 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:54682 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SQtcf-0002Pk-40 for 11156@debbugs.gnu.org; Sun, 06 May 2012 01:03:06 -0400 Received: from bb116-15-158-8.singnet.com.sg ([116.15.158.8]:51619 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SQtao-00030K-Ja for 11156@debbugs.gnu.org; Sun, 06 May 2012 01:01:11 -0400 From: Chong Yidong To: 11156@debbugs.gnu.org Subject: Re: bug#11156: 24.0.95; require-final-newline and read-only files References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> <20120415134821.0001E20235@saturn.ch.ristopher.com> <87k41d4kvj.fsf@gnu.org> <20120501170252.64A6B20269@saturn.ch.ristopher.com> Date: Sun, 06 May 2012 13:01:04 +0800 In-Reply-To: <20120501170252.64A6B20269@saturn.ch.ristopher.com> (Christopher Schmidt's message of "Tue, 01 May 2012 19:02:46 +0200") Message-ID: <87obq1c38v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11156 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Christopher Schmidt writes: >> Thanks, committed to the repository. > > Thank you. Could the patch also be applied to the emacs-24 branch? Doesn't seem important enough for that. From unknown Sun Aug 17 22:01:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Jun 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 02 14:49:01 2012 Received: (at control) by debbugs.gnu.org; 2 Sep 2012 18:49:01 +0000 Received: from localhost ([127.0.0.1]:34789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8FED-0001uj-47 for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:49:01 -0400 Received: from ristopher.com ([146.185.21.93]:51400 helo=saturn.ch.ristopher.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8FEB-0001uc-Nh for control@debbugs.gnu.org; Sun, 02 Sep 2012 14:49:00 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 996B420D26; Sun, 2 Sep 2012 19:47:30 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1346611650; bh=twHbGEdSWNlDij21sPfR0XPsHCldy/GkNqvFCXISY6A=; h=From:To:Subject:Message-ID:MIME-Version:Content-Type:Date; b=EAT4hMu3k+M7oNVIiJAz61etb98gBkGjSiPtenZ9U0Z2CqnsqzHLhDuH71NwtYwdm l1LFnPAQ6uSwcoJrVVgdHRzwUm3GlmjDk8VfA+aA6pUDoT+pg7iPvc57T8j6Dhe2k3 misdSfjTcPuJSyPB2Gj3jDOGAkeJQ8QTS7tdWrdM= From: Christopher Schmidt To: control@debbugs.gnu.org Subject: unarchive 11156 Message-ID: <87oblofeiq@ch.ristopher.com> MIME-Version: 1.0 Content-Type: text/plain Date: Sun, 2 Sep 2012 19:47:30 +0100 (BST) X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) unarchive 11156 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 02 14:57:09 2012 Received: (at submit) by debbugs.gnu.org; 2 Sep 2012 18:57:10 +0000 Received: from localhost ([127.0.0.1]:34826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8FM5-000279-6K for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:57:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42352) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T8FM3-000273-9u for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8FKc-0001M6-IJ for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:55:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FKc-0001M2-F6 for submit@debbugs.gnu.org; Sun, 02 Sep 2012 14:55:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FKb-0007aU-K2 for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8FKa-0001Lq-Og for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:55:37 -0400 Received: from ristopher.com ([146.185.21.93]:54233 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8FKa-0001Lm-FJ for bug-gnu-emacs@gnu.org; Sun, 02 Sep 2012 14:55:36 -0400 Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 8EFE020D26; Sun, 2 Sep 2012 19:55:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1346612134; bh=t0nKWigAP26gsZRp0f8LxdxsOD/heVa8nYisOWo0axg=; h=From:To:Subject:In-Reply-To:References:Message-ID:MIME-Version: Content-Type:Date; b=Gsg9HuOkTBZGUyc7/b3MYy8iA93fb/rdAr1Il6hldeQS70dxTdQNft+ll+JaV8Tz/ BqwfvLqrlTKRdM3mHI7UTTiK6VuQRf6S1jStXutukPzdX1pUnfHtagAjZIiPbUU/Sz ld720LEW7lBUzpMHiIsO8sLQ12EWj39Vv/u1M0Cg= From: Christopher Schmidt To: bug-gnu-emacs@gnu.org Subject: bug#11156: 24.2.50; require-final-newline and read-only files (was: bug#11156: 24.0.95; require-final-newline and read-only files) In-Reply-To: <87k41d4kvj.fsf@gnu.org> (Chong Yidong's message of "Wed, 18 Apr 2012 14:25:20 +0800") References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> <20120415134821.0001E20235@saturn.ch.ristopher.com> <87k41d4kvj.fsf@gnu.org> Message-ID: <87ligsw8yy.fsf_-_@earth.home> Mail-Followup-To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain Date: Sun, 2 Sep 2012 19:55:34 +0100 (BST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) reopen 11156 Chong Yidong writes: > Christopher Schmidt writes: > >>> `after-find-file' shouldn't try adding a newline if >>> `buffer-read-only' is non-nil. And the values 'visit and >>> 'visit-save should be documented in the Elisp manual. >> >> === modified file 'doc/lispref/ChangeLog' >> ... > > Thanks, committed to the repository. There is still a minor bug in regard to require-final-newline. Recipe: emacs -q M-: (setq require-final-newline 'visit) Open an image file via C-x C-f There is a new buffer but no window displays it. The *Messages*-buffer contains "find-file-noselect-1: Text is read-only". This is because image-mode sets the read-only property of the whole buffer string to t. buffer-read-only is nil in this case, though. I think all code fragments that try to add new lines due to require-final-newline should ignore text-read-only errors. Christopher From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 07 06:54:03 2012 Received: (at 11156) by debbugs.gnu.org; 7 Sep 2012 10:54:03 +0000 Received: from localhost ([127.0.0.1]:45560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9wCJ-00072e-Dm for submit@debbugs.gnu.org; Fri, 07 Sep 2012 06:54:03 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:52774) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9wCG-00072F-Q1 for 11156@debbugs.gnu.org; Fri, 07 Sep 2012 06:54:01 -0400 Received: by ieak13 with SMTP id k13so4757754iea.3 for <11156@debbugs.gnu.org>; Fri, 07 Sep 2012 03:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=lg1TNY+GTxNFrmdWNpxaCBiDsbdgQ02S9QTKoMG+yJU=; b=sAS2mrp/mFAZ/ben5GzyQLRf+SipQbawuTTx/NlCSAATUXIpct3ui+jlmHpSAH3CfA SyzHuZVDWlmEqIw/BgxTPJfEFS2zSZd65pS4bTGaG6YtRrb/2EikZqmQZQFfHJn+Qfoe gpKq5pxNQOWI6tV/063gS9HW+y3f7xHDOf/NUi4ADkWYKY1yKOI73Em+ok0AhzR8cmBp qIWc6/30CfPX1vPDHYNkGF/J3QSAseYdO7rVFw/kpHjn0V75EzxfV/HP/filWj6LesyP 097EF6V+HwTnjzJMhxYU/PRJPRTaaK22AY/IpnytFbdEnJIQtgi4ByKEwwiDehMGIMEt Qtmg== Received: by 10.50.220.194 with SMTP id py2mr8032714igc.15.1347015223075; Fri, 07 Sep 2012 03:53:43 -0700 (PDT) Received: from ulysses ([155.69.18.183]) by mx.google.com with ESMTPS id va9sm7662343igb.17.2012.09.07.03.53.40 (version=SSLv3 cipher=OTHER); Fri, 07 Sep 2012 03:53:42 -0700 (PDT) From: Chong Yidong To: 11156@debbugs.gnu.org Subject: Re: bug#11156: 24.2.50; require-final-newline and read-only files References: <20120402215210.3718F201C8@saturn.ch.ristopher.com> <20120414134925.D1D9B20217@saturn.ch.ristopher.com> <4F89C879.6070209@gmx.at> <20120415134821.0001E20235@saturn.ch.ristopher.com> <87k41d4kvj.fsf@gnu.org> <87ligsw8yy.fsf_-_@earth.home> Date: Fri, 07 Sep 2012 18:53:37 +0800 In-Reply-To: <87ligsw8yy.fsf_-_@earth.home> (Christopher Schmidt's message of "Sun, 2 Sep 2012 19:55:34 +0100 (BST)") Message-ID: <87r4qertn2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11156 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Christopher Schmidt writes: > There is still a minor bug in regard to require-final-newline. > > Recipe: > emacs -q > M-: (setq require-final-newline 'visit) > Open an image file via C-x C-f > > There is a new buffer but no window displays it. The *Messages*-buffer > contains "find-file-noselect-1: Text is read-only". > > I think all code fragments that try to add new lines due to > require-final-newline should ignore text-read-only errors. Fixed, thanks. From unknown Sun Aug 17 22:01:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Oct 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator