From unknown Wed Jun 25 05:38:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11141 <11141@debbugs.gnu.org> To: bug#11141 <11141@debbugs.gnu.org> Subject: Status: 24.0.94; crash with `x-popup-dialog' Reply-To: bug#11141 <11141@debbugs.gnu.org> Date: Wed, 25 Jun 2025 12:38:49 +0000 retitle 11141 24.0.94; crash with `x-popup-dialog' reassign 11141 emacs submitter 11141 "Drew Adams" severity 11141 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 31 17:24:05 2012 Received: (at submit) by debbugs.gnu.org; 31 Mar 2012 21:24:05 +0000 Received: from localhost ([127.0.0.1]:33310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SE5mG-0006o9-Dk for submit@debbugs.gnu.org; Sat, 31 Mar 2012 17:24:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46571) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SE5mD-0006nl-RQ for submit@debbugs.gnu.org; Sat, 31 Mar 2012 17:24:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SE5m5-00082e-K9 for submit@debbugs.gnu.org; Sat, 31 Mar 2012 17:23:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE5m5-00082Y-Go for submit@debbugs.gnu.org; Sat, 31 Mar 2012 17:23:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE5m3-00034v-PT for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 17:23:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SE5m1-00082G-Ts for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 17:23:51 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:20527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SE5m1-00081y-Ns for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2012 17:23:49 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q2VLNkgW029186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 31 Mar 2012 21:23:47 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q2VLNjZD016967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 31 Mar 2012 21:23:46 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q2VLNjhJ029318 for ; Sat, 31 Mar 2012 16:23:45 -0500 Received: from dradamslap1 (/10.159.47.251) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 31 Mar 2012 14:23:45 -0700 From: "Drew Adams" To: Subject: 24.0.94; crash with `x-popup-dialog' Date: Sat, 31 Mar 2012 14:23:37 -0700 Message-ID: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac0PhIiUFkAR/m0IRN6/3PJCDrqSag== X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4F7775E3.0029,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) 100% reproducible, from emacs -Q. (defun titi (event) (interactive "e") (let ((choice (x-popup-dialog event '("ABC" "DEF" ("OK" . bar))))) (and choice (call-interactively choice)))) (defun bar () (interactive) t) (global-set-key [double-mouse-2] 'titi) (global-set-key [mouse-2] nil) Then double-click mouse-2. Note that if you remove the string "DEF" there is no crash. In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600) of 2012-03-19 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 01 02:18:04 2012 Received: (at 11141) by debbugs.gnu.org; 1 Apr 2012 06:18:04 +0000 Received: from localhost ([127.0.0.1]:33498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEE71-0003NC-PV for submit@debbugs.gnu.org; Sun, 01 Apr 2012 02:18:04 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:38382) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEE6y-0003Mn-3k for 11141@debbugs.gnu.org; Sun, 01 Apr 2012 02:18:03 -0400 Received: from bb121-6-72-34.singnet.com.sg ([121.6.72.34]:33450 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SEE6n-0003IT-Fq; Sun, 01 Apr 2012 02:17:50 -0400 From: Chong Yidong To: "Drew Adams" Subject: Re: bug#11141: 24.0.94; crash with `x-popup-dialog' References: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> Date: Sun, 01 Apr 2012 14:17:42 +0800 In-Reply-To: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> (Drew Adams's message of "Sat, 31 Mar 2012 14:23:37 -0700") Message-ID: <87y5qgou0p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11141 Cc: 11141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) "Drew Adams" writes: > 100% reproducible, from emacs -Q. > > (defun titi (event) > (interactive "e") > (let ((choice (x-popup-dialog > event > '("ABC" > "DEF" > ("OK" . bar))))) > (and choice (call-interactively choice)))) > > (defun bar () (interactive) t) > > (global-set-key [double-mouse-2] 'titi) > (global-set-key [mouse-2] nil) > > Then double-click mouse-2. Note that if you remove the string "DEF" > there is no crash. No crash on latest trunk, x86_64-unknown-linux-gnu. Maybe a Windows issue. Any backtrace? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 01 02:32:13 2012 Received: (at 11141) by debbugs.gnu.org; 1 Apr 2012 06:32:13 +0000 Received: from localhost ([127.0.0.1]:33514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEEKi-0004Vr-R1 for submit@debbugs.gnu.org; Sun, 01 Apr 2012 02:32:13 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:22690) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEEKg-0004Vj-5m for 11141@debbugs.gnu.org; Sun, 01 Apr 2012 02:32:11 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q316Vxqg011271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 1 Apr 2012 06:32:00 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q316VwKp026342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 1 Apr 2012 06:31:59 GMT Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q316VwsH009680; Sun, 1 Apr 2012 01:31:58 -0500 Received: from dradamslap1 (/10.159.53.220) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 31 Mar 2012 23:31:57 -0700 From: "Drew Adams" To: "'Chong Yidong'" References: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> <87y5qgou0p.fsf@gnu.org> Subject: RE: bug#11141: 24.0.94; crash with `x-popup-dialog' Date: Sat, 31 Mar 2012 23:31:49 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87y5qgou0p.fsf@gnu.org> Thread-Index: Ac0PzyzttSE++huRRaSIDiIclnYrVgAABcIg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090204.4F77F661.0001,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11141 Cc: 11141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > No crash on latest trunk, x86_64-unknown-linux-gnu. Maybe a Windows > issue. Any backtrace? $ ./gdb -p 5128 GNU gdb (GDB) 7.2 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "mingw32". For bug reporting instructions, please see: . Attaching to process 5128 [New Thread 5128.0xfdc] [New Thread 5128.0xc58] [New Thread 5128.0x1584] Reading symbols from C:\Emacs-24-2012-03-19\bin\emacs.exe...done. [Switching to Thread 5128.0x1584] Warning: c:\drews-lisp-20\bin/../lwlib: No such file or directory. SIGINT is used by the debugger. Are you sure you want to change it? (y or n) [answered Y; input not from terminal] Environment variable "DISPLAY" not defined. TERM = cygwin .gdbinit:1328: Error in sourced command file: No symbol "Vsystem_type" in current context. (gdb) c Continuing. Program received signal SIGTRAP, Trace/breakpoint trap. [Switching to Thread 5128.0xfdc] 0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.dll (gdb) bt #0 0x7c90120f in ntdll!DbgUiConnectToDbg () from C:\WINDOWS\system32\ntdll.dll #1 0x0114f2fe in w32_abort () at w32fns.c:7210 #2 0x010421b3 in die ( msg=0x15d2e48 "assertion failed: CONSP (((0+(((((((((enum Lisp_Type) ((((options))) & ((((int) 1) << 3) - 1))) == Lisp_Cons)) || suppress_checking ? (void) 0 : die ((\"assertio n failed: \" \"CONSP ((options))\"), \"w32me"..., file=0x15d26b7 "w32menu.c", line=1185) at alloc.c:6339 #3 0x012b59ab in is_simple_dialog (contents=75445966) at w32menu.c:1185 #4 0x012b3507 in Fx_popup_dialog (position=74376382, contents=75445966, header=54724634) at w32menu.c:195 #5 0x01034e58 in eval_sub (form=75445950) at eval.c:2356 #6 0x01031fed in Flet (args=75446038) at eval.c:1090 #7 0x01034965 in eval_sub (form=75445934) at eval.c:2298 #8 0x010301ee in Fprogn (args=75446094) at eval.c:364 #9 0x01037a0f in funcall_lambda (fun=75446182, nargs=1, arg_vector=0x83f944) at eval.c:3226 #10 0x010370ed in Ffuncall (nargs=2, args=0x83f940) at eval.c:3063 #11 0x010e354c in Fcall_interactively (function=76468802, record_flag=54724634, keys=54745861) at callint.c:852 #12 0x01036cf3 in Ffuncall (nargs=4, args=0x83fb70) at eval.c:3009 #13 0x0103620f in call3 (fn=54844778, arg1=76468802, arg2=54724634, arg3=54724634) at eval.c:2802 #14 0x0101f9e2 in Fcommand_execute (cmd=76468802, record_flag=54724634, keys=54724634, special=54724634) at keyboard.c:10328 #15 0x0100658f in command_loop_1 () at keyboard.c:1571 #16 0x01032beb in internal_condition_case (bfun=0x100569b , handlers=54782362, hfun=0x1004eba ) at eval.c:1515 #17 0x010052f7 in command_loop_2 (ignore=54724634) at keyboard.c:1159 #18 0x0103260e in internal_catch (tag=54780386, func=0x10052d3 , arg=54724634) at eval.c:1272 #19 0x010052b3 in command_loop () at keyboard.c:1138 #20 0x0100488f in recursive_edit_1 () at keyboard.c:758 #21 0x01004baa in Frecursive_edit () at keyboard.c:822 #22 0x010028b5 in main (argc=3, argv=0x33c68) at emacs.c:1715 Lisp Backtrace: "x-popup-dialog" (0x83f574) "let" (0x83f75c) "titi" (0x83f944) "call-interactively" (0x83fb74) (gdb) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 01 02:35:10 2012 Received: (at 11141) by debbugs.gnu.org; 1 Apr 2012 06:35:10 +0000 Received: from localhost ([127.0.0.1]:33518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEENZ-0004aG-M8 for submit@debbugs.gnu.org; Sun, 01 Apr 2012 02:35:10 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:23076) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEENX-0004a7-99 for 11141@debbugs.gnu.org; Sun, 01 Apr 2012 02:35:08 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q316YvHY012659 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 1 Apr 2012 06:34:58 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q316YuO1003453 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 1 Apr 2012 06:34:57 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q316YuTM010629; Sun, 1 Apr 2012 01:34:56 -0500 Received: from dradamslap1 (/10.159.53.220) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 31 Mar 2012 23:34:55 -0700 From: "Drew Adams" To: "'Drew Adams'" , "'Chong Yidong'" References: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com><87y5qgou0p.fsf@gnu.org> Subject: RE: bug#11141: 24.0.94; crash with `x-popup-dialog' Date: Sat, 31 Mar 2012 23:34:47 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac0PzyzttSE++huRRaSIDiIclnYrVgAABcIgAACH7aA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-CT-RefId: str=0001.0A090208.4F77F712.0028,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11141 Cc: 11141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > No crash on latest trunk, x86_64-unknown-linux-gnu. Maybe a Windows > > issue. Sounds likely. Windows has its own implementation of `x-popup-dialog'. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 01 03:17:03 2012 Received: (at 11141) by debbugs.gnu.org; 1 Apr 2012 07:17:03 +0000 Received: from localhost ([127.0.0.1]:33550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEF27-0005ZO-4S for submit@debbugs.gnu.org; Sun, 01 Apr 2012 03:17:03 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:60941) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SEF24-0005Yv-KR for 11141@debbugs.gnu.org; Sun, 01 Apr 2012 03:17:02 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VL7D24fqFz3hhVk; Sun, 1 Apr 2012 09:16:48 +0200 (CEST) Received: from linux.local (ppp-88-217-123-48.dynamic.mnet-online.de [88.217.123.48]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VL7D00J5lz4KK3l; Sun, 1 Apr 2012 09:16:47 +0200 (CEST) Received: by linux.local (Postfix, from userid 501) id 8701A1E52D1; Sun, 1 Apr 2012 09:16:57 +0200 (CEST) From: Andreas Schwab To: "Drew Adams" Subject: Re: bug#11141: 24.0.94; crash with `x-popup-dialog' References: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> <87y5qgou0p.fsf@gnu.org> X-Yow: Yow! STYROFOAM.. Date: Sun, 01 Apr 2012 09:16:57 +0200 In-Reply-To: (Drew Adams's message of "Sat, 31 Mar 2012 23:31:49 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11141 Cc: 'Chong Yidong' , 11141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Please try this. Andreas. * w32menu.c (is_simple_dialog): Properly check lisp types. diff --git a/src/w32menu.c b/src/w32menu.c index b5cc680..b25edf0 100644 --- a/src/w32menu.c +++ b/src/w32menu.c @@ -1173,18 +1173,23 @@ w32_dialog_show (FRAME_PTR f, int keymaps, static int is_simple_dialog (Lisp_Object contents) { - Lisp_Object options = XCDR (contents); + Lisp_Object options; Lisp_Object name, yes, no, other; + if (!CONSP (contents)) + return 0; + options = XCDR (contents); + yes = build_string ("Yes"); no = build_string ("No"); if (!CONSP (options)) return 0; - name = XCAR (XCAR (options)); - if (!CONSP (options)) + name = XCAR (options); + if (!CONSP (name)) return 0; + name = XCAR (name); if (!NILP (Fstring_equal (name, yes))) other = no; @@ -1197,7 +1202,10 @@ is_simple_dialog (Lisp_Object contents) if (!CONSP (options)) return 0; - name = XCAR (XCAR (options)); + name = XCAR (options); + if (!CONSP (name)) + return 0; + name = XCAR (name); if (NILP (Fstring_equal (name, other))) return 0; -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 01 12:35:27 2012 Received: (at 11141) by debbugs.gnu.org; 1 Apr 2012 16:35:27 +0000 Received: from localhost ([127.0.0.1]:34981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SENkU-00034L-H5 for submit@debbugs.gnu.org; Sun, 01 Apr 2012 12:35:27 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:62449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SENkR-00034D-GP for 11141@debbugs.gnu.org; Sun, 01 Apr 2012 12:35:24 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M1T006007AL5J00@a-mtaout22.012.net.il> for 11141@debbugs.gnu.org; Sun, 01 Apr 2012 19:34:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.100.223]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M1T006937DS4830@a-mtaout22.012.net.il>; Sun, 01 Apr 2012 19:34:41 +0300 (IDT) Date: Sun, 01 Apr 2012 19:34:47 +0300 From: Eli Zaretskii Subject: Re: bug#11141: 24.0.94; crash with `x-popup-dialog' In-reply-to: X-012-Sender: halo1@inter.net.il To: Andreas Schwab Message-id: <834nt3jtqw.fsf@gnu.org> References: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> <87y5qgou0p.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 11141 Cc: cyd@gnu.org, 11141@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Andreas Schwab > Date: Sun, 01 Apr 2012 09:16:57 +0200 > Cc: 'Chong Yidong' , 11141@debbugs.gnu.org > > Please try this. > > Andreas. > > * w32menu.c (is_simple_dialog): Properly check lisp types. Works for me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 01 12:46:45 2012 Received: (at 11141-done) by debbugs.gnu.org; 1 Apr 2012 16:46:45 +0000 Received: from localhost ([127.0.0.1]:34986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SENvR-0003Mf-09 for submit@debbugs.gnu.org; Sun, 01 Apr 2012 12:46:45 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:48913) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SENvO-0003MY-KJ for 11141-done@debbugs.gnu.org; Sun, 01 Apr 2012 12:46:43 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3VLMsL739qz4LDds for <11141-done@debbugs.gnu.org>; Sun, 1 Apr 2012 18:46:30 +0200 (CEST) Received: from linux.local (ppp-88-217-123-48.dynamic.mnet-online.de [88.217.123.48]) by mail.mnet-online.de (Postfix) with ESMTPA id 3VLMsL0VMQz4KK3v for <11141-done@debbugs.gnu.org>; Sun, 1 Apr 2012 18:46:30 +0200 (CEST) Received: by linux.local (Postfix, from userid 501) id 67D5C1E5306; Sun, 1 Apr 2012 18:46:29 +0200 (CEST) From: Andreas Schwab To: 11141-done@debbugs.gnu.org Subject: Re: bug#11141: 24.0.94; crash with `x-popup-dialog' References: <6BE6D98D3BE7424E993D454647337EA9@us.oracle.com> <87y5qgou0p.fsf@gnu.org> <834nt3jtqw.fsf@gnu.org> X-Yow: Somewhere in Tenafly, New Jersey, a chiropractor is viewing ``Leave it to Beaver''! Date: Sun, 01 Apr 2012 18:46:29 +0200 In-Reply-To: <834nt3jtqw.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 Apr 2012 19:34:47 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11141-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Fixed. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Wed Jun 25 05:38:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Apr 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator