GNU bug report logs - #11134
24.0.94; Mac's Text to Speech stopped working in emacs buffers when I moved from Snow Leopard to Lion

Previous Next

Packages: ns, emacs;

Reported by: Charles Magid <cmmagid <at> gmail.com>

Date: Fri, 30 Mar 2012 18:43:02 UTC

Severity: wishlist

Tags: patch

Found in version 24.0.94

Done: Jan Djärv <jan.h.d <at> swipnet.se>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
Cc: Charles Magid <cmmagid <at> gmail.com>, 11134 <at> debbugs.gnu.org, Jan Djärv <jan.h.d <at> swipnet.se>
Subject: bug#11134: 24.0.94; Mac's Text to Speech stopped working in emacs buffers when I moved	from Snow Leopard to Lion
Date: Sun, 01 Apr 2012 09:26:03 -0400
>> The NS port does not support accessability at all, but if it is the
>> function described by YAMAMOTO Mitsuharu above you want, try the
>> patch below.
>> +  else if ([attribute isEqualToString:NSAccessibilityValueAttribute])
>> +    {
>> +      if (! NILP (BVAR (current_buffer, mark_active)))
>> +        str = ns_get_local_selection (QPRIMARY, QUTF8_STRING);
>> +      if (NILP (str))
>> +        str = Fbuffer_string ();
>> +    }
> Is it safe to call Fbuffer_string (in particular, move the gap) inside
> read_socket_hook?  It is apparently unsafe without SYNC_INPUT, but I'm
> not sure if it is supposed to be OK for the SYNC_INPUT case.

Indeed without SYNC_INPUT it's clearly unsafe (not just because of
move_gap).

And to tell you the truth, I'm not sure either what is safe with
SYNC_INPUT and what isn't.

This said, it shouldn't be difficult to change make_buffer_string_both
such that it doesn't need to move the gap, at which point I think it
would be OK.


        Stefan




This bug report was last modified 12 years and 311 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.