From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 30 04:58:57 2012 Received: (at submit) by debbugs.gnu.org; 30 Mar 2012 08:58:57 +0000 Received: from localhost ([127.0.0.1]:45980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDXfd-0002aW-B4 for submit@debbugs.gnu.org; Fri, 30 Mar 2012 04:58:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42687) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDXfb-0002aQ-Qs for submit@debbugs.gnu.org; Fri, 30 Mar 2012 04:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDXB5-0006r5-3J for submit@debbugs.gnu.org; Fri, 30 Mar 2012 04:27:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,RCVD_IN_XBL,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:39008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDXB4-0006qI-TQ for submit@debbugs.gnu.org; Fri, 30 Mar 2012 04:27:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDXAy-0005Ko-Rv for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 04:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDXAs-0006nz-G8 for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 04:27:16 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:45286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDXAs-0006nr-9H for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 04:27:10 -0400 Received: by ghrr18 with SMTP id r18so167612ghr.0 for ; Fri, 30 Mar 2012 01:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=F2KijuGUSwFoH9vDLegmRbxdqWBlmNjpbnVjKtijRyc=; b=uPUXdk0mGCSC7PVLQwxX0/XEOmfQBoLSwWznMF19Ry99Rq7TS5iDmEO6nQs+WQ+FVL XqzzfXb2amzkqfKZbPF2yvTG725CD+1YB9aLJRGzRBmTeWi9VKN6kVXjL/7eOyU+i+YM rXbDY5p2gnbLUO8mZoNDEm/8EwAaHQnUoF+Mntzb2wh59fqo6qiCWGY+NxLRn9p74RGd C8aB9ktXIZmnJgVRGKViQKea2TXb8MPydgjFLFKBMEoTaEfAzaKErAmOFOePp80IpWlr G8JHX9z3mQLLod6HN7F1e1tdT7s/a+zNoXhHIfu6yBM2H1xaJvJWOC6dpDwjNbOx+J+j WWEw== Received: by 10.68.136.10 with SMTP id pw10mr7336488pbb.134.1333096028186; Fri, 30 Mar 2012 01:27:08 -0700 (PDT) Received: from JAMBU-NETBOOK ([115.242.172.67]) by mx.google.com with ESMTPS id ml10sm261773pbc.29.2012.03.30.01.27.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Mar 2012 01:27:07 -0700 (PDT) From: Jambunathan K To: bug-gnu-emacs@gnu.org Subject: 24.0.94; Apropos bookmarks Date: Fri, 30 Mar 2012 13:56:49 +0530 Message-ID: <81sjgqqyt2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Please provide an ido-like completion read for C-x r b. Please provide a convenient default for C-x r m. You can work out the details. Some context: As a developer, I used to use cscope to browse C code. Whenever I jump to a symbol definition using cscope, I had a small hook which would automatically set the bookmark at the function definition, with the bookmark name given by the which-function or the symbol that I looked up in the first place. /very long time back/, I had used one of the completion packages (icomplete?, pcomplete?, mcomplete?) to enable ido-like completion for bookmark names. In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600) of 2012-03-19 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 30 09:17:35 2012 Received: (at 11131) by debbugs.gnu.org; 30 Mar 2012 13:17:35 +0000 Received: from localhost ([127.0.0.1]:46342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDbhu-0001UK-U8 for submit@debbugs.gnu.org; Fri, 30 Mar 2012 09:17:35 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:56044) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDbhs-0001UB-IR for 11131@debbugs.gnu.org; Fri, 30 Mar 2012 09:17:33 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9MCqRV/2dsb2JhbACBX5x7eYhwnhmGGQSbGYQJ X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="170667392" Received: from 76-10-164-85.dsl.teksavvy.com (HELO pastel.home) ([76.10.164.85]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Mar 2012 08:45:59 -0400 Received: by pastel.home (Postfix, from userid 20848) id 63BCC59276; Fri, 30 Mar 2012 08:45:59 -0400 (EDT) From: Stefan Monnier To: Jambunathan K Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Message-ID: References: <81sjgqqyt2.fsf@gmail.com> Date: Fri, 30 Mar 2012 08:45:59 -0400 In-Reply-To: <81sjgqqyt2.fsf@gmail.com> (Jambunathan K.'s message of "Fri, 30 Mar 2012 13:56:49 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Please provide an ido-like completion read for C-x r b. It's a bit late to change things for 24.1, but for 24.2 we can adjust. Which part of "ido-like" would you like to see there? > Please provide a convenient default for C-x r m. You can work out the > details. C-x r m already provides a default, so could you give some more details as to what kind of default would be more "convenient"? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 04:10:56 2012 Received: (at 11131) by debbugs.gnu.org; 11 Sep 2012 08:10:56 +0000 Received: from localhost ([127.0.0.1]:53578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBLYd-0004cu-TB for submit@debbugs.gnu.org; Tue, 11 Sep 2012 04:10:56 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:33375) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBLYb-0004cn-RU for 11131@debbugs.gnu.org; Tue, 11 Sep 2012 04:10:54 -0400 Received: by pbbrr4 with SMTP id rr4so441896pbb.3 for <11131@debbugs.gnu.org>; Tue, 11 Sep 2012 01:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Bi9tJ0QIXBuGQc23mvbvEBlgibL6kUF6kyOgGCFmQhY=; b=SsKe9sKkcEzIUQ0Shy9hrfBblDW2QTZmKAo6835OjJ9w0ABzqRPM0SQD2e1Q2wdNhc K73aMGNsSUqq16M0fMqus4NOxs5VaHMo8KhqaBuiYhdRlBwkGo5iFapfV7CvPOxblvtB UCwedN80Ct9RjKewq5SmvMMaSRwiNzp/DPCgMp5VceXPg0cYkBU94YU+EcQQrrfcsEmE NrpkFAESfllKNWcYIMvRQZyVQKyK79+cvCFBc+Av5Xtr3tCCJfnz36EAsXxgdlTt719F t6Rkqa/6yOawLTopA2nJZpj5IGOo9SAbtBV9OlVlXaEcFDYEwN9x/nvs2vCFAX/gocDf F/bg== Received: by 10.66.82.3 with SMTP id e3mr25770462pay.56.1347351012604; Tue, 11 Sep 2012 01:10:12 -0700 (PDT) Received: from debian-6.05 ([101.62.124.73]) by mx.google.com with ESMTPS id uu6sm9383441pbc.70.2012.09.11.01.10.08 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 01:10:11 -0700 (PDT) From: Jambunathan K To: Stefan Monnier Subject: Re: bug#11131: 24.0.94; Apropos bookmarks References: <81sjgqqyt2.fsf@gmail.com> Date: Tue, 11 Sep 2012 13:41:08 +0530 In-Reply-To: (Stefan Monnier's message of "Fri, 30 Mar 2012 08:45:59 -0400") Message-ID: <87wr01htcz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: >> Please provide an ido-like completion read for C-x r b. > > It's a bit late to change things for 24.1, but for 24.2 we can adjust. > Which part of "ido-like" would you like to see there? > >> Please provide a convenient default for C-x r m. You can work out the >> details. > > C-x r m already provides a default, so could you give some more details > as to what kind of default would be more "convenient"? Use case: ======== I mark frequently used functions with `C-x r m' and I create a bookmark to that function name using something like this in .emacs. (defadvice bookmark-set (around my-bookmark-set (name no-overwrite)) (ad-set-arg 0 (which-function)) (ad-set-arg 1 nil) (message "Bookmark: %s" (ad-get-arg 0)) ad-do-it) (ad-activate 'bookmark-set) With a simple ido-like completion (or iswitchb-like completion), I can jump to the function name quickly without typing the whole function name. (Indicative) patch ================== This is not an actual patch. Something like this will do. === modified file 'lisp/bookmark.el' --- lisp/bookmark.el 2012-08-08 08:48:57 +0000 +++ lisp/bookmark.el 2012-09-11 08:03:37 +0000 @@ -433,7 +433,7 @@ the empty string." (format " (%s): " default) ": "))) (str - (completing-read prompt + (ido-completing-read prompt bookmark-alist nil 0 Gnus also does it ================= Gnus also tries to achieve the same thing - that which I am trying to do wrt bookmarks - by it's own private user variable. ,---- from gnus-util.el :: L43 | (defcustom gnus-completing-read-function 'gnus-emacs-completing-read | "Function use to do completing read." | :version "24.1" | :group 'gnus-meta | :type `(radio (function-item | :doc "Use Emacs standard `completing-read' function." | gnus-emacs-completing-read) | ;; iswitchb.el is very old and ido.el is unavailable | ;; in XEmacs, so we exclude those function items. | ,@(unless (featurep 'xemacs) | '((function-item | :doc "Use `ido-completing-read' function." | gnus-ido-completing-read) | (function-item | :doc "Use iswitchb based completing-read function." | gnus-iswitchb-completing-read))))) `---- There is another way to do it ============================= Have bookmark use completing-read-function. Then I can set it to use ido-completing-read. ,----[ C-h v completing-read-function RET ] | completing-read-function is a variable defined in `minibuffer.el'. | Its value is completing-read-default | | This variable may be risky if used as a file-local variable. | | Documentation: | The function called by `completing-read' to do its work. | It should accept the same arguments as `completing-read'. | | [back] `---- Question ======== Now the question is, what is the best way to kill multiple mangoes with a single stone and not allow above customizations to proliferate on per-package basis. -- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 09:20:03 2012 Received: (at 11131) by debbugs.gnu.org; 11 Sep 2012 13:20:03 +0000 Received: from localhost ([127.0.0.1]:53827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBQNm-0004uU-Hq for submit@debbugs.gnu.org; Tue, 11 Sep 2012 09:20:03 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:21680) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBQNk-0004u2-Qc for 11131@debbugs.gnu.org; Tue, 11 Sep 2012 09:20:01 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09soXr9/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="198057840" Received: from 108-161-122-253.dsl.teksavvy.com (HELO pastel.home) ([108.161.122.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Sep 2012 09:19:17 -0400 Received: by pastel.home (Postfix, from userid 20848) id 81DD552309; Tue, 11 Sep 2012 09:18:59 -0400 (EDT) From: Stefan Monnier To: Jambunathan K Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Message-ID: References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> Date: Tue, 11 Sep 2012 09:18:59 -0400 In-Reply-To: <87wr01htcz.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 11 Sep 2012 13:41:08 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > With a simple ido-like completion (or iswitchb-like completion), I can > jump to the function name quickly without typing the whole function > name. Again: "Which part of "ido-like" would you like to see there?". IDO completion has many differences compared to Emacs's historical prefix-completion. But Emacs's current default completion code supports several of those features. E.g. in Emacs-24, C-x b provides substring completion (and if you enable icomplete-mode which just shows you the list of completion candidates at the end of the minibuffer, it gets even closer to iswitchb). > - (completing-read prompt > + (ido-completing-read prompt That is not an option: we want the completion behavior to be consistent, and there's nothing magical about bookmarks which justifies a thoroughly different behavior, I think. OTOH, maybe bookmarks have particular properties which justify tweaking the completion behavior for them, just like it is the case for C-x b. E.g. we could make C-x r b use substring completion. > Have bookmark use completing-read-function. It does, since it calls completing-read which in turn calls the completing-read-function. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 12:52:43 2012 Received: (at 11131) by debbugs.gnu.org; 11 Sep 2012 16:52:43 +0000 Received: from localhost ([127.0.0.1]:54926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBThb-0001gN-6K for submit@debbugs.gnu.org; Tue, 11 Sep 2012 12:52:43 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]:48912) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBThY-0001gF-EY for 11131@debbugs.gnu.org; Tue, 11 Sep 2012 12:52:41 -0400 Received: by dadf8 with SMTP id f8so431108dad.3 for <11131@debbugs.gnu.org>; Tue, 11 Sep 2012 09:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Pumqq9jgz3WP3QhAB8+QuNG+OBRFO8NOtWfSSuVXsBc=; b=AkmR0ivnRXS81+IwpwDAduKUZzEWFQVDBiosQNkQSSD4hD9/rZoVqg3G54wBcT79x3 i82XEyzKImKzpfJ3QeUjAnCseczNa45Yf/puXcswBY+wT29NqnA977I9wDevVUALdjIw 38Q5LNUPDQYzaLrwxK337i+0474MupdrfCpgdDzV3HAh8x1RdRtqj+I7qpEOpKKPZNJo qbjsoGXDmagai4Khod00E/IaxAMf4sm32tWZP8sKGurHLUE6zbw3h80hpJGpW1JCwjge tPudnyW1IWj5Yex19uB+bChXcFqyPDIf9T7iVgXsADmbvTIZUyRBd+aJptEyqYgqYzE7 md+g== Received: by 10.66.89.6 with SMTP id bk6mr27279141pab.81.1347382318556; Tue, 11 Sep 2012 09:51:58 -0700 (PDT) Received: from debian-6.05 ([101.62.98.151]) by mx.google.com with ESMTPS id pj10sm10006213pbb.46.2012.09.11.09.51.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Sep 2012 09:51:57 -0700 (PDT) From: Jambunathan K To: Stefan Monnier Subject: Re: bug#11131: 24.0.94; Apropos bookmarks References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> Date: Tue, 11 Sep 2012 22:22:50 +0530 In-Reply-To: (Stefan Monnier's message of "Tue, 11 Sep 2012 09:18:59 -0400") Message-ID: <87sjao33j1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> With a simple ido-like completion (or iswitchb-like completion), I can >> jump to the function name quickly without typing the whole function >> name. > > Again: "Which part of "ido-like" would you like to see there?". The answer has to be how the UI works (i.e., how I *interact* with the completion mechanism and not how completions are computed.) It would be wonderful if - All aspects of completion happens right within the mini-buffer. With the default interface the following are turn-offs (which is pretty much everything) - TAB, - work window getting split in to two - Using mouse or RET for final choice > IDO completion has many differences compared to Emacs's historical > prefix-completion. But Emacs's current default completion code supports > several of those features. > > E.g. in Emacs-24, C-x b provides substring completion (and if you > enable icomplete-mode which just shows you the list of completion > candidates at the end of the minibuffer, it gets even closer to > iswitchb). > >> - (completing-read prompt >> + (ido-completing-read prompt > > That is not an option: we want the completion behavior to be consistent, > and there's nothing magical about bookmarks which justifies a thoroughly > different behavior, I think. > OTOH, maybe bookmarks have particular properties which justify tweaking > the completion behavior for them, just like it is the case for C-x b. > E.g. we could make C-x r b use substring completion. Since my bookmarks are function names, substring completion is what I desire. (Many functions share the *same* prefix) [Context Switch] I think having a standard hook to choose the default name of bookmark will also be useful. In prog-modes, I will probably set it to which-function. >> Have bookmark use completing-read-function. > > It does, since it calls completing-read which in turn calls the > completing-read-function. May be there is a reason why completing-read-function is not customizable? > Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 14:05:19 2012 Received: (at 11131) by debbugs.gnu.org; 11 Sep 2012 18:05:19 +0000 Received: from localhost ([127.0.0.1]:55086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUpq-00062Y-2x for submit@debbugs.gnu.org; Tue, 11 Sep 2012 14:05:18 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52502) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBUpl-00062N-4u for 11131@debbugs.gnu.org; Tue, 11 Sep 2012 14:05:16 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q8BI4Sxu015949; Tue, 11 Sep 2012 14:04:28 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 324E2B4085; Tue, 11 Sep 2012 14:04:28 -0400 (EDT) From: Stefan Monnier To: Jambunathan K Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Message-ID: References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> Date: Tue, 11 Sep 2012 14:04:28 -0400 In-Reply-To: <87sjao33j1.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 11 Sep 2012 22:22:50 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) >>> With a simple ido-like completion (or iswitchb-like completion), >>> I can jump to the function name quickly without typing the whole >>> function name. >> Again: "Which part of "ido-like" would you like to see there?". > The answer has to be how the UI works (i.e., how I *interact* with the > completion mechanism and not how completions are computed.) In that case the change can't be active by default because that would be incompatible with our desire for a consistent completion UI. > It would be wonderful if - > All aspects of completion happens right within the mini-buffer. > With the default interface the following are turn-offs (which is pretty > much everything) > - TAB, > - work window getting split in to two > - Using mouse or RET for final choice I'm not exactly sure about what you mean by the above. IDO still uses TAB and RET in mostly similar ways to the default UI, and still splits the window when displaying the *Completions* buffer. Have you tried icomplete-mode? > Since my bookmarks are function names, substring completion is what I > desire. (Many functions share the *same* prefix) It seems this can't be changed by customizing completion-category-overrides right now, so we'll need to change bookmark.el's completion table to provide a `category'. > [Context Switch] I think having a standard hook to choose the default > name of bookmark will also be useful. In prog-modes, I will probably > set it to which-function. Sounds fine. Patch welcome. >>> Have bookmark use completing-read-function. >> It does, since it calls completing-read which in turn calls the >> completing-read-function. > May be there is a reason why completing-read-function is not > customizable? You can customize it, just not with Custom. No particular reason. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 15:31:45 2012 Received: (at 11131) by debbugs.gnu.org; 11 Sep 2012 19:31:45 +0000 Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBWBV-00083u-Kp for submit@debbugs.gnu.org; Tue, 11 Sep 2012 15:31:45 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:41458 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBWBT-00083l-C0 for 11131@debbugs.gnu.org; Tue, 11 Sep 2012 15:31:44 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id A45DB451CC73; Tue, 11 Sep 2012 12:30:59 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Organization: JURTA References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> Date: Tue, 11 Sep 2012 22:29:15 +0300 In-Reply-To: (Stefan Monnier's message of "Tue, 11 Sep 2012 14:04:28 -0400") Message-ID: <87pq5s4aus.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org, Jambunathan K X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> [Context Switch] I think having a standard hook to choose the default >> name of bookmark will also be useful. In prog-modes, I will probably >> set it to which-function. > > Sounds fine. Patch welcome. Bug#12107 added a new parameter for the default bookmark names. So `bookmark-make-record-default' could be modified to set its value from the result of a function defined by a new customizable variable (where `which-function' could be one of its possible value). From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 13:37:58 2012 Received: (at 11131) by debbugs.gnu.org; 26 Oct 2012 17:37:58 +0000 Received: from localhost ([127.0.0.1]:35049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRnr4-0007qd-G2 for submit@debbugs.gnu.org; Fri, 26 Oct 2012 13:37:58 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14068) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRnr2-0007qW-QP for 11131@debbugs.gnu.org; Fri, 26 Oct 2012 13:37:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu0/O+LFW/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202926466" Received: from 206-248-177-86.dsl.teksavvy.com (HELO pastel.home) ([206.248.177.86]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Oct 2012 13:35:41 -0400 Received: by pastel.home (Postfix, from userid 20848) id 697F05940A; Fri, 26 Oct 2012 13:35:40 -0400 (EDT) From: Stefan Monnier To: Jambunathan K Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Message-ID: References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> Date: Fri, 26 Oct 2012 13:35:40 -0400 In-Reply-To: <87sjao33j1.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 11 Sep 2012 22:22:50 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) >> Again: "Which part of "ido-like" would you like to see there?". > With the default interface the following are turn-offs (which is pretty > much everything) > - TAB, > - work window getting split in to two > - Using mouse or RET for final choice IIUC, you're looking into making icomplete provide what you need, so this is tracked elsewhere now. > Since my bookmarks are function names, substring completion is what I > desire. (Many functions share the *same* prefix) I haven't changed the default, but I have added a `category' of `bookmark', so you can use substring completion simply by customizing completion-category-overrides. > [Context Switch] I think having a standard hook to choose the default > name of bookmark will also be useful. In prog-modes, I will probably > set it to which-function. I'd be happy to install patch that goes along these lines (tho I'd probably prefer "filename:functionname"). >>> Have bookmark use completing-read-function. >> It does, since it calls completing-read which in turn calls the >> completing-read-function. > May be there is a reason why completing-read-function is not > customizable? Yes: it's expected to be modified by Lisp code rather than via a Custom setting. The Customize UI wouldn't be able to provide much guidance as to what value the user could want to put there. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 13:38:34 2012 Received: (at control) by debbugs.gnu.org; 26 Oct 2012 17:38:34 +0000 Received: from localhost ([127.0.0.1]:35056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRnrd-0007rm-Rl for submit@debbugs.gnu.org; Fri, 26 Oct 2012 13:38:34 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:54784) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRnrc-0007rg-3n for control@debbugs.gnu.org; Fri, 26 Oct 2012 13:38:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu0/O+LFW/2dsb2JhbABEsEiDSYEIghEFAQUZPTMLNBIUGA2GAAeCKBa6CY0mgx4DozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202926501" Received: from 206-248-177-86.dsl.teksavvy.com (HELO pastel.home) ([206.248.177.86]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Oct 2012 13:36:21 -0400 Received: by pastel.home (Postfix, from userid 20848) id 639105940A; Fri, 26 Oct 2012 13:36:21 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Message-ID: References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> Date: Fri, 26 Oct 2012 13:36:21 -0400 In-Reply-To: <87sjao33j1.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 11 Sep 2012 22:22:50 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) close 11131 thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 16:12:13 2012 Received: (at 11131) by debbugs.gnu.org; 26 Oct 2012 20:12:13 +0000 Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRqGK-0003jc-KA for submit@debbugs.gnu.org; Fri, 26 Oct 2012 16:12:13 -0400 Received: from mail-da0-f44.google.com ([209.85.210.44]:37170) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRqGH-0003jQ-10 for 11131@debbugs.gnu.org; Fri, 26 Oct 2012 16:12:11 -0400 Received: by mail-da0-f44.google.com with SMTP id h15so1395262dan.3 for <11131@debbugs.gnu.org>; Fri, 26 Oct 2012 13:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=quGmiCS/UyjZC0XWrD9XCa3CN6oPaUmgRNEhug8wfTg=; b=ffXfcYVBuqhjDlZWnW8hXzoO46LkQqaURLlgN2+/bKTy3QF0ndK8pvZxgixqc6/diS 7KZbqZ8pW4tPQdGOCtIV6Yz0XpgufIazdnGFwguBZMjMKh04rgZjt237c/AaLLiZu/CE S5SZThh0LAfmwiqBo+WztLcpP/siKLCpk9i0GZSL1gBAnBE/clxPD1OeGvccM6ArDk+X Am9ryMYcqaLbhCdq+jA+AuLX8a+wmpIbliChgTnFg4l7nMWhX9+VaWtHhRPmGX5+zlZ/ 51+DsdDMrj5J0ADaFqdSqvqDcaocz31oeVhZMkZcUOQZ4GoRIAhqnpRoT1RDbuL3DqGA q4qw== Received: by 10.66.80.133 with SMTP id r5mr65212754pax.24.1351282197441; Fri, 26 Oct 2012 13:09:57 -0700 (PDT) Received: from debian-6.05 ([101.63.222.21]) by mx.google.com with ESMTPS id sg7sm1633648pbb.50.2012.10.26.13.09.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Oct 2012 13:09:56 -0700 (PDT) From: Jambunathan K To: Stefan Monnier Subject: Re: bug#11131: 24.0.94; Apropos bookmarks References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> Date: Sat, 27 Oct 2012 01:41:59 +0530 In-Reply-To: (Stefan Monnier's message of "Fri, 26 Oct 2012 13:35:40 -0400") Message-ID: <87objphu28.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> Since my bookmarks are function names, substring completion is what I >> desire. (Many functions share the *same* prefix) > > I haven't changed the default, but I have added a `category' of > `bookmark', so you can use substring completion simply by customizing > completion-category-overrides. Thanks for this patch. Good news: I can confirm that `substring' for `bookmark' category works. (custom-set-variables '(completion-category-overrides (quote ((buffer (styles basic substring)) (bookmark (styles substring)))))) Bad news: `icomplete-mode' never kicks in for `C-x r b' (even with default setting of `completion-category-overrides'). Once I reverse your changes icomplete-mode kicks in. $ bzr merge . -r 110680..110679 Something is surely amiss. Request: Following patch advertizes new category. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=bug11131.diff Content-Description: bug11131.diff === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-10-26 18:01:30 +0000 +++ lisp/ChangeLog 2012-10-26 20:02:27 +0000 @@ -1,3 +1,8 @@ +2012-10-26 Jambunathan K + + * minibuffer.el (completion-category-overrides): New completion + category `bookmark' (bug#11131). + 2012-10-26 Stefan Monnier * emacs-lisp/advice.el (ad-assemble-advised-definition): === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2012-10-25 12:56:13 +0000 +++ lisp/minibuffer.el 2012-10-26 19:58:22 +0000 @@ -743,6 +743,7 @@ (const buffer) (const file) (const unicode-name) + (const bookmark) symbol) :value-type (set :tag "Properties to override" --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 26 16:47:17 2012 Received: (at 11131) by debbugs.gnu.org; 26 Oct 2012 20:47:17 +0000 Received: from localhost ([127.0.0.1]:35230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRqoG-0004wA-Md for submit@debbugs.gnu.org; Fri, 26 Oct 2012 16:47:16 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:41983) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRqoD-0004w1-5G for 11131@debbugs.gnu.org; Fri, 26 Oct 2012 16:47:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu0/O+LFW/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="202940422" Received: from 206-248-177-86.dsl.teksavvy.com (HELO pastel.home) ([206.248.177.86]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Oct 2012 16:45:01 -0400 Received: by pastel.home (Postfix, from userid 20848) id 28F595940A; Fri, 26 Oct 2012 16:45:01 -0400 (EDT) From: Stefan Monnier To: Jambunathan K Subject: Re: bug#11131: 24.0.94; Apropos bookmarks Message-ID: References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> <87objphu28.fsf@gmail.com> Date: Fri, 26 Oct 2012 16:45:01 -0400 In-Reply-To: <87objphu28.fsf@gmail.com> (Jambunathan K.'s message of "Sat, 27 Oct 2012 01:41:59 +0530") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 11131 Cc: 11131@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) > `icomplete-mode' never kicks in for `C-x r b' (even with default > setting of `completion-category-overrides'). Once I reverse your > changes icomplete-mode kicks in. > $ bzr merge . -r 110680..110679 > Something is surely amiss. (setq icomplete-with-completion-tables t) > Request: > Following patch advertizes new category. Thanks, installed, Stefan From unknown Sun Jun 22 17:14:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 24 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator