From unknown Sun Jun 22 11:43:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2012 05:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 11130@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133308663122095 (code B ref -1); Fri, 30 Mar 2012 05:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Mar 2012 05:50:31 +0000 Received: from localhost ([127.0.0.1]:45830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDUjG-0005kJ-Bi for submit@debbugs.gnu.org; Fri, 30 Mar 2012 01:50:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54122) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDUin-0005jJ-4u for submit@debbugs.gnu.org; Fri, 30 Mar 2012 01:50:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDUEG-0004LJ-B9 for submit@debbugs.gnu.org; Fri, 30 Mar 2012 01:18:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDUEG-0004LE-7b for submit@debbugs.gnu.org; Fri, 30 Mar 2012 01:18:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDUEE-0002UN-5b for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 01:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDUEB-0004Kq-S8 for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 01:18:25 -0400 Received: from plane.gmane.org ([80.91.229.3]:33201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDUEB-0004Kj-HZ for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 01:18:23 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SDUE7-0004Ix-UJ for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 07:18:19 +0200 Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 30 Mar 2012 07:18:19 +0200 Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 30 Mar 2012 07:18:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Fri, 30 Mar 2012 07:18:10 +0200 Lines: 143 Message-ID: <87mx6yu0od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) Cancel-Lock: sha1:Deb7HrUihtKT6h4fAEKoW4kLHUA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) --=-=-= Content-Type: text/plain Hi, I reopen this as it seem it is not fixed. (Moved from emacs-dev list) I attach the patch again here, please review and try it. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=patch-r119231.patch Content-Description: bugfix # HG changeset patch # User Thierry Volpiatto # Date 1333042420 -7200 # Node ID c2de4670a69cefd92095caca612f8b1e4fd0c217 # Parent 0c4996976cc3ded487b93f71a27641a48c127767 * lisp/files.el (copy-directory): Check if file is a directory but a symlink. diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1264,7 +1264,8 @@ (defun dired-copy-file-recursive (from to ok-flag &optional preserve-time top recursive) - (when (file-subdir-of-p to from) + (when (and (eq t (car (file-attributes from))) + (file-subdir-of-p to from)) (error "Cannot copy `%s' into its subdirectory `%s'" from to)) (let ((attrs (file-attributes from))) (if (and recursive @@ -1452,10 +1453,14 @@ (eq file-creator 'dired-copy-file)) (setq to destname)) ;; If DESTNAME and FROM are the same directory or - ;; If DESTNAME is a subdirectory of FROM, return error. - (and (file-subdir-of-p destname from) - (error "Cannot copy `%s' into its subdirectory `%s'" - from to))) + ;; If DESTNAME is a subdirectory of FROM, not a symlink, + ;; and the method in use is copying return error. + (when (and (eq t ; A dir but not a symlink. + (car (file-attributes destname))) + (eq file-creator 'dired-copy-file) + (file-subdir-of-p destname from)) + (error "Here:Cannot copy `%s' into its subdirectory `%s'" + from to))) (condition-case err (progn (funcall file-creator from to dired-overwrite-confirmed) diff --git a/lisp/files.el b/lisp/files.el --- a/lisp/files.el +++ b/lisp/files.el @@ -5102,10 +5102,10 @@ ;; We do not want to copy "." and "..". (directory-files directory 'full directory-files-no-dot-files-regexp)) - (if (file-directory-p file) - (copy-directory file newname keep-time parents) - (let ((target (expand-file-name (file-name-nondirectory file) newname)) - (attrs (file-attributes file))) + (let ((target (expand-file-name (file-name-nondirectory file) newname)) + (attrs (file-attributes file))) + (if (eq t (car attrs)) ; A directory but not a symlink. + (copy-directory file newname keep-time parents) (if (stringp (car attrs)) ; Symbolic link (make-symbolic-link (car attrs) target t) (copy-file file target t keep-time))))) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit --8<---------------cut here---------------start------------->8--- Hi, I had sent a reply to bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy after it had been closed, saying that there are still problems. Unfortunately I got no answer. Since it was an important bug: Can please somebody have a look? Thanks. This was my message: Hello again, I'm afraid there are still problems. I encountered these two: 1. Creating symlinks to parent directories doesn't work anymore. E.g. if you have a directory "~/test/dir1/", open a dired for "~", go to "test/", hit S, enter "~/test/dir1/" and hit RET. You get the error dired-create-files: Cannot copy `/home/micha/test' into its subdirectory `/home/micha/test/dir1/test' But I only wanted a symlink... This worked in Emacs 23. 2. Symlinks to parent directories (still) lead to ininite loops when copying containing dir. To use the above example: just create this symlink from outside Emacs, so you get e.g. this: /home/micha/test/dir1: total used in directory 8,0K available 94267456 drwxr-xr-x 2 micha users 4,0K Mär 22 02:32 . drwxr-xr-x 3 micha users 4,0K Mär 22 02:33 .. lrwxrwxrwx 1 micha users 22 Mär 22 02:32 test -> /home/micha/test Now dired "~", and copy "~/test" to "~/test2". You get a hierarchy ~/test2/dir1/test/dir1/test/... again (the command terminates without error, btw). And all these are real directories, and _not_ symlinks! I also wonder why dired doesn't copy the symlink itself, but copies the target instead? This seems to be the case also in other examples. If I copy a directory containing any symlinks with dired, copying always copies the targets of the symlinks. Michael --8<---------------cut here---------------end--------------->8--- -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 --=-=-=-- From unknown Sun Jun 22 11:43:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2012 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Thierry Volpiatto Cc: 11130@debbugs.gnu.org Received: via spool by 11130-submit@debbugs.gnu.org id=B11130.133309248231076 (code B ref 11130); Fri, 30 Mar 2012 07:28:02 +0000 Received: (at 11130) by debbugs.gnu.org; 30 Mar 2012 07:28:02 +0000 Received: from localhost ([127.0.0.1]:45901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDWFZ-000853-Hm for submit@debbugs.gnu.org; Fri, 30 Mar 2012 03:27:58 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:41438) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDWF5-00084P-TG for 11130@debbugs.gnu.org; Fri, 30 Mar 2012 03:27:55 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SDVkZ-0006kE-GN; Fri, 30 Mar 2012 02:55:55 -0400 From: Glenn Morris References: <87mx6yu0od.fsf@gmail.com> X-Spook: Glock JFK Craig Livingstone spy SRI Aldergrove military X-Ran: &@x,,bJQ4VBwkv#m_~:t\l81@~o|gGCqD[|%*a0kX1b'$5bIwdVOY"$9X'YfZ%#DSpqiR6 X-Hue: blue X-Attribution: GM Date: Fri, 30 Mar 2012 02:55:55 -0400 In-Reply-To: <87mx6yu0od.fsf@gmail.com> (Thierry Volpiatto's message of "Fri, 30 Mar 2012 07:18:10 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Thierry Volpiatto wrote: > I reopen this as it seem it is not fixed. No, you just made a new bug. I already reopened the old one. Information on reopening etc is in admin/notes/bugtracker. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 30 03:28:13 2012 Received: (at control) by debbugs.gnu.org; 30 Mar 2012 07:28:13 +0000 Received: from localhost ([127.0.0.1]:45905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDWFo-00085r-Uh for submit@debbugs.gnu.org; Fri, 30 Mar 2012 03:28:13 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:41447) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDWFn-00085k-3l for control@debbugs.gnu.org; Fri, 30 Mar 2012 03:28:11 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SDVlH-0006ll-Ou for control@debbugs.gnu.org; Fri, 30 Mar 2012 02:56:39 -0400 Date: Fri, 30 Mar 2012 02:56:39 -0400 Message-Id: Subject: control message for bug 11130 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) forcemerge 10489 11130 From unknown Sun Jun 22 11:43:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy In-Reply-To: <87mx6yu0od.fsf@gmail.com> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2012 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 11130@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133310176916269 (code B ref -1); Fri, 30 Mar 2012 10:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Mar 2012 10:02:49 +0000 Received: from localhost ([127.0.0.1]:46084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDYfQ-0004EL-8i for submit@debbugs.gnu.org; Fri, 30 Mar 2012 06:02:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55405) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDYfN-0004EE-Vz for submit@debbugs.gnu.org; Fri, 30 Mar 2012 06:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDYAm-0003Qm-8X for submit@debbugs.gnu.org; Fri, 30 Mar 2012 05:31:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYAm-0003Qg-59 for submit@debbugs.gnu.org; Fri, 30 Mar 2012 05:31:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYAg-0002vZ-0k for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 05:31:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDYAe-0003PO-6f for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 05:31:01 -0400 Received: from plane.gmane.org ([80.91.229.3]:38530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYAe-0003PI-0T for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 05:31:00 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SDYAb-0003Ey-Qb for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2012 11:30:57 +0200 Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 30 Mar 2012 11:30:57 +0200 Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 30 Mar 2012 11:30:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Fri, 30 Mar 2012 11:30:43 +0200 Lines: 20 Message-ID: <87aa2ypha4.fsf@gmail.com> References: <87mx6yu0od.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) Cancel-Lock: sha1:cdUMyobrcDKhvkKGuCYCNaEIzQM= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Glenn Morris writes: > Thierry Volpiatto wrote: > >> I reopen this as it seem it is not fixed. > > No, you just made a new bug. > I already reopened the old one. Don't see it, anyway add the patch to it. > Information on reopening etc is in admin/notes/bugtracker. > > > > -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Sun Jun 22 11:43:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2012 17:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Thierry Volpiatto Cc: 11130@debbugs.gnu.org Received: via spool by 11130-submit@debbugs.gnu.org id=B11130.133312828729609 (code B ref 11130); Fri, 30 Mar 2012 17:25:01 +0000 Received: (at 11130) by debbugs.gnu.org; 30 Mar 2012 17:24:47 +0000 Received: from localhost ([127.0.0.1]:47260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDfZ8-0007hW-Md for submit@debbugs.gnu.org; Fri, 30 Mar 2012 13:24:47 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:57458) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDfZ4-0007hM-EM for 11130@debbugs.gnu.org; Fri, 30 Mar 2012 13:24:45 -0400 Received: from bb121-6-72-34.singnet.com.sg ([121.6.72.34]:57201 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SDf4V-0001QY-Bg; Fri, 30 Mar 2012 12:53:08 -0400 From: Chong Yidong References: <87mx6yu0od.fsf@gmail.com> Date: Sat, 31 Mar 2012 00:52:59 +0800 In-Reply-To: <87mx6yu0od.fsf@gmail.com> (Thierry Volpiatto's message of "Fri, 30 Mar 2012 07:18:10 +0200") Message-ID: <87y5qiyqs4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Thierry Volpiatto writes: > I attach the patch again here, please review and try it. Looks fine, thank you. Committed to trunk. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 30 13:27:07 2012 Received: (at control) by debbugs.gnu.org; 30 Mar 2012 17:27:08 +0000 Received: from localhost ([127.0.0.1]:47264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDfbP-0007l6-GI for submit@debbugs.gnu.org; Fri, 30 Mar 2012 13:27:07 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:57507) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDfbO-0007ky-Je for control@debbugs.gnu.org; Fri, 30 Mar 2012 13:27:06 -0400 Received: from bb121-6-72-34.singnet.com.sg ([121.6.72.34]:57206 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SDf6q-0001fj-7u for control@debbugs.gnu.org; Fri, 30 Mar 2012 12:55:32 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 10489 Date: Sat, 31 Mar 2012 00:55:26 +0800 Message-ID: <87pqbujaf5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 10489 thanks From unknown Sun Jun 22 11:43:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11130: [PATCH] Reopen bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2012 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Chong Yidong Cc: 11130@debbugs.gnu.org Received: via spool by 11130-submit@debbugs.gnu.org id=B11130.13331307274064 (code B ref 11130); Fri, 30 Mar 2012 18:06:02 +0000 Received: (at 11130) by debbugs.gnu.org; 30 Mar 2012 18:05:27 +0000 Received: from localhost ([127.0.0.1]:47305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDgCG-00013G-86 for submit@debbugs.gnu.org; Fri, 30 Mar 2012 14:05:27 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:46034) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDgBz-00012U-OU for 11130@debbugs.gnu.org; Fri, 30 Mar 2012 14:05:11 -0400 Received: by wgbds11 with SMTP id ds11so914821wgb.3 for <11130@debbugs.gnu.org>; Fri, 30 Mar 2012 10:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=1AsSZfFoj9kdwKZA4M4kte7xRGvQHJax+1hkY934Xy0=; b=a/UwriOcYOCndAg5eyD4JlGplTMOBFk3xeZ4eLkHxgBNcL1dwSI37qYuF1D5miU7p6 ssFgDKVHhz7NFktt7dnSsFKI88G4td6waVl1TIvQ59A8k9mfGWSK98WAc/X5IIbssQVZ JOMuybvjkr1va6VdNolE5btH8JSsMZuQiexndBEyAavS0I0BZUVuhzqeXP1joZVkPoJp bYAcLXW1wzx/SlFmsCDNiJWreTsRZg4pfUdQxU12HI0S1EDlXiPduCJovB7wiiwACOVN 5tfPQ/crfnCXkNgyqsdJI0oVkxQqFJth/IdrkcS0tAg4FuNEXkKK7T9XjbyuDK+CjLEA upng== Received: by 10.180.86.132 with SMTP id p4mr142625wiz.15.1333128800051; Fri, 30 Mar 2012 10:33:20 -0700 (PDT) Received: from thierry-MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id ex2sm12723098wib.8.2012.03.30.10.33.18 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Mar 2012 10:33:19 -0700 (PDT) From: Thierry Volpiatto References: <87mx6yu0od.fsf@gmail.com> <87y5qiyqs4.fsf@gnu.org> Date: Fri, 30 Mar 2012 19:33:16 +0200 In-Reply-To: <87y5qiyqs4.fsf@gnu.org> (Chong Yidong's message of "Sat, 31 Mar 2012 00:52:59 +0800") Message-ID: <871uoaouxv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Chong Yidong writes: > Thierry Volpiatto writes: > >> I attach the patch again here, please review and try it. > > Looks fine, thank you. Committed to trunk. Thanks Chong. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997