GNU bug report logs - #1113
slash screen covers the *Messages* buffer when errors are present in .emacs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1113 in the body.
You can then email your comments to 1113 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: slash screen covers the *Messages* buffer when errors are present in .emacs
Date: Tue, 7 Oct 2008 08:34:52 -0700 (PDT)

Create a bad .emacs:

echo ")" > ~/.emacs

emacs&

Emacs starts up, it shows the *Messages* buffer that says that there are
errors in .emacs, but the splash screens covers it before the user has
time to read the information.

The splash screen should not be displayed at all in this case, the user
has to have a chance to read the text in *Messages*.

Message #10 received at 1113-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1113-done <at> debbugs.gnu.org
Subject: Re: slash screen covers the *Messages* buffer when errors are present in .emacs
Date: Tue, 07 Oct 2008 15:51:26 -0400

> Create a bad .emacs:
>
> echo ")" > ~/.emacs
>
> emacs&
>
> Emacs starts up, it shows the *Messages* buffer that says that there
> are errors in .emacs, but the splash screens covers it before the user
> has time to read the information.

I've tweaked startup.el to fix this.  Init file errors use
display-warning, just like other startup errors.

Thanks.

Message #11 received at 1113-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 1113-done <at> debbugs.gnu.org
Subject: Re: slash screen covers the *Messages* buffer when errors are present in .emacs
Date: Tue, 7 Oct 2008 13:14:58 -0700 (PDT)

Chong Yidong <cyd <at> stupidchicken.com> writes:

  > > Create a bad .emacs:
  > >
  > > echo ")" > ~/.emacs
  > >
  > > emacs&
  > >
  > > Emacs starts up, it shows the *Messages* buffer that says that there
  > > are errors in .emacs, but the splash screens covers it before the user
  > > has time to read the information.
  > 
  > I've tweaked startup.el to fix this.  Init file errors use
  > display-warning, just like other startup errors.

Unfortunately this does not work for "emacs --daemon" the warnings do
not appear at all in the *Messages* buffer in that case, they used to
before your patch.

Message #12 received at 1113-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Dan Nicolaescu <dann <at> ics.uci.edu>, 1113-done <at> debbugs.gnu.org
Subject: Re: Re: slash screen covers the *Messages* buffer when errors are
 present in .emacs
Date: Tue, 07 Oct 2008 22:27:52 +0200

Chong Yidong wrote:
>> Create a bad .emacs:
>>
>> echo ")" > ~/.emacs
>>
>> emacs&
>>
>> Emacs starts up, it shows the *Messages* buffer that says that there
>> are errors in .emacs, but the splash screens covers it before the user
>> has time to read the information.
> 
> I've tweaked startup.el to fix this.  Init file errors use
> display-warning, just like other startup errors.

Didn't we discuss this before? The disadvantage of using display-warning
is that you can't see the relation to other messages in the *Messages*
buffer.

Unless, of course the message goes to the message buffer too.

> Thanks.
> 

Message #13 received at 1113-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1113-done <at> debbugs.gnu.org
Subject: Re: slash screen covers the *Messages* buffer when errors are present in .emacs
Date: Tue, 07 Oct 2008 17:03:25 -0400

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> Unfortunately this does not work for "emacs --daemon" the warnings do
> not appear at all in the *Messages* buffer in that case, they used to
> before your patch.

The same could be said of the warnings about invalid user names, missing
home directories, and pure space overflow...

Message #14 received at 1113-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 1113-done <at> debbugs.gnu.org
Subject: Re: slash screen covers the *Messages* buffer when errors are present in .emacs
Date: Tue, 7 Oct 2008 14:16:34 -0700 (PDT)

Chong Yidong <cyd <at> stupidchicken.com> writes:

  > Dan Nicolaescu <dann <at> ics.uci.edu> writes:
  > 
  > > Unfortunately this does not work for "emacs --daemon" the warnings do
  > > not appear at all in the *Messages* buffer in that case, they used to
  > > before your patch.
  > 
  > The same could be said of the warnings about invalid user names, missing
  > home directories, and pure space overflow...

Please don't make things worse then, people actually want to see these
warnings...

Message #15 received at 1113-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1113-done <at> debbugs.gnu.org
Subject: Re: slash screen covers the *Messages* buffer when errors are present in .emacs
Date: Tue, 07 Oct 2008 18:19:40 -0400

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> Chong Yidong <cyd <at> stupidchicken.com> writes:
>
>   > Dan Nicolaescu <dann <at> ics.uci.edu> writes:
>   > 
>   > > Unfortunately this does not work for "emacs --daemon" the
>   > > warnings do not appear at all in the *Messages* buffer in that
>   > > case, they used to before your patch.
>   > 
>   > The same could be said of the warnings about invalid user names,
>   > missing home directories, and pure space overflow...
>
> Please don't make things worse then, people actually want to see these
> warnings...

Maybe the solution is to make `display-warning' do something different
if it is called in daemon mode initialization.  Does this patch DTRT?

*** trunk/lisp/emacs-lisp/warnings.el.~1.16.~	2008-05-05 23:21:21.000000000 -0400
--- trunk/lisp/emacs-lisp/warnings.el	2008-10-07 18:18:59.000000000 -0400
***************
*** 268,274 ****
  	    (goto-char warning-series)))
  	(if (nth 2 level-info)
  	    (funcall (nth 2 level-info)))
! 	(if noninteractive
  	    ;; Noninteractively, take the text we inserted
  	    ;; in the warnings buffer and print it.
  	    ;; Do this unconditionally, since there is no way
--- 268,274 ----
  	    (goto-char warning-series)))
  	(if (nth 2 level-info)
  	    (funcall (nth 2 level-info)))
!      (cond (noninteractive
  	    ;; Noninteractively, take the text we inserted
  	    ;; in the warnings buffer and print it.
  	    ;; Do this unconditionally, since there is no way
***************
*** 280,286 ****
  		(goto-char end)
  		(if (bolp)
  		    (forward-char -1))
! 		(message "%s" (buffer-substring start (point)))))
  	  ;; Interactively, decide whether the warning merits
  	  ;; immediate display.
  	  (or (< (warning-numeric-level level)
--- 280,298 ----
  		(goto-char end)
  		(if (bolp)
  		    (forward-char -1))
! 		(message "%s" (buffer-substring start (point))))))
! 	   ((and (daemonp) (null after-init-time))
! 	    ;; Warnings assigned during daemon initialization go into
! 	    ;; the messages buffer.
! 	    (message
! 	     "%s"
! 	     (with-current-buffer buffer
! 	       (save-excursion
! 		 (goto-char end)
! 		 (if (bolp)
! 		     (forward-char -1))
! 		 (buffer-substring start (point))))))
! 	   (t
  	  ;; Interactively, decide whether the warning merits
  	  ;; immediate display.
  	  (or (< (warning-numeric-level level)
***************
*** 290,296 ****
  		(when (and (markerp warning-series)
  			   (eq (marker-buffer warning-series) buffer))
  		  (set-window-start window warning-series))
! 		(sit-for 0)))))))
  
  ;;;###autoload
  (defun lwarn (type level message &rest args)
--- 302,308 ----
  		(when (and (markerp warning-series)
  			   (eq (marker-buffer warning-series) buffer))
  		  (set-window-start window warning-series))
! 		(sit-for 0))))))))
  
  ;;;###autoload
  (defun lwarn (type level message &rest args)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.