GNU bug report logs - #11124
24.0.94; doc of `customize-apropos-*'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11124 in the body.
You can then email your comments to 11124 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.94; doc of `customize-apropos-*'
Date: Thu, 29 Mar 2012 10:31:39 -0700

All of the `customize-apropos-*' commands except for `customize-apropos'
need to have their doc strings updated.  The arg is no longer
necessarily a REGEXP.  The doc string should say the same thing for
these commands as it says for `customize-apropos' about the PATTERN arg
(or refer to the `customize-apropos' doc).

In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'
 

Message #8 received at 11124 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <11124 <at> debbugs.gnu.org>
Subject: RE: bug#11124: 24.0.94; doc of `customize-apropos-*'
Date: Fri, 30 Mar 2012 07:47:24 -0700

> All of the `customize-apropos-*' commands except for 
> `customize-apropos' need to have their doc strings updated.
> The arg is no longer necessarily a REGEXP.  The doc string
> should say the same thing for these commands as it says for
> `customize-apropos' about the PATTERN arg
> (or refer to the `customize-apropos' doc).

I was wrong about that.  But I should have been right ;-) - they should accept a
PATTERN the same as `customize-apropos' does.

So consider this an enhancement request for each of the `customize-apropos-*'
commands to allow a PATTERN (as in `customize-apropos') instead of just a REGEXP
as arg.

Just use `apropos-read-pattern' in their `interactive' specs.

Or be smarter: move the logic of `apropos-read-pattern' out of the `interactive'
spec, and put it in the body of `customize-apropos':

(when (string= (regexp-quote pattern) pattern)
  (setq pattern  (split-string pattern "[ \t]+" 'OMIT-NULLS)))
(apropos-parse-pattern pattern)

(I also fixed bug #11132 here: provide non-nil 3rd arg.) 

Message #11 received at 11124 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 11124 <at> debbugs.gnu.org
Subject: Re: bug#11124: 24.0.94; doc of `customize-apropos-*'
Date: Mon, 23 Apr 2012 20:33:14 +0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

> All of the `customize-apropos-*' commands except for `customize-apropos'
> need to have their doc strings updated.  The arg is no longer
> necessarily a REGEXP.  The doc string should say the same thing for
> these commands as it says for `customize-apropos' about the PATTERN arg
> (or refer to the `customize-apropos' doc).

Fixed, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.