From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 28 21:32:35 2012 Received: (at submit) by debbugs.gnu.org; 29 Mar 2012 01:32:35 +0000 Received: from localhost ([127.0.0.1]:43863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SD4E4-0000G2-36 for submit@debbugs.gnu.org; Wed, 28 Mar 2012 21:32:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40647) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SD4DY-0000F5-Vf for submit@debbugs.gnu.org; Wed, 28 Mar 2012 21:32:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SD3j9-0004S0-EU for submit@debbugs.gnu.org; Wed, 28 Mar 2012 21:00:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD3j9-0004Ro-4T for submit@debbugs.gnu.org; Wed, 28 Mar 2012 21:00:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCzvb-000415-9c for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2012 16:57:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCzvZ-0002Sd-Ab for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2012 16:57:10 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:47186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCzvZ-0002Rg-2s for bug-gnu-emacs@gnu.org; Wed, 28 Mar 2012 16:57:09 -0400 Received: by iajr24 with SMTP id r24so2450073iaj.0 for ; Wed, 28 Mar 2012 13:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type; bh=N1MxbDVDPBzyKso5AWhYDu7F9E35EWKj5vBwGkYZ/LY=; b=Gno7iX4cYv926pst60aJvSgN8bE0zXPolrBmLdHLpbrN6JrZ6V3p+71hG5wtonzIn0 ThXWj0fCS1tc1PqkcnV6GJ+GA+JysrbpPVilj3pc9Ck/L52pPlyRLAbFOI/Na12xFID0 m5LhgAW9qzfHoMigd1c1ly0guPAYOjsnir5nM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type:x-gm-message-state; bh=N1MxbDVDPBzyKso5AWhYDu7F9E35EWKj5vBwGkYZ/LY=; b=LN/Zqvy2VjRDl25DVLPZDuJDHWbzhj06vbcGE5QCXEhEF/i7bbd9iEli8m1C+/lFSm ZpamGJar9UmiomvCc1cBVwOr8f5R/l7yYlrqHm+YegHktv96LhkmpnJPEH219MAhbwgS 6h4lYzxK6AuuaZIscwI9yEoVrzi1ubkxeOdEAPIanzvhtsa4PRmMv8lgjAIHMwhY0lIx W8sfa9TYeCb4lmyo8DwcCOxot1VqRHx/2Dc1XzJIDNFqlPOe+6kQeQAW6f7eS4AGUh4u i8rYQoTT/JvfNTrki9NCrAMITATiS7g5/JnPI8L4DumEV+XyRi64XQiZBiYlEup/c37F DGfw== Received: by 10.42.141.72 with SMTP id n8mr18560143icu.47.1332968226132; Wed, 28 Mar 2012 13:57:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.197.165 with HTTP; Wed, 28 Mar 2012 13:56:45 -0700 (PDT) From: Peter Oliver Date: Wed, 28 Mar 2012 21:56:45 +0100 X-Google-Sender-Auth: Nv26oMcwpnJ0gWPQqqCFFswl5wc Message-ID: Subject: New option perl-indent-parens-as-block To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=90e6ba6e8dce9d911804bc53d9aa X-Gm-Message-State: ALoCoQmyDzt20lhAJWpZK5MdNDC66puijCbOP/1M87nB2igyS83p0BTnz7Flf9FeiDOM1gxf4CRg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) --90e6ba6e8dce9d911804bc53d9aa Content-Type: text/plain; charset=ISO-8859-1 At present, perl-mode aligns non-block closing brackets with the contents of the brackets, thus: my @list = ( 'item one', 'item two', 'item three', ); Now, cperl-mode features on option, cperl-indent-parens-as-block, that causes the closing bracket to be aligned with the line of the opening bracket, as follows: my @list = ( 'item one', 'item two', 'item three', ); I personally find the latter behaviour easier to follow, and would like perl-mode to be able to do the same thing. A patch is on the way... -- Peter Oliver --90e6ba6e8dce9d911804bc53d9aa Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable At present, perl-mode aligns non-block closing brackets with the contents o= f the brackets, thus:

my @list =3D (
=A0=A0=A0 'item one',
=A0=A0=A0 'item two',
=A0=A0=A0 'item three',
=A0=A0=A0 );

Now, cperl-mode feat= ures on option, cperl-indent-parens-as-block, that causes the closing brack= et to be aligned with the line of the opening bracket, as follows:

m= y @list =3D (
=A0=A0=A0 'item one',
=A0=A0=A0 'item two',
=A0=A0=A0= 'item three',
);

I personally find the latter behaviour = easier to follow, and would like perl-mode to be able to do the same thing.=

A patch is on the way...

--
Peter Oliver

--90e6ba6e8dce9d911804bc53d9aa-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 15:28:22 2012 Received: (at 11118) by debbugs.gnu.org; 29 Mar 2012 19:28:22 +0000 Received: from localhost ([127.0.0.1]:45254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDL1B-00040U-Kt for submit@debbugs.gnu.org; Thu, 29 Mar 2012 15:28:21 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]:64515) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDL1A-00040O-QN for 11118@debbugs.gnu.org; Thu, 29 Mar 2012 15:28:21 -0400 Received: by yhkk25 with SMTP id k25so1699910yhk.3 for <11118@debbugs.gnu.org>; Thu, 29 Mar 2012 11:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mavit.org.uk; s=google; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:content-type; bh=ALFbNumn4IWZCsj5GApUSbuvda2IxE/q6QZusc7LKO0=; b=L3wDCGObhqnOuEbPSuHQEhvkzGxhJU+EbTDFTt21OlB5UUMc4qzAiGqx03uwoQrgac bAU7PO47eTM+pHFOmUepXjiRKg7L+Gt0UprGeebdy4J0u7X78ephOyNRNzJughAis58h zjAhM5U1aR1TDmUtOAv5fUvMLUtPOzUITFp5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:from:date:x-google-sender-auth:message-id :subject:to:x-gm-message-state:content-type; bh=ALFbNumn4IWZCsj5GApUSbuvda2IxE/q6QZusc7LKO0=; b=cUAeqHNySITgBYqgJYiqJVVX0q7EPdQbU2DpJrDqN2EQtLY3KXobN+USDpzPYFD5jb AuRDJ8nnYI8MdCZu0z8NGyX1JWHYips9+fWEMevo6jCSGPn17czxgcgHsq/kIjwpXYfq iT7XbK9wlCGjUapS7n0WFMTMZDD2qnvNb9gOcGeUl06ngKiogNVe8fKj5g29PfPFQCPb L4WOk2ucvPMMflQMEGpAmrYHpbfx0vJsZuMceos93MQm24ke5BSC6zH+YlIqe8AeBTEi L2t03RduuEl+9V9AqEkjh+M/YkfEHU/1iezb3Aj28LIUD13N9wfV84IfkGVFRWFPWiyL 5ydA== Received: by 10.50.216.232 with SMTP id ot8mr3008193igc.22.1333047411423; Thu, 29 Mar 2012 11:56:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.197.165 with HTTP; Thu, 29 Mar 2012 11:56:31 -0700 (PDT) From: Peter Oliver Date: Thu, 29 Mar 2012 19:56:31 +0100 X-Google-Sender-Auth: W5hLF7vx9P0kKECVLmN-Vn3t0nY Message-ID: Subject: Patch To: 11118@debbugs.gnu.org X-Gm-Message-State: ALoCoQkApsTJNANdz+Mfc5vMbujL5+MdQyCsF//ST2cMm6oNIBNDKkoml9u9swGp344C/EXpGZDu Content-Type: multipart/mixed; boundary=14dae934048d6d393104bc664957 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11118 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) --14dae934048d6d393104bc664957 Content-Type: multipart/alternative; boundary=14dae934048d6d392e04bc664955 --14dae934048d6d392e04bc664955 Content-Type: text/plain; charset=ISO-8859-1 --14dae934048d6d392e04bc664955 Content-Type: text/html; charset=ISO-8859-1
--14dae934048d6d392e04bc664955-- --14dae934048d6d393104bc664957 Content-Type: application/octet-stream; name="emacs-perl-indent-parens-as-block.diff" Content-Disposition: attachment; filename="emacs-perl-indent-parens-as-block.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h0e5zgc50 PT09IG1vZGlmaWVkIGZpbGUgJ2V0Yy9ORVdTJwotLS0gZXRjL05FV1MJMjAxMi0wMy0yNyAyMDoy NDo0OCArMDAwMAorKysgZXRjL05FV1MJMjAxMi0wMy0yOCAyMToxMjo0MiArMDAwMApAQCAtNzg0 LDYgKzc4NCwxMSBAQAogSWYgYG54bWwtYmluZC1tZXRhLXRhYi10by1jb21wbGV0ZS1mbGFnJyBp cyBub24tbmlsICh0aGUgZGVmYXVsdCksCiB0aGlzIHBlcmZvcm1zIHRhZyBjb21wbGV0aW9uLgog CisqKiBQZXJsIG1vZGUKKworKioqIFRoZXJlIGlzIGEgbmV3IG9wdGlvbiwgcGVybC1pbmRlbnQt cGFyZW5zLWFzLWJsb2NrLCB3aGljaCBjYXVzZXMKK25vbi1ibG9jayBjbG9zaW5nIGJyYWNrZXRz IHRvIGJlIGFsaWduZWQgd2l0aCB0aGUgbGluZSBvZiB0aGUgb3BlbmluZyBicmFja2V0LgorCiAt LS0KICoqIFByb2xvZyBtb2RlIGhhcyBiZWVuIGNvbXBsZXRlbHkgcmV2YW1wZWQsIHdpdGggbG90 cyBvZiBhZGRpdGlvbmFsCiBmdW5jdGlvbmFsaXR5IHN1Y2ggYXMgbW9yZSBpbnRlbGxpZ2VudCBp bmRlbnRhdGlvbiwgZWxlY3RyaWNpdHksIHN1cHBvcnQgZm9yCgo9PT0gbW9kaWZpZWQgZmlsZSAn bGlzcC9DaGFuZ2VMb2cnCi0tLSBsaXNwL0NoYW5nZUxvZwkyMDEyLTAzLTI5IDE0OjAwOjAwICsw MDAwCisrKyBsaXNwL0NoYW5nZUxvZwkyMDEyLTAzLTI5IDE4OjQ2OjE5ICswMDAwCkBAIC0xLDMg KzEsOSBAQAorMjAxMi0wMy0yOCAgUGV0ZXIgT2xpdmVyICA8YnpyQG1hdml0Lm9yZy51az4KKwor CSogcHJvZ21vZGVzL3BlcmwtbW9kZS5lbCAocGVybC1pbmRlbnQtcGFyZW5zLWFzLWJsb2NrKTog TmV3IG9wdGlvbgorCXRvIGFsaWduIG5vbi1ibG9jayBjbG9zaW5nIGJyYWNrZXRzIHdpdGggdGhl IG9wZW5pbmcgbGluZQorCShidWcjMTExMTgpLgorCiAyMDEyLTAzLTI4ICBTYW0gU3RlaW5nb2xk ICA8c2RzQGdudS5vcmc+CiAKIAkqIGNhbGVuZGFyL2NhbGVuZGFyLmVsIChjYWxlbmRhci1leGl0 KTogVXNlIGBxdWl0LXdpbmRvd3Mtb24nCgo9PT0gbW9kaWZpZWQgZmlsZSAnbGlzcC9wcm9nbW9k ZXMvcGVybC1tb2RlLmVsJwotLS0gbGlzcC9wcm9nbW9kZXMvcGVybC1tb2RlLmVsCTIwMTItMDMt MTUgMDM6MDk6MjYgKzAwMDAKKysrIGxpc3AvcHJvZ21vZGVzL3BlcmwtbW9kZS5lbAkyMDEyLTAz LTI4IDIwOjI4OjA4ICswMDAwCkBAIC01MTAsNiArNTEwLDEyIEBACiBJZiBuaWwsIGNvbnRpbnVl ZCBhcmd1bWVudHMgYXJlIGFsaWduZWQgd2l0aCB0aGUgZmlyc3QgYXJndW1lbnQuIgogICA6dHlw ZSAnKGNob2ljZSBpbnRlZ2VyIChjb25zdCBuaWwpKQogICA6Z3JvdXAgJ3BlcmwpCisoZGVmY3Vz dG9tIHBlcmwtaW5kZW50LXBhcmVucy1hcy1ibG9jayBuaWwKKyAgIipOb24tbmlsIG1lYW5zIHRo YXQgbm9uLWJsb2NrICgpLSwge30tIGFuZCBbXS1ncm91cHMgYXJlIGluZGVudGVkIGFzIGJsb2Nr cy4KK1RoZSBjbG9zaW5nIGJyYWNrZXQgaXMgYWxpZ25lZCB3aXRoIHRoZSBsaW5lIG9mIHRoZSBv cGVuaW5nCiticmFja2V0LCBub3QgdGhlIGNvbnRlbnRzIG9mIHRoZSBicmFja2V0cy4iCisgIDp0 eXBlICdib29sZWFuCisgIDpncm91cCAncGVybCkKIAogKGRlZmN1c3RvbSBwZXJsLXRhYi1hbHdh eXMtaW5kZW50IHRhYi1hbHdheXMtaW5kZW50CiAgICJOb24tbmlsIG1lYW5zIFRBQiBpbiBQZXJs IG1vZGUgYWx3YXlzIGluZGVudHMgdGhlIGN1cnJlbnQgbGluZS4KQEAgLTg1Miw3ICs4NTgsOCBA QAogICAgICAgKGNvbmQgKChudGggMyBzdGF0ZSkgc3RhdGUpCTsgSW4gYSBxdW90ZWQgc3RyaW5n PwogCSAgICAoKG51bGwgY29udGFpbmluZy1zZXhwKQk7IExpbmUgaXMgYXQgdG9wIGxldmVsLgog CSAgICAgKHNraXAtY2hhcnMtZm9yd2FyZCAiIFx0XGYiKQotCSAgICAgKGlmICg9IChmb2xsb3dp bmctY2hhcikgP3spCisJICAgICAoaWYgKG1lbXEgKGZvbGxvd2luZy1jaGFyKQorCQkgICAgICAg KGlmIHBlcmwtaW5kZW50LXBhcmVucy1hcy1ibG9jayAnKD9ceyA/XCggP1xbKSAnKD9ceykpKQog CQkgMCAgOyBtb3ZlIHRvIGJlZ2lubmluZyBvZiBsaW5lIGlmIGl0IHN0YXJ0cyBhIGZ1bmN0aW9u IGJvZHkKIAkgICAgICAgOzsgaW5kZW50IGEgbGl0dGxlIGlmIHRoaXMgaXMgYSBjb250aW51YXRp b24gbGluZQogCSAgICAgICAocGVybC1iYWNrd2FyZC10by1ub25jb21tZW50KQpAQCAtODk2LDcg KzkwMyw5IEBACiAJCQkgIDAgcGVybC1jb250aW51ZWQtc3RhdGVtZW50LW9mZnNldCkKIAkJICAg ICAgKGN1cnJlbnQtY29sdW1uKQogCQkgICAgICAoaWYgKHNhdmUtZXhjdXJzaW9uIChnb3RvLWNo YXIgaW5kZW50LXBvaW50KQotCQkJCQkgIChsb29raW5nLWF0ICJbIFx0XSp7IikpCisJCQkJCSAg KGxvb2tpbmctYXQgCisJCQkJCSAgIChpZiBwZXJsLWluZGVudC1wYXJlbnMtYXMtYmxvY2sKKwkJ CQkJICAgICAgICJbIFx0XSpbeyhcW10iICJbIFx0XSp7IikpKQogCQkJICBwZXJsLWNvbnRpbnVl ZC1icmFjZS1vZmZzZXQgMCkpKQogCSAgICAgICA7OyBUaGlzIGxpbmUgc3RhcnRzIGEgbmV3IHN0 YXRlbWVudC4KIAkgICAgICAgOzsgUG9zaXRpb24gYXQgbGFzdCB1bmNsb3NlZCBvcGVuLgoK --14dae934048d6d393104bc664957-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 30 00:06:50 2012 Received: (at 11118) by debbugs.gnu.org; 30 Mar 2012 04:06:50 +0000 Received: from localhost ([127.0.0.1]:45716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDT6v-0000ib-Pm for submit@debbugs.gnu.org; Fri, 30 Mar 2012 00:06:50 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:27501) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SDT6T-0000hs-GP; Fri, 30 Mar 2012 00:06:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9MCqRV/2dsb2JhbACBX5x7eacJhhkEmxmECQ X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="170645505" Received: from 76-10-164-85.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.164.85]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Mar 2012 23:34:50 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 92470AE14B; Thu, 29 Mar 2012 23:34:50 -0400 (EDT) From: Stefan Monnier To: Peter Oliver Subject: Re: bug#11118: Patch Message-ID: References: Date: Thu, 29 Mar 2012 23:34:50 -0400 In-Reply-To: (Peter Oliver's message of "Thu, 29 Mar 2012 19:56:31 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11118 Cc: 11118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 11118 pending thanks The patch looks very good. We can't install it just now because we're in feature freeze, so we'll keep it for when the trunk opens again for new features. Thank you, Stefan >>>>> "Peter" == Peter Oliver writes: > === modified file 'etc/NEWS' > --- etc/NEWS 2012-03-27 20:24:48 +0000 > +++ etc/NEWS 2012-03-28 21:12:42 +0000 > @@ -784,6 +784,11 @@ > If `nxml-bind-meta-tab-to-complete-flag' is non-nil (the default), > this performs tag completion. > +** Perl mode > + > +*** There is a new option, perl-indent-parens-as-block, which causes > +non-block closing brackets to be aligned with the line of the opening bracket. > + > --- > ** Prolog mode has been completely revamped, with lots of additional > functionality such as more intelligent indentation, electricity, support for > === modified file 'lisp/ChangeLog' > --- lisp/ChangeLog 2012-03-29 14:00:00 +0000 > +++ lisp/ChangeLog 2012-03-29 18:46:19 +0000 > @@ -1,3 +1,9 @@ > +2012-03-28 Peter Oliver > + > + * progmodes/perl-mode.el (perl-indent-parens-as-block): New option > + to align non-block closing brackets with the opening line > + (bug#11118). > + > 2012-03-28 Sam Steingold > * calendar/calendar.el (calendar-exit): Use `quit-windows-on' > === modified file 'lisp/progmodes/perl-mode.el' > --- lisp/progmodes/perl-mode.el 2012-03-15 03:09:26 +0000 > +++ lisp/progmodes/perl-mode.el 2012-03-28 20:28:08 +0000 > @@ -510,6 +510,12 @@ > If nil, continued arguments are aligned with the first argument." > :type '(choice integer (const nil)) > :group 'perl) > +(defcustom perl-indent-parens-as-block nil > + "*Non-nil means that non-block ()-, {}- and []-groups are indented as blocks. > +The closing bracket is aligned with the line of the opening > +bracket, not the contents of the brackets." > + :type 'boolean > + :group 'perl) > (defcustom perl-tab-always-indent tab-always-indent > "Non-nil means TAB in Perl mode always indents the current line. > @@ -852,7 +858,8 @@ > (cond ((nth 3 state) state) ; In a quoted string? > ((null containing-sexp) ; Line is at top level. > (skip-chars-forward " \t\f") > - (if (= (following-char) ?{) > + (if (memq (following-char) > + (if perl-indent-parens-as-block '(?\{ ?\( ?\[) '(?\{))) > 0 ; move to beginning of line if it starts a function body > ;; indent a little if this is a continuation line > (perl-backward-to-noncomment) > @@ -896,7 +903,9 @@ > 0 perl-continued-statement-offset) > (current-column) > (if (save-excursion (goto-char indent-point) > - (looking-at "[ \t]*{")) > + (looking-at > + (if perl-indent-parens-as-block > + "[ \t]*[{(\[]" "[ \t]*{"))) > perl-continued-brace-offset 0))) > ;; This line starts a new statement. > ;; Position at last unclosed open. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 16 22:48:56 2012 Received: (at 11118-done) by debbugs.gnu.org; 17 Apr 2012 02:48:57 +0000 Received: from localhost ([127.0.0.1]:37575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJyTQ-0005mV-GC for submit@debbugs.gnu.org; Mon, 16 Apr 2012 22:48:56 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:35236 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJyTO-0005mO-Ju for 11118-done@debbugs.gnu.org; Mon, 16 Apr 2012 22:48:55 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SJyTI-0000PS-KO; Mon, 16 Apr 2012 22:48:48 -0400 From: Glenn Morris To: 11118-done@debbugs.gnu.org Subject: Re: bug#11118: Patch References: X-Spook: CBNRC bce offensive information warfare Elvis Syria Waco, X-Ran: JGQSwk^L9v@UyNtp[h4{N$(-r-cSLKDaT,fspBH9RN(t#u\F#x[~eEnJ$Xy^nD.]=yDE;: X-Hue: cyan X-Attribution: GM Date: Mon, 16 Apr 2012 22:48:48 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 29 Mar 2012 23:34:50 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11118-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Version: 24.2 Thanks; applied to trunk, so expect it in 24.2. Thanks especially for including ChangeLog and NEWS entries. The only thing you forgot was the :version tag. :) BTW, we would need an FSF copyright assignment to accept any further patches from you. It's straightforward to do - let me know off-list if you want. From unknown Sun Jun 22 04:27:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 May 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator