GNU bug report logs - #11087
vector limitation in compiling to bytecode

Previous Next

Package: guile;

Reported by: Ian Price <ianprice90 <at> googlemail.com>

Date: Sat, 24 Mar 2012 20:42:02 UTC

Severity: normal

Done: Andy Wingo <wingo <at> pobox.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11087: closed (vector limitation in compiling to bytecode)
Date: Thu, 05 Jul 2012 21:07:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 05 Jul 2012 23:01:42 +0200
with message-id <87hatl53d5.fsf <at> pobox.com>
and subject line Re: bug#11087: vector limitation in compiling to bytecode
has caused the debbugs.gnu.org bug report #11087,
regarding vector limitation in compiling to bytecode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11087: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11087
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ian Price <ianprice90 <at> googlemail.com>
To: bug-guile <at> gnu.org
Subject: vector limitation in compiling to bytecode
Date: Sat, 24 Mar 2012 20:09:28 +0000
Hi guilers,

Earlier today I had a compilation warning while running a script.

~/src/mine/algorithms-course $ guile -L . -s invsinarray.scm 
;;; note: auto-compilation is enabled, set GUILE_AUTO_COMPILE=0
;;;       or pass the --no-auto-compile argument to disable.
;;; compiling /home/ian/src/mine/algorithms-course/invsinarray.scm
;;; WARNING: compilation of /home/ian/src/mine/algorithms-course/invsinarray.scm failed:
;;; ERROR: In procedure bytevector-u8-set!: Value out of range: 390

It ran fine, but the compilation problem was that I had a vector
constant containing 100000 values[0]. Now, the vector instruction in the
vm expects the value to be less than 2^16, and when compiling this it
performs splits the value into two by taking the value and modulus from
dividing by 256. This leads to the instruction (vector 390 160), which
further on down the line write-byte fails on.

This limitation is documented, and somewhat reasonable, but on IRC mark
weaver asked me to file a bug anyway, since he thinks the assembler
should have a fall back plan.

[0] as you can guess from the names, it was data provided for an online
algorithms class I'm taking. I did the lazy thing and just wrapped the
file in #(...). I've since changed it to actually read the vector from
the file.

-- 
Ian Price

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"



[Message part 3 (message/rfc822, inline)]
From: Andy Wingo <wingo <at> pobox.com>
To: Ian Price <ianprice90 <at> googlemail.com>
Cc: 11087-done <at> debbugs.gnu.org
Subject: Re: bug#11087: vector limitation in compiling to bytecode
Date: Thu, 05 Jul 2012 23:01:42 +0200
On Sat 24 Mar 2012 21:09, Ian Price <ianprice90 <at> googlemail.com> writes:

> ;;; ERROR: In procedure bytevector-u8-set!: Value out of range: 390
> vector constant containing 100000 values
>
> This limitation is documented, and somewhat reasonable, but on IRC mark
> weaver asked me to file a bug anyway, since he thinks the assembler
> should have a fall back plan.

I agree with Mark.

For what it's worth, if the vector is really constant (e.g. just
composed of immediates), the RTL VM will emit the whole thing
statically.  Otherwise it will emit code to allocate a vector
of the right size at init time, initializing its elements with
individual instructions.   This latter strategy is probably the right
thing to do with the Guile 2.0 VM.

In the mean time, I added a check for the vector-length to
glil/compile-assembly.scm.  If the vector is too big, it hits the array
case, which has a 24-bit range.  It seems to hit some other problem
after that, but I gave it the ole college try, right?

Cheers,

Andy
-- 
http://wingolog.org/


This bug report was last modified 12 years and 323 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.