GNU bug report logs - #11068
24.0.94; Face-remapped background does not extend to end of window

Previous Next

Full log

Message #31 received at 11068 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: darthandrus <at> gmail.com, 11068 <at> debbugs.gnu.org,
	Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#11068: 24.0.94;
	Face-remapped background does not extend to end of window
Date: Sat, 24 Mar 2012 22:17:41 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>    /* Face extension extends the background and box of IT->face_id
>       to the end of the line.  If the background equals the background
>       of the frame, we don't have to do anything.  */
>    if (it->face_before_selective_p)
>      face = FACE_FROM_ID (f, it->saved_face_id);
> +  else if (it->face_id == DEFAULT_FACE_ID)
> +    face = default_face;
>    else
>      face = FACE_FROM_ID (f, it->face_id);

This looks a bit strange.  Why is DEFAULT_FACE_ID handled specially
here?  Shouldn't we be checking for face remapping no matter what the
face_id is?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.