GNU bug report logs - #11067
diff-no-select assumes diff-command understands -L option

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11067: closed (diff-no-select assumes diff-command
 understands -L option)
Date: Mon, 11 Feb 2013 08:30:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 11 Feb 2013 03:29:10 -0500
with message-id <24haljw8x5.fsf <at> fencepost.gnu.org>
and subject line Re: bug#11067: 24.0.94.1; diff-buffer-with-file
has caused the debbugs.gnu.org bug report #11067,
regarding diff-no-select assumes diff-command understands -L option
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11067: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11067
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arni Magnusson <arnima <at> hafro.is>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.94.1; diff-buffer-with-file
Date: Thu, 22 Mar 2012 14:54:16 +0000 (UTC)

I'm running Emacs 24.0.94.1 alpha,

http://alpha.gnu.org/gnu/emacs/windows/emacs-20120319-r107630-bin-i386.zip

and `diff-buffer-with-file' is not working like it did in Emacs 23.4.1

1. Start emacs -Q
2. Set `diff-command' to "winmerge" and `diff-switches' to nil
3. Open a file, say c:/gnu/emacs/BUGS, make some changes without saving
4. M-x diff-buffer-with-file

Emacs 23.4.1 performs this task very nicely, but Emacs 24.0.94.1 alpha 
provides the external program with args that cannot be compared:

  c:\gnu\emacs\-L
  c:\gnu\emacs\BUGS

Examining the Emacs *Diff* buffer provides some insights. In Emacs 23.4.1 
it contains

  winmerge "c:/gnu/emacs/BUGS" "c:/Temp/buffer-content-3436L7C"

which looks sensible, but in Emacs 24.0.94.1 alpha it the *Diff* buffer 
contains

  winmerge "-L" "c:/gnu/emacs/BUGS" "-L" "#<buffer BUGS>" 
"c:/gnu/emacs/BUGS" "c:/Temp/buffer-content-2640boz"

which looks like 6 args instead of 2, including some "-L" options (even 
after specifically disabling all diff switches) and "#<buffer BUGS>" 
(probably of no use to an external program).

To me, it looks like version 24.0.94.1 of `diff-buffer-with-file' in 
diff.el should try harder to mimic the behavior of version 23.4.1 in 
files.el.

Many thanks,

Arni

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 11067-done <at> debbugs.gnu.org
Subject: Re: bug#11067: 24.0.94.1; diff-buffer-with-file
Date: Mon, 11 Feb 2013 03:29:10 -0500

Version: 24.4

Fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.