From unknown Sun Jun 22 00:20:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11051: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Mar 2012 17:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11051@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.133226384826334 (code B ref -1); Tue, 20 Mar 2012 17:18:03 +0000 Received: (at submit) by debbugs.gnu.org; 20 Mar 2012 17:17:28 +0000 Received: from localhost ([127.0.0.1]:58264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SA2gX-0006qc-4l for submit@debbugs.gnu.org; Tue, 20 Mar 2012 13:17:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39885) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SA2gU-0006qS-C2 for submit@debbugs.gnu.org; Tue, 20 Mar 2012 13:17:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2Cl-0001k2-Km for submit@debbugs.gnu.org; Tue, 20 Mar 2012 12:46:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2Cl-0001jy-Hd for submit@debbugs.gnu.org; Tue, 20 Mar 2012 12:46:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2Cf-0003zJ-93 for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2012 12:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2Cd-0001jY-BQ for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2012 12:46:32 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:40237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2Cd-0001jM-4S for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2012 12:46:31 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q2KGkRA1013271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Mar 2012 16:46:28 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q2KGkRGF017603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 20 Mar 2012 16:46:27 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q2KGkQf6024478 for ; Tue, 20 Mar 2012 11:46:26 -0500 Received: from dradamslap1 (/10.159.47.74) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 20 Mar 2012 09:46:26 -0700 From: "Drew Adams" Date: Tue, 20 Mar 2012 09:46:22 -0700 Message-ID: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0GuPsxqm6lpJBmTj2/MwpO51zrTw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-CT-RefId: str=0001.0A090201.4F68B464.00C6,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This code in wid-edit.el is wrong: (defun widget-complete () "Complete content of editable field from point. When not inside a field, signal an error." (interactive) (let ((data (widget-completions-at-point))) (cond ((functionp data) (funcall data)) ((consp data) (let ((completion-extra-properties (nth 3 data))) (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data) (plist-get completion-extra-properties :predicate)))) ((widget-field-find (point)) ;; This defaulting used to be performed in widget-default-complete, but ;; it seems more appropriate here than in widget-default-completions. (call-interactively 'widget-complete-field)) ;;; WRONG - remove quote ^ (t (error "Not in an editable field"))))) `widget-complete-field' is not a command. Its value is a command. In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600) of 2012-03-19 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' From unknown Sun Jun 22 00:20:46 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11051: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Mar 2012 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: <11051@debbugs.gnu.org> Received: via spool by 11051-submit@debbugs.gnu.org id=B11051.133226406326898 (code B ref 11051); Tue, 20 Mar 2012 17:22:01 +0000 Received: (at 11051) by debbugs.gnu.org; 20 Mar 2012 17:21:03 +0000 Received: from localhost ([127.0.0.1]:58273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SA2k2-0006zm-QF for submit@debbugs.gnu.org; Tue, 20 Mar 2012 13:21:03 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:19201) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SA2k0-0006zL-Al for 11051@debbugs.gnu.org; Tue, 20 Mar 2012 13:21:01 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q2KGoLZG027167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <11051@debbugs.gnu.org>; Tue, 20 Mar 2012 16:50:22 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q2KGoKCJ011677 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <11051@debbugs.gnu.org>; Tue, 20 Mar 2012 16:50:21 GMT Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q2KGoKd4023886 for <11051@debbugs.gnu.org>; Tue, 20 Mar 2012 11:50:20 -0500 Received: from dradamslap1 (/10.159.47.74) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 20 Mar 2012 09:50:19 -0700 From: "Drew Adams" References: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> Date: Tue, 20 Mar 2012 09:50:15 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> Thread-Index: Ac0GuPsxqm6lpJBmTj2/MwpO51zrTwAAELiQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-CT-RefId: str=0001.0A090203.4F68B54E.00D6,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) 1. Here is the backtrace, BTW: Debugger entered--Lisp error: (wrong-type-argument commandp widget-complete-field) * call-interactively(widget-complete-field) * (cond ((functionp data) (funcall data)) ((consp data) (let ((completion-extra-properties (nth 3 data))) (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data) (plist-get completion-extra-properties :predicate)))) ((widget-field-find (point)) (call-interactively (quote widget-complete-field))) (t (error "Not in an editable field"))) * (let ((data (widget-completions-at-point))) (cond ((functionp data) (funcall data)) ((consp data) (let ((completion-extra-properties (nth 3 data))) (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data) (plist-get completion-extra-properties :predicate)))) ((widget-field-find (point)) (call-interactively (quote widget-complete-field))) (t (error "Not in an editable field")))) widget-complete() * call-interactively(widget-complete nil nil) 2. But won't fixing this by removing the quote lead to an infloop: `widget-complete' calling the command bound to `M-TAB', which invokes `widget-complete'...? Not sure the logic of this code is correct anymore, since it was last changed. From unknown Sun Jun 22 00:20:46 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Drew Adams" Subject: bug#11051: closed (Re: bug#11051: 24.0.94; `widget-complete': Remove quote for `widget-complete-field') Message-ID: References: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> X-Gnu-PR-Message: they-closed 11051 X-Gnu-PR-Package: emacs Reply-To: 11051@debbugs.gnu.org Date: Wed, 21 Mar 2012 02:48:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1332298083-20102-1" This is a multi-part message in MIME format... ------------=_1332298083-20102-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11051: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11051@debbugs.gnu.org. --=20 11051: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11051 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1332298083-20102-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11051-done) by debbugs.gnu.org; 21 Mar 2012 02:47:12 +0000 Received: from localhost ([127.0.0.1]:58553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SABZv-0005D3-A6 for submit@debbugs.gnu.org; Tue, 20 Mar 2012 22:47:11 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:9004) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SABZt-0005Cx-Fw for 11051-done@debbugs.gnu.org; Tue, 20 Mar 2012 22:47:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9FxKFU/2dsb2JhbACBX5x7eacJhhkEmxmECQ X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="169138103" Received: from 69-196-161-84.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.196.161.84]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Mar 2012 22:16:29 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 7906EAE220; Tue, 20 Mar 2012 22:16:28 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#11051: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' Message-ID: References: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> Date: Tue, 20 Mar 2012 22:16:27 -0400 In-Reply-To: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> (Drew Adams's message of "Tue, 20 Mar 2012 09:46:22 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11051-done Cc: 11051-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > `widget-complete-field' is not a command. Its value is a command. Indeed, this was completely broken, and there doesn't seem to be much of a fix. I just removed it: after all, the fact that it didn't work hasn't seemed to cause much uproar; and with the new code there are other ways to get similar results. Stefan ------------=_1332298083-20102-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Mar 2012 17:17:28 +0000 Received: from localhost ([127.0.0.1]:58264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SA2gX-0006qc-4l for submit@debbugs.gnu.org; Tue, 20 Mar 2012 13:17:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39885) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SA2gU-0006qS-C2 for submit@debbugs.gnu.org; Tue, 20 Mar 2012 13:17:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2Cl-0001k2-Km for submit@debbugs.gnu.org; Tue, 20 Mar 2012 12:46:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2Cl-0001jy-Hd for submit@debbugs.gnu.org; Tue, 20 Mar 2012 12:46:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2Cf-0003zJ-93 for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2012 12:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2Cd-0001jY-BQ for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2012 12:46:32 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:40237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2Cd-0001jM-4S for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2012 12:46:31 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q2KGkRA1013271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Mar 2012 16:46:28 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q2KGkRGF017603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 20 Mar 2012 16:46:27 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q2KGkQf6024478 for ; Tue, 20 Mar 2012 11:46:26 -0500 Received: from dradamslap1 (/10.159.47.74) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 20 Mar 2012 09:46:26 -0700 From: "Drew Adams" To: Subject: 24.0.94; `widget-complete': Remove quote for `widget-complete-field' Date: Tue, 20 Mar 2012 09:46:22 -0700 Message-ID: <313DC3057C304A4DBD89172E6B1DB89D@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0GuPsxqm6lpJBmTj2/MwpO51zrTw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-CT-RefId: str=0001.0A090201.4F68B464.00C6,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This code in wid-edit.el is wrong: (defun widget-complete () "Complete content of editable field from point. When not inside a field, signal an error." (interactive) (let ((data (widget-completions-at-point))) (cond ((functionp data) (funcall data)) ((consp data) (let ((completion-extra-properties (nth 3 data))) (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data) (plist-get completion-extra-properties :predicate)))) ((widget-field-find (point)) ;; This defaulting used to be performed in widget-default-complete, but ;; it seems more appropriate here than in widget-default-completions. (call-interactively 'widget-complete-field)) ;;; WRONG - remove quote ^ (t (error "Not in an editable field"))))) `widget-complete-field' is not a command. Its value is a command. In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600) of 2012-03-19 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' ------------=_1332298083-20102-1--