GNU bug report logs - #11051
24.0.94; `widget-complete': Remove quote for `widget-complete-field'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11051 in the body.
You can then email your comments to 11051 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.94; `widget-complete': Remove quote for `widget-complete-field'
Date: Tue, 20 Mar 2012 09:46:22 -0700

This code in wid-edit.el is wrong:
 
(defun widget-complete ()
  "Complete content of editable field from point.
When not inside a field, signal an error."
  (interactive)
  (let ((data (widget-completions-at-point)))
    (cond
     ((functionp data) (funcall data))
     ((consp data)
      (let ((completion-extra-properties (nth 3 data)))
        (completion-in-region (nth 0 data) (nth 1 data) (nth 2 data)
                              (plist-get completion-extra-properties
                                         :predicate))))
     ((widget-field-find (point))
      ;; This defaulting used to be performed in widget-default-complete, but
      ;; it seems more appropriate here than in widget-default-completions.
      (call-interactively 'widget-complete-field))
 
;;; WRONG - remove quote  ^
 
     (t
      (error "Not in an editable field")))))
 
`widget-complete-field' is not a command.  Its value is a command.

In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'
 

Message #8 received at 11051 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <11051 <at> debbugs.gnu.org>
Subject: RE: bug#11051: 24.0.94;
	`widget-complete': Remove quote for `widget-complete-field'
Date: Tue, 20 Mar 2012 09:50:15 -0700

1. Here is the backtrace, BTW:

Debugger entered--Lisp error: (wrong-type-argument commandp
widget-complete-field)
* call-interactively(widget-complete-field)
* (cond ((functionp data) (funcall data)) ((consp data) (let
((completion-extra-properties (nth 3 data))) (completion-in-region (nth 0 data)
(nth 1 data) (nth 2 data) (plist-get completion-extra-properties :predicate))))
((widget-field-find (point)) (call-interactively (quote widget-complete-field)))
(t (error "Not in an editable field")))
* (let ((data (widget-completions-at-point))) (cond ((functionp data) (funcall
data)) ((consp data) (let ((completion-extra-properties (nth 3 data)))
(completion-in-region (nth 0 data) (nth 1 data) (nth 2 data) (plist-get
completion-extra-properties :predicate)))) ((widget-field-find (point))
(call-interactively (quote widget-complete-field))) (t (error "Not in an
editable field"))))
  widget-complete()
* call-interactively(widget-complete nil nil)

2. But won't fixing this by removing the quote lead to an infloop:
`widget-complete' calling the command bound to `M-TAB', which invokes
`widget-complete'...?

Not sure the logic of this code is correct anymore, since it was last changed.

Message #13 received at 11051-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 11051-done <at> debbugs.gnu.org
Subject: Re: bug#11051: 24.0.94;
	`widget-complete': Remove quote for `widget-complete-field'
Date: Tue, 20 Mar 2012 22:16:27 -0400

> `widget-complete-field' is not a command.  Its value is a command.

Indeed, this was completely broken, and there doesn't seem to be much of
a fix.  I just removed it: after all, the fact that it didn't work
hasn't seemed to cause much uproar; and with the new code there are
other ways to get similar results.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.