GNU bug report logs - #11046
24.0.94; Customize: M-TAB moves cursor over tag; clicking button moves cursor over button

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11046 in the body.
You can then email your comments to 11046 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.94; Customize: M-TAB moves cursor over tag;
	clicking button moves cursor over button
Date: Tue, 20 Mar 2012 09:02:30 -0700

emacs -Q

M-x customize-option RET site-run-file RET
 
Click Value Menu button.  Choose String in the menu.
 
1. First bug: Cursor should be in the edit field.  But it is on top of
the Value Menu button.
 
2. Put cursor at beginning of the edit field.  Hit `M-TAB'.
 
You see this error message: "lookup-words: lookup-words error: No plain
word-list found at systemdefault locations.  Customize
`ispell-alternate-dictionary' to set yours."
 
But the cursor is moved back on top of the tag `String:', before the
`:' (second bug).
 
In GNU Emacs 24.0.94.1 (i386-mingw-nt5.1.2600)
 of 2012-03-19 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'
 

Message #8 received at 11046 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 11046 <at> debbugs.gnu.org
Subject: Re: bug#11046: 24.0.94; Customize: M-TAB moves cursor over tag;
	clicking button moves cursor over button
Date: Tue, 20 Mar 2012 19:48:31 +0200

> From: "Drew Adams" <drew.adams <at> oracle.com>
> Date: Tue, 20 Mar 2012 09:02:30 -0700
> 
> emacs -Q
> 
> M-x customize-option RET site-run-file RET
>  
> Click Value Menu button.  Choose String in the menu.
>  
> 1. First bug: Cursor should be in the edit field.  But it is on top of
> the Value Menu button.

Confirmed.

> 2. Put cursor at beginning of the edit field.  Hit `M-TAB'.
>  
> You see this error message: "lookup-words: lookup-words error: No plain
> word-list found at systemdefault locations.  Customize
> `ispell-alternate-dictionary' to set yours."
>  
> But the cursor is moved back on top of the tag `String:', before the
> `:' (second bug).

I don't get the error message, but a "*Choices*" buffer (because my
ispell-alternate-dictionary _is_ properly configured), but that buffer
shows hits for "String".  Here's a sample:

(0) /Usr/Dict/Web2:190067:String       (1) /Usr/Dict/Web2:190068:Stringboard
(2) /Usr/Dict/Web2:190069:Stringcourse (3) /Usr/Dict/Web2:190070:Stringend

etc. -- quite un-useful.  IOW, it _really_ tries to complete the word
"String", which is not what the user wants.

(Shouldn't the type of the widget be "file" instead of "string"?)

Message #11 received at 11046 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Eli Zaretskii'" <eliz <at> gnu.org>
Cc: 11046 <at> debbugs.gnu.org
Subject: RE: bug#11046: 24.0.94; Customize: M-TAB moves cursor over tag;
	clicking button moves cursor over button
Date: Sun, 16 Sep 2012 17:07:06 -0700

ping

Message #14 received at 11046 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 11046 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#11046: 24.0.94; Customize: M-TAB moves cursor over tag;
 clicking button moves cursor over button
Date: Mon, 30 Sep 2019 13:08:50 -0300

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Drew Adams" <drew.adams <at> oracle.com>
>> Date: Tue, 20 Mar 2012 09:02:30 -0700
>>
>> emacs -Q
>>
>> M-x customize-option RET site-run-file RET
>>
>> Click Value Menu button.  Choose String in the menu.
>>
>> 1. First bug: Cursor should be in the edit field.  But it is on top of
>> the Value Menu button.
>
> Confirmed.

This is because widget-button-click-moves-point is set to t for
customize buffers, and also because there is no mechanism implemented
for widgets to "pass focus" to others.  If it is a desired feature, I
can try to come up with something.

>> 2. Put cursor at beginning of the edit field.  Hit `M-TAB'.
>>
>> You see this error message: "lookup-words: lookup-words error: No plain
>> word-list found at systemdefault locations.  Customize
>> `ispell-alternate-dictionary' to set yours."
>>
>> But the cursor is moved back on top of the tag `String:', before the
>> `:' (second bug).
>
> I don't get the error message, but a "*Choices*" buffer (because my
> ispell-alternate-dictionary _is_ properly configured), but that buffer
> shows hits for "String".  Here's a sample:
>
> (0) /Usr/Dict/Web2:190067:String       (1)
/Usr/Dict/Web2:190068:Stringboard
> (2) /Usr/Dict/Web2:190069:Stringcourse (3) /Usr/Dict/Web2:190070:Stringend
>
> etc. -- quite un-useful.  IOW, it _really_ tries to complete the word
> "String", which is not what the user wants.

This is because the completion function used for string widgets is
ispell-complete-word and that command will look back from point until it
finds a word to complete.
I can't think of another way of fixing this other than peeking what will
ispell-complete-word try to complete, so I attach a patch that does
that.

> (Shouldn't the type of the widget be "file" instead of "string"?)

I think so.

[Message part 2 (text/html, inline)]

[0001-Only-complete-words-inside-of-the-string-widget.patch (text/x-patch, attachment)]

Message #17 received at 11046 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 11046 <at> debbugs.gnu.org
Subject: Re: bug#11046: 24.0.94; Customize: M-TAB moves cursor over tag;
 clicking button moves cursor over button
Date: Tue, 01 Oct 2019 14:33:44 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> This is because the completion function used for string widgets is
> ispell-complete-word and that command will look back from point until it
> finds a word to complete.
> I can't think of another way of fixing this other than peeking what will
> ispell-complete-word try to complete, so I attach a patch that does
> that.

I think that makes sense...

> -  :complete-function 'ispell-complete-word
> +  :complete (lambda (widget)
> +              (eval-and-compile (require 'ispell)) ; For `ispell-get-word'.

I think the way we usually do this is by just saying (require 'ispell)
in the function, and pacify the compiler by using a `declare-function'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 11046 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 11046 <at> debbugs.gnu.org
Subject: Re: bug#11046: 24.0.94; Customize: M-TAB moves cursor over tag;
 clicking button moves cursor over button
Date: Sat, 5 Oct 2019 10:15:10 -0300

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
> I think that makes sense...
>
>> -  :complete-function 'ispell-complete-word
>> +  :complete (lambda (widget)
>> +              (eval-and-compile (require 'ispell)) ; For
`ispell-get-word'.
>
> I think the way we usually do this is by just saying (require 'ispell)
> in the function, and pacify the compiler by using a `declare-function'.

Thanks for reviewing.  I attach a patch with that change.

Best regards,
Mauro.

[Message part 2 (text/html, inline)]

[0001-Only-complete-words-inside-of-the-string-widget.patch (text/x-patch, attachment)]

Message #23 received at 11046 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 11046 <at> debbugs.gnu.org
Subject: Re: bug#11046: 24.0.94; Customize: M-TAB moves cursor over tag;
 clicking button moves cursor over button
Date: Mon, 07 Oct 2019 04:00:06 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> Thanks for reviewing.  I attach a patch with that change.

Thanks; looks good.  I've now applied it to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.