GNU bug report logs - #11036
24.0.94; imagemagick-render-type is void as a variable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11036 in the body.
You can then email your comments to 11036 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.94; imagemagick-render-type is void as a variable
Date: Sat, 17 Mar 2012 11:07:10 +0800

My emacs is built without imagemagick support and I am seeing this:

imagemagick-render-type is a variable defined in `C source code'.
It is void as a variable.

Documentation:
Integer indicating which ImageMagick rendering method to use.
The options are:
  0 -- the default method (pixel pushing)
  1 -- a newer method ("MagickExportImagePixels") that may perform
       better (speed etc) in some cases, but has not been as thoroughly
       tested with Emacs as the default method.  This method requires
       ImageMagick version 6.4.6 (approximately) or later.


Leo

Message #8 received at 11036 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11036 <at> debbugs.gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Sat, 17 Mar 2012 10:52:36 +0200

> From: Leo <sdl.web <at> gmail.com>
> Date: Sat, 17 Mar 2012 11:07:10 +0800
> 
> My emacs is built without imagemagick support and I am seeing this:
> 
> imagemagick-render-type is a variable defined in `C source code'.
> It is void as a variable.
> 
> Documentation:
> Integer indicating which ImageMagick rendering method to use.
> The options are:
>   0 -- the default method (pixel pushing)
>   1 -- a newer method ("MagickExportImagePixels") that may perform
>        better (speed etc) in some cases, but has not been as thoroughly
>        tested with Emacs as the default method.  This method requires
>        ImageMagick version 6.4.6 (approximately) or later.

Why do you consider this a problem?

Message #11 received at 11036 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 11036 <at> debbugs.gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Sat, 17 Mar 2012 21:10:32 +0800

On 2012-03-17 16:52 +0800, Eli Zaretskii wrote:
> Why do you consider this a problem?

Do you see other void variables show up in C-h v?

Leo

Message #14 received at 11036 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 11036 <at> debbugs.gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Sat, 17 Mar 2012 14:36:43 -0400

Leo wrote:

> On 2012-03-17 16:52 +0800, Eli Zaretskii wrote:
>> Why do you consider this a problem?
>
> Do you see other void variables show up in C-h v?

x-resource-name in a build without-x, for example.

Message #17 received at 11036 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11036 <at> debbugs.gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Sat, 17 Mar 2012 14:53:42 -0400

I guess it is because Snarf-documentation does not understand #ifdefs.
See also http://lists.gnu.org/archive/html/emacs-devel/2008-05/msg01545.html .
In this case, the symbol imagemagick-render-type appears in cus-start.el.

Message #20 received at 11036 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11036 <at> debbugs.gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Tue, 20 Mar 2012 17:06:31 -0400

Obviously not for 24.1, but the following seems to work.
Anything that is in DOC should be defined at startup if relevant to the
platform in use.

I compared the results of `C-h f TAB' and `C-h v TAB' with and without
this change, and it just removes a few more void things.
Eg for me, the variables: motif-version-string, gtk-version-string, 
ns-initialized.


*** src/doc.c	2012-02-06 16:53:51 +0000
--- src/doc.c	2012-03-20 20:50:48 +0000
***************
*** 671,676 ****
--- 671,677 ----
  		  /* Install file-position as variable-documentation property
  		     and make it negative for a user-variable
  		     (doc starts with a `*').  */
+                   if (!NILP (Fboundp (sym)))
                      Fput (sym, Qvariable_documentation,
                            make_number ((pos + end + 1 - buf)
                                         * (end[1] == '*' ? -1 : 1)));
***************
*** 678,685 ****
  
  	      /* Attach a docstring to a function?  */
  	      else if (p[1] == 'F')
  		store_function_docstring (sym, pos + end + 1 - buf);
! 
  	      else if (p[1] == 'S')
  		; /* Just a source file name boundary marker.  Ignore it.  */
  
--- 679,688 ----
  
  	      /* Attach a docstring to a function?  */
  	      else if (p[1] == 'F')
+                 {
+                   if (!NILP (Ffboundp (sym)))
                      store_function_docstring (sym, pos + end + 1 - buf);
!                 }
  	      else if (p[1] == 'S')
  		; /* Just a source file name boundary marker.  Ignore it.  */
  

Message #25 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Wed, 21 Mar 2012 07:56:20 +0800

On 2012-03-21 05:06 +0800, Glenn Morris wrote:
> Obviously not for 24.1, but the following seems to work.
> Anything that is in DOC should be defined at startup if relevant to the
> platform in use.

Thank you for fixing this.

Leo

Message #30 received at 11036-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11036-done <at> debbugs.gnu.org
Subject: Re: bug#11036: 24.0.94; imagemagick-render-type is void as a variable
Date: Mon, 09 Apr 2012 16:44:08 -0400

Version: 24.2

Patch applied to trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.