Subject: bug#11030: [FYI] {maint} install-mans: avoid spurious failure with NetBSD make (was: Re: bug#11030: should an empty "pkgdata_DATA" cause creation of $(pkgdatadir) by "make install"?)

From: Stefano Lattarini <[email-masked]>
Date: Sun, 18 Mar 2012 22:34:03 +0100

On 03/18/2012 08:19 PM, Stefano Lattarini wrote:
> tags 11030 + patch
> close 11030
> thanks
> 
> On 03/18/2012 08:03 AM, Stefano Lattarini wrote:
>>
>>> On 03/16/2012 11:04 PM, Stefano Lattarini wrote:
>>>>
>>>> You have convinced me that this behaviour is more a bug than a feature.
>>>>
>>> And here is a patch (for maint) that should settle the issue.  I will push by
>>> tomorrow if there is no objection.
>>>
> Patch pushed now.  I'm thus closing this bug report.
> 
The change introduced some new issues with NetBSD make when installing manpages.
The attached follow-up (already applied to maint and merged into branch-1.11)
fixes that.

Sorry for the noise,
  Stefano
>From 45ffbe9f8746224daf11a3980d69b10fc0520384 Mon Sep 17 00:00:00 2001
Message-Id: <45ffbe9f8[email-masked]>
From: Stefano Lattarini <[email-masked]>
Date: Sun, 18 Mar 2012 22:19:45 +0100
Subject: [PATCH] install-mans: avoid spurious failure with NetBSD make

* lib/am/mans.am: After the changes introduced by previous commit
v1.11-759-g368f1c4, some manpage installation recipes started to
fail spuriously on NetBSD 5.1 make.  Apparently, the system make
there eats backslashes used to escape whitespace characters in the
relevant recipes.  Revert to slightly slower but safer idioms that
avoid the need of such escaping.

Signed-off-by: Stefano Lattarini <[email-masked]>
---
 lib/am/mans.am |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/am/mans.am b/lib/am/mans.am
index b0d5335..b92576d 100644
--- a/lib/am/mans.am
+++ b/lib/am/mans.am
@@ -36,7 +36,7 @@ if %?NOTRANS_MANS%
 ?!HAVE_NOTRANS?	list2=''; \
 ?HAVE_NOTRANS?	list2='%NOTRANS_LIST%'; \
 	test -n "$(man%SECTION%dir)" \
-	  && case "$$list1$$list2" in *[^\ ]*) :;; *) false;; esac \
+	  && test -n "`echo $$list1$$list2`" \
 	  || exit 0; \
 	echo " $(MKDIR_P) '$(DESTDIR)$(man%SECTION%dir)'"; \
 	$(MKDIR_P) "$(DESTDIR)$(man%SECTION%dir)" || exit 1; \
@@ -77,7 +77,7 @@ if %?TRANS_MANS%
 ?!HAVE_TRANS?	list2=''; \
 ?HAVE_TRANS?	list2='%TRANS_LIST%'; \
 	test -n "$(man%SECTION%dir)" \
-	  && case "$$list1$$list2" in *[^\ ]*) :;; *) false;; esac \
+	  && test -n "`echo $$list1$$list2`" \
 	  || exit 0; \
 	echo " $(MKDIR_P) '$(DESTDIR)$(man%SECTION%dir)'"; \
 	$(MKDIR_P) "$(DESTDIR)$(man%SECTION%dir)" || exit 1; \
-- 
1.7.9