GNU bug report logs - #1103
23.0.60; which-func misses functions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1103 in the body.
You can then email your comments to 1103 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; which-func misses functions
Date: Tue, 07 Oct 2008 00:01:01 +0200

Instead of displaying the last function in an elisp file it may display
the name of a variable that is above the function. I do not know if the
patch below is the right way to fix it.


Index: which-func.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/which-func.el,v
retrieving revision 1.25
diff -u -r1.25 which-func.el
--- which-func.el	30 Sep 2008 03:42:47 -0000	1.25
+++ which-func.el	6 Oct 2008 21:56:46 -0000
@@ -313,7 +313,8 @@
                                            (reverse (cons (car pair)
namestack)))))
                          ;; Entries in order, so can skip all those
after point.
                          (setq alist nil
-                               imstack nil)))))
+                               ;;imstack nil
+                               )))))

             (setq alist     (car imstack)
                   namestack (cdr namestack)


In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'

Message #10 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: 1103 <at> debbugs.gnu.org
Subject: Re: bug#1103: 23.0.60; which-func misses functions
Date: Tue, 07 Oct 2008 12:48:48 +0200

[Message part 1 (text/plain, inline)]

Lennart Borgman (gmail) wrote:
> Instead of displaying the last function in an elisp file it may display
> the name of a variable that is above the function. I do not know if the
> patch below is the right way to fix it.


Here is a new patch which I think is correct.

[which-func.diff (text/plain, inline)]

Index: which-func.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/which-func.el,v
retrieving revision 1.25
diff -u -r1.25 which-func.el
--- which-func.el	30 Sep 2008 03:42:47 -0000	1.25
+++ which-func.el	7 Oct 2008 10:45:56 -0000
@@ -287,11 +287,12 @@
 	       (boundp 'imenu--index-alist) imenu--index-alist)
       (let ((alist imenu--index-alist)
             (minoffset (point-max))
-            offset pair mark imstack namestack)
+            offset pair mark imstack namestack
+            skip-sub)
         ;; Elements of alist are either ("name" . marker), or
         ;; ("submenu" ("name" . marker) ... ). The list can be
         ;; arbitrarily nested.
-        (while (or alist imstack)
+        (while (or alist imstack skip-sub)
           (if alist
               (progn
                 (setq pair (car-safe alist)
@@ -302,9 +303,12 @@
                       ((imenu--subalist-p pair)
                        (setq imstack   (cons alist imstack)
                              namestack (cons (car pair) namestack)
-                             alist     (cdr pair)))
+                             alist     (cdr pair)
+                             skip-sub  nil
+                             ))
 
                       ((number-or-marker-p (setq mark (cdr pair)))
+                       (unless skip-sub
                        (if (>= (setq offset (- (point) mark)) 0)
                            (if (< offset minoffset) ; find the closest item
                                (setq minoffset offset
@@ -312,12 +316,15 @@
                                            which-func-imenu-joiner-function
                                            (reverse (cons (car pair) namestack)))))
                          ;; Entries in order, so can skip all those after point.
-                         (setq alist nil
-                               imstack nil)))))
+                           ;;(setq alist nil imstack nil)
+                           (setq skip-sub t)
+                           )
+                         ))))
 
             (setq alist     (car imstack)
                   namestack (cdr namestack)
-                  imstack   (cdr imstack))))))
+                  imstack   (cdr imstack)
+                  skip-sub  nil)))))
 
     ;; Try using add-log support.
     (when (and (null name) (boundp 'add-log-current-defun-function)

Message #15 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Lennart Borgman \(gmail\)" <lennart.borgman <at> gmail.com>
Cc: 1103 <at> debbugs.gnu.org
Subject: Re: 23.0.60; which-func misses functions
Date: Wed, 08 Oct 2008 12:19:20 -0400

> Instead of displaying the last function in an elisp file it may
> display the name of a variable that is above the function.

Could you send (i) a recipe to reproduce this problem, and (ii) a
ChangeLog entry for your patch?

Thanks.

Message #20 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 1103 <at> debbugs.gnu.org
Subject: Re: 23.0.60; which-func misses functions
Date: Thu, 09 Oct 2008 01:22:14 +0200

Chong Yidong wrote:
>> Instead of displaying the last function in an elisp file it may
>> display the name of a variable that is above the function.
> 
> Could you send (i) a recipe to reproduce this problem, and

Hm, sorry, I can't reproduce it now. It might be a problem with an imenu
library I loaded, I did not think of that. I have to investigate this
further.

> (ii) a
> ChangeLog entry for your patch?
> 
> Thanks.
> 

Message #27 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: 1103 <at> debbugs.gnu.org
Cc: Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: bug#1103: 23.0.60; which-func misses functions
Date: Thu, 09 Oct 2008 02:45:50 +0200

Lennart Borgman (gmail) wrote:
> Chong Yidong wrote:
>>> Instead of displaying the last function in an elisp file it may
>>> display the name of a variable that is above the function.
>> Could you send (i) a recipe to reproduce this problem, and
> 
> Hm, sorry, I can't reproduce it now. It might be a problem with an imenu
> library I loaded, I did not think of that. I have to investigate this
> further.

I am a bit puzzled. I see a bit different things. I just tested with a
checkout from 2008-10-03:

  emacs -Q
  M-x find-function RET which-function-mode
  M-x which-function-mode

This gives me wrong function names in the mode line. But there is
something strange there, I will check with a new checkout later ...

>> (ii) a
>> ChangeLog entry for your patch?
>>
>> Thanks.
>>
> 
> 
> 
> 
> 

Message #32 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
Cc: 1103 <at> debbugs.gnu.org, Chong Yidong <cyd <at> stupidchicken.com>
Subject: Re: bug#1103: 23.0.60; which-func misses functions
Date: Thu, 09 Oct 2008 20:18:41 +0200

Lennart Borgman (gmail) wrote:
> Lennart Borgman (gmail) wrote:
>> Chong Yidong wrote:
>>>> Instead of displaying the last function in an elisp file it may
>>>> display the name of a variable that is above the function.
>>> Could you send (i) a recipe to reproduce this problem, and
>> Hm, sorry, I can't reproduce it now. It might be a problem with an imenu
>> library I loaded, I did not think of that. I have to investigate this
>> further.
> 
> I am a bit puzzled. I see a bit different things. I just tested with a
> checkout from 2008-10-03:
> 
>   emacs -Q
>   M-x find-function RET which-function-mode
>   M-x which-function-mode
> 
> This gives me wrong function names in the mode line. But there is
> something strange there, I will check with a new checkout later ...

With a fresh update from today I can still reproduce this problem as above.

Can you please reopen this bug so we do not forget it?

>>> (ii) a
>>> ChangeLog entry for your patch?
>>>
>>> Thanks.
>>>
>>
>>
>>
>>
> 

Message #37 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Lennart Borgman \(gmail\)" <lennart.borgman <at> gmail.com>
Cc: 1103 <at> debbugs.gnu.org
Subject: Re: bug#1103: 23.0.60; which-func misses functions
Date: Thu, 09 Oct 2008 16:00:26 -0400

>>   emacs -Q
>>   M-x find-function RET which-function-mode
>>   M-x which-function-mode
>> 
>> This gives me wrong function names in the mode line. But there is
>> something strange there, I will check with a new checkout later ...
>
> With a fresh update from today I can still reproduce this problem as
> above.

Could you send a ChangeLog for your patch (assuming you still think it's
correct)?

Message #44 received at 1103 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 1103 <at> debbugs.gnu.org,
        Daniel Colascione <dan.colascione <at> gmail.com>
Subject: Re: bug#1103: 23.0.60; which-func misses functions
Date: Thu, 09 Oct 2008 22:40:39 +0200

[Message part 1 (text/plain, inline)]

Chong Yidong wrote:
>>>   emacs -Q
>>>   M-x find-function RET which-function-mode
>>>   M-x which-function-mode
>>>
>>> This gives me wrong function names in the mode line. But there is
>>> something strange there, I will check with a new checkout later ...
>> With a fresh update from today I can still reproduce this problem as
>> above.
> 
> Could you send a ChangeLog for your patch (assuming you still think it's
> correct)?

I have attached a changlog.

Daniel, I think you might have been changing which-function before me.
Do you have any comments on my change?

[changelog-which-func (text/plain, inline)]

2008-10-09  Lennart Borgman  <lennart.borgman <at> gmail.com>

	* which-func.el (which-function): Skip just current sublist when a
	possible match is found in an imenu index.

Message #51 received at 1103-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 1103-done <at> debbugs.gnu.org
Subject: Re: bug#1103: 23.0.60; which-func misses functions
Date: Fri, 15 Jul 2011 17:08:03 -0400

I think this should be closed until a description of how to reproduce
the problem is provided.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.