GNU bug report logs - #11028
24.0.94; bad lighter and menus for `text-scale-mode'

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: drew.adams <at> oracle.com, 11028 <at> debbugs.gnu.org
Subject: bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode'
Date: Sun, 01 May 2016 22:22:20 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi <at> gnus.org>
>> Date: Sun, 01 May 2016 21:46:39 +0200
>> Cc: 11028 <at> debbugs.gnu.org
>> 
>> "Drew Adams" <drew.adams <at> oracle.com> writes:
>> 
>> >  -1
>> >  -------------------
>> >  Turn Off minor mode
>> >  Help for minor mode
>> 
>> [...]
>>   (let* ((minor-mode (lookup-minor-mode-from-indicator indicator))
>>          (mm-fun (or (get minor-mode :minor-mode-function) minor-mode)))
>> 
>> Wow, that's a roundabout way of doing it...  Anyway, we then have the
>> mode symbol...  What about using a pretty version of the mode symbol as
>> the menu header?  That would be "Text Scale Mode" in this case.
>
> What menu header?  Drew was complaining about the tooltip, not the
> menu.  When you actually click on the lighter, the pop-up menu does
> have a header that shows the mode name.
>
> So what are you trying to do here?

The thing with the "+1" at the top is a menu:

      (setq menu
            (if menu
                (mouse-menu-non-singleton menu)
              (if (fboundp mm-fun)      ; bug#20201
                  `(keymap
                    ,indicator
                    (turn-off menu-item "Turn off minor mode" ,mm-fun)
                    (help menu-item "Help for minor mode"
                          (lambda () (interactive)
                            (describe-function ',mm-fun)))))))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.