From unknown Fri Aug 15 16:55:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11019: 24.0.94; ring-insert+extend does not grow ring properly Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Mar 2012 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11019@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13317949289038 (code B ref -1); Thu, 15 Mar 2012 07:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2012 07:02:08 +0000 Received: from localhost ([127.0.0.1]:51485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S84hL-0002Li-Q1 for submit@debbugs.gnu.org; Thu, 15 Mar 2012 03:02:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53893) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S84hI-0002LX-Ma for submit@debbugs.gnu.org; Thu, 15 Mar 2012 03:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S84E9-0003Pd-0t for submit@debbugs.gnu.org; Thu, 15 Mar 2012 02:31:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S84E8-0003PY-UO for submit@debbugs.gnu.org; Thu, 15 Mar 2012 02:31:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S84E4-0000LY-Ch for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S84E2-0003P8-Ln for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S84E2-0003P4-Il for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:50 -0400 Received: from [155.69.19.195] (port=50875 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S84E1-0005wW-ER for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:50 -0400 From: Chong Yidong Date: Thu, 15 Mar 2012 14:31:42 +0800 Message-ID: <87sjha1ik1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Looks like ring-insert+extend with a non-nil GROW-P argument does not grow the ring properly if the ring is already "wrapped around": (require 'ring) (setq ring (make-ring 4)) (ring-insert ring 0) (ring-insert ring 1) (ring-insert ring 2) (ring-insert ring 3) (ring-insert ring 4) (setq foo (ring-elements ring)) ;; ==> (4 3 2 1) (ring-insert+extend ring 5 t) (setq bar (ring-elements ring)) ;; ==> (1 4 5 3 2) ;; expected: (5 4 3 2 1) I will write up a fix for this soon. From unknown Fri Aug 15 16:55:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Chong Yidong Subject: bug#11019: closed (Re: bug#11019: 24.0.94; ring-insert+extend does not grow ring properly) Message-ID: References: <87haxquvrs.fsf@gnu.org> <87sjha1ik1.fsf@gnu.org> X-Gnu-PR-Message: they-closed 11019 X-Gnu-PR-Package: emacs Reply-To: 11019@debbugs.gnu.org Date: Thu, 15 Mar 2012 08:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1331801042-17603-1" This is a multi-part message in MIME format... ------------=_1331801042-17603-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11019: 24.0.94; ring-insert+extend does not grow ring properly which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11019@debbugs.gnu.org. --=20 11019: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11019 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1331801042-17603-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11019-done) by debbugs.gnu.org; 15 Mar 2012 08:43:53 +0000 Received: from localhost ([127.0.0.1]:51563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S86Hp-0004ZU-2b for submit@debbugs.gnu.org; Thu, 15 Mar 2012 04:43:53 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43495) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S86Hd-0004ZA-Rl for 11019-done@debbugs.gnu.org; Thu, 15 Mar 2012 04:43:52 -0400 Received: from [155.69.19.195] (port=50879 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S85oU-0002On-AE for 11019-done@debbugs.gnu.org; Thu, 15 Mar 2012 04:13:34 -0400 From: Chong Yidong To: 11019-done@debbugs.gnu.org Subject: Re: bug#11019: 24.0.94; ring-insert+extend does not grow ring properly References: <87sjha1ik1.fsf@gnu.org> Date: Thu, 15 Mar 2012 16:13:27 +0800 In-Reply-To: <87sjha1ik1.fsf@gnu.org> (Chong Yidong's message of "Thu, 15 Mar 2012 14:31:42 +0800") Message-ID: <87haxquvrs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11019-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Chong Yidong writes: > I will write up a fix for this soon. Fixed in revno 107606. ------------=_1331801042-17603-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Mar 2012 07:02:08 +0000 Received: from localhost ([127.0.0.1]:51485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S84hL-0002Li-Q1 for submit@debbugs.gnu.org; Thu, 15 Mar 2012 03:02:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53893) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S84hI-0002LX-Ma for submit@debbugs.gnu.org; Thu, 15 Mar 2012 03:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S84E9-0003Pd-0t for submit@debbugs.gnu.org; Thu, 15 Mar 2012 02:31:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S84E8-0003PY-UO for submit@debbugs.gnu.org; Thu, 15 Mar 2012 02:31:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S84E4-0000LY-Ch for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S84E2-0003P8-Ln for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S84E2-0003P4-Il for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:50 -0400 Received: from [155.69.19.195] (port=50875 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S84E1-0005wW-ER for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 02:31:50 -0400 From: Chong Yidong To: bug-gnu-emacs@gnu.org Subject: 24.0.94; ring-insert+extend does not grow ring properly Date: Thu, 15 Mar 2012 14:31:42 +0800 Message-ID: <87sjha1ik1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Looks like ring-insert+extend with a non-nil GROW-P argument does not grow the ring properly if the ring is already "wrapped around": (require 'ring) (setq ring (make-ring 4)) (ring-insert ring 0) (ring-insert ring 1) (ring-insert ring 2) (ring-insert ring 3) (ring-insert ring 4) (setq foo (ring-elements ring)) ;; ==> (4 3 2 1) (ring-insert+extend ring 5 t) (setq bar (ring-elements ring)) ;; ==> (1 4 5 3 2) ;; expected: (5 4 3 2 1) I will write up a fix for this soon. ------------=_1331801042-17603-1--