From svenjoac@gmx.de Mon Oct 6 02:01:40 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.4 required=4.0 tests=AWL,BAYES_00,HAS_PACKAGE, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 6 Oct 2008 09:01:40 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9691Xng029841 for ; Mon, 6 Oct 2008 02:01:34 -0700 Received: from mx10.gnu.org ([199.232.76.166]:55916) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kmlvs-0001Sq-8o for emacs-pretest-bug@gnu.org; Mon, 06 Oct 2008 04:59:12 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kmly6-0005aK-3R for emacs-pretest-bug@gnu.org; Mon, 06 Oct 2008 05:01:31 -0400 Received: from mail.gmx.net ([213.165.64.20]:38049) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Kmly5-0005Xw-9a for emacs-pretest-bug@gnu.org; Mon, 06 Oct 2008 05:01:29 -0400 Received: (qmail invoked by alias); 06 Oct 2008 09:01:24 -0000 Received: from p5486783F.dip.t-dialin.net (EHLO debian) [84.134.120.63] by mail.gmx.net (mp056) with SMTP; 06 Oct 2008 11:01:24 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX19GDm4HE2hGYj+VQaFnle56pHureb4PEdcsoGPnlO VyyTHHpRupc7JY From: Sven Joachim To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Various eshell files need cl at compile time for `assert' Date: Mon, 06 Oct 2008 11:01:22 +0200 Message-ID: <87bpxy2j31.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Package: emacs Version: 23.0.60 Tags: patch A recent message¹ on help-gnu-emacs showed eshell failing because `assert' is not defined. There are no less than six eshell files which use this macro without requiring cl at compile time. The following patch takes care of this: --8<---------------cut here---------------start------------->8--- Index: lisp/eshell/em-cmpl.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/em-cmpl.el,v retrieving revision 1.27 diff -c -r1.27 em-cmpl.el *** lisp/eshell/em-cmpl.el 21 May 2008 03:51:06 -0000 1.27 --- lisp/eshell/em-cmpl.el 6 Oct 2008 08:25:44 -0000 *************** *** 71,76 **** --- 71,77 ---- ;;; Code: (eval-when-compile + (require 'cl) (require 'eshell)) (require 'esh-util) Index: lisp/eshell/em-hist.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/em-hist.el,v retrieving revision 1.29 diff -c -r1.29 em-hist.el *** lisp/eshell/em-hist.el 21 May 2008 03:51:06 -0000 1.29 --- lisp/eshell/em-hist.el 6 Oct 2008 08:25:44 -0000 *************** *** 55,60 **** --- 55,63 ---- ;;; Code: + (eval-when-compile + (require 'cl)) + (require 'ring) (require 'esh-opt) (require 'em-pred) Index: lisp/eshell/em-ls.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/em-ls.el,v retrieving revision 1.34 diff -c -r1.34 em-ls.el *** lisp/eshell/em-ls.el 15 Aug 2008 06:55:37 -0000 1.34 --- lisp/eshell/em-ls.el 6 Oct 2008 08:25:44 -0000 *************** *** 27,33 **** ;;; Code: ! (eval-when-compile (require 'eshell)) (require 'esh-util) (require 'esh-opt) --- 27,35 ---- ;;; Code: ! (eval-when-compile ! (require 'cl) ! (require 'eshell)) (require 'esh-util) (require 'esh-opt) Index: lisp/eshell/esh-cmd.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/esh-cmd.el,v retrieving revision 1.43 diff -c -r1.43 esh-cmd.el *** lisp/eshell/esh-cmd.el 15 Aug 2008 06:55:11 -0000 1.43 --- lisp/eshell/esh-cmd.el 6 Oct 2008 08:25:45 -0000 *************** *** 109,114 **** --- 109,115 ---- (require 'esh-ext) (eval-when-compile + (require 'cl) (require 'pcomplete)) Index: lisp/eshell/esh-ext.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/esh-ext.el,v retrieving revision 1.29 diff -c -r1.29 esh-ext.el *** lisp/eshell/esh-ext.el 6 May 2008 03:36:20 -0000 1.29 --- lisp/eshell/esh-ext.el 6 Oct 2008 08:25:45 -0000 *************** *** 33,38 **** --- 33,39 ---- (provide 'esh-ext) (eval-when-compile + (require 'cl) (require 'esh-cmd)) (require 'esh-util) Index: lisp/eshell/esh-io.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/esh-io.el,v retrieving revision 1.23 diff -c -r1.23 esh-io.el *** lisp/eshell/esh-io.el 7 Jun 2008 02:37:13 -0000 1.23 --- lisp/eshell/esh-io.el 6 Oct 2008 08:25:45 -0000 *************** *** 57,63 **** (provide 'esh-io) ! (eval-when-compile (require 'eshell)) (defgroup eshell-io nil "Eshell's I/O management code provides a scheme for treating many --- 57,65 ---- (provide 'esh-io) ! (eval-when-compile ! (require 'cl) ! (require 'eshell)) (defgroup eshell-io nil "Eshell's I/O management code provides a scheme for treating many --8<---------------cut here---------------end--------------->8--- Suggested Changelog entry: --8<---------------cut here---------------start------------->8--- 2008-10-06 Sven Joachim * eshell/em-cmpl.el (require): * eshell/em-hist.el (require): * eshell/em-ls.el (require): * eshell/esh-cmd.el (require): * eshell/esh-ext.el (require): * eshell/esh-io.el (require): Require cl at compile time because `assert' needs it. --8<---------------cut here---------------end--------------->8--- ¹ http://lists.gnu.org/archive/html/help-gnu-emacs/2008-10/msg00120.html From rgm@gnu.org Wed Oct 8 00:44:30 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1099-done) by emacsbugs.donarmstrong.com; 8 Oct 2008 07:44:30 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m987iRIs014596 for <1099-done@emacsbugs.donarmstrong.com>; Wed, 8 Oct 2008 00:44:28 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KnTgJ-0001yQ-Ro; Wed, 08 Oct 2008 03:42:03 -0400 From: Glenn Morris To: 1099-done@debbugs.gnu.org Subject: Re: bug#1099: 23.0.60; Various eshell files need cl at compile time for `assert' References: <87bpxy2j31.fsf@gmx.de> X-Spook: Perl-RSA USCODE Albright Cohiba import InfoSec analyzer X-Ran: NwMNex$8P:6WLQS5)*Dd4\^(Y8Rz_P^5q>uAaCqQk;X (Sven Joachim's message of "Mon, 06 Oct 2008 11:01:22 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Sven Joachim wrote: > A recent message=B9 on help-gnu-emacs showed eshell failing because > `assert' is not defined.=20=20 Unreproducible. >There are no less than six eshell files which use this macro without >requiring cl at compile time. The following patch takes care of this: I don't think there is a real problem here, because cl is brought in through other requires, nevertheless for the sake of clarity I have installed your patch. From svenjoac@gmx.de Wed Oct 8 01:28:45 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.0 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1099) by emacsbugs.donarmstrong.com; 8 Oct 2008 08:28:45 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m988SfsN026071 for <1099@emacsbugs.donarmstrong.com>; Wed, 8 Oct 2008 01:28:42 -0700 Received: (qmail invoked by alias); 08 Oct 2008 08:28:35 -0000 Received: from p5486575E.dip.t-dialin.net (EHLO debian) [84.134.87.94] by mail.gmx.net (mp040) with SMTP; 08 Oct 2008 10:28:35 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX1+/A/Av7jq/o7xmEs/h/VMDr0NXM+j7cq72Q903tm g9Q3MXkv87N+ez From: Sven Joachim To: Glenn Morris , 1099@debbugs.gnu.org Subject: Re: bug#1099 closed by Glenn Morris (Re: bug#1099: 23.0.60; Various eshell files need cl at compile time for `assert') References: <87bpxy2j31.fsf@gmx.de> Date: Wed, 08 Oct 2008 10:28:27 +0200 In-Reply-To: (Emacs bug Tracking System's message of "Wed, 8 Oct 2008 00:50:03 -0700") Message-ID: <87tzbnebis.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.59 > From: Glenn Morris > Subject: Re: bug#1099: 23.0.60; Various eshell files need cl at compile time for `assert' > To: 1099-done@emacsbugs.donarmstrong.com > Date: Wed, 08 Oct 2008 03:42:03 -0400 > User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) > > Sven Joachim wrote: > >> A recent message¹ on help-gnu-emacs showed eshell failing because >> `assert' is not defined. > > Unreproducible. I had the same problem, though. It went away after bootstrapping. >>There are no less than six eshell files which use this macro without >>requiring cl at compile time. The following patch takes care of this: > > I don't think there is a real problem here, because cl is brought in > through other requires, It isn't. When I byte-compiled the affected files manually, I got a warning that `assert' is not known to be defined. Maybe you have cl loaded in your environment? > nevertheless for the sake of clarity I have > installed your patch. Thanks. Sven From rgm@gnu.org Wed Oct 8 09:39:36 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.7 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,UNRESOLVED_TEMPLATE,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1099) by emacsbugs.donarmstrong.com; 8 Oct 2008 16:39:36 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m98GdT9d019830 for <1099@emacsbugs.donarmstrong.com>; Wed, 8 Oct 2008 09:39:30 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Knc25-0001i3-LT; Wed, 08 Oct 2008 12:37:05 -0400 From: Glenn Morris To: Sven Joachim Cc: 1099@debbugs.gnu.org Subject: Re: bug#1099 closed by Glenn Morris (Re: bug#1099: 23.0.60; Various eshell files need cl at compile time for `assert') References: <87bpxy2j31.fsf@gmx.de> <87tzbnebis.fsf@gmx.de> X-Spook: Perl-RSA NASA White Water pipeline SEAL Team 6 MIT-LL X-Ran: =c?/87=8=,/IyA%^D\{2B"wBA6U'!n8Fp@n"zp=)`/}f[$%OLcAMh0RcXJ(UgV"csi.RV{ X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 08 Oct 2008 12:37:05 -0400 In-Reply-To: <87tzbnebis.fsf@gmx.de> (Sven Joachim's message of "Wed, 08 Oct 2008 10:28:27 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I think you might have seen such a problem if eshell.el was compiled first, which is not something that happens during a normal serial bootstrap, due to the way the files happen to sort. From svenjoac@gmx.de Wed Oct 8 10:26:09 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1099) by emacsbugs.donarmstrong.com; 8 Oct 2008 17:26:09 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m98HQ2tI032577 for <1099@emacsbugs.donarmstrong.com>; Wed, 8 Oct 2008 10:26:04 -0700 Received: (qmail invoked by alias); 08 Oct 2008 17:25:53 -0000 Received: from p5486581D.dip.t-dialin.net (EHLO turtle) [84.134.88.29] by mail.gmx.net (mp055) with SMTP; 08 Oct 2008 19:25:53 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX1/JRXJaNAzJfT0Em2FDvYCa6Oafmp+Me5LQbUhEn8 JICAuy3AaCki9X From: Sven Joachim To: Glenn Morris Cc: 1099@debbugs.gnu.org Subject: Re: bug#1099 closed by Glenn Morris (Re: bug#1099: 23.0.60; Various eshell files need cl at compile time for `assert') References: <87bpxy2j31.fsf@gmx.de> <87tzbnebis.fsf@gmx.de> Date: Wed, 08 Oct 2008 19:25:51 +0200 In-Reply-To: (Glenn Morris's message of "Wed, 08 Oct 2008 12:37:05 -0400") Message-ID: <87k5cjt2w0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.8100000000000001 On 2008-10-08 18:37 +0200, Glenn Morris wrote: > I think you might have seen such a problem if eshell.el was compiled > first, which is not something that happens during a normal serial > bootstrap, due to the way the files happen to sort. Exactly. It must have happened when one of the files was recompiled after `cvs up'. From unknown Tue Aug 19 02:52:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Nov 2008 15:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator