GNU bug report logs - #10987
ibuffer: remove "No Buffers" error

Previous Next

Full log

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#10987: ibuffer: remove "No Buffers" error
Date: Sun, 11 Mar 2012 19:34:24 +0100

[Message part 1 (text/plain, inline)]

Chong Yidong <cyd <at> gnu.org> writes:

> Thanks.  I committed your patch to trunk.

Thank you very much.  I just skimmed through ibuffer.el and found the
same error in ibuffer-redisplay.

[ibuffer2.diff (text/x-diff, inline)]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 4710434..5b11660 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-11  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* ibuffer.el (ibuffer-redisplay): Remove gratuitous error
+	(Bug#10987).
+
 2012-03-11  Michael Albinus  <michael.albinus <at> gmx.de>
 
 	* autorevert.el (auto-revert-handler): Ensure, that
diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 7db4cc4..7e5a4aa 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -2173,11 +2173,10 @@ If optional arg SILENT is non-nil, do not display progress messages."
 		   (cadr bufs))
 		 (ibuffer-current-buffers-with-marks bufs)
 		 ibuffer-display-maybe-show-predicates)))
-    (when (null blist)
-      (if (and (featurep 'ibuf-ext)
+    (when (and (null blist)
+	       (featurep 'ibuf-ext)
 	       ibuffer-filtering-qualifiers)
-	  (message "No buffers! (note: filtering in effect)")
-	(error "No buffers!")))
+      (message "No buffers! (note: filtering in effect)"))
     (unless silent
       (message "Updating buffer list..."))
     (ibuffer-redisplay-engine blist arg)

[Message part 3 (text/plain, inline)]

        Christopher

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.