From unknown Mon Aug 18 14:22:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10967 <10967@debbugs.gnu.org> To: bug#10967 <10967@debbugs.gnu.org> Subject: Status: Weird 'du' behavior. Bug in coreutils-8.15 ? Reply-To: bug#10967 <10967@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:22:00 +0000 retitle 10967 Weird 'du' behavior. Bug in coreutils-8.15 ? reassign 10967 coreutils submitter 10967 Daniel Stavrovski severity 10967 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 19:49:47 2012 Received: (at submit) by debbugs.gnu.org; 8 Mar 2012 00:49:47 +0000 Received: from localhost ([127.0.0.1]:38184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5RY6-0008FD-3p for submit@debbugs.gnu.org; Wed, 07 Mar 2012 19:49:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42092) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5RVp-0008BY-EC for submit@debbugs.gnu.org; Wed, 07 Mar 2012 19:47:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5RUn-0002KF-Sg for submit@debbugs.gnu.org; Wed, 07 Mar 2012 19:46:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,BODY_8BITS, HTML_FONT_FACE_BAD,HTML_MESSAGE,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5RUn-0002KA-MT for submit@debbugs.gnu.org; Wed, 07 Mar 2012 19:46:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5RUl-0006SQ-J5 for bug-coreutils@gnu.org; Wed, 07 Mar 2012 19:46:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5RUj-0002Jx-AB for bug-coreutils@gnu.org; Wed, 07 Mar 2012 19:46:14 -0500 Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:33225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5RUi-0002Jp-VS for bug-coreutils@gnu.org; Wed, 07 Mar 2012 19:46:13 -0500 Received: by obbta14 with SMTP id ta14so8896562obb.0 for ; Wed, 07 Mar 2012 16:46:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stavrovski.net; s=stavrovski.net; h=mime-version:x-originating-ip:date:message-id:subject:from:to :content-type; bh=ZiPI7aLe9zYAjLzq0Sn+mmHOyr4rQHqYdk+BR55/EoM=; b=NNg1QJcPhqVVSJlIR8nOFW1GKLY8ExRyCtPJY+ivPZAMFMdFyyQjcoT3o/4Yk3DN2H TFp9KcNbxU59s3EOSwSeLPeShOOBulQLQ1s6xftCRsKameMtP/1b9k1A+4msH47y48xz pVxLupvpwCnUcaaEgU4Ct1nUXvtQ7lCDDt03o= MIME-Version: 1.0 Received: by 10.60.28.133 with SMTP id b5mr1760292oeh.4.1331167569879; Wed, 07 Mar 2012 16:46:09 -0800 (PST) Received: by 10.60.19.169 with HTTP; Wed, 7 Mar 2012 16:46:09 -0800 (PST) X-Originating-IP: [216.114.78.160] Date: Wed, 7 Mar 2012 18:46:09 -0600 Message-ID: Subject: Weird 'du' behavior. Bug in coreutils-8.15 ? From: Daniel Stavrovski To: bug-coreutils@gnu.org Content-Type: multipart/alternative; boundary=e89a8fb1f7a623a07304bab09a4c X-Gm-Message-State: ALoCoQljNWIcWCYr7tNBarzDTbj5sUi4iIUbouuRvYWey1yKBy0DpzR3mKqMcYMGb2mje+j6tg1e X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 07 Mar 2012 19:49:30 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) --e89a8fb1f7a623a07304bab09a4c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=94=8C=E2=94=80[01:17:15]-[root@stavrovski]-[~] =E2=94=94=E2=94=80=E2=80=BA mkdir /tmp/another_test/ && for i in $(seq 1 20= ); do dd if=3D/dev/zero of=3D/tmp/another_test/file-$i bs=3D1024 count=3D10240 ; done =E2=94=8C=E2=94=80[01:17:17]-[root@stavrovski]-[~] =E2=94=94=E2=94=80=E2=80=BA ls -1 /tmp/another_test/* | wc -l 20 =E2=94=8C=E2=94=80[01:17:36]-[root@stavrovski]-[~] =E2=94=94=E2=94=80=E2=80=BA du -csxh /tmp/another_test/* 0 total =E2=94=8C=E2=94=80[01:28:19]-[root@stavrovski]-[~] =E2=94=94=E2=94=80=E2=80=BA du --version du (GNU coreutils) 8.15 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Torbj=C3=B6rn Granlund, David MacKenzie, Paul Eggert, and Jim Meyering. =E2=94=8C=E2=94=80[01:39:04]-[root@stavrovski]-[~] =E2=94=94=E2=94=80=E2=80=BA cat /etc/issue Arch Linux \r (\l) =E2=94=8C=E2=94=80[01:39:22]-[root@stavrovski]-[~] =E2=94=94=E2=94=80=E2=80=BA pacman -Qs coreutils local/coreutils 8.15-1 (base) with coreutils-8.14 du is working as expected. strace =3D> http://pastebin.com/dPAKCNwF --=20 An Educated Fool --e89a8fb1f7a623a07304bab09a4c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E2=94=8C=E2=94=80[01:17:15]-[root@stavrovski]-[~]
=E2=94=94=E2=94=80=E2= =80=BA mkdir /tmp/another_test/ && for i in $(seq 1 20); do dd if= =3D/dev/zero of=3D/tmp/another_test/file-$i=C2=A0 bs=3D1024=C2=A0 count=3D1= 0240 ; done

=E2=94=8C=E2=94=80[01:17:17]-[root@stavrovski]-[~]
=E2=94=94=E2=94=80=E2=80=BA ls -1 /tmp/another_test/* | wc -l
20

= =E2=94=8C=E2=94=80[01:17:36]-[root@stavrovski]-[~]
=E2=94=94=E2=94=80=E2= =80=BA du -csxh /tmp/another_test/*
0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 total

=E2=94=8C=E2=94=80[01:28:19]-[root@stavrovski]-[~]
=E2= =94=94=E2=94=80=E2=80=BA du --version
du (GNU coreutils) 8.15
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GP= L version 3 or later <http:= //gnu.org/licenses/gpl.html>.
This is free software: you are free= to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tor= bj=C3=B6rn Granlund, David MacKenzie, Paul Eggert,
and Jim Meyering.
=
=E2=94=8C=E2=94=80[01:39:04]-[root@stavrovski]-[~]
=E2=94=94=E2=94= =80=E2=80=BA cat /etc/issue
Arch Linux \r (\l)

=E2=94=8C=E2=94=80[01:39:22]-[root@stavrovski]-[~]
=E2=94=94=E2=94= =80=E2=80=BA pacman -Qs coreutils
local/coreutils 8.15-1 (base)

w= ith coreutils-8.14 du is working as expected.

strace =3D> http://pastebin.com/dPAKCNwF

--
An Educ= ated Fool

--e89a8fb1f7a623a07304bab09a4c-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 03:20:58 2012 Received: (at 10967) by debbugs.gnu.org; 8 Mar 2012 08:20:58 +0000 Received: from localhost ([127.0.0.1]:38509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5Yao-0001nZ-8J for submit@debbugs.gnu.org; Thu, 08 Mar 2012 03:20:58 -0500 Received: from mx.meyering.net ([88.168.87.75]:45815) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5Yab-0001n9-OA for 10967@debbugs.gnu.org; Thu, 08 Mar 2012 03:20:46 -0500 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 22D8760132; Thu, 8 Mar 2012 09:19:41 +0100 (CET) From: Jim Meyering To: Daniel Stavrovski Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? In-Reply-To: (Daniel Stavrovski's message of "Wed, 7 Mar 2012 18:46:09 -0600") References: Date: Thu, 08 Mar 2012 09:19:41 +0100 Message-ID: <87d38nqzc2.fsf@rho.meyering.net> Lines: 36 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10967 Cc: 10967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Daniel Stavrovski wrote: > =E2=94=8C=E2=94=80[01:17:15]-[root@stavrovski]-[~] > =E2=94=94=E2=94=80=E2=80=BA mkdir /tmp/another_test/ && for i in $(seq 1 = 20); do dd if=3D/dev/zero > of=3D/tmp/another_test/file-$i bs=3D1024 count=3D10240 ; done > > =E2=94=8C=E2=94=80[01:17:17]-[root@stavrovski]-[~] > =E2=94=94=E2=94=80=E2=80=BA ls -1 /tmp/another_test/* | wc -l > 20 > > =E2=94=8C=E2=94=80[01:17:36]-[root@stavrovski]-[~] > =E2=94=94=E2=94=80=E2=80=BA du -csxh /tmp/another_test/* > 0 total > > =E2=94=8C=E2=94=80[01:28:19]-[root@stavrovski]-[~] > =E2=94=94=E2=94=80=E2=80=BA du --version > du (GNU coreutils) 8.15 Oh! That's a regression. Thank you for finding/reporting it! Here's the fix I expect to use: diff --git a/src/du.c b/src/du.c index e4e36df..c1c0417 100644 --- a/src/du.c +++ b/src/du.c @@ -443,7 +443,9 @@ process_file (FTS *fts, FTSENT *ent) return false; } - if (fts->fts_options & FTS_XDEV && fts->fts_dev !=3D sb->st_dev) + if (fts->fts_options & FTS_XDEV + && FTS_ROOTLEVEL < ent->fts_level + && fts->fts_dev !=3D sb->st_dev) excluded =3D true; } From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 05:38:16 2012 Received: (at 10967) by debbugs.gnu.org; 8 Mar 2012 10:38:16 +0000 Received: from localhost ([127.0.0.1]:38670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5ajc-0004wy-Vs for submit@debbugs.gnu.org; Thu, 08 Mar 2012 05:38:16 -0500 Received: from mx.meyering.net ([88.168.87.75]:46204) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5ajH-0004w4-LT for 10967@debbugs.gnu.org; Thu, 08 Mar 2012 05:37:56 -0500 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id C3FB6600E3; Thu, 8 Mar 2012 11:36:46 +0100 (CET) From: Jim Meyering To: Daniel Stavrovski Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? In-Reply-To: <87d38nqzc2.fsf@rho.meyering.net> (Jim Meyering's message of "Thu, 08 Mar 2012 09:19:41 +0100") References: <87d38nqzc2.fsf@rho.meyering.net> Date: Thu, 08 Mar 2012 11:36:46 +0100 Message-ID: <877gyvqszl.fsf@rho.meyering.net> Lines: 131 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10967 Cc: 10967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Jim Meyering wrote: ... >> du (GNU coreutils) 8.15 > > Oh! That's a regression. > Thank you for finding/reporting it! > > Here's the fix I expect to use: > > diff --git a/src/du.c b/src/du.c > index e4e36df..c1c0417 100644 > --- a/src/du.c > +++ b/src/du.c > @@ -443,7 +443,9 @@ process_file (FTS *fts, FTSENT *ent) > return false; > } > > - if (fts->fts_options & FTS_XDEV && fts->fts_dev !=3D sb->st_de= v) > + if (fts->fts_options & FTS_XDEV > + && FTS_ROOTLEVEL < ent->fts_level > + && fts->fts_dev !=3D sb->st_dev) > excluded =3D true; > } Thanks again. A small reproducer is to run this: du -x /etc/passwd If it prints nothing (coreutils-8.15), you have the bug. Here is a complete patch: >From b51e77776fbc4c8fa6727388b735427596595477 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 8 Mar 2012 10:33:50 +0100 Subject: [PATCH] du: --one-file-system (-x) ignores non-directory arguments Surprise! "du -x non-DIR" would print nothing. Note that the problem arises only when processing a non-directory specified on the command line. Not surprisingly, "du -x" still works as expected for any directory argument. When performing its same-file-system check, du may skip an entry only if it is at fts_level 1 or greater. Command-line arguments are at fts_level =3D=3D 0 (FTS_ROOTLEVEL). * src/du.c (process_file): Don't use the top-level FTS->fts_dev when testing for --one-file-system (-x). It happens to be valid for directories, but it is always 0 for a non-directory. * tests/du/one-file-system: Add tests for this. * NEWS (Bug fixes): Mention it. Reported by Daniel Stavrovski in http://bugs.gnu.org/10967. Introduced by commit v8.14-95-gcfe1040. --- NEWS | 4 ++++ THANKS.in | 1 + src/du.c | 9 ++++++++- tests/du/one-file-system | 10 +++++++++- 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 04c911f..3224b30 100644 --- a/NEWS +++ b/NEWS @@ -22,6 +22,10 @@ GNU coreutils NEWS -*= - outline -*- ** Bug fixes + du --one-file-system (-x) would ignore any non-directory specified on + the command line. For example, "touch f; du -x f" would print nothing. + [bug introduced in coreutils-8.14] + mv now lets you move a symlink onto a same-inode destination file that has two or more hard links. Before, it would reject that, saying that they are the same, implicitly warning you that the move would result in diff --git a/THANKS.in b/THANKS.in index c8dd75f..d23f7b3 100644 --- a/THANKS.in +++ b/THANKS.in @@ -134,6 +134,7 @@ Dan Hagerty hag@gnu.ai.it.edu Dan Pascu dan@services.iiruc.ro Daniel Bergstrom noa@melody.se Daniel P. Berrang=E9 berrange@redhat.com +Daniel Stavrovski d@stavrovski.net D=E1niel Varga danielv@axelero.hu Danny Levinson danny.levinson@overture.com Darrel Francis d.francis@cheerful.com diff --git a/src/du.c b/src/du.c index e4e36df..41c9535 100644 --- a/src/du.c +++ b/src/du.c @@ -443,7 +443,14 @@ process_file (FTS *fts, FTSENT *ent) return false; } - if (fts->fts_options & FTS_XDEV && fts->fts_dev !=3D sb->st_dev) + /* The --one-file-system (-x) option cannot exclude anything + specified on the command-line. By definition, it can exclude + a file or directory only when its device number is different + from that of its just-processed parent directory, and du does + not process the parent of a command-line argument. */ + if (fts->fts_options & FTS_XDEV + && FTS_ROOTLEVEL < ent->fts_level + && fts->fts_dev !=3D sb->st_dev) excluded =3D true; } diff --git a/tests/du/one-file-system b/tests/du/one-file-system index f0d264a..110080f 100755 --- a/tests/du/one-file-system +++ b/tests/du/one-file-system @@ -43,7 +43,15 @@ compare exp out || fail=3D1 du -xL d > u || fail=3D1 sed 's/^[0-9][0-9]* //' u > out1 echo d > exp1 || fail=3D1 - compare exp1 out1 || fail=3D1 +# With coreutils-8.15, "du -xs FILE" would print no output. +touch f +for opt in -x -xs; do + du $opt f > u || fail=3D1 + sed 's/^[0-9][0-9]* //' u > out2 + echo f > exp2 || fail=3D1 + compare exp2 out2 || fail=3D1 +done + Exit $fail -- 1.7.9.3.363.g121f0 From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 06:06:22 2012 Received: (at 10967) by debbugs.gnu.org; 8 Mar 2012 11:06:22 +0000 Received: from localhost ([127.0.0.1]:38707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5bAo-0005aX-BI for submit@debbugs.gnu.org; Thu, 08 Mar 2012 06:06:21 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:40127) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5bAP-0005Zb-0d for 10967@debbugs.gnu.org; Thu, 08 Mar 2012 06:06:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq0DAEuRWE9tTB6M/2dsb2JhbAAMNrQkBIQcAQEBAwEnCwFGBQsLDQQDAQIBCRYPCQMCAQIBPQgGDQEFAgEBFodptzqKb4V/BJtHhR6Ec4Jj Received: from unknown (HELO [192.168.1.79]) ([109.76.30.140]) by mail1.vodafone.ie with ESMTP; 08 Mar 2012 11:04:47 +0000 Message-ID: <4F589246.7070501@draigBrady.com> Date: Thu, 08 Mar 2012 11:04:38 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? References: <87d38nqzc2.fsf@rho.meyering.net> <877gyvqszl.fsf@rho.meyering.net> In-Reply-To: <877gyvqszl.fsf@rho.meyering.net> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10967 Cc: 10967@debbugs.gnu.org, Daniel Stavrovski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 03/08/2012 10:36 AM, Jim Meyering wrote: > Jim Meyering wrote: > ... >>> du (GNU coreutils) 8.15 >> >> Oh! That's a regression. >> Thank you for finding/reporting it! >> >> Here's the fix I expect to use: >> >> diff --git a/src/du.c b/src/du.c >> index e4e36df..c1c0417 100644 >> --- a/src/du.c >> +++ b/src/du.c >> @@ -443,7 +443,9 @@ process_file (FTS *fts, FTSENT *ent) >> return false; >> } >> >> - if (fts->fts_options & FTS_XDEV && fts->fts_dev != sb->st_dev) >> + if (fts->fts_options & FTS_XDEV >> + && FTS_ROOTLEVEL < ent->fts_level >> + && fts->fts_dev != sb->st_dev) >> excluded = true; >> } > > Thanks again. > A small reproducer is to run this: > > du -x /etc/passwd > > If it prints nothing (coreutils-8.15), you have the bug. > > Here is a complete patch: > >>>From b51e77776fbc4c8fa6727388b735427596595477 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 8 Mar 2012 10:33:50 +0100 > Subject: [PATCH] du: --one-file-system (-x) ignores non-directory arguments I find it a bit easier to parse if the summary describes the change rather than the bug. So something like: du: fix -x to include non-directory arguments > Surprise! "du -x non-DIR" would print nothing. > Note that the problem arises only when processing a non-directory > specified on the command line. Not surprisingly, "du -x" still > works as expected for any directory argument. > > When performing its same-file-system check, du may skip an entry > only if it is at fts_level 1 or greater. Command-line arguments > are at fts_level == 0 (FTS_ROOTLEVEL). > > * src/du.c (process_file): Don't use the top-level FTS->fts_dev > when testing for --one-file-system (-x). It happens to be valid > for directories, but it is always 0 for a non-directory. > * tests/du/one-file-system: Add tests for this. > * NEWS (Bug fixes): Mention it. > Reported by Daniel Stavrovski in http://bugs.gnu.org/10967. > Introduced by commit v8.14-95-gcfe1040. While I can `git show` the above revision format, gitk doesn't hyperlink it. Does gitweb auto link the above format? I guess they may in future at least? > --- > NEWS | 4 ++++ > THANKS.in | 1 + > src/du.c | 9 ++++++++- > tests/du/one-file-system | 10 +++++++++- > 4 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 04c911f..3224b30 100644 > --- a/NEWS > +++ b/NEWS > @@ -22,6 +22,10 @@ GNU coreutils NEWS -*- outline -*- > > ** Bug fixes > > + du --one-file-system (-x) would ignore any non-directory specified on > + the command line. For example, "touch f; du -x f" would print nothing. > + [bug introduced in coreutils-8.14] > + > mv now lets you move a symlink onto a same-inode destination file that > has two or more hard links. Before, it would reject that, saying that > they are the same, implicitly warning you that the move would result in > diff --git a/THANKS.in b/THANKS.in > index c8dd75f..d23f7b3 100644 > --- a/THANKS.in > +++ b/THANKS.in > @@ -134,6 +134,7 @@ Dan Hagerty hag@gnu.ai.it.edu > Dan Pascu dan@services.iiruc.ro > Daniel Bergstrom noa@melody.se > Daniel P. Berrangé berrange@redhat.com > +Daniel Stavrovski d@stavrovski.net > Dániel Varga danielv@axelero.hu > Danny Levinson danny.levinson@overture.com > Darrel Francis d.francis@cheerful.com > diff --git a/src/du.c b/src/du.c > index e4e36df..41c9535 100644 > --- a/src/du.c > +++ b/src/du.c > @@ -443,7 +443,14 @@ process_file (FTS *fts, FTSENT *ent) > return false; > } > > - if (fts->fts_options & FTS_XDEV && fts->fts_dev != sb->st_dev) > + /* The --one-file-system (-x) option cannot exclude anything > + specified on the command-line. By definition, it can exclude > + a file or directory only when its device number is different > + from that of its just-processed parent directory, and du does > + not process the parent of a command-line argument. */ > + if (fts->fts_options & FTS_XDEV > + && FTS_ROOTLEVEL < ent->fts_level > + && fts->fts_dev != sb->st_dev) > excluded = true; > } > > diff --git a/tests/du/one-file-system b/tests/du/one-file-system > index f0d264a..110080f 100755 > --- a/tests/du/one-file-system > +++ b/tests/du/one-file-system > @@ -43,7 +43,15 @@ compare exp out || fail=1 > du -xL d > u || fail=1 > sed 's/^[0-9][0-9]* //' u > out1 > echo d > exp1 || fail=1 > - > compare exp1 out1 || fail=1 > > +# With coreutils-8.15, "du -xs FILE" would print no output. > +touch f > +for opt in -x -xs; do > + du $opt f > u || fail=1 > + sed 's/^[0-9][0-9]* //' u > out2 > + echo f > exp2 || fail=1 > + compare exp2 out2 || fail=1 Maybe this is enough? du $opt f | grep . > /dev/null || fail=1 cheers, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 06:40:28 2012 Received: (at 10967) by debbugs.gnu.org; 8 Mar 2012 11:40:29 +0000 Received: from localhost ([127.0.0.1]:38737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5bhs-0006QU-1l for submit@debbugs.gnu.org; Thu, 08 Mar 2012 06:40:28 -0500 Received: from mx.meyering.net ([88.168.87.75]:46386) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5bhf-0006Pc-8Q for 10967@debbugs.gnu.org; Thu, 08 Mar 2012 06:40:17 -0500 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id F1E24600E1; Thu, 8 Mar 2012 12:39:09 +0100 (CET) From: Jim Meyering To: =?iso-8859-1?Q?P=E1draig?= Brady Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? In-Reply-To: <4F589246.7070501@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?= =?iso-8859-1?Q?g?= Brady"'s message of "Thu, 08 Mar 2012 11:04:38 +0000") References: <87d38nqzc2.fsf@rho.meyering.net> <877gyvqszl.fsf@rho.meyering.net> <4F589246.7070501@draigBrady.com> Date: Thu, 08 Mar 2012 12:39:09 +0100 Message-ID: <87k42vpbj6.fsf@rho.meyering.net> Lines: 61 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10967 Cc: 10967@debbugs.gnu.org, Daniel Stavrovski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) P=E1draig Brady wrote: > On 03/08/2012 10:36 AM, Jim Meyering wrote: ... >> Subject: [PATCH] du: --one-file-system (-x) ignores non-directory argume= nts > > I find it a bit easier to parse if the summary describes > the change rather than the bug. So something like: > > du: fix -x to include non-directory arguments Thanks for the quick feedback. I see your point, but prefer not to use "include", because that might evoke du's --exclude or --exclude-from options. How about this? du: fix -x: don't ignore non-directory arguments ... >> * src/du.c (process_file): Don't use the top-level FTS->fts_dev >> when testing for --one-file-system (-x). It happens to be valid >> for directories, but it is always 0 for a non-directory. >> * tests/du/one-file-system: Add tests for this. >> * NEWS (Bug fixes): Mention it. >> Reported by Daniel Stavrovski in http://bugs.gnu.org/10967. >> Introduced by commit v8.14-95-gcfe1040. > > While I can `git show` the above revision format, > gitk doesn't hyperlink it. Does gitweb auto link the above format? > I guess they may in future at least? I much prefer to use the version-including form, v8.14-95-gcfe1040 over the bare-SHA1 form that stock gitk currently highlights, so I patched gitk to also highlight the more human-friendly form. Not only is it more readable, but with the version-including form, there is much less need to specify a commit date, title, etc. that we have been doing. I posted the patch, and Junio (the git maintainer) liked it http://marc.info/?t=3D132352993500001&r=3D1&w=3D2 so I think we're waiting for sign-off from the gitk maintainer, whom I've just pinged privately. Here's what it looks like: http://meyering.net/code/gitk/gitk-highlight-git-describe-SHA1.jpg It would be nicer to highlight the entire string, but that would have required a more invasive patch. >> + sed 's/^[0-9][0-9]* //' u > out2 >> + echo f > exp2 || fail=3D1 >> + compare exp2 out2 || fail=3D1 > > Maybe this is enough? > > du $opt f | grep . > /dev/null || fail=3D1 Technically that is enough to detect the bug, but it would pass even if du were to print nonsense and exit nonzero. Since these are the only tests that make du operate on a non-directory, I prefer to check du's exit status and its precise output. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 06:49:15 2012 Received: (at 10967) by debbugs.gnu.org; 8 Mar 2012 11:49:15 +0000 Received: from localhost ([127.0.0.1]:38748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5bqM-0006du-LH for submit@debbugs.gnu.org; Thu, 08 Mar 2012 06:49:15 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:54228) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5bq7-0006dA-Jh for 10967@debbugs.gnu.org; Thu, 08 Mar 2012 06:49:00 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoADAA+cWE9tTB6M/2dsb2JhbAAMNrQcBIQcAQEBAwEyAUYFCwsNCgEJFg8JAwIBAgE9CAYNAQcBAYgBELc/im+FfwSbTIoRgmM Received: from unknown (HELO [192.168.1.79]) ([109.76.30.140]) by mail1.vodafone.ie with ESMTP; 08 Mar 2012 11:47:54 +0000 Message-ID: <4F589C67.4070200@draigBrady.com> Date: Thu, 08 Mar 2012 11:47:51 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? References: <87d38nqzc2.fsf@rho.meyering.net> <877gyvqszl.fsf@rho.meyering.net> <4F589246.7070501@draigBrady.com> <87k42vpbj6.fsf@rho.meyering.net> In-Reply-To: <87k42vpbj6.fsf@rho.meyering.net> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10967 Cc: 10967@debbugs.gnu.org, Daniel Stavrovski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 03/08/2012 11:39 AM, Jim Meyering wrote: > Pádraig Brady wrote: >> On 03/08/2012 10:36 AM, Jim Meyering wrote: > ... >>> Subject: [PATCH] du: --one-file-system (-x) ignores non-directory arguments >> >> I find it a bit easier to parse if the summary describes >> the change rather than the bug. So something like: >> >> du: fix -x to include non-directory arguments > > Thanks for the quick feedback. > > I see your point, but prefer not to use "include", because that > might evoke du's --exclude or --exclude-from options. > How about this? > > du: fix -x: don't ignore non-directory arguments perfect >>> Introduced by commit v8.14-95-gcfe1040. >> >> While I can `git show` the above revision format, >> gitk doesn't hyperlink it. Does gitweb auto link the above format? >> I guess they may in future at least? > > I much prefer to use the version-including form, v8.14-95-gcfe1040 > over the bare-SHA1 form that stock gitk currently highlights, so I > patched gitk to also highlight the more human-friendly form. > Not only is it more readable, but with the version-including form, > there is much less need to specify a commit date, title, etc. that > we have been doing. I agree. > I posted the patch, and Junio (the git maintainer) liked it > http://marc.info/?t=132352993500001&r=1&w=2 > so I think we're waiting for sign-off from the gitk maintainer, > whom I've just pinged privately. Hah cool. Even if you hadn't been proactive enough to do this, as long as it was technically possible I'd have been fine to go with the improved references. > Here's what it looks like: > http://meyering.net/code/gitk/gitk-highlight-git-describe-SHA1.jpg > > It would be nicer to highlight the entire string, but that would > have required a more invasive patch. > >>> + sed 's/^[0-9][0-9]* //' u > out2 >>> + echo f > exp2 || fail=1 >>> + compare exp2 out2 || fail=1 >> >> Maybe this is enough? >> >> du $opt f | grep . > /dev/null || fail=1 > > Technically that is enough to detect the bug, but it would > pass even if du were to print nonsense and exit nonzero. > Since these are the only tests that make du operate on a non-directory, > I prefer to check du's exit status and its precise output. cheers, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 23:33:09 2012 Received: (at 10967) by debbugs.gnu.org; 9 Mar 2012 04:33:09 +0000 Received: from localhost ([127.0.0.1]:39750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5rVs-00070L-Pt for submit@debbugs.gnu.org; Thu, 08 Mar 2012 23:33:09 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:57036) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5rVg-0006zl-Mm for 10967@debbugs.gnu.org; Thu, 08 Mar 2012 23:33:07 -0500 Received: by obbta4 with SMTP id ta4so1560484obb.3 for <10967@debbugs.gnu.org>; Thu, 08 Mar 2012 20:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stavrovski.net; s=stavrovski.net; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=0pEC4A+F48IcxsSUgqoRo7KWPKq6D47dS92kgJ0cJZQ=; b=ccre2pNZAn42qgeFU7p/gSiD/heW3MU8u+bKz70iheNcWcQOspBYOzbKxBUr2LT4oY uw8e2lK/MlbPMI9c5VsUV5KU1gYczJ2VY9iVwI0OT8djSMW8v0XF+ZSBidg166+hrFS7 /2cOULXZpWcS7FtkjCzaKiAFUES8Zu6zDwpJk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type:x-gm-message-state; bh=0pEC4A+F48IcxsSUgqoRo7KWPKq6D47dS92kgJ0cJZQ=; b=lcLpGKwp1Jx7XrEoewnwAB4g/aBLo4GtL4yfC1s6Q1Z2Dq+uB4CcEIdYOcIHznRq82 Vt1SL5yEEFKcHu4/COQZOaLI+bcRORvNhMw5gKxlXg9ix0GBfuxXRCeuos84qM7K7Z+r ofyDvsV9J016IWs2hHevN5AscUKX79Ox3zFQrYxkSGsQK77SYhSVdu4AdmMPmOaiVMjs FhhTwz/77+Wo6OghaZ1x5ZTW4fKGjCO3xTEmmpOOsrkhj2BLS11AhCXirpNkKqR3VJN5 pBN+kTZLuTiJOWXihUlPPXi5mfRshKY/JgV+mg3bYBztY3lKDK0gRJ7dLIOogAyHKe/E 2lhQ== MIME-Version: 1.0 Received: by 10.60.28.133 with SMTP id b5mr341114oeh.4.1331267522527; Thu, 08 Mar 2012 20:32:02 -0800 (PST) Received: by 10.60.19.169 with HTTP; Thu, 8 Mar 2012 20:32:02 -0800 (PST) X-Originating-IP: [216.114.78.160] In-Reply-To: <4F589C67.4070200@draigBrady.com> References: <87d38nqzc2.fsf@rho.meyering.net> <877gyvqszl.fsf@rho.meyering.net> <4F589246.7070501@draigBrady.com> <87k42vpbj6.fsf@rho.meyering.net> <4F589C67.4070200@draigBrady.com> Date: Thu, 8 Mar 2012 22:32:02 -0600 Message-ID: Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? From: Daniel Stavrovski To: =?ISO-8859-1?Q?P=E1draig_Brady?= Content-Type: multipart/alternative; boundary=e89a8fb1f7a6c8026004bac7df10 X-Gm-Message-State: ALoCoQmH+kY506kdpIoYse+He/IfKRk67vq9SIcSnUW0WT8G1QgZ4x7PzcanSV8U8Ssj73QQD8D7 X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 10967 Cc: 10967@debbugs.gnu.org, Jim Meyering X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.9 (/) --e89a8fb1f7a6c8026004bac7df10 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thank you gurus. Just keep up the great work. Daniel 2012/3/8 P=E1draig Brady > On 03/08/2012 11:39 AM, Jim Meyering wrote: > > P=E1draig Brady wrote: > >> On 03/08/2012 10:36 AM, Jim Meyering wrote: > > ... > >>> Subject: [PATCH] du: --one-file-system (-x) ignores non-directory > arguments > >> > >> I find it a bit easier to parse if the summary describes > >> the change rather than the bug. So something like: > >> > >> du: fix -x to include non-directory arguments > > > > Thanks for the quick feedback. > > > > I see your point, but prefer not to use "include", because that > > might evoke du's --exclude or --exclude-from options. > > How about this? > > > > du: fix -x: don't ignore non-directory arguments > > perfect > > >>> Introduced by commit v8.14-95-gcfe1040. > >> > >> While I can `git show` the above revision format, > >> gitk doesn't hyperlink it. Does gitweb auto link the above format? > >> I guess they may in future at least? > > > > I much prefer to use the version-including form, v8.14-95-gcfe1040 > > over the bare-SHA1 form that stock gitk currently highlights, so I > > patched gitk to also highlight the more human-friendly form. > > Not only is it more readable, but with the version-including form, > > there is much less need to specify a commit date, title, etc. that > > we have been doing. > > I agree. > > > I posted the patch, and Junio (the git maintainer) liked it > > http://marc.info/?t=3D132352993500001&r=3D1&w=3D2 > > so I think we're waiting for sign-off from the gitk maintainer, > > whom I've just pinged privately. > > Hah cool. > Even if you hadn't been proactive enough to do this, > as long as it was technically possible I'd have been > fine to go with the improved references. > > > Here's what it looks like: > > http://meyering.net/code/gitk/gitk-highlight-git-describe-SHA1.jpg > > > > It would be nicer to highlight the entire string, but that would > > have required a more invasive patch. > > > >>> + sed 's/^[0-9][0-9]* //' u > out2 > >>> + echo f > exp2 || fail=3D1 > >>> + compare exp2 out2 || fail=3D1 > >> > >> Maybe this is enough? > >> > >> du $opt f | grep . > /dev/null || fail=3D1 > > > > Technically that is enough to detect the bug, but it would > > pass even if du were to print nonsense and exit nonzero. > > Since these are the only tests that make du operate on a non-directory, > > I prefer to check du's exit status and its precise output. > > cheers, > P=E1draig > --=20 An Educated Fool --e89a8fb1f7a6c8026004bac7df10 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thank you gurus.

Just keep up the great work.

Daniel

<= div class=3D"gmail_quote">2012/3/8 P=E1draig Brady <P@draigbrady.com>
On 03/08/2012 11:39 AM, Jim Meyering wrote:
> P=E1draig Brady wrote:
>> On 03/08/2012 10:36 AM, Jim Meyering wrote:
> ...
>>> Subject: [PATCH] du: --one-file-system (-x) ignores non-direct= ory arguments
>>
>> I find it a bit easier to parse if the summary describes
>> the change rather than the bug. So something like:
>>
>> du: fix -x to include non-directory arguments
>
> Thanks for the quick feedback.
>
> I see your point, but prefer not to use "include", because t= hat
> might evoke du's --exclude or --exclude-from options.
> How about this?
>
> =A0 du: fix -x: don't ignore non-directory arguments

perfect

>>> Introduced by commit v8.14-95-gcfe1040.
>>
>> While I can `git show` the above revision format,
>> gitk doesn't hyperlink it. Does gitweb auto link the above for= mat?
>> I guess they may in future at least?
>
> I much prefer to use the version-including form, v8.14-95-gcfe1040
> over the bare-SHA1 form that stock gitk currently highlights, so I
> patched gitk to also highlight the more human-friendly form.
> Not only is it more readable, but with the version-including form,
> there is much less need to specify a commit date, title, etc. that
> we have been doing.

I agree.

> I posted the patch, and Junio (the git maintainer) liked it
> =A0 http://marc.info/?t=3D132352993500001&r=3D1&= ;w=3D2
> so I think we're waiting for sign-off from the gitk maintainer, > whom I've just pinged privately.

Hah cool.
Even if you hadn't been proactive enough to do this,
as long as it was technically possible I'd have been
fine to go with the improved references.

> Here's what it looks like:
> =A0 http://meyering.net/code/gitk/gitk-highlight= -git-describe-SHA1.jpg
>
> It would be nicer to highlight the entire string, but that would
> have required a more invasive patch.
>
>>> + =A0sed 's/^[0-9][0-9]* =A0 =A0 =A0//' u > out2 >>> + =A0echo f > exp2 || fail=3D1
>>> + =A0compare exp2 out2 || fail=3D1
>>
>> Maybe this is enough?
>>
>> du $opt f | grep . > /dev/null || fail=3D1
>
> Technically that is enough to detect the bug, but it would
> pass even if du were to print nonsense and exit nonzero.
> Since these are the only tests that make du operate on a non-directory= ,
> I prefer to check du's exit status and its precise output.

cheers,
P=E1draig



--
An Educated Fool

--e89a8fb1f7a6c8026004bac7df10-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 09 02:22:33 2012 Received: (at 10967-done) by debbugs.gnu.org; 9 Mar 2012 07:22:33 +0000 Received: from localhost ([127.0.0.1]:39855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5u9p-0002Sc-2N for submit@debbugs.gnu.org; Fri, 09 Mar 2012 02:22:33 -0500 Received: from mx.meyering.net ([88.168.87.75]:49445) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5u9m-0002SU-Tj for 10967-done@debbugs.gnu.org; Fri, 09 Mar 2012 02:22:32 -0500 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 78CA8600E3 for <10967-done@debbugs.gnu.org>; Fri, 9 Mar 2012 08:21:35 +0100 (CET) From: Jim Meyering To: 10967-done@debbugs.gnu.org Subject: Re: bug#10967: Weird 'du' behavior. Bug in coreutils-8.15 ? In-Reply-To: <4F589C67.4070200@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?= =?iso-8859-1?Q?g?= Brady"'s message of "Thu, 08 Mar 2012 11:47:51 +0000") References: <87d38nqzc2.fsf@rho.meyering.net> <877gyvqszl.fsf@rho.meyering.net> <4F589246.7070501@draigBrady.com> <87k42vpbj6.fsf@rho.meyering.net> <4F589C67.4070200@draigBrady.com> Date: Fri, 09 Mar 2012 08:21:35 +0100 Message-ID: <8762eeme80.fsf@rho.meyering.net> Lines: 23 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10967-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) P=E1draig Brady wrote: > On 03/08/2012 11:39 AM, Jim Meyering wrote: >> P=E1draig Brady wrote: >>> On 03/08/2012 10:36 AM, Jim Meyering wrote: >> ... >>>> Subject: [PATCH] du: --one-file-system (-x) ignores non-directory argu= ments >>> >>> I find it a bit easier to parse if the summary describes >>> the change rather than the bug. So something like: >>> >>> du: fix -x to include non-directory arguments >> >> Thanks for the quick feedback. >> >> I see your point, but prefer not to use "include", because that >> might evoke du's --exclude or --exclude-from options. >> How about this? >> >> du: fix -x: don't ignore non-directory arguments > > perfect With that, I pushed yesterday and am closing the ticket now. From unknown Mon Aug 18 14:22:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 Apr 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator