GNU bug report logs - #10953
Potential logical bug in readtokens.c

Previous Next

Full log

Message #23 received at 10953-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Xu Zhongxing <xu_zhong_xing <at> 163.com>, 10953-done <at> debbugs.gnu.org
Subject: Re: bug#10953: Potential logical bug in readtokens.c
Date: Wed, 07 Mar 2012 21:07:31 +0100

Paul Eggert wrote:
> On 03/07/2012 11:52 AM, Jim Meyering wrote:
>> Here's a proposed readtokens test module:
>
> I took a quick look, and it looks fine, thanks.

Thanks for the quick review.

While I'd tested like this,
  ./gnulib-tool --create-testdir --with-tests --test readtokens
I nearly forgot to compile with warnings enabled,
so nearly missed an unused variable and the lack of <unistd.h>
for declarations of write and close.

Just pushed.

> The bug's fixed now, so I'm marking it as 'done'.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.