From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 04 07:17:02 2012 Received: (at submit) by debbugs.gnu.org; 4 Mar 2012 12:17:02 +0000 Received: from localhost ([127.0.0.1]:60671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4AMy-0004uX-DD for submit@debbugs.gnu.org; Sun, 04 Mar 2012 07:17:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38106) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4AMg-0004tl-DI for submit@debbugs.gnu.org; Sun, 04 Mar 2012 07:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4ALy-0003Q8-Tr for submit@debbugs.gnu.org; Sun, 04 Mar 2012 07:15:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:34582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4ALy-0003Q4-O1 for submit@debbugs.gnu.org; Sun, 04 Mar 2012 07:15:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4ALx-0008K9-1U for bug-guile@gnu.org; Sun, 04 Mar 2012 07:15:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4ALv-0003PO-4i for bug-guile@gnu.org; Sun, 04 Mar 2012 07:15:52 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:47488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4ALu-0003PD-S6 for bug-guile@gnu.org; Sun, 04 Mar 2012 07:15:51 -0500 Received: by eeke53 with SMTP id e53so1191458eek.0 for ; Sun, 04 Mar 2012 04:15:48 -0800 (PST) Received-SPF: pass (google.com: domain of stefan.itampe@gmail.com designates 10.213.4.13 as permitted sender) client-ip=10.213.4.13; Authentication-Results: mr.google.com; spf=pass (google.com: domain of stefan.itampe@gmail.com designates 10.213.4.13 as permitted sender) smtp.mail=stefan.itampe@gmail.com; dkim=pass header.i=stefan.itampe@gmail.com Received: from mr.google.com ([10.213.4.13]) by 10.213.4.13 with SMTP id 13mr2562251ebp.15.1330863348237 (num_hops = 1); Sun, 04 Mar 2012 04:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=3KyAG3ozXAWOjOo8iUDhmJAo3UoZfFfKbdGIbNpSeYs=; b=QQoTS2KdMcZRu1pMG0BM4uxsK8GwLuO7Nm5+laxxEQfGqhIsKqRk3e/sHl+SrA2bvn VNPCY7x5HBI9gTXxHDSnPMCkAQyn3fl64vbNR4V6Rpkr5bsyT3glHQzLw2nn7FGmZVCY IW+d/pyohReQ8BNOu+u8uDtR89cHk8W5GJT43xOz9NlRwkAPla7IslCE2m0ViRV9yiiU Jg1HOH2JVQJb6fFnPU+gYT91bnj/Po9f78PnfVGwR9p+N/UMuowqpVzAGqEMZLfBkakV QQ5ONjM5ABGgtV+LFUIYvTivMiz428gAu29E3ui8gV31/+q2NFUIV2l/BAgLCEmCSgOB lT/A== MIME-Version: 1.0 Received: by 10.213.4.13 with SMTP id 13mr1945151ebp.15.1330863347956; Sun, 04 Mar 2012 04:15:47 -0800 (PST) Received: by 10.213.13.206 with HTTP; Sun, 4 Mar 2012 04:15:47 -0800 (PST) Date: Sun, 4 Mar 2012 13:15:47 +0100 Message-ID: Subject: procedure-arguments return differnet output when procedure-property is used From: Stefan Israelsson Tampe To: bug-guile@gnu.org Content-Type: multipart/alternative; boundary=001517478aa2197b9f04ba69c5d3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --001517478aa2197b9f04ba69c5d3 Content-Type: text/plain; charset=ISO-8859-1 Typeically in guile > (procedure-arguments g) $3 = ((required x) (optional) (keyword) (allow-other-keys? . #f) (rest . #f)) for a program g. But if we attach a procedure property 'arglist the outpu is acording to (system ice-9 session), (define (procedure-arguments proc) "Return an alist describing the arguments that `proc' accepts, or `#f' if the information cannot be obtained. The alist keys that are currently defined are `required', `optional', `keyword', and `rest'." (cond ((procedure-property proc 'arglist) => (lambda (arglist) `((required . ,(car arglist)) (optional . ,(cadr arglist)) (keyword . ,(caddr arglist)) (allow-other-keys? . ,(cadddr arglist)) (rest . ,(car (cddddr arglist)))))) ((procedure-source proc) => cadr) (((@ (system vm program) program?) proc) ((@ (system vm program) program-arguments-alist) proc)) (else #f))) Acording to the description allow-other-keys? is not included, but returned for a program but not of prop 'arglist is used, so either 1. drop allow-other-keys? from the program? version or add it to the proper version and change doc string Regards Stefan --001517478aa2197b9f04ba69c5d3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Typeically in guile

> (procedure-arguments g)
$3 =3D ((require= d x) (optional) (keyword) (allow-other-keys? . #f) (rest . #f))

for = a program g. But if we attach a procedure property 'arglist the outpu i= s acording to (system ice-9 session),
(define (procedure-arguments proc)
=A0 "Return an alist describing = the arguments that `proc' accepts, or `#f'
if the information ca= nnot be obtained.

The alist keys that are currently defined are `req= uired', `optional',
`keyword', and `rest'."
=A0 (cond
=A0=A0 ((procedure-pro= perty proc 'arglist)
=A0=A0=A0 =3D> (lambda (arglist)
=A0=A0= =A0=A0=A0=A0=A0=A0 `((required . ,(car arglist))
=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 (optional . ,(cadr arglist))
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (k= eyword . ,(caddr arglist))
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (allow-other-keys? . ,(cadddr arglist))
= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (rest . ,(car (cddddr arglist))))))
=A0= =A0 ((procedure-source proc)
=A0=A0=A0 =3D> cadr)
=A0=A0 (((@ (sys= tem vm program) program?) proc)
=A0=A0=A0 ((@ (system vm program) progra= m-arguments-alist) proc))
=A0=A0 (else #f)))

Acording to the description allow-other-keys? is = not included, but returned for a program
but not of prop 'arglist is= used, so either

1. drop allow-other-keys? from the program? version= or add it to the proper version and change doc string

Regards
Stefan
--001517478aa2197b9f04ba69c5d3-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 04 07:25:05 2012 Received: (at 10938) by debbugs.gnu.org; 4 Mar 2012 12:25:05 +0000 Received: from localhost ([127.0.0.1]:60678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4AUk-000567-PB for submit@debbugs.gnu.org; Sun, 04 Mar 2012 07:25:04 -0500 Received: from mail-ee0-f44.google.com ([74.125.83.44]:57160) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4AUS-00055d-9r for 10938@debbugs.gnu.org; Sun, 04 Mar 2012 07:24:46 -0500 Received: by eeke51 with SMTP id e51so1710336eek.3 for <10938@debbugs.gnu.org>; Sun, 04 Mar 2012 04:23:58 -0800 (PST) Received-SPF: pass (google.com: domain of stefan.itampe@gmail.com designates 10.213.21.142 as permitted sender) client-ip=10.213.21.142; Authentication-Results: mr.google.com; spf=pass (google.com: domain of stefan.itampe@gmail.com designates 10.213.21.142 as permitted sender) smtp.mail=stefan.itampe@gmail.com; dkim=pass header.i=stefan.itampe@gmail.com Received: from mr.google.com ([10.213.21.142]) by 10.213.21.142 with SMTP id j14mr2546500ebb.53.1330863838123 (num_hops = 1); Sun, 04 Mar 2012 04:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=uEjtUlUwFE1OVbyQzepzjNLoXcXdOPKZzgjmWcKsYrc=; b=xDmLT0qCMl+vpNJKkjsverwQMyX2WX6p9RT0vaA7g3AXFxxjQemE583LX3Ed4oRcvl aTxCx05OzqgqdpIj+YBmiDtx+/pShChjirReQ8p5QL6okIqrvkY9ocjWWWE1swiPWu4k Q17OlPrQyUEBmIiPKgV9zi2bf5HCI8qSjhGTH0ZXZrSBtnXbNm5vo/Y0H5Q3QySACA65 ssxOTTc4VIJzZSco3KSoj5Ah19zdPrV+UaOjFO6EIqGmQVZfOKn+zoghuWCnbt3rf5cC rajhfsjkgDFrwei4FOqPuUAilHvjKHWeQtY61nXIYDXbPwQQbjIxeWD47m4fxdKUxSkg AwSg== MIME-Version: 1.0 Received: by 10.213.21.142 with SMTP id j14mr1937438ebb.53.1330863838059; Sun, 04 Mar 2012 04:23:58 -0800 (PST) Received: by 10.213.13.206 with HTTP; Sun, 4 Mar 2012 04:23:58 -0800 (PST) Date: Sun, 4 Mar 2012 13:23:58 +0100 Message-ID: Subject: patch From: Stefan Israelsson Tampe To: 10938@debbugs.gnu.org Content-Type: multipart/mixed; boundary=0015174c0ba44fdcd304ba69e2e0 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10938 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --0015174c0ba44fdcd304ba69e2e0 Content-Type: multipart/alternative; boundary=0015174c0ba44fdcc204ba69e2de --0015174c0ba44fdcc204ba69e2de Content-Type: text/plain; charset=ISO-8859-1 Sorry I posted a version of session.scm with a prtly fix included anyway here is a patch where we add allow-other-keys? --0015174c0ba44fdcc204ba69e2de Content-Type: text/html; charset=ISO-8859-1 Sorry I posted a version of session.scm with a prtly fix included
anyway here is a patch where we add allow-other-keys?

--0015174c0ba44fdcc204ba69e2de-- --0015174c0ba44fdcd304ba69e2e0 Content-Type: text/x-patch; charset=US-ASCII; name="session.diff" Content-Disposition: attachment; filename="session.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gze22itc0 ZGlmZiAtLWdpdCBhL21vZHVsZS9pY2UtOS9zZXNzaW9uLnNjbSBiL21vZHVsZS9pY2UtOS9zZXNz aW9uLnNjbQppbmRleCBmYmIwM2QyLi5kYzJjOTI3IDEwMDY0NAotLS0gYS9tb2R1bGUvaWNlLTkv c2Vzc2lvbi5zY20KKysrIGIvbW9kdWxlL2ljZS05L3Nlc3Npb24uc2NtCkBAIC01MDQsMTMgKzUw NCwxNCBAQCBJdCBpcyBhbiBpbWFnZSB1bmRlciB0aGUgbWFwcGluZyBFWFRSQUNULiIKIGlmIHRo ZSBpbmZvcm1hdGlvbiBjYW5ub3QgYmUgb2J0YWluZWQuCiAKIFRoZSBhbGlzdCBrZXlzIHRoYXQg YXJlIGN1cnJlbnRseSBkZWZpbmVkIGFyZSBgcmVxdWlyZWQnLCBgb3B0aW9uYWwnLAotYGtleXdv cmQnLCBhbmQgYHJlc3QnLiIKK2BrZXl3b3JkJywgYWxsb3ctb3RoZXIta2V5cz8gYW5kIGByZXN0 Jy4iCiAgIChjb25kCiAgICAoKHByb2NlZHVyZS1wcm9wZXJ0eSBwcm9jICdhcmdsaXN0KQogICAg ID0+IChsYW1iZGEgKGFyZ2xpc3QpCiAgICAgICAgICBgKChyZXF1aXJlZCAuICwoY2FyIGFyZ2xp c3QpKQogICAgICAgICAgICAob3B0aW9uYWwgLiAsKGNhZHIgYXJnbGlzdCkpCiAgICAgICAgICAg IChrZXl3b3JkIC4gLChjYWRkciBhcmdsaXN0KSkKKyAgICAgICAgICAgKGFsbG93LW90aGVyLWtl eXM/IC4gLChjYWRkZHIgYXJnbGlzdCkpCiAgICAgICAgICAgIChyZXN0IC4gLChjYXIgKGNkZGRk ciBhcmdsaXN0KSkpKSkpCiAgICAoKHByb2NlZHVyZS1zb3VyY2UgcHJvYykKICAgICA9PiBjYWRy KQo= --0015174c0ba44fdcd304ba69e2e0-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 05 12:00:36 2012 Received: (at 10938) by debbugs.gnu.org; 5 Mar 2012 17:00:36 +0000 Received: from localhost ([127.0.0.1]:34382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4bH1-000664-Ji for submit@debbugs.gnu.org; Mon, 05 Mar 2012 12:00:36 -0500 Received: from xanadu.aquilenet.fr ([88.191.123.111]:41163) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4bGp-00065i-VZ for 10938@debbugs.gnu.org; Mon, 05 Mar 2012 12:00:24 -0500 Received: from localhost (xanadu.aquilenet.fr [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 392C07240; Mon, 5 Mar 2012 17:59:34 +0100 (CET) Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xzmjsWVbWkfB; Mon, 5 Mar 2012 17:59:34 +0100 (CET) Received: from pluto (unknown [193.50.110.167]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id DF102723F; Mon, 5 Mar 2012 17:59:33 +0100 (CET) From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) To: Stefan Israelsson Tampe Subject: Re: bug#10938: patch References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 =?iso-8859-1?Q?Vent=F4se?= an 220 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu Date: Mon, 05 Mar 2012 17:59:33 +0100 In-Reply-To: (Stefan Israelsson Tampe's message of "Sun, 4 Mar 2012 13:23:58 +0100") Message-ID: <87y5rfhtl6.fsf@gnu.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10938 Cc: 10938@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) Hi Stefan, Stefan Israelsson Tampe skribis: > diff --git a/module/ice-9/session.scm b/module/ice-9/session.scm > index fbb03d2..dc2c927 100644 > --- a/module/ice-9/session.scm > +++ b/module/ice-9/session.scm > @@ -504,13 +504,14 @@ It is an image under the mapping EXTRACT." > if the information cannot be obtained. >=20=20 > The alist keys that are currently defined are `required', `optional', > -`keyword', and `rest'." > +`keyword', allow-other-keys? and `rest'." > (cond > ((procedure-property proc 'arglist) > =3D> (lambda (arglist) > `((required . ,(car arglist)) > (optional . ,(cadr arglist)) > (keyword . ,(caddr arglist)) > + (allow-other-keys? . ,(cadddr arglist)) > (rest . ,(car (cddddr arglist)))))) > ((procedure-source proc) > =3D> cadr) Can you provide one or more test cases that illustrate that this patch fixes? Also, please send your patch in =E2=80=98git format-patch=E2=80=99 format. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 10 11:10:35 2012 Received: (at 10938) by debbugs.gnu.org; 10 Mar 2012 16:10:35 +0000 Received: from localhost ([127.0.0.1]:43335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6OsM-0005RI-74 for submit@debbugs.gnu.org; Sat, 10 Mar 2012 11:10:34 -0500 Received: from mail-ey0-f172.google.com ([209.85.215.172]:40822) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6OsI-0005R5-Lv for 10938@debbugs.gnu.org; Sat, 10 Mar 2012 11:10:32 -0500 Received: by eaaq11 with SMTP id q11so877198eaa.3 for <10938@debbugs.gnu.org>; Sat, 10 Mar 2012 07:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=CWaaKqx2ByLzDJOlHzQixcio/n+ObscydkwjJsQVC68=; b=zMvKrs/r8i3t/4lxEOUm1XzraocFgGRdOh1KKRpE/R5zyuzAixSRviTm4SdFdKbHa0 Flpf0p/fh677SfY/PoH+yH4CNrdKKgJc3eQd16lqJkz5z9M3M+3arfvMyIaQuAI//C6k vG13r/jm/Mej7YGOec+gK0KN/e4s+vvyo6UP+3wSxBiAvkpcvdJmg39LIwLvi6/wqX3/ 0yrSYAHLlq54aVTdMDFJJakk8cO2DfiRUnZADI+qODzejofE3CDhN1iPMhViRj3kx2CQ fCyg/uPBtByMqUHhv8Tg3v13QzoSWI1DIoBuy27v3JmTVbXU7Zn4VOwheBKympZBDUfR FmTQ== MIME-Version: 1.0 Received: by 10.14.32.139 with SMTP id o11mr1088507eea.10.1331394050039; Sat, 10 Mar 2012 07:40:50 -0800 (PST) Received: by 10.213.13.206 with HTTP; Sat, 10 Mar 2012 07:40:49 -0800 (PST) In-Reply-To: <87y5rfhtl6.fsf@gnu.org> References: <87y5rfhtl6.fsf@gnu.org> Date: Sat, 10 Mar 2012 16:40:49 +0100 Message-ID: Subject: Re: bug#10938: patch From: Stefan Israelsson Tampe To: =?ISO-8859-1?Q?Ludovic_Court=E8s?= Content-Type: multipart/mixed; boundary=00235451e82868a0c104bae555ab X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10938 Cc: 10938@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) --00235451e82868a0c104bae555ab Content-Type: multipart/alternative; boundary=00235451e82868a0b704bae555a9 --00235451e82868a0b704bae555a9 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Following this email is the requested patch format Test case. With the patch: (define (f x) x) (define arg1 (procedure-arguments f)) (set-procedure-property! f 'arglist (map cdr arg1)) (define arg2 (procedure-arguments f)) (equal? arg1 arg2) $4 =3D #t Without the patch a field is missing and the result would be #f /Stefan 2012/3/5 Ludovic Court=E8s > Hi Stefan, > > Stefan Israelsson Tampe skribis: > > > diff --git a/module/ice-9/session.scm b/module/ice-9/session.scm > > index fbb03d2..dc2c927 100644 > > --- a/module/ice-9/session.scm > > +++ b/module/ice-9/session.scm > > @@ -504,13 +504,14 @@ It is an image under the mapping EXTRACT." > > if the information cannot be obtained. > > > > The alist keys that are currently defined are `required', `optional', > > -`keyword', and `rest'." > > +`keyword', allow-other-keys? and `rest'." > > (cond > > ((procedure-property proc 'arglist) > > =3D> (lambda (arglist) > > `((required . ,(car arglist)) > > (optional . ,(cadr arglist)) > > (keyword . ,(caddr arglist)) > > + (allow-other-keys? . ,(cadddr arglist)) > > (rest . ,(car (cddddr arglist)))))) > > ((procedure-source proc) > > =3D> cadr) > > Can you provide one or more test cases that illustrate that this patch > fixes? > > Also, please send your patch in =91git format-patch=92 format. > > Thanks, > Ludo=92. > --00235451e82868a0b704bae555a9 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Following this email is the requested patch format

Test case.
Wit= h the patch:

(define (f x) x)
(define arg1 (procedure-arguments f= ))
(set-procedure-property! f 'arglist (map cdr arg1))
(define ar= g2 (procedure-arguments f))
(equal? arg1 arg2)
$4 =3D #t

Without the patch a field is missing= and the result would be #f

/Stefan


2012/3/5 Ludovic Court=E8s <ludo@gnu.org>
Hi Stefan,

Stefan Israelsson Tampe <stef= an.itampe@gmail.com> skribis:

> diff --git a/module/ice-9/session.scm b/module/ice-9/session.scm
> index fbb03d2..dc2c927 100644
> --- a/module/ice-9/session.scm
> +++ b/module/ice-9/session.scm
> @@ -504,13 +504,14 @@ It is an image under the mapping EXTRACT."<= br> > =A0if the information cannot be obtained.
>
> =A0The alist keys that are currently defined are `required', `opti= onal',
> -`keyword', and `rest'."
> +`keyword', allow-other-keys? and `rest'."
> =A0 =A0(cond
> =A0 =A0 ((procedure-property proc 'arglist)
> =A0 =A0 =A0=3D> (lambda (arglist)
> =A0 =A0 =A0 =A0 =A0 `((required . ,(car arglist))
> =A0 =A0 =A0 =A0 =A0 =A0 (optional . ,(cadr arglist))
> =A0 =A0 =A0 =A0 =A0 =A0 (keyword . ,(caddr arglist))
> + =A0 =A0 =A0 =A0 =A0 (allow-other-keys? . ,(cadddr arglist))
> =A0 =A0 =A0 =A0 =A0 =A0 (rest . ,(car (cddddr arglist))))))
> =A0 =A0 ((procedure-source proc)
> =A0 =A0 =A0=3D> cadr)

Can you provide one or more test cases that illustrate that this patch
fixes?

Also, please send your patch in =91git format-patch=92 format.

Thanks,
Ludo=92.

--00235451e82868a0b704bae555a9-- --00235451e82868a0c104bae555ab Content-Type: text/x-patch; charset=US-ASCII; name="session.patch" Content-Disposition: attachment; filename="session.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gzmtr2x90 RnJvbSA3NzkyODk4MjhlNmU4MzQwZTRkMWZiNTA5N2U5Yjk3ODE1ODhiNGMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gSXNyYWVsc3NvbiBUYW1wZSA8c3RlZmFuLml0YW1w ZUBnbWFpbC5jb20+CkRhdGU6IFNhdCwgMTAgTWFyIDIwMTIgMTY6MzE6NDYgKzAxMDAKU3ViamVj dDogW1BBVENIXSAqIG1vZHVsZS9pY2UtOS9zZXNzaW9uLnNjbSAocHJvY2VkdXJlLWFyZ3VtZW50 cyk6IG1pc3NpbmcKIGZpZWxkIGFsbG93LW90aGVyLWtleXM/IGFkZGVkCgotLS0KIG1vZHVsZS9p Y2UtOS9zZXNzaW9uLnNjbSB8ICAgMTEgKysrKysrLS0tLS0KIDEgZmlsZXMgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL21vZHVsZS9pY2UtOS9z ZXNzaW9uLnNjbSBiL21vZHVsZS9pY2UtOS9zZXNzaW9uLnNjbQppbmRleCBmYmIwM2QyLi4zZTVh ZDNmIDEwMDY0NAotLS0gYS9tb2R1bGUvaWNlLTkvc2Vzc2lvbi5zY20KKysrIGIvbW9kdWxlL2lj ZS05L3Nlc3Npb24uc2NtCkBAIC01MDQsMTQgKzUwNCwxNSBAQCBJdCBpcyBhbiBpbWFnZSB1bmRl ciB0aGUgbWFwcGluZyBFWFRSQUNULiIKIGlmIHRoZSBpbmZvcm1hdGlvbiBjYW5ub3QgYmUgb2J0 YWluZWQuCiAKIFRoZSBhbGlzdCBrZXlzIHRoYXQgYXJlIGN1cnJlbnRseSBkZWZpbmVkIGFyZSBg cmVxdWlyZWQnLCBgb3B0aW9uYWwnLAotYGtleXdvcmQnLCBhbmQgYHJlc3QnLiIKK2BrZXl3b3Jk JyxhbGxvdy1vdGhlci1rZXlzPyAgYW5kIGByZXN0Jy4iCiAgIChjb25kCiAgICAoKHByb2NlZHVy ZS1wcm9wZXJ0eSBwcm9jICdhcmdsaXN0KQogICAgID0+IChsYW1iZGEgKGFyZ2xpc3QpCi0gICAg ICAgICBgKChyZXF1aXJlZCAuICwoY2FyIGFyZ2xpc3QpKQotICAgICAgICAgICAob3B0aW9uYWwg LiAsKGNhZHIgYXJnbGlzdCkpCi0gICAgICAgICAgIChrZXl3b3JkIC4gLChjYWRkciBhcmdsaXN0 KSkKLSAgICAgICAgICAgKHJlc3QgLiAsKGNhciAoY2RkZGRyIGFyZ2xpc3QpKSkpKSkKKyAgICAg ICAgIGAoKHJlcXVpcmVkICAgICAgICAgIC4gLChjYXIgYXJnbGlzdCkpCisgICAgICAgICAgIChv cHRpb25hbCAgICAgICAgICAuICwoY2FkciBhcmdsaXN0KSkKKyAgICAgICAgICAgKGtleXdvcmQg ICAgICAgICAgIC4gLChjYWRkciBhcmdsaXN0KSkKKyAgICAgICAgICAgKGFsbG93LW90aGVyLWtl eXM/IC4gLChjYWRkZHIgYXJnbGlzdCkpCisgICAgICAgICAgIChyZXN0ICAgICAgICAgICAgICAu ICwoY2FyIChjZGRkZHIgYXJnbGlzdCkpKSkpKQogICAgKChwcm9jZWR1cmUtc291cmNlIHByb2Mp CiAgICAgPT4gY2FkcikKICAgICgoKEAgKHN5c3RlbSB2bSBwcm9ncmFtKSBwcm9ncmFtPykgcHJv YykKLS0gCjEuNy45Cgo= --00235451e82868a0c104bae555ab-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 02 09:16:10 2012 Received: (at 10938-done) by debbugs.gnu.org; 2 Jul 2012 13:16:10 +0000 Received: from localhost ([127.0.0.1]:41607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SlgU6-0002Lp-AM for submit@debbugs.gnu.org; Mon, 02 Jul 2012 09:16:10 -0400 Received: from xanadu.aquilenet.fr ([88.191.123.111]:36764) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SlgU4-0002Lh-8F for 10938-done@debbugs.gnu.org; Mon, 02 Jul 2012 09:16:09 -0400 Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 1BCA715C9; Mon, 2 Jul 2012 15:11:32 +0200 (CEST) Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WgRmIzR3rVXW; Mon, 2 Jul 2012 15:11:32 +0200 (CEST) Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id AF0CFCF2; Mon, 2 Jul 2012 15:11:31 +0200 (CEST) From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) To: Stefan Israelsson Tampe Subject: Re: bug#10938: patch References: <87y5rfhtl6.fsf@gnu.org> Date: Mon, 02 Jul 2012 15:11:30 +0200 In-Reply-To: (Stefan Israelsson Tampe's message of "Sat, 10 Mar 2012 16:40:49 +0100") Message-ID: <87r4suux31.fsf@gnu.org> User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10938-done Cc: 10938-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) Hi Stefan, Thanks, fixed differently in a8215aedad433a15abf87c2310a41c684dfcef97. In the future, could you please provide a patch with a log and test case similar to what=E2=80=99s in the above commit? Ludo=E2=80=99. From unknown Thu Sep 11 06:07:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 31 Jul 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator