From unknown Thu Sep 11 11:24:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10937 <10937@debbugs.gnu.org> To: bug#10937 <10937@debbugs.gnu.org> Subject: Status: 24.0.94; fix savehist-printable Reply-To: bug#10937 <10937@debbugs.gnu.org> Date: Thu, 11 Sep 2025 18:24:18 +0000 retitle 10937 24.0.94; fix savehist-printable reassign 10937 emacs submitter 10937 Leo severity 10937 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 04 04:17:14 2012 Received: (at submit) by debbugs.gnu.org; 4 Mar 2012 09:17:14 +0000 Received: from localhost ([127.0.0.1]:60588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S47Yz-0007ar-6y for submit@debbugs.gnu.org; Sun, 04 Mar 2012 04:17:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40210) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S47YZ-0007aC-Cq for submit@debbugs.gnu.org; Sun, 04 Mar 2012 04:16:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S47Xs-00076p-PB for submit@debbugs.gnu.org; Sun, 04 Mar 2012 04:16:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S47Xs-00076i-JM for submit@debbugs.gnu.org; Sun, 04 Mar 2012 04:16:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S47Xq-0007Kc-Qj for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2012 04:15:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S47Xo-00076O-Va for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2012 04:15:58 -0500 Received: from mail-iy0-f169.google.com ([209.85.210.169]:35086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S47Xo-000769-O2 for bug-gnu-emacs@gnu.org; Sun, 04 Mar 2012 04:15:56 -0500 Received: by iajr24 with SMTP id r24so5125992iaj.0 for ; Sun, 04 Mar 2012 01:15:55 -0800 (PST) Received-SPF: pass (google.com: domain of sdl.web@gmail.com designates 10.42.152.134 as permitted sender) client-ip=10.42.152.134; Authentication-Results: mr.google.com; spf=pass (google.com: domain of sdl.web@gmail.com designates 10.42.152.134 as permitted sender) smtp.mail=sdl.web@gmail.com; dkim=pass header.i=sdl.web@gmail.com Received: from mr.google.com ([10.42.152.134]) by 10.42.152.134 with SMTP id i6mr10711739icw.27.1330852555026 (num_hops = 1); Sun, 04 Mar 2012 01:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=yEA1EKKoFZXoApDuuF37kuZ4hbB9fCv4uMhaPK6Z6O8=; b=XEZRYu80o6thiHePYPQfRRsy7pN0CSp54qclYSgGzEPi3vsciGgFF3EwaW1luvONv6 uaZq7JfufbMRz5Hzik4dwIbmFsFwJ7cH/0BKm6kMkq0rqhLO0PYfztFyO0eCbTr4R2H7 J2GTZuOd99xu10J+SZ5I/jOXUNwkxytEkLQ+qi6Q9ywhmPAVleWFg1eGJ6SeDlXYb06j CKE1FmWcP0wFiQ6vTMXOIk3Du6y/rrAkBJ1DiDmLyEfhse2RbHULTBt2WoCgiEamJOo/ WWIWVTy3DaL4E7MbNSWRp6VhMVVwCiHq5/ulbHh/y7fDbx2l+qlgQIOGaUfGhyFvpv8C Ftaw== Received: by 10.42.152.134 with SMTP id i6mr8821478icw.27.1330852554967; Sun, 04 Mar 2012 01:15:54 -0800 (PST) Received: from localhost ([123.114.53.68]) by mx.google.com with ESMTPS id ba4sm7712160igb.14.2012.03.04.01.15.50 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 04 Mar 2012 01:15:54 -0800 (PST) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.0.94; fix savehist-printable Date: Sun, 04 Mar 2012 17:15:44 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) In savehist-printable, strings are not necessary printable. They can contain anything in their properties. Because of this I have kill-ring emptied for almost every restart of emacs. I propose: diff --git a/lisp/savehist.el b/lisp/savehist.el index c1515fa4..a3ba9f1a 100644 --- a/lisp/savehist.el +++ b/lisp/savehist.el @@ -369,7 +369,7 @@ (defun savehist-printable (value) "Return non-nil if VALUE is printable." (cond ;; Quick response for oft-encountered types known to be printable. - ((stringp value)) + ((equal-including-properties value (substring-no-properties value))) ((numberp value)) ((symbolp value)) (t or just remove (stringp value) and let the default handle it. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 09 13:13:35 2012 Received: (at 10937-done) by debbugs.gnu.org; 9 Mar 2012 18:13:35 +0000 Received: from localhost ([127.0.0.1]:40866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S64Jq-0002c9-VZ for submit@debbugs.gnu.org; Fri, 09 Mar 2012 13:13:35 -0500 Received: from mail-iy0-f172.google.com ([209.85.210.172]:46663) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S64Jo-0002c2-TJ for 10937-done@debbugs.gnu.org; Fri, 09 Mar 2012 13:13:34 -0500 Received: by iazz13 with SMTP id z13so2292098iaz.3 for <10937-done@debbugs.gnu.org>; Fri, 09 Mar 2012 10:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=z5xFThOXEet0Gi8QWc3NKg+rkrT7SBU0hF3DV2XcWcY=; b=BgXsVzWx+zo3822xB+L/YEfH00VYfb0VXlnL/UcFfdw0sWA3yf2ny7X3+Z2B3Z+h9g mjE69rMa4NjF9uh1bV5txKks6FGuI8+ajtfO+Oc+Du3qRKDAv3VuTy3kGKe14D/IqK+O nTZJU1p0l+p7XhTQzlFWge3s9jSQOF+ZXKepeE6ssMmgR984GLL3GH4fPOGnXgmGrW9D auB1SqrZsqthPdkD0webPiPljSY0BXLSES72glOHfq/09ZiuicRlSW6f6i5qL9gMG/vw mW/mygAJRPyzHOt0Yla0xCalHW6TCi11IPpUdRT5xXE3AwxwXcDiO0dKaZlkThx2dqek derw== Received: by 10.50.46.194 with SMTP id x2mr4541785igm.60.1331316755608; Fri, 09 Mar 2012 10:12:35 -0800 (PST) Received: from localhost ([222.130.132.83]) by mx.google.com with ESMTPS id cu4sm2491815igc.15.2012.03.09.10.12.31 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 09 Mar 2012 10:12:34 -0800 (PST) From: Leo To: 10937-done@debbugs.gnu.org Subject: Re: bug#10937: 24.0.94; fix savehist-printable References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Sat, 10 Mar 2012 02:12:26 +0800 In-Reply-To: (Leo's message of "Sun, 04 Mar 2012 17:15:44 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (Mac OS X 10.6.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10937-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixed in 24.0.95. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 21 14:26:42 2012 Received: (at 10937) by debbugs.gnu.org; 21 Mar 2012 18:26:42 +0000 Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAQF7-0006O8-PF for submit@debbugs.gnu.org; Wed, 21 Mar 2012 14:26:42 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:61204) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAQF6-0006O1-1U for 10937@debbugs.gnu.org; Wed, 21 Mar 2012 14:26:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9FxKFU/2dsb2JhbACBX5x7eYhwnhmGGQSbGYQJ X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="169219201" Received: from 69-196-161-84.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.84]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Mar 2012 13:55:57 -0400 Received: by pastel.home (Postfix, from userid 20848) id AD2AF58C3D; Wed, 21 Mar 2012 13:55:56 -0400 (EDT) From: Stefan Monnier To: Leo Subject: Re: bug#10937: 24.0.94; fix savehist-printable Message-ID: References: Date: Wed, 21 Mar 2012 13:55:56 -0400 In-Reply-To: (Leo's message of "Sun, 04 Mar 2012 17:15:44 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10937 Cc: 10937@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > In savehist-printable, strings are not necessary printable. They can > contain anything in their properties. Because of this I have kill-ring > emptied for almost every restart of Emacs. Maybe we should strip their properties? Stefan From unknown Thu Sep 11 11:24:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Apr 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator