From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 23:33:17 2012 Received: (at submit) by debbugs.gnu.org; 4 Mar 2012 04:33:17 +0000 Received: from localhost ([127.0.0.1]:60523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S438C-00014B-5x for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:33:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52398) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S437v-00013T-3F for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:33:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S437F-00045C-7y for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:32:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S437F-000455-1n for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:32:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S437D-0001US-0z for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S436p-0003zr-9G for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:32:10 -0500 Received: from mail-iy0-f169.google.com ([209.85.210.169]:60898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S436p-0003zg-1p for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:31:47 -0500 Received: by iajr24 with SMTP id r24so4954884iaj.0 for ; Sat, 03 Mar 2012 20:31:45 -0800 (PST) Received-SPF: pass (google.com: domain of sdl.web@gmail.com designates 10.50.193.226 as permitted sender) client-ip=10.50.193.226; Authentication-Results: mr.google.com; spf=pass (google.com: domain of sdl.web@gmail.com designates 10.50.193.226 as permitted sender) smtp.mail=sdl.web@gmail.com; dkim=pass header.i=sdl.web@gmail.com Received: from mr.google.com ([10.50.193.226]) by 10.50.193.226 with SMTP id hr2mr3132104igc.34.1330835505283 (num_hops = 1); Sat, 03 Mar 2012 20:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; bh=s1aXYocNUkALHyVIbnhlcHYkBVtrLclrc1xZ3BKKlQM=; b=lGMtYc1V2fVLjS2/3CwTlKLAF32e+YQShR7OsmrjapD1kfXF/CE2Kf81BAyTW6IfOp F+bd5E4DPMExmzmm1BDulS9JYP5KBCckKUM328zb/ZzPA7dabsK7jAAa2QectkkvC6oJ iikIL1Pt0DgOYSZFLe33GiUrfLlQc0vSvrbgkRdpekV8oY4c0GVAvkeVNU0kaHMh6CPy RhXvkZRUBmAJ1ebIew3Q9nYwYniDuw0nEvjoOPG4Yedv2hOOD1FYSykcfBPa5TiqmjzZ /3fP6OiyW+Bz4tgQ861cnTq6wnVQrgUdde08A9r2zPFHjZvN63MyMhsZdqQcKDt2Ao8P H6Ew== Received: by 10.50.193.226 with SMTP id hr2mr2608040igc.34.1330835505245; Sat, 03 Mar 2012 20:31:45 -0800 (PST) Received: from localhost ([111.194.103.246]) by mx.google.com with ESMTPS id dl10sm7117270igb.9.2012.03.03.20.31.39 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Mar 2012 20:31:44 -0800 (PST) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.0.94; cperl system abbrevs fix X-Debbugs-CC: Stefan Monnier Date: Sun, 04 Mar 2012 12:31:33 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) In cperl-mode it uses a hack to avoid having programmably-defined abbrevs written to the abbrev file. This is not safe i.e. those abbrevs can still be saved to disk, and users might be tricked to edit them but lose their editing because they are redefined by cperl-mode. I think the following patch is due. commit 0d5a31c8fc9faf708e98bee32913bc2dfe31bf7d Date: Fri Apr 16 21:09:01 2010 +0100 Fix cperl-mode abbrevs See http://permalink.gmane.org/gmane.emacs.devel/123752. --- lisp/progmodes/cperl-mode.el | 44 ++++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 23 deletions(-) Modified lisp/progmodes/cperl-mode.el diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index eb881d01..3a332b24 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -1714,29 +1714,27 @@ (defun cperl-mode () [(control c) (control h) f]))) (setq major-mode cperl-use-major-mode) (setq mode-name "CPerl") - (let ((prev-a-c abbrevs-changed)) - (define-abbrev-table 'cperl-mode-abbrev-table '( - ("if" "if" cperl-electric-keyword 0) - ("elsif" "elsif" cperl-electric-keyword 0) - ("while" "while" cperl-electric-keyword 0) - ("until" "until" cperl-electric-keyword 0) - ("unless" "unless" cperl-electric-keyword 0) - ("else" "else" cperl-electric-else 0) - ("continue" "continue" cperl-electric-else 0) - ("for" "for" cperl-electric-keyword 0) - ("foreach" "foreach" cperl-electric-keyword 0) - ("formy" "formy" cperl-electric-keyword 0) - ("foreachmy" "foreachmy" cperl-electric-keyword 0) - ("do" "do" cperl-electric-keyword 0) - ("=pod" "=pod" cperl-electric-pod 0) - ("=over" "=over" cperl-electric-pod 0) - ("=head1" "=head1" cperl-electric-pod 0) - ("=head2" "=head2" cperl-electric-pod 0) - ("pod" "pod" cperl-electric-pod 0) - ("over" "over" cperl-electric-pod 0) - ("head1" "head1" cperl-electric-pod 0) - ("head2" "head2" cperl-electric-pod 0))) - (setq abbrevs-changed prev-a-c)) + (define-abbrev-table 'cperl-mode-abbrev-table + '(("if" "if" cperl-electric-keyword 0 t) + ("elsif" "elsif" cperl-electric-keyword 0 t) + ("while" "while" cperl-electric-keyword 0 t) + ("until" "until" cperl-electric-keyword 0 t) + ("unless" "unless" cperl-electric-keyword 0 t) + ("else" "else" cperl-electric-else 0 t) + ("continue" "continue" cperl-electric-else 0 t) + ("for" "for" cperl-electric-keyword 0 t) + ("foreach" "foreach" cperl-electric-keyword 0 t) + ("formy" "formy" cperl-electric-keyword 0 t) + ("foreachmy" "foreachmy" cperl-electric-keyword 0 t) + ("do" "do" cperl-electric-keyword 0 t) + ("=pod" "=pod" cperl-electric-pod 0 t) + ("=over" "=over" cperl-electric-pod 0 t) + ("=head1" "=head1" cperl-electric-pod 0 t) + ("=head2" "=head2" cperl-electric-pod 0 t) + ("pod" "pod" cperl-electric-pod 0 t) + ("over" "over" cperl-electric-pod 0 t) + ("head1" "head1" cperl-electric-pod 0 t) + ("head2" "head2" cperl-electric-pod 0 t))) (setq local-abbrev-table cperl-mode-abbrev-table) (if (cperl-val 'cperl-electric-keywords) (abbrev-mode 1)) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 04 09:49:52 2012 Received: (at 10934) by debbugs.gnu.org; 4 Mar 2012 14:49:52 +0000 Received: from localhost ([127.0.0.1]:60720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4Ckx-0000g0-Sv for submit@debbugs.gnu.org; Sun, 04 Mar 2012 09:49:52 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:6457) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4Ckb-0000fR-7g for 10934@debbugs.gnu.org; Sun, 04 Mar 2012 09:49:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9FxJvl/2dsb2JhbACBX5x7eYhwnhmGGQSGUJRJhAs X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="165836156" Received: from 69-196-155-229.dsl.teksavvy.com (HELO pastel.home) ([69.196.155.229]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Mar 2012 09:48:44 -0500 Received: by pastel.home (Postfix, from userid 20848) id 496065931F; Sun, 4 Mar 2012 09:48:42 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix Message-ID: References: Date: Sun, 04 Mar 2012 09:48:42 -0500 In-Reply-To: (Leo's message of "Sun, 04 Mar 2012 12:31:33 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10934 Cc: 10934@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > In cperl-mode it uses a hack to avoid having programmably-defined > abbrevs written to the abbrev file. This is not safe i.e. those abbrevs > can still be saved to disk, and users might be tricked to edit them but > lose their editing because they are redefined by cperl-mode. > I think the following patch is due. Thanks for the patch. But cperl-mode maintainership is a bit delicate, so I prefer to minimize the difference between our version and the upstream version. IOW, please try and find a patch that is acceptable to Ilya (I suspect that he'll want the patch to be backward-compatible). Stefan PS: The whole define-abbrev-table (c|sh)ould be moved to the toplevel. > commit 0d5a31c8fc9faf708e98bee32913bc2dfe31bf7d > Date: Fri Apr 16 21:09:01 2010 +0100 > Fix cperl-mode abbrevs > See http://permalink.gmane.org/gmane.emacs.devel/123752. > --- > lisp/progmodes/cperl-mode.el | 44 ++++++++++++++++++++---------------------- > 1 file changed, 21 insertions(+), 23 deletions(-) > Modified lisp/progmodes/cperl-mode.el > diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el > index eb881d01..3a332b24 100644 > --- a/lisp/progmodes/cperl-mode.el > +++ b/lisp/progmodes/cperl-mode.el > @@ -1714,29 +1714,27 @@ (defun cperl-mode () > [(control c) (control h) f]))) > (setq major-mode cperl-use-major-mode) > (setq mode-name "CPerl") > - (let ((prev-a-c abbrevs-changed)) > - (define-abbrev-table 'cperl-mode-abbrev-table '( > - ("if" "if" cperl-electric-keyword 0) > - ("elsif" "elsif" cperl-electric-keyword 0) > - ("while" "while" cperl-electric-keyword 0) > - ("until" "until" cperl-electric-keyword 0) > - ("unless" "unless" cperl-electric-keyword 0) > - ("else" "else" cperl-electric-else 0) > - ("continue" "continue" cperl-electric-else 0) > - ("for" "for" cperl-electric-keyword 0) > - ("foreach" "foreach" cperl-electric-keyword 0) > - ("formy" "formy" cperl-electric-keyword 0) > - ("foreachmy" "foreachmy" cperl-electric-keyword 0) > - ("do" "do" cperl-electric-keyword 0) > - ("=pod" "=pod" cperl-electric-pod 0) > - ("=over" "=over" cperl-electric-pod 0) > - ("=head1" "=head1" cperl-electric-pod 0) > - ("=head2" "=head2" cperl-electric-pod 0) > - ("pod" "pod" cperl-electric-pod 0) > - ("over" "over" cperl-electric-pod 0) > - ("head1" "head1" cperl-electric-pod 0) > - ("head2" "head2" cperl-electric-pod 0))) > - (setq abbrevs-changed prev-a-c)) > + (define-abbrev-table 'cperl-mode-abbrev-table > + '(("if" "if" cperl-electric-keyword 0 t) > + ("elsif" "elsif" cperl-electric-keyword 0 t) > + ("while" "while" cperl-electric-keyword 0 t) > + ("until" "until" cperl-electric-keyword 0 t) > + ("unless" "unless" cperl-electric-keyword 0 t) > + ("else" "else" cperl-electric-else 0 t) > + ("continue" "continue" cperl-electric-else 0 t) > + ("for" "for" cperl-electric-keyword 0 t) > + ("foreach" "foreach" cperl-electric-keyword 0 t) > + ("formy" "formy" cperl-electric-keyword 0 t) > + ("foreachmy" "foreachmy" cperl-electric-keyword 0 t) > + ("do" "do" cperl-electric-keyword 0 t) > + ("=pod" "=pod" cperl-electric-pod 0 t) > + ("=over" "=over" cperl-electric-pod 0 t) > + ("=head1" "=head1" cperl-electric-pod 0 t) > + ("=head2" "=head2" cperl-electric-pod 0 t) > + ("pod" "pod" cperl-electric-pod 0 t) > + ("over" "over" cperl-electric-pod 0 t) > + ("head1" "head1" cperl-electric-pod 0 t) > + ("head2" "head2" cperl-electric-pod 0 t))) > (setq local-abbrev-table cperl-mode-abbrev-table) > (if (cperl-val 'cperl-electric-keywords) > (abbrev-mode 1)) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 15 07:26:13 2012 Received: (at submit) by debbugs.gnu.org; 15 Mar 2012 11:26:13 +0000 Received: from localhost ([127.0.0.1]:51685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S88ot-0000bb-OG for submit@debbugs.gnu.org; Thu, 15 Mar 2012 07:26:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52916) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S88oq-0000bS-BH for submit@debbugs.gnu.org; Thu, 15 Mar 2012 07:26:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S88La-0002Ad-BR for submit@debbugs.gnu.org; Thu, 15 Mar 2012 06:56:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,RCVD_NUMERIC_HELO autolearn=ham version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S88La-0002AZ-8c for submit@debbugs.gnu.org; Thu, 15 Mar 2012 06:55:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S88LU-0002ZH-8G for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 06:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S88L2-00027R-31 for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 06:55:47 -0400 Received: from plane.gmane.org ([80.91.229.3]:35130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S88L1-000272-T0 for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 06:55:20 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S88Kz-0001ER-Ez for bug-gnu-emacs@gnu.org; Thu, 15 Mar 2012 11:55:17 +0100 Received: from 111.194.94.220 ([111.194.94.220]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 15 Mar 2012 11:55:17 +0100 Received: from sdl.web by 111.194.94.220 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 15 Mar 2012 11:55:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix Date: Thu, 15 Mar 2012 18:55:02 +0800 Lines: 17 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 111.194.94.220 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (Mac OS X 10.6.8) Cancel-Lock: sha1:zA/FAitCt66DOCMSDsOgeHIWcmY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) On 2012-03-04 22:48 +0800, Stefan Monnier wrote: > Thanks for the patch. > But cperl-mode maintainership is a bit delicate, so I prefer to minimize the > difference between our version and the upstream version. > IOW, please try and find a patch that is acceptable to Ilya (I suspect > that he'll want the patch to be backward-compatible). > > > Stefan > > > PS: The whole define-abbrev-table (c|sh)ould be moved to the toplevel. Do you mind if we install this for the emacs release? We can ask the author of cperl mode to incorporate it later. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 15 08:39:34 2012 Received: (at 10934) by debbugs.gnu.org; 15 Mar 2012 12:39:34 +0000 Received: from localhost ([127.0.0.1]:51765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S89xe-00033I-Qr for submit@debbugs.gnu.org; Thu, 15 Mar 2012 08:39:34 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:14859) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S89xF-00032L-Tc for 10934@debbugs.gnu.org; Thu, 15 Mar 2012 08:39:01 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9soXdS/2dsb2JhbACBX5x7eYhwnhmGGQSbGYQJ X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="168106500" Received: from 108-161-119-82.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([108.161.119.82]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 Mar 2012 08:08:45 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 9A63BAE30A; Thu, 15 Mar 2012 08:08:45 -0400 (EDT) From: Stefan Monnier To: Leo Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix Message-ID: References: Date: Thu, 15 Mar 2012 08:08:45 -0400 In-Reply-To: (Leo's message of "Thu, 15 Mar 2012 18:55:02 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10934 Cc: 10934@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> Thanks for the patch. >> But cperl-mode maintainership is a bit delicate, so I prefer to minimize the >> difference between our version and the upstream version. >> IOW, please try and find a patch that is acceptable to Ilya (I suspect >> that he'll want the patch to be backward-compatible). > Do you mind if we install this for the emacs release? We can ask the > author of cperl mode to incorporate it later. I'd rather first get his agreement, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 24 01:40:03 2016 Received: (at 10934) by debbugs.gnu.org; 24 Feb 2016 06:40:03 +0000 Received: from localhost ([127.0.0.1]:42371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYT7D-0002Pa-4Z for submit@debbugs.gnu.org; Wed, 24 Feb 2016 01:40:03 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:36413) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYT7B-0002P5-5m for 10934@debbugs.gnu.org; Wed, 24 Feb 2016 01:40:01 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYT6k-0003Vi-7L; Wed, 24 Feb 2016 07:39:34 +0100 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix References: Date: Wed, 24 Feb 2016 17:39:29 +1100 In-Reply-To: (Stefan Monnier's message of "Thu, 15 Mar 2012 08:08:45 -0400") Message-ID: <87mvqqboim.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYT6k-0003Vi-7L X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456900776.07741@zvOc217ozhnyREhFuJsxtw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10934 Cc: 10934@debbugs.gnu.org, Leo , Ilya Zakharevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >>> Thanks for the patch. >>> But cperl-mode maintainership is a bit delicate, so I prefer to minimize the >>> difference between our version and the upstream version. >>> IOW, please try and find a patch that is acceptable to Ilya (I suspect >>> that he'll want the patch to be backward-compatible). > >> Do you mind if we install this for the emacs release? We can ask the >> author of cperl mode to incorporate it later. > > I'd rather first get his agreement, It looks like this patch was not applied. Leo, did you contact Ilya? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 24 03:15:31 2016 Received: (at 10934) by debbugs.gnu.org; 24 Feb 2016 08:15:31 +0000 Received: from localhost ([127.0.0.1]:42430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYUbb-0007vj-HU for submit@debbugs.gnu.org; Wed, 24 Feb 2016 03:15:31 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:33783) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYUba-0007vU-Eo for 10934@debbugs.gnu.org; Wed, 24 Feb 2016 03:15:30 -0500 Received: by mail-pf0-f177.google.com with SMTP id q63so8869417pfb.0 for <10934@debbugs.gnu.org>; Wed, 24 Feb 2016 00:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=RgkgdBWsXr7n66sJiz2MksklVkbrYhbXvankS6EGP8U=; b=X80L5sHfEv6217DF2xsZVfeSyPbwgzQp/la/LBJqaBTXMbjsWxOeTR998VdJh9V2eN XJaM50Ru2NM3spdNYGV9plm1wC2excCIBYBod7PHf2yl28YvLMTVsWtjgnuiue/YEGob uKkLvVyX9f9XkNzo4phHAZiJTK7EvK7itcvl3kB9wUvdyXcKx7q8eaFAkbpy65JJSPxK HXcEiWhPraPtVg+D1Q/hPVEIiwXajtYYKMGgXRWVvU+nPq4oyG2bHD3jSSiWQOi1k7IX fmzMRVrntN4vS3VrtwphJfU0oofZLA7BIDSV/AM/4WKcgw9GidLLXX7/MFluS0wUNHEZ qqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=RgkgdBWsXr7n66sJiz2MksklVkbrYhbXvankS6EGP8U=; b=DS9Quu5oiD80PCkvQMxYq3QrDNfJbW0Yvt4Lzrc4t/RVMVpC+YgViBHTYPpwYvQ8qc 4PaTIPulZ422SOSatpMzqpVjK5SwzMmNx0g7YeGy3TgNyzRPZp615msdLX1g4pjuQ9hs S+tP7/fyYGzl2K33nqv+gREaX9S8jMeAJi2N/gLZ/FlXrdEZF2ZVjSbzRGvZpQEOda2l Pk96KFhhbUMiyUHjplsb/D63hYMLZql6Aw1aMYDqNuT9bpXzR8rOKKXi56tqnVxFP3li GaLr5IEShglVR+ciUh4IG53fEugCYcXQuYis81nw4/NqXXuJQdi7XxAW8UI4g/qY/S4D VsfQ== X-Gm-Message-State: AG10YOSfh0E+PxrlnoYdxhw74ZymhTQBzUORTA2ZuUdC4JrVHIVOhBUc3dx0dPpfo73vBQ== X-Received: by 10.98.65.11 with SMTP id o11mr52403101pfa.115.1456301724737; Wed, 24 Feb 2016 00:15:24 -0800 (PST) Received: from localhost ([116.213.171.154]) by smtp.gmail.com with ESMTPSA id f12sm2819629pfd.87.2016.02.24.00.15.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2016 00:15:23 -0800 (PST) From: Leo Liu To: Lars Ingebrigtsen Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix References: <87mvqqboim.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Wed, 24 Feb 2016 16:15:18 +0800 In-Reply-To: <87mvqqboim.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2016 17:39:29 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (OS X 10.11.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 10934 Cc: 10934@debbugs.gnu.org, Stefan Monnier , Ilya Zakharevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-02-24 17:39 +1100, Lars Ingebrigtsen wrote: > It looks like this patch was not applied. Leo, did you contact Ilya? No sadly. There was a time I had trouble finding the most recent cperl-mode.el to make an update-to-date patch. Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 24 06:12:20 2016 Received: (at 10934) by debbugs.gnu.org; 24 Feb 2016 11:12:20 +0000 Received: from localhost ([127.0.0.1]:42521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYXMh-0003lA-Pe for submit@debbugs.gnu.org; Wed, 24 Feb 2016 06:12:19 -0500 Received: from nm20-vm9.bullet.mail.gq1.yahoo.com ([98.136.217.40]:39523) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYXMe-0003kw-UI for 10934@debbugs.gnu.org; Wed, 24 Feb 2016 06:12:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1456312330; bh=8hl5VbBsRR3nSCWK91QFUF1A/4563UMtAT2AvyaUViU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=sh8PYlXZJ1max7aFWfM9q9q0yzqgq0GKT8NcaBXkVwe8p1Dt+dwYt2rErE5Ns01llwjYRmQDCfVhbC3dpreE9quWrAxYVsmCsW3raKk6anJbD8ZQ++j4zdEflADVvVYanD7wZSnZb2NQu6Z8bZ35cBufqRWY8kiUMhb+kSy2L2MFTjppIRAFc3CifHqL8HabibxEGRCZpLklhsdoI3rMoqbRWqsL6kUZKmeGUetaPdvkdGcYo9e8pqqiPbf2gSPsIeqFZXdh+6sPQDW5JRgT+iex2zNGquBTlDtG44YZu7cqQu1qtGqepnK/RMS3ZFXhNZZS9o/g29AF0VqFb7gxVQ== Received: from [216.39.60.184] by nm20.bullet.mail.gq1.yahoo.com with NNFMP; 24 Feb 2016 11:12:10 -0000 Received: from [208.71.42.208] by tm20.bullet.mail.gq1.yahoo.com with NNFMP; 24 Feb 2016 11:12:10 -0000 Received: from [127.0.0.1] by smtp219.mail.gq1.yahoo.com with NNFMP; 24 Feb 2016 11:12:10 -0000 X-Yahoo-Newman-Id: 961045.92214.bm@smtp219.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: SmdNU8UVM1nCChA7ExVesr9cr1csKcd7bBvsFe386DHXxkv 60Fo5juqe36qBol7cITPWJUuVOQD7q1f1zNS_zS9FA4WsCYRHQhxcHOhn6zr Ah5KyAG.GBWDIAcniEN5hjcOiH.rbhFH4s7rWvClIZ7cHaxr0v0qTqk_AE18 jv6aIo6ukRr9PXAchqJbgWhoB8wNXuEh3I9RzlGg4qj3zcpJn5Uo0goVvy0S c8iV6XyzbQuaIe0iStsJYkJ7CsHmkOG_sRV6kKm_LrNnkkNnKA5V4ZHqg5Pq 7UilDeItdaxMutJrn8ba2t8x1gLOXG4Jo_8xl96R9PHX11KZKHfJpJMuc3xQ kta8L5wHxXEpaQusm1KARdzBGB_cFRKNAJfqhXaMLcguCW8VabaOOkutp6A0 Abn1u0EwLMea1mdEMy.OyA6ai7tOAeiTJY7HnjKSkkCZCqpEDP798wXE_CVz TQdsr.e80I9fDuAadpS5.ya4DGPrELDDqyXTXeUkn7Ts7l2BhpUzHhCAdIev vfZj4RIiWb5A6PoY- X-Yahoo-SMTP: oLSY3dWswBBqoBVzCkLl_RIsw6heKMxu8wpEbARv1SU- Date: Wed, 24 Feb 2016 03:12:07 -0800 From: Ilya Zakharevich To: Leo Liu Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix Message-ID: <20160224111206.GA19286@math.berkeley.edu> References: <87mvqqboim.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 10934 Cc: Lars Ingebrigtsen , Stefan Monnier , 10934@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Feb 24, 2016 at 04:15:18PM +0800, Leo Liu wrote: > On 2016-02-24 17:39 +1100, Lars Ingebrigtsen wrote: > > It looks like this patch was not applied. Leo, did you contact Ilya? > > No sadly. There was a time I had trouble finding the most recent > cperl-mode.el to make an update-to-date patch. Guys, sorry for being such a boor, but I do not think that nowadays it is practical to pay attention to my opinion w.r.t. cperl-mode. I could not touch it for years — so if I ever would find time to deal with it, a few extra patches should not be showstopers. So, please, disregard me; — if/when I’m back, I would let you know. Yours, Ilya (and sorry again!) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 24 08:02:46 2016 Received: (at 10934) by debbugs.gnu.org; 24 Feb 2016 13:02:46 +0000 Received: from localhost ([127.0.0.1]:42619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYZ5X-0008Gf-71 for submit@debbugs.gnu.org; Wed, 24 Feb 2016 08:02:46 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:33284) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYZ5S-0008GM-3K for 10934@debbugs.gnu.org; Wed, 24 Feb 2016 08:02:41 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BEFgA731xV/+OhCkxcgxBUXoJQhVW9FoV1BAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kARKIJAgNzxYBAQEBAQEBAQIBAQEBAQEBFwSLOoUFB4QtBYwwinGHdoNrkD2BRSOCChyBcCAxgkcBAQE X-IPAS-Result: A0BEFgA731xV/+OhCkxcgxBUXoJQhVW9FoV1BAICgTw8EQEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kARKIJAgNzxYBAQEBAQEBAQIBAQEBAQEBFwSLOoUFB4QtBYwwinGHdoNrkD2BRSOCChyBcCAxgkcBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="194226942" Received: from 76-10-161-227.dsl.teksavvy.com (HELO pastel.home) ([76.10.161.227]) by ironport2-out.teksavvy.com with ESMTP; 24 Feb 2016 08:02:31 -0500 Received: by pastel.home (Postfix, from userid 20848) id 8DB1660201; Wed, 24 Feb 2016 08:02:31 -0500 (EST) From: Stefan Monnier To: Jonathan Rockway , Lars Ingebrigtsen Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix Message-ID: References: <87mvqqboim.fsf@gnus.org> Date: Wed, 24 Feb 2016 08:02:31 -0500 In-Reply-To: <87mvqqboim.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2016 17:39:29 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 10934 Cc: 10934@debbugs.gnu.org, Leo , Ilya Zakharevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >>>>> "Lars" == Lars Ingebrigtsen writes: > Stefan Monnier writes: >>>> Thanks for the patch. >>>> But cperl-mode maintainership is a bit delicate, so I prefer to minimize the >>>> difference between our version and the upstream version. >>>> IOW, please try and find a patch that is acceptable to Ilya (I suspect >>>> that he'll want the patch to be backward-compatible). >> >>> Do you mind if we install this for the emacs release? We can ask the >>> author of cperl mode to incorporate it later. >> >> I'd rather first get his agreement, > It looks like this patch was not applied. Leo, did you contact Ilya? IIRC, Jonathan Rockway had agreed to maintain cperl-mode (he has a few changes in his version which you can clone from https://github.com/jrockway/cperl-mode). Jonathan, where are we with that? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 22:39:43 2016 Received: (at 10934-done) by debbugs.gnu.org; 11 Dec 2016 03:39:43 +0000 Received: from localhost ([127.0.0.1]:37441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFuzH-0008AM-M2 for submit@debbugs.gnu.org; Sat, 10 Dec 2016 22:39:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFuzG-0008A9-F0 for 10934-done@debbugs.gnu.org; Sat, 10 Dec 2016 22:39:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFuzA-0001N3-HW for 10934-done@debbugs.gnu.org; Sat, 10 Dec 2016 22:39:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFuzA-0001My-EZ for 10934-done@debbugs.gnu.org; Sat, 10 Dec 2016 22:39:36 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cFuz9-0006YQ-RU; Sat, 10 Dec 2016 22:39:35 -0500 From: Glenn Morris To: 10934-done@debbugs.gnu.org Subject: Re: bug#10934: 24.0.94; cperl system abbrevs fix References: <87mvqqboim.fsf@gnus.org> <20160224111206.GA19286@math.berkeley.edu> X-Spook: Domestic Nuclear Detection Office Hail Secure Border X-Ran: F#rmU|jd@&oo,q-bcPSOS!4;mi9qaVy=3|#JK&'U4)&*W<9iYfSnl#T X-Hue: brightmagenta X-Attribution: GM Date: Sat, 10 Dec 2016 22:39:35 -0500 In-Reply-To: <20160224111206.GA19286@math.berkeley.edu> (Ilya Zakharevich's message of "Wed, 24 Feb 2016 03:12:07 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 10934-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) Version: 26.1 Following comments in http://debbugs.gnu.org/10934#23, applied in 3aa3f73 and subsequent. From unknown Thu Sep 11 18:07:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 08 Jan 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator