From unknown Fri Aug 15 18:11:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10906 <10906@debbugs.gnu.org> To: bug#10906 <10906@debbugs.gnu.org> Subject: Status: 24.0.94; `c-mark-function' does set the mark well Reply-To: bug#10906 <10906@debbugs.gnu.org> Date: Sat, 16 Aug 2025 01:11:49 +0000 retitle 10906 24.0.94; `c-mark-function' does set the mark well reassign 10906 emacs,cc-mode submitter 10906 Dani Moncayo severity 10906 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 28 07:40:25 2012 Received: (at submit) by debbugs.gnu.org; 28 Feb 2012 12:40:25 +0000 Received: from localhost ([127.0.0.1]:60898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2MLs-0006vD-9Z for submit@debbugs.gnu.org; Tue, 28 Feb 2012 07:40:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42004) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2MLS-0006uD-Rt for submit@debbugs.gnu.org; Tue, 28 Feb 2012 07:40:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2MIL-0005ph-IF for submit@debbugs.gnu.org; Tue, 28 Feb 2012 07:36:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:45700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2MIL-0005pa-Cr for submit@debbugs.gnu.org; Tue, 28 Feb 2012 07:36:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2MIF-0002rW-1q for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 07:36:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2MID-0005oh-4U for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 07:36:34 -0500 Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:59296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2MIC-0005oW-R7 for bug-gnu-emacs@gnu.org; Tue, 28 Feb 2012 07:36:32 -0500 Received: by obbta7 with SMTP id ta7so8055995obb.0 for ; Tue, 28 Feb 2012 04:36:30 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.60.25.41 as permitted sender) client-ip=10.60.25.41; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.60.25.41 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.60.25.41]) by 10.60.25.41 with SMTP id z9mr4655889oef.70.1330432590833 (num_hops = 1); Tue, 28 Feb 2012 04:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=TcFQQ7OjAd+hUR8Z6ThPibzC0QWDCDs9L7KovuqoqFw=; b=lPNPISe/OH4GbMivxZGIFzs57hWm2OrLIr6/NCYPOfA1pZN4Vi+1RygAzj7KsIBbVl AEstjwNHom7XjVQZKwfvE5ezJ1nDEA8EWjdNspYVKXkNk3q/exSn4B9w6FuEmrjkFsvT P56NECjDkWLsru4EM4qbTyyLo5dFgqZbJQTLg= MIME-Version: 1.0 Received: by 10.60.25.41 with SMTP id z9mr4111194oef.70.1330432590789; Tue, 28 Feb 2012 04:36:30 -0800 (PST) Received: by 10.60.42.193 with HTTP; Tue, 28 Feb 2012 04:36:30 -0800 (PST) Date: Tue, 28 Feb 2012 13:36:30 +0100 Message-ID: Subject: 24.0.94; `c-mark-function' does set the mark well From: Dani Moncayo To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=e89a8ff252d0f8ba2404ba05798e X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Recipe from "emacs -Q": 1. Visit the attached file. 2. Move point to the end of the "printf" sentence. 3. Type C-M-h 4. C-g 5. Type C-u C-SPC --> Expected result: The point moves back to the position it occupied just before step #3, i.e., to the end of the "printf" sentence. This is the behavior that makes sense, and the one you get if you replace steps #3 and #4 with "Type C-M-a". [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dmoncayo[at]gmail.com) 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Recipe from "emacs -Q": 1. Visit the attached file. 2. Move point to the end of the "printf" sentence. 3. Type C-M-h 4. C-g 5. Type C-u C-SPC --> Expected result: The point moves back to the position it occupied just before step #3, i.e., to the end of the "printf" sentence. This is the behavior that makes sense, and the one you get if you replace steps #3 and #4 with "Type C-M-a". [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dmoncayo[at]gmail.com) 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --e89a8ff252d0f8ba2404ba05798e Content-Type: text/plain; charset=ISO-8859-1 Recipe from "emacs -Q": 1. Visit the attached file. 2. Move point to the end of the "printf" sentence. 3. Type C-M-h 4. C-g 5. Type C-u C-SPC --> Expected result: The point moves back to the position it occupied just before step #3, i.e., to the end of the "printf" sentence. This is the behavior that makes sense, and the one you get if you replace steps #3 and #4 with "Type C-M-a". --> Observed result: The point moves to the end of the "main" function. In GNU Emacs 24.0.94.1 (i386-mingw-nt6.1.7601) of 2012-02-27 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-gcc (4.6)' -- Dani Moncayo --e89a8ff252d0f8ba2404ba05798e Content-Type: text/x-csrc; charset=US-ASCII; name="test.c" Content-Disposition: attachment; filename="test.c" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gz6x5rll0 DQovLyBUZXN0DQp2b2lkIG1haW4odm9pZCkNCnsNCiAgLy8gU2F5IGhlbGxvDQogIHByaW50Zigi SGVsbG8sIHdvcmxkISIpOw0KfQ0KDQovLyBFbmQgb2YgZmlsZQ0K --e89a8ff252d0f8ba2404ba05798e-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 29 04:03:34 2012 Received: (at 10906) by debbugs.gnu.org; 29 Feb 2012 09:03:34 +0000 Received: from localhost ([127.0.0.1]:55100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2fRZ-0000WB-30 for submit@debbugs.gnu.org; Wed, 29 Feb 2012 04:03:34 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:50499) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2fR9-0000VC-6a for 10906@debbugs.gnu.org; Wed, 29 Feb 2012 04:03:18 -0500 Received: by obbeh20 with SMTP id eh20so3482825obb.3 for <10906@debbugs.gnu.org>; Wed, 29 Feb 2012 01:02:44 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.60.5.231 as permitted sender) client-ip=10.60.5.231; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.60.5.231 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.60.5.231]) by 10.60.5.231 with SMTP id v7mr5821731oev.50.1330506164943 (num_hops = 1); Wed, 29 Feb 2012 01:02:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TOKcqK+EGo4GluS8Ha8ieW9K0Z+pzJ8qUVObYT7VIgw=; b=AVE6HeAhFZH82Of7adl+6tntTAp26FjCCWVAMoeMdfDmx61OyRksGRcR121kr0y0Sq Jl77m3pptiReY1wCifDd73MKFLFieCkFFczJstXtqLJ5lsCO1yNR2tt8BfRHFidRk+ix dmkQbREPijXPWKCrl5xHHq73nOdbp5kt1L76U= MIME-Version: 1.0 Received: by 10.60.5.231 with SMTP id v7mr5089934oev.50.1330506164852; Wed, 29 Feb 2012 01:02:44 -0800 (PST) Received: by 10.60.42.193 with HTTP; Wed, 29 Feb 2012 01:02:44 -0800 (PST) In-Reply-To: References: Date: Wed, 29 Feb 2012 10:02:44 +0100 Message-ID: Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10906 Cc: 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Wed, Feb 29, 2012 at 01:14, Juri Linkov wrote: >[...] > Regarding bug#10906, I think `c-mark-function' should be rewritten > to follow the logic of `mark-defun'. Agreed, and BTW, if `c-mark-function' is going to be revised, please, take also this problem into account: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525 Thanks. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 16:26:00 2012 Received: (at 10906) by debbugs.gnu.org; 1 Mar 2012 21:26:00 +0000 Received: from localhost ([127.0.0.1]:57941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3DVQ-000472-Hs for submit@debbugs.gnu.org; Thu, 01 Mar 2012 16:25:59 -0500 Received: from colin.muc.de ([193.149.48.1]:38732 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3DUz-00046Q-HP for 10906@debbugs.gnu.org; Thu, 01 Mar 2012 16:25:33 -0500 Received: (qmail 39962 invoked by uid 3782); 1 Mar 2012 21:24:50 -0000 Received: from acm.muc.de (pD955650C.dip.t-dialin.net [217.85.101.12]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 01 Mar 2012 22:24:44 +0100 Received: (qmail 19650 invoked by uid 1000); 1 Mar 2012 21:24:04 -0000 Date: Thu, 1 Mar 2012 21:24:04 +0000 To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well Message-ID: <20120301212404.GB19099@acm.acm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Hello, Dani. On Wed, Feb 29, 2012 at 10:02:44AM +0100, Dani Moncayo wrote: > On Wed, Feb 29, 2012 at 01:14, Juri Linkov wrote: > >[...] > > Regarding bug#10906, I think `c-mark-function' should be rewritten > > to follow the logic of `mark-defun'. Any chance of a quick summary of how c-mark-function differs from mark-defun? > Agreed, and BTW, if `c-mark-function' is going to be revised, please, > take also this problem into account: > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525 Again, what is this bug? Could you not even quote the title line from it? > Thanks. > -- > Dani Moncayo -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 18:04:39 2012 Received: (at 10906) by debbugs.gnu.org; 1 Mar 2012 23:04:39 +0000 Received: from localhost ([127.0.0.1]:58005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3F33-0006NA-OK for submit@debbugs.gnu.org; Thu, 01 Mar 2012 18:04:39 -0500 Received: from mail-yw0-f44.google.com ([209.85.213.44]:65424) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3F2m-0006MO-Em for 10906@debbugs.gnu.org; Thu, 01 Mar 2012 18:04:22 -0500 Received: by yhpp34 with SMTP id p34so552837yhp.3 for <10906@debbugs.gnu.org>; Thu, 01 Mar 2012 15:03:49 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.60.12.8 as permitted sender) client-ip=10.60.12.8; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.60.12.8 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.60.12.8]) by 10.60.12.8 with SMTP id u8mr3093028oeb.60.1330643029054 (num_hops = 1); Thu, 01 Mar 2012 15:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=ccJZ8wC6EHzAq6ZPmFepOx6f/Lvk5dhqfxwhJcGy5jA=; b=mJWi1nbhU27Lg04+M7EG9XPlHodzFXFvgGEyYRd/5azsDNT/vxjNg4kucMulRWOIMZ 2XJAm/NB7QbyHurez27qDf9INFhN4/qmux7QkMj3RzBPhDFpFtctdeDOmoDjeeGMjBlI Y5JPxnh4G5TeXzOn7Lr488z9ueZqLEfDDWaj5foUw9J9IUuQbX8eqLFQ8jUcH3cM9vli ah6IBZNr2z1CPCnKL5HR9FCw/N4XoSjFUL6oMlNoOKgzj7vj+ePvVM6q2XTqil/Qe/oI 87V4OFpvas3OHEW/OaN5yVn9HFljK7L5RdPrPbS02yXq48IzSD4Ku9sMPKGC2JyXovI/ o9xw== MIME-Version: 1.0 Received: by 10.60.12.8 with SMTP id u8mr2643862oeb.60.1330643028982; Thu, 01 Mar 2012 15:03:48 -0800 (PST) Received: by 10.60.42.193 with HTTP; Thu, 1 Mar 2012 15:03:48 -0800 (PST) In-Reply-To: <20120301212404.GB19099@acm.acm> References: <20120301212404.GB19099@acm.acm> Date: Fri, 2 Mar 2012 00:03:48 +0100 Message-ID: Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well From: Dani Moncayo To: Alan Mackenzie Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Hello, Dani. Hi Alan. >> > Regarding bug#10906, I think `c-mark-function' should be rewritten >> > to follow the logic of `mark-defun'. > > Any chance of a quick summary of how c-mark-function differs from > mark-defun? AFAIK, they differ at least in two things: 1. `mark-defun' saves the original point location in the mark ring, whereas `c-mark-function' does not. IMO, the point should be saved, because in large defuns it may jump to a remote location and you may want to return back to the original position. This bug report is about this inconsistency, as you can see in the original post. 2. Successive interactive invocations of `mark-defun' extend the region to the next defuns (which I find useful), whereas `c-mark-function' does not have this feature. Bug #5525 is a request to remove this inconsistency, as you can see in the corresponding thread. >> Agreed, and BTW, if `c-mark-function' is going to be revised, please, >> take also this problem into account: > >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5525 > > Again, what is this bug? =A0Could you not even quote the title line from > it? I think this question is already answered. --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 18:15:03 2012 Received: (at 10906) by debbugs.gnu.org; 1 Mar 2012 23:15:03 +0000 Received: from localhost ([127.0.0.1]:58015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3FDD-0006c1-0x for submit@debbugs.gnu.org; Thu, 01 Mar 2012 18:15:03 -0500 Received: from colin.muc.de ([193.149.48.1]:22068 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3FD0-0006bY-Me for 10906@debbugs.gnu.org; Thu, 01 Mar 2012 18:14:52 -0500 Received: (qmail 49773 invoked by uid 3782); 1 Mar 2012 23:14:22 -0000 Received: from acm.muc.de (pD955650C.dip.t-dialin.net [217.85.101.12]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 02 Mar 2012 00:14:21 +0100 Received: (qmail 20236 invoked by uid 1000); 1 Mar 2012 23:13:41 -0000 Date: Thu, 1 Mar 2012 23:13:41 +0000 To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well Message-ID: <20120301231341.GC19099@acm.acm> References: <20120301212404.GB19099@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On Fri, Mar 02, 2012 at 12:03:48AM +0100, Dani Moncayo wrote: > > Hello, Dani. > Hi Alan. > >> > Regarding bug#10906, I think `c-mark-function' should be rewritten > >> > to follow the logic of `mark-defun'. > > Any chance of a quick summary of how c-mark-function differs from > > mark-defun? > AFAIK, they differ at least in two things: > 1. `mark-defun' saves the original point location in the mark ring, > whereas `c-mark-function' does not. IMO, the point should be saved, > because in large defuns it may jump to a remote location and you may > want to return back to the original position. This bug report is > about this inconsistency, as you can see in the original post. > 2. Successive interactive invocations of `mark-defun' extend the > region to the next defuns (which I find useful), whereas > `c-mark-function' does not have this feature. Bug #5525 is a request > to remove this inconsistency, as you can see in the corresponding > thread. > >> Agreed, and BTW, if `c-mark-function' is going to be revised, please, > >> take also this problem into account: > >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525 > > Again, what is this bug?  Could you not even quote the title line from > > it? > I think this question is already answered. Thanks! > -- > Dani Moncayo -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 18:17:41 2012 Received: (at 10906) by debbugs.gnu.org; 1 Mar 2012 23:17:41 +0000 Received: from localhost ([127.0.0.1]:58022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3FFl-0006ga-6t for submit@debbugs.gnu.org; Thu, 01 Mar 2012 18:17:41 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:51322) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3FFY-0006gE-Cr for 10906@debbugs.gnu.org; Thu, 01 Mar 2012 18:17:29 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1S3FF5-0002gg-7a; Thu, 01 Mar 2012 18:16:59 -0500 From: Glenn Morris To: Alan Mackenzie Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well References: <20120301212404.GB19099@acm.acm> X-Spook: tempest AIEWS terrorism Clinton George W. Bush import X-Ran: |YNRg({'cOCC5@e!sMjO|-=m`.3eElTmGj=eq5&2@joyWATTL/[$f^;S0/n5oRe@GzDP7w X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 01 Mar 2012 18:16:59 -0500 In-Reply-To: <20120301212404.GB19099@acm.acm> (Alan Mackenzie's message of "Thu, 1 Mar 2012 21:24:04 +0000") Message-ID: <68mx7zzzbo.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10906 Cc: 10906@debbugs.gnu.org, Dani Moncayo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) Alan Mackenzie wrote: >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525 > > Again, what is this bug? Could you not even quote the title line from > it? If you have rms-type issues with visiting URLs, you can do wget 'http://debbugs.gnu.org/cgi/bugreport.cgi?mbox=yes;bug=5525' to fetch an mbox of this or any other debbugs report, which you can then read off-line at your convenience, eg with Rmail. To get a listing of all bugs currently assigned to cc-mode, you can send a mail to request@debbugs.gnu.org with "index packages cc-mode" in the body. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 01 18:20:08 2012 Received: (at 10906) by debbugs.gnu.org; 1 Mar 2012 23:20:08 +0000 Received: from localhost ([127.0.0.1]:58028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3FI7-0006jx-Pt for submit@debbugs.gnu.org; Thu, 01 Mar 2012 18:20:08 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:51362) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3FHv-0006jb-SH for 10906@debbugs.gnu.org; Thu, 01 Mar 2012 18:19:56 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1S3FHS-0002o4-9M; Thu, 01 Mar 2012 18:19:26 -0500 From: Glenn Morris To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well References: X-Spook: secure assassination undercover BRLO DRM domestic X-Ran: `.:)ogfeS&"pGxCWoRe':+)dbwhSfG4.d.<"$W{h(DK!D (Dani Moncayo's message of "Wed, 29 Feb 2012 10:02:44 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) >> Regarding bug#10906, I think `c-mark-function' should be rewritten >> to follow the logic of `mark-defun'. > > Agreed, and BTW, if `c-mark-function' is going to be revised, please, > take also this problem into account: > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525 As I said there, the simplest way to get consistency is surely to remove c-mark-defun altogether, set end-of-defun-function etc appropriately, and let mark-defun handle it. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 03 09:18:26 2012 Received: (at 10906) by debbugs.gnu.org; 3 Mar 2012 14:18:26 +0000 Received: from localhost ([127.0.0.1]:59846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3pn0-0006tE-8h for submit@debbugs.gnu.org; Sat, 03 Mar 2012 09:18:26 -0500 Received: from colin.muc.de ([193.149.48.1]:18963 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S3pmn-0006sU-Nf for 10906@debbugs.gnu.org; Sat, 03 Mar 2012 09:18:14 -0500 Received: (qmail 56021 invoked by uid 3782); 3 Mar 2012 14:17:36 -0000 Received: from acm.muc.de (pD955636A.dip.t-dialin.net [217.85.99.106]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 03 Mar 2012 15:17:33 +0100 Received: (qmail 21042 invoked by uid 1000); 3 Mar 2012 14:16:51 -0000 Date: Sat, 3 Mar 2012 14:16:51 +0000 To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well Message-ID: <20120303141651.GA2168@acm.acm> References: <20120301212404.GB19099@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Hello, Dani, On Fri, Mar 02, 2012 at 12:03:48AM +0100, Dani Moncayo wrote: > > Any chance of a quick summary of how c-mark-function differs from > > mark-defun? > AFAIK, they differ at least in two things: > 1. `mark-defun' saves the original point location in the mark ring, > whereas `c-mark-function' does not. IMO, the point should be saved, > because in large defuns it may jump to a remote location and you may > want to return back to the original position. This bug report is > about this inconsistency, as you can see in the original post. > 2. Successive interactive invocations of `mark-defun' extend the > region to the next defuns (which I find useful), whereas > `c-mark-function' does not have this feature. Bug #5525 is a request > to remove this inconsistency, as you can see in the corresponding > thread. OK, I'll amend c-mark-function to do these things. > -- > Dani Moncayo -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 05 13:43:27 2012 Received: (at 10906) by debbugs.gnu.org; 5 Mar 2012 18:43:27 +0000 Received: from localhost ([127.0.0.1]:34501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4csZ-0000qc-Bm for submit@debbugs.gnu.org; Mon, 05 Mar 2012 13:43:27 -0500 Received: from colin.muc.de ([193.149.48.1]:45746 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4csL-0000px-Nh for 10906@debbugs.gnu.org; Mon, 05 Mar 2012 13:43:15 -0500 Received: (qmail 257 invoked by uid 3782); 5 Mar 2012 18:42:23 -0000 Received: from acm.muc.de (pD951A032.dip.t-dialin.net [217.81.160.50]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 05 Mar 2012 19:42:18 +0100 Received: (qmail 27185 invoked by uid 1000); 5 Mar 2012 18:41:33 -0000 Date: Mon, 5 Mar 2012 18:41:33 +0000 To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well Message-ID: <20120305184133.GC2824@acm.acm> References: <20120301212404.GB19099@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Hello, Dani. On Fri, Mar 02, 2012 at 12:03:48AM +0100, Dani Moncayo wrote: > >> > Regarding bug#10906, I think `c-mark-function' should be rewritten > >> > to follow the logic of `mark-defun'. > > Any chance of a quick summary of how c-mark-function differs from > > mark-defun? > AFAIK, they differ at least in two things: > 1. `mark-defun' saves the original point location in the mark ring, > whereas `c-mark-function' does not. IMO, the point should be saved, > because in large defuns it may jump to a remote location and you may > want to return back to the original position. This bug report is > about this inconsistency, as you can see in the original post. > 2. Successive interactive invocations of `mark-defun' extend the > region to the next defuns (which I find useful), whereas > `c-mark-function' does not have this feature. Bug #5525 is a request > to remove this inconsistency, as you can see in the corresponding > thread. > >> Agreed, and BTW, if `c-mark-function' is going to be revised, please, > >> take also this problem into account: > >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5525 Here is a patch which should fix these problems. The logic around transient-mark-mode is somewhat complicated, so I would be grateful if you would check the patch does the Right Thing. I haven't amended the doc string yet. Thanks! diff -r f6961b0b1c51 cc-cmds.el --- a/cc-cmds.el Fri Mar 02 21:25:40 2012 +0000 +++ b/cc-cmds.el Mon Mar 05 18:35:18 2012 +0000 @@ -1966,8 +1966,20 @@ (if (not decl-limits) (error "Cannot find any declaration") - (goto-char (car decl-limits)) - (push-mark (cdr decl-limits) nil t)))) + (let* ((extend-region-p + (or (and (eq this-command 'c-mark-function) + (eq last-command 'c-mark-function)))) + (push-mark-p (and (eq this-command 'c-mark-function) + (not extend-region-p) + (not (and transient-mark-mode mark-active))))) + (if push-mark-p (push-mark (point))) + (if extend-region-p + (progn + (exchange-point-and-mark) + (goto-char (cdr (c-declaration-limits t))) + (exchange-point-and-mark)) + (goto-char (car decl-limits)) + (push-mark (cdr decl-limits) nil t)))))) (defun c-cpp-define-name () "Return the name of the current CPP macro, or NIL if we're not in one." > -- > Dani Moncayo -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 05 17:38:06 2012 Received: (at 10906) by debbugs.gnu.org; 5 Mar 2012 22:38:06 +0000 Received: from localhost ([127.0.0.1]:34919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4gXY-0000Mk-Iv for submit@debbugs.gnu.org; Mon, 05 Mar 2012 17:38:06 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:44295) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S4gXH-0000MJ-Jo for 10906@debbugs.gnu.org; Mon, 05 Mar 2012 17:37:49 -0500 Received: by obbta4 with SMTP id ta4so2518892obb.3 for <10906@debbugs.gnu.org>; Mon, 05 Mar 2012 14:36:53 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.60.5.231 as permitted sender) client-ip=10.60.5.231; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.60.5.231 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.60.5.231]) by 10.60.5.231 with SMTP id v7mr9988572oev.50.1330987013166 (num_hops = 1); Mon, 05 Mar 2012 14:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=vlGzOtONNMBFl+LNiPQnEnzhuDIj72P7iptoeRHR904=; b=U7TD934vQd5b8H8XdpHLLVYMOUw/7cEbifInwbQQCUx7zDMRZzEzppqgcVwIuqXY5e r8cAIOi7/DS3u9eM6sXTFhPo5ZuxpSlYWNwmgvX/2nf2eVUZS2rOTeszjMurgFoGBiLC MMGdWyRzaW7SFbFESYpaU9rIVvj1yePBY+DDWP8hIwYG1fYdZLh8lakIbWn8YTxVEnwk O2NC2HA11VQ+43HuKQCynWperucZuAjL7QdUvywl0/ESQvLPcI2yrtyUbUbrnCpJlA8q VcrorKT1X0YJ7CG9G34AKmzux1MNDIyAKuqV2A6h8p+Nww+Q8Sd317ZFZZIfB285U9a1 VmoA== MIME-Version: 1.0 Received: by 10.60.5.231 with SMTP id v7mr8661392oev.50.1330987013014; Mon, 05 Mar 2012 14:36:53 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 5 Mar 2012 14:36:52 -0800 (PST) In-Reply-To: <20120305184133.GC2824@acm.acm> References: <20120301212404.GB19099@acm.acm> <20120305184133.GC2824@acm.acm> Date: Mon, 5 Mar 2012 23:36:52 +0100 Message-ID: Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well From: Dani Moncayo To: Alan Mackenzie Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Mon, Mar 5, 2012 at 19:41, Alan Mackenzie wrote: >> > Any chance of a quick summary of how c-mark-function differs from >> > mark-defun? > >> AFAIK, they differ at least in two things: > >> 1. `mark-defun' saves the original point location in the mark ring, >> whereas `c-mark-function' does not. =A0IMO, the point should be saved, >> because in large defuns it may jump to a remote location and you may >> want to return back to the original position. =A0This bug report is >> about this inconsistency, as you can see in the original post. > >> 2. Successive interactive invocations of `mark-defun' extend the >> region to the next defuns (which I find useful), whereas >> `c-mark-function' does not have this feature. =A0Bug #5525 is a request >> to remove this inconsistency, as you can see in the corresponding >> thread. > >> >> Agreed, and BTW, if `c-mark-function' is going to be revised, please, >> >> take also this problem into account: > >> >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5525 > > Here is a patch which should fix these problems. =A0The logic around > transient-mark-mode is somewhat complicated, so I would be grateful if > you would check the patch does the Right Thing. =A0I haven't amended the > doc string yet. =A0Thanks! Thank you. I've tried your patch, and it seems to work[*], at least with my usage pattern, i.e., with `transient-mark-mode' enabled. [*] Except for one thing: - If you do `C-M-h' several times in a row until the mark reaches the end of the file, the point ends up at the end of the region, and the mark at the beginning (which doesn't seem right). - If you try the same experiment with `mark-defun', the mark stays at the end and the point at the start of the region (as expected). --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 16:11:35 2012 Received: (at 10906) by debbugs.gnu.org; 7 Mar 2012 21:11:35 +0000 Received: from localhost ([127.0.0.1]:37994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5O90-0003Ac-Om for submit@debbugs.gnu.org; Wed, 07 Mar 2012 16:11:35 -0500 Received: from colin.muc.de ([193.149.48.1]:18269 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5O8o-0003AF-18 for 10906@debbugs.gnu.org; Wed, 07 Mar 2012 16:11:23 -0500 Received: (qmail 8030 invoked by uid 3782); 7 Mar 2012 21:10:19 -0000 Received: from acm.muc.de (pD951AE67.dip.t-dialin.net [217.81.174.103]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 07 Mar 2012 22:10:17 +0100 Received: (qmail 4061 invoked by uid 1000); 7 Mar 2012 21:09:29 -0000 Date: Wed, 7 Mar 2012 21:09:29 +0000 To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well Message-ID: <20120307210929.GA2486@acm.acm> References: <20120301212404.GB19099@acm.acm> <20120305184133.GC2824@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Hello, Dani. On Mon, Mar 05, 2012 at 11:36:52PM +0100, Dani Moncayo wrote: > On Mon, Mar 5, 2012 at 19:41, Alan Mackenzie wrote: > > Here is a patch which should fix these problems.  The logic around > > transient-mark-mode is somewhat complicated, so I would be grateful if > > you would check the patch does the Right Thing.  I haven't amended the > > doc string yet.  Thanks! > Thank you. > I've tried your patch, and it seems to work[*], at least with my usage > pattern, i.e., with `transient-mark-mode' enabled. > [*] Except for one thing: > - If you do `C-M-h' several times in a row until the mark reaches the > end of the file, the point ends up at the end of the region, and the > mark at the beginning (which doesn't seem right). > - If you try the same experiment with `mark-defun', the mark stays at > the end and the point at the start of the region (as expected). Thanks for spotting that. Here's a revised patch. I think it'll work this time. diff -r f6961b0b1c51 cc-cmds.el --- a/cc-cmds.el Fri Mar 02 21:25:40 2012 +0000 +++ b/cc-cmds.el Wed Mar 07 21:06:31 2012 +0000 @@ -1950,7 +1950,12 @@ (defun c-mark-function () "Put mark at end of the current top-level declaration or macro, point at beginning. -If point is not inside any then the closest following one is chosen. +If point is not inside any then the closest following one is +chosen. Each successive call of this command extends the marked +region by one function. + +A mark is left where the command started, unless the region is already active +\(in Transient Mark mode). As opposed to \\[c-beginning-of-defun] and \\[c-end-of-defun], this function does not require the declaration to contain a brace block." @@ -1966,8 +1971,24 @@ (if (not decl-limits) (error "Cannot find any declaration") - (goto-char (car decl-limits)) - (push-mark (cdr decl-limits) nil t)))) + (let* ((extend-region-p + (or (and (eq this-command 'c-mark-function) + (eq last-command 'c-mark-function)))) + (push-mark-p (and (eq this-command 'c-mark-function) + (not extend-region-p) + (not (and transient-mark-mode mark-active))))) + (if push-mark-p (push-mark (point))) + (if extend-region-p + (progn + (exchange-point-and-mark) + (setq decl-limits (c-declaration-limits t)) + (when (not decl-limits) + (exchange-point-and-mark) + (error "Cannot find any declaration")) + (goto-char (cdr decl-limits)) + (exchange-point-and-mark)) + (goto-char (car decl-limits)) + (push-mark (cdr decl-limits) nil t)))))) (defun c-cpp-define-name () "Return the name of the current CPP macro, or NIL if we're not in one." > -- > Dani Moncayo -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 16:38:34 2012 Received: (at 10906) by debbugs.gnu.org; 7 Mar 2012 21:38:34 +0000 Received: from localhost ([127.0.0.1]:38013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5OZ3-0003o0-Hd for submit@debbugs.gnu.org; Wed, 07 Mar 2012 16:38:34 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:38437) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5OYm-0003n2-Hx for 10906@debbugs.gnu.org; Wed, 07 Mar 2012 16:38:18 -0500 Received: by obbta4 with SMTP id ta4so5231441obb.3 for <10906@debbugs.gnu.org>; Wed, 07 Mar 2012 13:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=bJDrJVn3p1gidxmBVDjUNhx2SSQCq4qZth2jbZe+T0g=; b=zc9QBSpS6BjelYEuB70mZgAjmZj4aYtLuzEbsPjz87zpiVhC8Kdes275HGrezeBVVG OF15IY+DBB79i/fbj/ekcVU3sVWB4soJLINc8V72Y3w6uenMx8Z8bZA5EzE8beeiiGjG WL4fnOc0OJWoyeRl67lGugcsy8JkJkBjN2caSZ0ei3GsMxvoC31NAgMgOMQ9W4IKOgP7 R5drPO71xRCQHJnXhIO04MILnLxJ0PoIJLXS+JBtAnX2Vc7Nd9RGrAZcwOY7vjlZHORh rMjZ1gjlKCu6veSsBrTfQgP7ZDQc1FtITdY+hRBDoDXVSHl5SPJw2bW1lnvFxFO2nYil tO/g== MIME-Version: 1.0 Received: by 10.182.119.101 with SMTP id kt5mr1361553obb.70.1331156231010; Wed, 07 Mar 2012 13:37:11 -0800 (PST) Received: by 10.60.42.193 with HTTP; Wed, 7 Mar 2012 13:37:10 -0800 (PST) In-Reply-To: <20120307210929.GA2486@acm.acm> References: <20120301212404.GB19099@acm.acm> <20120305184133.GC2824@acm.acm> <20120307210929.GA2486@acm.acm> Date: Wed, 7 Mar 2012 22:37:10 +0100 Message-ID: Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well From: Dani Moncayo To: Alan Mackenzie Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Here's a revised patch. =A0I think it'll work this time. It works, thank you. BTW, I have a question (I've still a beginner on elisp): What's the point of the "or" form here? > + =A0 =A0 =A0 =A0 =A0 =A0 (or (and (eq this-command 'c-mark-function) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(eq last-command 'c-mark-fun= ction)))) It has a single argument, so that it would be equivalent to get rid of it, like this: > + =A0 =A0 =A0 =A0 =A0 =A0 (and (eq this-command 'c-mark-function) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(eq last-command 'c-mark-fun= ction))) ?? --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 08 06:53:47 2012 Received: (at 10906-done) by debbugs.gnu.org; 8 Mar 2012 11:53:47 +0000 Received: from localhost ([127.0.0.1]:38759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5buk-0006kZ-Da for submit@debbugs.gnu.org; Thu, 08 Mar 2012 06:53:47 -0500 Received: from colin.muc.de ([193.149.48.1]:34288 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S5buX-0006kB-Jv for 10906-done@debbugs.gnu.org; Thu, 08 Mar 2012 06:53:34 -0500 Received: (qmail 97928 invoked by uid 3782); 8 Mar 2012 11:52:28 -0000 Received: from acm.muc.de (pD955631B.dip.t-dialin.net [217.85.99.27]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 08 Mar 2012 12:52:25 +0100 Received: (qmail 2948 invoked by uid 1000); 8 Mar 2012 11:51:36 -0000 Date: Thu, 8 Mar 2012 11:51:36 +0000 To: 10906-done@debbugs.gnu.org Subject: Re: Bug #10906 - `c-mark-function' does set the mark well. Message-ID: <20120308115136.GB2618@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 10906-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.4 (/) Bug fixed - Revision #107534. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 09 11:51:26 2012 Received: (at 10906) by debbugs.gnu.org; 9 Mar 2012 16:51:27 +0000 Received: from localhost ([127.0.0.1]:40749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S632M-0008HW-Iu for submit@debbugs.gnu.org; Fri, 09 Mar 2012 11:51:26 -0500 Received: from colin.muc.de ([193.149.48.1]:49694 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S632J-0008HN-UW for 10906@debbugs.gnu.org; Fri, 09 Mar 2012 11:51:25 -0500 Received: (qmail 81400 invoked by uid 3782); 9 Mar 2012 16:50:26 -0000 Received: from acm.muc.de (pD951A7C6.dip.t-dialin.net [217.81.167.198]) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 09 Mar 2012 17:50:22 +0100 Received: (qmail 4314 invoked by uid 1000); 9 Mar 2012 16:49:32 -0000 Date: Fri, 9 Mar 2012 16:49:32 +0000 To: Dani Moncayo Subject: Re: bug#10906: 24.0.94; `c-mark-function' does set the mark well Message-ID: <20120309164931.GA3748@acm.acm> References: <20120301212404.GB19099@acm.acm> <20120305184133.GC2824@acm.acm> <20120307210929.GA2486@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10906 Cc: Juri Linkov , 10906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Hello, Dani. On Wed, Mar 07, 2012 at 10:37:10PM +0100, Dani Moncayo wrote: > > Here's a revised patch.  I think it'll work this time. > It works, thank you. I've committed a patch for this into savannah. > BTW, I have a question (I've still a beginner on elisp): What's the > point of the "or" form here? > > +             (or (and (eq this-command 'c-mark-function) > > +                      (eq last-command 'c-mark-function)))) > It has a single argument, so that it would be equivalent to get rid of > it, like this: > > +             (and (eq this-command 'c-mark-function) > > +                      (eq last-command 'c-mark-function))) Yes! That was a coding mistake, thanks for picking it up. > ?? > -- > Dani Moncayo -- Alan Mackenzie (Nuremberg, Germany). From unknown Fri Aug 15 18:11:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Apr 2012 11:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator