From unknown Fri Sep 19 23:36:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10894 <10894@debbugs.gnu.org> To: bug#10894 <10894@debbugs.gnu.org> Subject: Status: Mixed C-Vala projects distcheck is broken Reply-To: bug#10894 <10894@debbugs.gnu.org> Date: Sat, 20 Sep 2025 06:36:09 +0000 retitle 10894 Mixed C-Vala projects distcheck is broken reassign 10894 automake submitter 10894 Quentin Glidic severity 10894 normal tag 10894 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 26 18:18:00 2012 Received: (at submit) by debbugs.gnu.org; 26 Feb 2012 23:18:00 +0000 Received: from localhost ([127.0.0.1]:58631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1nLr-0008Bq-HT for submit@debbugs.gnu.org; Sun, 26 Feb 2012 18:18:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60333) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1lzQ-0006EC-8t for submit@debbugs.gnu.org; Sun, 26 Feb 2012 16:50:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1lwh-0006lT-M9 for submit@debbugs.gnu.org; Sun, 26 Feb 2012 16:47:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00,RCVD_IN_PSBL autolearn=no version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:39900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1lwh-0006lP-Id for submit@debbugs.gnu.org; Sun, 26 Feb 2012 16:47:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1lwg-0004sO-Dp for bug-automake@gnu.org; Sun, 26 Feb 2012 16:47:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1lwf-0006lC-0o for bug-automake@gnu.org; Sun, 26 Feb 2012 16:47:54 -0500 Received: from 89-158-192-88.rev.dartybox.com ([89.158.192.88]:42185 helo=mail.sardemff7.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1lwe-0006kj-Ps for bug-automake@gnu.org; Sun, 26 Feb 2012 16:47:52 -0500 Received: from lizzy.sardemff7.net (lizzy.wlan [192.168.77.50]) by mail.sardemff7.net (Postfix) with ESMTPSA id AD6005A8901 for ; Sun, 26 Feb 2012 21:11:15 +0000 (UTC) Message-ID: <4F4AA052.8010708@sardemff7.net> Date: Sun, 26 Feb 2012 22:12:50 +0100 From: Quentin Glidic User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120223 Thunderbird/13.0a1 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: Mixed C-Vala projects distcheck is broken Content-Type: multipart/mixed; boundary="------------040105010509020808010703" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 26 Feb 2012 18:17:56 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) This is a multi-part message in MIME format. --------------040105010509020808010703 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Package: automake Version: 1.11.3 Hello, The distcheck of a project which mix C and Vala targets in the same=20 Makefile.am leads to a pass of C targets to valac, which is completely=20 wrong and fails if you put your headers in _SOURCES (valac ignores *.c=20 files only). Attached a patch that limits the vala stamps=E2=80=99 generation to targe= ts with=20 *.vala file. --=20 Quentin "Sardem FF7" Glidic --------------040105010509020808010703 Content-Type: text/x-patch; name="0001-vala-Fix-mixed-C-Vala-projects-distcheck.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-vala-Fix-mixed-C-Vala-projects-distcheck.patch" >From 98104788ad0b444e69fb4403cd7ad7c7780ca9ba Mon Sep 17 00:00:00 2001 From: Quentin Glidic Date: Sat, 4 Feb 2012 11:00:10 +0100 Subject: [PATCH] vala: Fix mixed C/Vala projects distcheck --- automake.in | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/automake.in b/automake.in index 69b6010..f354068 100644 --- a/automake.in +++ b/automake.in @@ -6038,12 +6038,13 @@ sub lang_vala_finish_target ($$) my $derived = canonicalize ($name); my $varname = $derived . '_SOURCES'; my $var = var ($varname); + my $vala_output_rules = ''; if ($var) { foreach my $file ($var->value_as_list_recursive) { - $output_rules .= "\$(srcdir)/$file: \$(srcdir)/${derived}_vala.stamp\n" + $vala_output_rules .= "\$(srcdir)/$file: \$(srcdir)/${derived}_vala.stamp\n" . "\t\@if test -f \$@; then :; else rm -f \$(srcdir)/${derived}_vala.stamp; fi\n" . "\t\@if test -f \$@; then :; else \\\n" . "\t \$(MAKE) \$(AM_MAKEFLAGS) \$(srcdir)/${derived}_vala.stamp; \\\n" @@ -6051,6 +6052,11 @@ sub lang_vala_finish_target ($$) if $file =~ s/(.*)\.vala$/$1.c/; } } + if ($vala_output_rules eq '') + { + return; + } + $output_rules .= $vala_output_rules; # Add rebuild rules for generated header and vapi files my $flags = var ($derived . '_VALAFLAGS'); -- 1.7.8.1 --------------040105010509020808010703-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 16:36:44 2012 Received: (at 10894) by debbugs.gnu.org; 27 Feb 2012 21:36:44 +0000 Received: from localhost ([127.0.0.1]:60257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S28FK-0001ev-Cg for submit@debbugs.gnu.org; Mon, 27 Feb 2012 16:36:44 -0500 Received: from mail-ey0-f172.google.com ([209.85.215.172]:38905) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S28F2-0001eP-0v for 10894@debbugs.gnu.org; Mon, 27 Feb 2012 16:36:27 -0500 Received: by eaal12 with SMTP id l12so3213418eaa.3 for <10894@debbugs.gnu.org>; Mon, 27 Feb 2012 13:33:11 -0800 (PST) Received-SPF: pass (google.com: domain of stefano.lattarini@gmail.com designates 10.14.100.142 as permitted sender) client-ip=10.14.100.142; Authentication-Results: mr.google.com; spf=pass (google.com: domain of stefano.lattarini@gmail.com designates 10.14.100.142 as permitted sender) smtp.mail=stefano.lattarini@gmail.com; dkim=pass header.i=stefano.lattarini@gmail.com Received: from mr.google.com ([10.14.100.142]) by 10.14.100.142 with SMTP id z14mr9355841eef.58.1330378391308 (num_hops = 1); Mon, 27 Feb 2012 13:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=Q1+btob6bEt7jsrUNqtjQTO4vSlanfIhSyfXa0Pxl1c=; b=gHJ3r4r/AU6lfWRq2kUGPjFDI3QIydhXke1AwTPEj6ZB/4L1RFyXVNjNZUF3cHuZVG bUkWQ+g/sTgdjj0YUqPtkPx+R8JegKEQish7X7x3fZ1WSqkxp/NPkj7PSFPdioDw2O+n 2E/an/Kfa/bHEBd12QGgZ4I5WhI6GrG7PTrSw= Received: by 10.14.100.142 with SMTP id z14mr6995034eef.58.1330378391213; Mon, 27 Feb 2012 13:33:11 -0800 (PST) Received: from [79.21.97.71] (host71-97-dynamic.21-79-r.retail.telecomitalia.it. [79.21.97.71]) by mx.google.com with ESMTPS id y14sm62241935eef.10.2012.02.27.13.33.08 (version=SSLv3 cipher=OTHER); Mon, 27 Feb 2012 13:33:09 -0800 (PST) Message-ID: <4F4BF691.6070907@gmail.com> Date: Mon, 27 Feb 2012 22:33:05 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Quentin Glidic Subject: Re: bug#10894: Mixed C-Vala projects distcheck is broken References: <4F4AA052.8010708@sardemff7.net> In-Reply-To: <4F4AA052.8010708@sardemff7.net> Content-Type: multipart/mixed; boundary="------------060700090506030702090600" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10894 Cc: 10894@debbugs.gnu.org, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------060700090506030702090600 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Quentin, thanks for the report. On 02/26/2012 10:12 PM, Quentin Glidic wrote: > Package: automake > Version: 1.11.3 > > Hello, > > The distcheck of a project which mix C and Vala targets in the same Makefile.am > leads to a pass of C targets to valac, which is completely wrong and fails if > you put your headers in _SOURCES (valac ignores *.c files only). > This is bad. We had a test in the automake testsuite that tried to build a project with mixed C/Vala sources, but it didn't use a C header as well :-( I've thus added a new test case that exposes the bug (see the first attached patch). > Attached a patch that limits the vala stamps’ generation to targets with > *.vala file. > Unfortunately, your patch doesn't seem to fix the issue. I've attached a second patch that seems to do the trick. It will appear in the next automake version (1.12) unless there are objections. Thanks, Stefano --------------060700090506030702090600 Content-Type: text/x-diff; name="0001-vala-expose-automake-bug-10894.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-vala-expose-automake-bug-10894.patch" >From 7d335efe6f874af817c2f29ef85a803d8db8a43a Mon Sep 17 00:00:00 2001 Message-Id: <7d335efe6f874af817c2f29ef85a803d8db8a43a.1330378365.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Mon, 27 Feb 2012 21:16:22 +0100 Subject: [PATCH 1/2] vala: expose automake bug#10894 * tests/vala-mix2.test: New test. * tests/list-of-tests.mk: Add it. * tests/Makefile.am (XFAIL_TESTS): Likewise. * THANKS: Update. --- THANKS | 1 + tests/Makefile.am | 1 + tests/list-of-tests.mk | 1 + tests/vala-mix2.test | 121 ++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 124 insertions(+), 0 deletions(-) create mode 100755 tests/vala-mix2.test diff --git a/THANKS b/THANKS index b512b6b..d54e9d4 100644 --- a/THANKS +++ b/THANKS @@ -264,6 +264,7 @@ Olivier Louchart-Fletcher olivier@zipworld.com.au Olly Betts olly@muscat.co.uk Oren Ben-Kiki oren@ben-kiki.org Owen Taylor otaylor@redhat.com +Quentin Glidic sardemff7+gnu@sardemff7.net Patrick Welche prlw1@newn.cam.ac.uk Patrik Weiskircher me@justp.at Paul Berrevoets paul@swi.com diff --git a/tests/Makefile.am b/tests/Makefile.am index eab45dc..8fd33f4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -30,6 +30,7 @@ pr8365-remake-timing.test \ lex-subobj-nodep.test \ remake-am-pr10111.test \ remake-m4-pr10111.test \ +vala-mix2.test \ txinfo5.test include $(srcdir)/parallel-tests.am diff --git a/tests/list-of-tests.mk b/tests/list-of-tests.mk index bc64d61..2b73de2 100644 --- a/tests/list-of-tests.mk +++ b/tests/list-of-tests.mk @@ -885,6 +885,7 @@ vala4.test \ vala5.test \ vala-vpath.test \ vala-mix.test \ +vala-mix2.test \ vars.test \ vars3.test \ vartar.test \ diff --git a/tests/vala-mix2.test b/tests/vala-mix2.test new file mode 100755 index 0000000..88d2818 --- /dev/null +++ b/tests/vala-mix2.test @@ -0,0 +1,121 @@ +#! /bin/sh +# Copyright (C) 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Vala sources, C and C++ sources and C and C++ headers in the same +# program. Functional test. See automake bug#10894. + +required='valac cc c++ GNUmake' +. ./defs || Exit 1 + +set -e + +cat >> configure.in <<'END' +AC_PROG_CC +AC_PROG_CXX +AM_PROG_VALAC +AC_OUTPUT +END + +cat > Makefile.am <<'END' +bin_PROGRAMS = zardoz +AM_VALAFLAGS = --profile=posix +zardoz_SOURCES = zardoz.vala foo.h bar.c baz.c zen.hh master.cxx +END + +cat > zardoz.vala <<'END' +int main () +{ + stdout.printf ("foo is alive\n"); + return 0; +} +END + +cat > foo.h <<'END' +int foo; +int bar (void); +int baz (void); +END + +cat > bar.c <<'END' +#include "foo.h" +int bar (void) { return foo + baz (); } +END + +cat > baz.c <<'END' +#include "foo.h" +extern int foo = 0; +int baz (void) { return 0; } +END + +cat > zen.hh <<'END' +#include +END + +cat > master.cxx <<'END' +#include "zen.hh" +void chatty (void) { std::cout << "Hello, stranger!\n"; } +END + +$ACLOCAL +$AUTOMAKE -a +$AUTOCONF + +./configure + +$MAKE all +ls -l # For debugging. + +have_generated_files () +{ + test -f zardoz_vala.stamp + test -f zardoz.c +} + +# Our vala-related rules must create stamp files and intermediate +# C files. +have_generated_files + +# Remake rules are not uselessly triggered. +$MAKE -q +$MAKE -n | $FGREP vala.stamp && Exit 1 + +# But are triggered when they should. +for file in zardoz.vala foo.h bar.c baz.c zen.hh master.cxx; do + $sleep + echo '& choke me !' >> $file + $MAKE && Exit 1 + $sleep + sed '$d' $file > t + mv -f t $file + $MAKE +done + +# Check the distribution. +$MAKE distcheck + +# Stamp files and intermediate C files should *not* be removed +# by "make clean". +$MAKE clean +ls -l # For debugging. +have_generated_files + +# But stamp files should be removed by "maintainer-clean" (the +# behaviour w.r.t. intermediate C files is still unclear, and +# better left undefined for the moment). +$MAKE maintainer-clean +ls *vala*.stamp | grep . && Exit 1 + +: -- 1.7.9 --------------060700090506030702090600 Content-Type: text/x-diff; name="0002-vala-fix-valac-calls-for-projects-with-mixed-Vala-C.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0002-vala-fix-valac-calls-for-projects-with-mixed-Vala-C.pat"; filename*1="ch" >From 51f61dfb1e861062aaa1d73fab71278c85fe0594 Mon Sep 17 00:00:00 2001 Message-Id: <51f61dfb1e861062aaa1d73fab71278c85fe0594.1330378365.git.stefano.lattarini@gmail.com> In-Reply-To: <7d335efe6f874af817c2f29ef85a803d8db8a43a.1330378365.git.stefano.lattarini@gmail.com> References: <7d335efe6f874af817c2f29ef85a803d8db8a43a.1330378365.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Mon, 27 Feb 2012 21:48:03 +0100 Subject: [PATCH 2/2] vala: fix 'valac' calls for projects with mixed Vala/C Fixes automake bug#10894. * automake.in (lang_vala_finish_target): Strip non-vala files from the dependencies of vala stamps, and from the invocation of valac compiler. Related refactorings. * tests/Makefile.am (XFAIL_TESTS): Remove 'vala-mix2.test'. --- automake.in | 27 +++++++++++++-------------- tests/Makefile.am | 1 - 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/automake.in b/automake.in index cdbb820..5ae151b 100644 --- a/automake.in +++ b/automake.in @@ -6014,20 +6014,19 @@ sub lang_vala_finish_target ($$) my ($self, $name) = @_; my $derived = canonicalize ($name); - my $varname = $derived . '_SOURCES'; - my $var = var ($varname); + my $var = var "${derived}_SOURCES"; + return unless $var; - if ($var) + my @vala_sources = grep { /\.vala$/ } ($var->value_as_list_recursive); + + foreach my $vala_file (@vala_sources) { - foreach my $file ($var->value_as_list_recursive) - { - $output_rules .= "\$(srcdir)/$file: \$(srcdir)/${derived}_vala.stamp\n" - . "\t\@if test -f \$@; then :; else rm -f \$(srcdir)/${derived}_vala.stamp; fi\n" - . "\t\@if test -f \$@; then :; else \\\n" - . "\t \$(MAKE) \$(AM_MAKEFLAGS) \$(srcdir)/${derived}_vala.stamp; \\\n" - . "\tfi\n" - if $file =~ s/(.*)\.vala$/$1.c/; - } + (my $c_file = $vala_file) =~ s/(.*)\.vala$/$1.c/; + $output_rules .= "\$(srcdir)/$c_file: \$(srcdir)/${derived}_vala.stamp\n" + . "\t\@if test -f \$@; then :; else rm -f \$(srcdir)/${derived}_vala.stamp; fi\n" + . "\t\@if test -f \$@; then :; else \\\n" + . "\t \$(MAKE) \$(AM_MAKEFLAGS) \$(srcdir)/${derived}_vala.stamp; \\\n" + . "\tfi\n" } # Add rebuild rules for generated header and vapi files @@ -6077,7 +6076,7 @@ sub lang_vala_finish_target ($$) my $silent = silent_flag (); $output_rules .= - "\$(srcdir)/${derived}_vala.stamp: \$(${derived}_SOURCES)\n". + "\$(srcdir)/${derived}_vala.stamp: @vala_sources\n". # Since the C files generated from the vala sources depend on the # ${derived}_vala.stamp file, we must ensure its timestamp is older than # those of the C files generated by the valac invocation below (this is @@ -6085,7 +6084,7 @@ sub lang_vala_finish_target ($$) # Thus we need to create the stamp file *before* invoking valac, and to # move it to its final location only after valac has been invoked. "\t${silent}rm -f \$\@ && echo stamp > \$\@-t\n". - "\t${verbose}\$(am__cd) \$(srcdir) && ${compile} \$(${derived}_SOURCES)\n". + "\t${verbose}\$(am__cd) \$(srcdir) && $compile @vala_sources\n". "\t${silent}mv -f \$\@-t \$\@\n"; push_dist_common ("${derived}_vala.stamp"); diff --git a/tests/Makefile.am b/tests/Makefile.am index 8fd33f4..eab45dc 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -30,7 +30,6 @@ pr8365-remake-timing.test \ lex-subobj-nodep.test \ remake-am-pr10111.test \ remake-m4-pr10111.test \ -vala-mix2.test \ txinfo5.test include $(srcdir)/parallel-tests.am -- 1.7.9 --------------060700090506030702090600-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 29 13:54:34 2012 Received: (at 10894) by debbugs.gnu.org; 29 Feb 2012 18:54:34 +0000 Received: from localhost ([127.0.0.1]:56368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2ofV-0006j5-21 for submit@debbugs.gnu.org; Wed, 29 Feb 2012 13:54:34 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:48269) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S2ofD-0006iD-H9; Wed, 29 Feb 2012 13:54:18 -0500 Received: by werb10 with SMTP id b10so2638296wer.3 for ; Wed, 29 Feb 2012 10:53:50 -0800 (PST) Received-SPF: pass (google.com: domain of stefano.lattarini@gmail.com designates 10.216.134.74 as permitted sender) client-ip=10.216.134.74; Authentication-Results: mr.google.com; spf=pass (google.com: domain of stefano.lattarini@gmail.com designates 10.216.134.74 as permitted sender) smtp.mail=stefano.lattarini@gmail.com; dkim=pass header.i=stefano.lattarini@gmail.com Received: from mr.google.com ([10.216.134.74]) by 10.216.134.74 with SMTP id r52mr840596wei.19.1330541630529 (num_hops = 1); Wed, 29 Feb 2012 10:53:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=g21lD6CimAUPdlul5EXXaKrC4GQD/VeSIMN3h/hrH4A=; b=SPYAJ0y5y5YSLeN/sCT36OrahNXO0bW0cM7YAX5Pnz9ZSp5rRCynxDzBWiWYFSaMDN E/HepABiPEbBfg0gBTGSgU4kRSAF8vOxunAHpGDfxMvOHKIHX0MHMz/vMr0FlUAo0ohb YuUuhFIFcKWQ/9NdVG4c4iwHh748xJs/KfWhU= Received: by 10.216.134.74 with SMTP id r52mr678784wei.19.1330541630454; Wed, 29 Feb 2012 10:53:50 -0800 (PST) Received: from [87.13.10.92] (host92-10-dynamic.13-87-r.retail.telecomitalia.it. [87.13.10.92]) by mx.google.com with ESMTPS id s4sm83691207wiy.5.2012.02.29.10.53.48 (version=SSLv3 cipher=OTHER); Wed, 29 Feb 2012 10:53:49 -0800 (PST) Message-ID: <4F4E743A.7070501@gmail.com> Date: Wed, 29 Feb 2012 19:53:46 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Quentin Glidic Subject: Re: bug#10894: Mixed C-Vala projects distcheck is broken References: <4F4AA052.8010708@sardemff7.net> <4F4BF691.6070907@gmail.com> In-Reply-To: <4F4BF691.6070907@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10894 Cc: 10894@debbugs.gnu.org, automake-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 10894 patch close 10894 thanks On 02/27/2012 10:33 PM, Stefano Lattarini wrote: > [PATCH 1/2] vala: expose automake bug#10894 > > * tests/vala-mix2.test: New test. > * tests/list-of-tests.mk: Add it. > * tests/Makefile.am (XFAIL_TESTS): Likewise. > * THANKS: Update. > [PATCH 2/2] vala: fix 'valac' calls for projects with mixed Vala/C > > Fixes automake bug#10894. > > * automake.in (lang_vala_finish_target): Strip non-vala files > from the dependencies of vala stamps, and from the invocation > of valac compiler. Related refactorings. > * tests/Makefile.am (XFAIL_TESTS): Remove 'vala-mix2.test'. I've pushed these patches to maint, and merged maint into master. I'm thus closing this bug report. Regards, Stefano From unknown Fri Sep 19 23:36:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Mar 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator