From unknown Mon Aug 18 04:42:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10891: bug fix lisp/url/url-http.el Resent-From: Devon Sean McCullough Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Feb 2012 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 10891@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13302793394012 (code B ref -1); Sun, 26 Feb 2012 18:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Feb 2012 18:02:19 +0000 Received: from localhost ([127.0.0.1]:58512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1iQN-00012f-1x for submit@debbugs.gnu.org; Sun, 26 Feb 2012 13:02:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57874) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1hpG-00008E-Mt for submit@debbugs.gnu.org; Sun, 26 Feb 2012 12:23:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1hmY-0001ac-Tg for submit@debbugs.gnu.org; Sun, 26 Feb 2012 12:21:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00,RCVD_IN_PSBL autolearn=no version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:52382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1hmY-0001aY-Q0 for submit@debbugs.gnu.org; Sun, 26 Feb 2012 12:21:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1hmX-0008B3-HI for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 12:21:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1hmW-0001aL-9A for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 12:21:09 -0500 Received: from gateway15.websitewelcome.com ([67.18.72.137]:41487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1hmW-0001Zo-4R for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 12:21:08 -0500 Received: by gateway15.websitewelcome.com (Postfix, from userid 5007) id 2CF92CBBE06D7; Sun, 26 Feb 2012 11:21:05 -0600 (CST) Received: from leaf.websitewelcome.com (leaf.websitewelcome.com [174.121.85.66]) by gateway15.websitewelcome.com (Postfix) with ESMTP id 2303FCBBE06B7 for ; Sun, 26 Feb 2012 11:21:05 -0600 (CST) Received: from [173.66.178.127] (port=56810 helo=ra.home) by leaf.websitewelcome.com with esmtps (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1S1hmS-0007cY-RM for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 11:21:05 -0600 From: Devon Sean McCullough Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Sun, 26 Feb 2012 12:21:04 -0500 Message-Id: <31A11F9D-C4A8-4CD7-9081-EBCCE143744F@jovi.net> Mime-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: pool-173-66-178-127.washdc.fios.verizon.net (ra.home) [173.66.178.127]:56810 X-Source-Auth: jovinet X-Email-Count: 1 X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: (let ((url-gateway-unplugged t)) (url-retrieve-synchronously "http://gnu.org")) bombs Wrong type argument: processp, nil should be Could not create connection to gnu.org:80 [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Mailman-Approved-At: Sun, 26 Feb 2012 13:02:17 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: (let ((url-gateway-unplugged t)) (url-retrieve-synchronously "http://gnu.org")) bombs Wrong type argument: processp, nil should be Could not create connection to gnu.org:80 [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] (let ((url-gateway-unplugged t)) (url-retrieve-synchronously "http://gnu.org")) bombs Wrong type argument: processp, nil should be Could not create connection to gnu.org:80 Peace --Devon PS: Here's the fix --- url-http.el.~1~ 2010-04-03 18:26:11.000000000 -0400 +++ url-http.el 2012-02-26 10:53:27.000000000 -0500 @@ -119,9 +120,7 @@ (url-http-debug "Reusing existing connection: %s:%d" host port) (url-http-debug "Contacting host: %s:%d" host port)) (url-lazy-message "Contacting host: %s:%d" host port) - (url-http-mark-connection-as-busy - host port - (or found + (let ((conn (or found (let ((buf (generate-new-buffer " *url-http-temp*"))) ;; `url-open-stream' needs a buffer in which to do things ;; like authentication. But we use another buffer afterwards. @@ -132,7 +131,9 @@ ;; Drop the temp buffer link before killing the buffer. (set-process-buffer proc nil)) proc) - (kill-buffer buf))))))) + (kill-buffer buf)))))) + (and conn + (url-http-mark-connection-as-busy host port conn))))) ;; Building an HTTP request (defun url-http-user-agent-string () From unknown Mon Aug 18 04:42:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10891: bug fix lisp/url/url-http.el Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Mar 2012 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Devon Sean McCullough Cc: 10891@debbugs.gnu.org Received: via spool by 10891-submit@debbugs.gnu.org id=B10891.133146084428002 (code B ref 10891); Sun, 11 Mar 2012 10:15:01 +0000 Received: (at 10891) by debbugs.gnu.org; 11 Mar 2012 10:14:04 +0000 Received: from localhost ([127.0.0.1]:44488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6fmt-0007HY-HE for submit@debbugs.gnu.org; Sun, 11 Mar 2012 06:14:03 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36417) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6fmp-0007H0-ML for 10891@debbugs.gnu.org; Sun, 11 Mar 2012 06:14:01 -0400 Received: from bb116-14-103-36.singnet.com.sg ([116.14.103.36]:56995 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S6fK1-0003kP-Dm; Sun, 11 Mar 2012 05:44:14 -0400 From: Chong Yidong References: <31A11F9D-C4A8-4CD7-9081-EBCCE143744F@jovi.net> Date: Sun, 11 Mar 2012 17:44:05 +0800 In-Reply-To: <31A11F9D-C4A8-4CD7-9081-EBCCE143744F@jovi.net> (Devon Sean McCullough's message of "Sun, 26 Feb 2012 12:21:04 -0500") Message-ID: <87aa3n1nh6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Devon Sean McCullough writes: > (let ((url-gateway-unplugged t)) > (url-retrieve-synchronously "http://gnu.org")) > > bombs > Wrong type argument: processp, nil > > should be > Could not create connection to gnu.org:80 > > PS: Here's the fix Thanks. I've committed a slightly tweaked version of the fix to trunk. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 11 06:14:10 2012 Received: (at control) by debbugs.gnu.org; 11 Mar 2012 10:14:10 +0000 Received: from localhost ([127.0.0.1]:44491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6fn0-0007Hr-GN for submit@debbugs.gnu.org; Sun, 11 Mar 2012 06:14:10 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36419) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6fmz-0007Hl-B0 for control@debbugs.gnu.org; Sun, 11 Mar 2012 06:14:09 -0400 Received: from bb116-14-103-36.singnet.com.sg ([116.14.103.36]:56996 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S6fKC-00046S-5Q for control@debbugs.gnu.org; Sun, 11 Mar 2012 05:44:24 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 10891 Date: Sun, 11 Mar 2012 17:44:18 +0800 Message-ID: <871uoztqtp.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 10891 thanks