From unknown Fri Aug 15 14:18:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10887 <10887@debbugs.gnu.org> To: bug#10887 <10887@debbugs.gnu.org> Subject: Status: 24.0.93; lazy-highlighting in `query-replace' after a word-type Isearch Reply-To: bug#10887 <10887@debbugs.gnu.org> Date: Fri, 15 Aug 2025 21:18:07 +0000 retitle 10887 24.0.93; lazy-highlighting in `query-replace' after a word-ty= pe Isearch reassign 10887 emacs submitter 10887 Dani Moncayo severity 10887 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 26 05:06:43 2012 Received: (at submit) by debbugs.gnu.org; 26 Feb 2012 10:06:44 +0000 Received: from localhost ([127.0.0.1]:56810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1b07-00053W-I6 for submit@debbugs.gnu.org; Sun, 26 Feb 2012 05:06:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45684) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1b05-00053P-RM for submit@debbugs.gnu.org; Sun, 26 Feb 2012 05:06:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1axK-0004Zs-91 for submit@debbugs.gnu.org; Sun, 26 Feb 2012 05:03:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_PSBL,T_DKIM_INVALID autolearn=no version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:48725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1axK-0004Zm-4H for submit@debbugs.gnu.org; Sun, 26 Feb 2012 05:03:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1axE-0004II-8k for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 05:03:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1ax6-0004Xq-F2 for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 05:03:44 -0500 Received: from mail-tul01m020-f169.google.com ([209.85.214.169]:56449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1ax6-0004Xm-8s for bug-gnu-emacs@gnu.org; Sun, 26 Feb 2012 05:03:36 -0500 Received: by obbta7 with SMTP id ta7so5232349obb.0 for ; Sun, 26 Feb 2012 02:03:35 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.60.5.231 as permitted sender) client-ip=10.60.5.231; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.60.5.231 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.60.5.231]) by 10.60.5.231 with SMTP id v7mr353142oev.50.1330250615347 (num_hops = 1); Sun, 26 Feb 2012 02:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=yI9uhB0Mb5ashIKD4MpkNzNiFYY99PRE2hVnOGTySWM=; b=hvmJqP5rDYR1R+ManlZYimIsqK203ZQto565RdTjgrs79Qc0TiGxPYNmeRIZhN5QQT SV0E+p3WLndXiMFh+octwibgkGMCxgCV2D+D8LPrC7dQOsZrCA0NtMi/qA2jLdb2G9IM aGEW2cKf2QRQPGDzO5/pH4pKqB5PugEQ0FNtI= MIME-Version: 1.0 Received: by 10.60.5.231 with SMTP id v7mr324525oev.50.1330250615296; Sun, 26 Feb 2012 02:03:35 -0800 (PST) Received: by 10.60.42.193 with HTTP; Sun, 26 Feb 2012 02:03:35 -0800 (PST) Date: Sun, 26 Feb 2012 11:03:35 +0100 Message-ID: Subject: 24.0.93; lazy-highlighting in `query-replace' after a word-type Isearch From: Dani Moncayo To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Recipe from "emacs -Q": 1. aa bb RET RET aa RET bb RET 2. C-s M-s w aa bb RET 3. M-< 4. M-% aa bb RET xx RET I observe that the "aabb" part is lazy-highlighted, but obviously it should not be, because the query-replace will never get there (it's doing a normal search, not a word-type one). [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dmoncayo[at]gmail.com) 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Recipe from "emacs -Q": 1. aa bb RET RET aa RET bb RET 2. C-s M-s w aa bb RET 3. M-< 4. M-% aa bb RET xx RET I observe that the "aabb" part is lazy-highlighted, but obviously it should not be, because the query-replace will never get there (it's doing a normal search, not a word-type one). [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [208.118.235.92 listed in psbl.surriel.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dmoncayo[at]gmail.com) 0.8 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Recipe from "emacs -Q": 1. aa bb RET RET aa RET bb RET 2. C-s M-s w aa bb RET 3. M-< 4. M-% aa bb RET xx RET I observe that the "aabb" part is lazy-highlighted, but obviously it should not be, because the query-replace will never get there (it's doing a normal search, not a word-type one). In GNU Emacs 24.0.93.1 (i386-mingw-nt6.1.7601) of 2012-02-14 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-gcc (4.6)' -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 06:48:07 2012 Received: (at 10887) by debbugs.gnu.org; 27 Feb 2012 11:48:07 +0000 Received: from localhost ([127.0.0.1]:59134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1z3l-0001kd-Nj for submit@debbugs.gnu.org; Mon, 27 Feb 2012 06:48:06 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:53376 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1z3g-0001k7-Ov for 10887@debbugs.gnu.org; Mon, 27 Feb 2012 06:48:02 -0500 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 87CBA451C0B6; Mon, 27 Feb 2012 03:43:29 -0800 (PST) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#10887: 24.0.93; lazy-highlighting in `query-replace' after a word-type Isearch Organization: JURTA References: Date: Mon, 27 Feb 2012 12:57:27 +0200 In-Reply-To: (Dani Moncayo's message of "Sun, 26 Feb 2012 11:03:35 +0100") Message-ID: <87d3904ibw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10887 Cc: 10887@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Recipe from "emacs -Q": > 1. aa bb RET RET aa RET bb RET > 2. C-s M-s w aa bb RET > 3. M-< > 4. M-% aa bb RET xx RET > > I observe that the "aabb" part is lazy-highlighted, but obviously > it should not be, because the query-replace will never get there (it's > doing a normal search, not a word-type one). Thanks for the report. For 24.1 it could be fixed with the patch below. (In 24.2 for the true "word-replace" `replace-highlight' may need a new argument `word' that will use isearch word mode for lazy-highlighting.) === modified file 'lisp/replace.el' --- lisp/replace.el 2012-02-24 22:46:57 +0000 +++ lisp/replace.el 2012-02-27 10:54:20 +0000 @@ -2117,13 +2114,13 @@ (defun replace-highlight (match-beg matc (if query-replace-lazy-highlight (let ((isearch-string string) (isearch-regexp regexp) + ;; Set isearch-word to nil because word-replace is regexp-based, + ;; so `isearch-search-fun' should not use `word-search-forward'. + (isearch-word nil) (search-whitespace-regexp nil) (isearch-case-fold-search case-fold) (isearch-forward t) (isearch-error nil)) - ;; Set isearch-word to nil because word-replace is regexp-based, - ;; so `isearch-search-fun' should not use `word-search-forward'. - (if (and isearch-word isearch-regexp) (setq isearch-word nil)) (isearch-lazy-highlight-new-loop range-beg range-end)))) (defun replace-dehighlight () From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 08:25:54 2012 Received: (at 10887) by debbugs.gnu.org; 27 Feb 2012 13:25:54 +0000 Received: from localhost ([127.0.0.1]:59232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S20aP-0004lD-CU for submit@debbugs.gnu.org; Mon, 27 Feb 2012 08:25:53 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:41516) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S20aL-0004l0-8X for 10887@debbugs.gnu.org; Mon, 27 Feb 2012 08:25:50 -0500 Received: by obbeh20 with SMTP id eh20so1185093obb.3 for <10887@debbugs.gnu.org>; Mon, 27 Feb 2012 05:22:57 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.182.160.65 as permitted sender) client-ip=10.182.160.65; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.182.160.65 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.182.160.65]) by 10.182.160.65 with SMTP id xi1mr4872101obb.40.1330348977715 (num_hops = 1); Mon, 27 Feb 2012 05:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=f4NNBjiawH64WMDonjLADz2YFEEJppm6Q4xpQSsogjw=; b=hrof1mLsQDQTf52LmBmjOKAhzltlEQxwfuuacZd0P6VdXieXsZuPm12Cjmdn/uRVQV rcAv8i8KTykuBlkZe5+SF5DJLjAKG/Tp2e9DUUSYTggCIbBMEzUmMPKk+ImUGQuRkkiE 17WVOvSk4yTxZU7/ZcPL/2UEGB8LvacpuZ6nk= MIME-Version: 1.0 Received: by 10.182.160.65 with SMTP id xi1mr4362599obb.40.1330348977670; Mon, 27 Feb 2012 05:22:57 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 27 Feb 2012 05:22:57 -0800 (PST) In-Reply-To: <87d3904ibw.fsf@mail.jurta.org> References: <87d3904ibw.fsf@mail.jurta.org> Date: Mon, 27 Feb 2012 14:22:57 +0100 Message-ID: Subject: Re: bug#10887: 24.0.93; lazy-highlighting in `query-replace' after a word-type Isearch From: Dani Moncayo To: Juri Linkov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10887 Cc: 10887@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> Recipe from "emacs -Q": >> 1. aa bb RET RET aa RET bb RET >> 2. C-s M-s w aa bb RET >> 3. M-< >> 4. M-% aa bb RET xx RET >> >> I observe that the "aabb" part is lazy-highlighted, but obviously >> it should not be, because the query-replace will never get there (it's >> doing a normal search, not a word-type one). > > Thanks for the report. =A0For 24.1 it could be fixed with the patch below= . I've done a quick test, and it seems to work. Thanks. > (In 24.2 for the true "word-replace" `replace-highlight' may need a new > argument `word' that will use isearch word mode for lazy-highlighting.) I'm looking forward for this true "word-replace". :) --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 11 07:00:39 2012 Received: (at 10887) by debbugs.gnu.org; 11 Mar 2012 11:00:39 +0000 Received: from localhost ([127.0.0.1]:44543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6gVk-0000nR-MA for submit@debbugs.gnu.org; Sun, 11 Mar 2012 07:00:39 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:35086 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S6gVT-0000lu-57 for 10887@debbugs.gnu.org; Sun, 11 Mar 2012 07:00:23 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9C3F9451C078; Sun, 11 Mar 2012 03:28:21 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#10887: 24.0.93; lazy-highlighting in `query-replace' after a word-type Isearch Organization: JURTA References: <87d3904ibw.fsf@mail.jurta.org> Date: Sun, 11 Mar 2012 12:29:36 +0200 In-Reply-To: <87d3904ibw.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 27 Feb 2012 12:57:27 +0200") Message-ID: <87fwdfctwv.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10887 Cc: 10887@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Thanks for the report. For 24.1 it could be fixed with the patch below. > (In 24.2 for the true "word-replace" `replace-highlight' may need a new > argument `word' that will use isearch word mode for lazy-highlighting.) Patch committed now. I'm not closing this report to leave it as a reminder to add the argument `word' in 24.2. This also depends on using `word-search-regexp' in `perform-replace' as proposed in bug#10885. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 06 04:57:12 2012 Received: (at 10887-done) by debbugs.gnu.org; 6 Sep 2012 08:57:12 +0000 Received: from localhost ([127.0.0.1]:42147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9Xtg-0004vP-3K for submit@debbugs.gnu.org; Thu, 06 Sep 2012 04:57:12 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:51332 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T9Xtd-0004vD-3C for 10887-done@debbugs.gnu.org; Thu, 06 Sep 2012 04:57:10 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id EE206451CC4B; Thu, 6 Sep 2012 01:56:56 -0700 (PDT) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#10887: 24.0.93; lazy-highlighting in `query-replace' after a word-type Isearch Organization: JURTA References: <87d3904ibw.fsf@mail.jurta.org> <87fwdfctwv.fsf@mail.jurta.org> Date: Thu, 06 Sep 2012 11:54:31 +0300 In-Reply-To: <87fwdfctwv.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 11 Mar 2012 12:29:36 +0200") Message-ID: <87wr07pm48.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10887-done Cc: 10887-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I'm not closing this report to leave it as a reminder to add the > argument `word' in 24.2. This also depends on using `word-search-regexp' > in `perform-replace' as proposed in bug#10885. After adding this argument to `replace-highlight' in bug#10885, this report can be closed now. From unknown Fri Aug 15 14:18:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Oct 2012 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator