From unknown Sun Jun 22 20:58:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10882: bs cannot recover from error splitting Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2012 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 10882@debbugs.gnu.org X-Debbugs-Original-To: Bug-Gnu-Emacs Received: via spool by submit@debbugs.gnu.org id=B.1330109145740 (code B ref -1); Fri, 24 Feb 2012 18:46:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2012 18:45:45 +0000 Received: from localhost ([127.0.0.1]:54481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S109J-0000Bl-2l for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:45:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53059) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S109H-0000BY-OQ for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:45:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S106d-0003EL-Bk for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:43:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:38991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S106d-0003EH-63 for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:42:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S106c-0006qs-0p for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 13:42:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S106a-0003E4-Rs for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 13:42:57 -0500 Received: from mail-pw0-f41.google.com ([209.85.160.41]:60225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S106a-0003Dx-JT for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 13:42:56 -0500 Received: by pbcwz17 with SMTP id wz17so3099561pbc.0 for ; Fri, 24 Feb 2012 10:42:55 -0800 (PST) Received-SPF: pass (google.com: domain of lekktu@gmail.com designates 10.68.135.34 as permitted sender) client-ip=10.68.135.34; Authentication-Results: mr.google.com; spf=pass (google.com: domain of lekktu@gmail.com designates 10.68.135.34 as permitted sender) smtp.mail=lekktu@gmail.com; dkim=pass header.i=lekktu@gmail.com Received: from mr.google.com ([10.68.135.34]) by 10.68.135.34 with SMTP id pp2mr10187818pbb.106.1330108975278 (num_hops = 1); Fri, 24 Feb 2012 10:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=hs2CVJ4QAs1J6IuRm4BpT0UJoMP3PAXmYnvdr3ewZ3c=; b=u8N7GuhukgaAbzSGMYVzTfcHL6vGsg7XFT3gvkDCwkccA3Tqoo8R35+GBHKxTe9CXQ dWsj5GopxUtUUc1fkA+M5TFqJbCPFJuNnsdwmu9b4QTtnwmE7CTyC5+z2t5HQ+2zE+0G NyliMLQngdpWkQYDmUbVjJqcouv0k9wFitUoQ= Received: by 10.68.135.34 with SMTP id pp2mr8411086pbb.106.1330108975238; Fri, 24 Feb 2012 10:42:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.241.5 with HTTP; Fri, 24 Feb 2012 10:42:15 -0800 (PST) From: Juanma Barranquero Date: Fri, 24 Feb 2012 19:42:15 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.1 (-) Package: emacs Severity: minor emacs -Q C-x 2 C-x b test M-: (setq window-size-fixed 'height) ;; in buffer "test" M-x bs-show =3D> Window # too small for spli= tting ;; ok, let's kill that window C-x 0 ;; now the only window shows "*scrach*" M-x bs-show =3D> we're back to the old config and the "too small" e= rror. The problem is that bs--show-with-configuration errs out, so bs-show ends and the saved configuration is never reset to nil. Each new attempt to use bs-show finds a saved configuration and restores it before anything else. The simplest way to fix it is using ignore-errors to protect against split-window-below failing, so the code acts as if the window was too small in the first place. It causes no harm because, once bs-show is exited normally, the current window configuration is restored. OK to install now? =C2=A0 =C2=A0 Juanma =3D=3D=3D modified file 'lisp/bs.el' --- lisp/bs.el 2012-01-19 07:21:25 +0000 +++ lisp/bs.el 2012-02-24 18:37:28 +0000 @@ -1415,5 +1415,5 @@ (setq bs--window-config-coming-from (current-window-configuration)) (when (> (window-height (selected-window)) 7) - (select-window (split-window-below)))) + (ignore-errors (select-window (split-window-below))))) (bs-show-in-buffer liste) (bs-message-without-log "%s" (bs--current-config-message))))) From unknown Sun Jun 22 20:58:09 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juanma Barranquero Subject: bug#10882: closed (Re: bug#10882: bs cannot recover from error splitting) Message-ID: References: X-Gnu-PR-Message: they-closed 10882 X-Gnu-PR-Package: emacs Reply-To: 10882@debbugs.gnu.org Date: Sat, 25 Feb 2012 23:32:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1330212723-18140-1" This is a multi-part message in MIME format... ------------=_1330212723-18140-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #10882: bs cannot recover from error splitting which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 10882@debbugs.gnu.org. --=20 10882: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D10882 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1330212723-18140-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 10882-done) by debbugs.gnu.org; 25 Feb 2012 23:31:22 +0000 Received: from localhost ([127.0.0.1]:56525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1R5G-0004hm-2K for submit@debbugs.gnu.org; Sat, 25 Feb 2012 18:31:22 -0500 Received: from mail-pw0-f44.google.com ([209.85.160.44]:34088) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1R5D-0004he-Rp for 10882-done@debbugs.gnu.org; Sat, 25 Feb 2012 18:31:20 -0500 Received: by pbcwz7 with SMTP id wz7so3544095pbc.3 for <10882-done@debbugs.gnu.org>; Sat, 25 Feb 2012 15:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of lekktu@gmail.com designates 10.68.193.136 as permitted sender) client-ip=10.68.193.136; Authentication-Results: mr.google.com; spf=pass (google.com: domain of lekktu@gmail.com designates 10.68.193.136 as permitted sender) smtp.mail=lekktu@gmail.com; dkim=pass header.i=lekktu@gmail.com Received: from mr.google.com ([10.68.193.136]) by 10.68.193.136 with SMTP id ho8mr23454220pbc.148.1330212516540 (num_hops = 1); Sat, 25 Feb 2012 15:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=ffuwLyH5XUXEt9MknqW6GQEszO40AcNpRqDI3/dGOSI=; b=hJnab88wCh5bwuGefT8l6LilIeGsMU7hhqOWsjDRuuP1+JOFREczfUu5bGmCY0A7C+ +tmoNYxv+inhY7UupdqLOpcYeaiXyijanNJzHW2Pdi5RGO99B06ThHjZP+m6RLfpN3pd 5np4qvRgOtK5g0IyWIw7L3IBa1pZAlywNgHZ8= Received: by 10.68.193.136 with SMTP id ho8mr19749069pbc.148.1330212516184; Sat, 25 Feb 2012 15:28:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.241.5 with HTTP; Sat, 25 Feb 2012 15:27:56 -0800 (PST) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 26 Feb 2012 00:27:56 +0100 Message-ID: Subject: Re: bug#10882: bs cannot recover from error splitting To: 10882-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10882-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Committed in revno:107431. ------------=_1330212723-18140-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Feb 2012 18:45:45 +0000 Received: from localhost ([127.0.0.1]:54481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S109J-0000Bl-2l for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:45:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53059) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S109H-0000BY-OQ for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:45:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S106d-0003EL-Bk for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:43:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:38991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S106d-0003EH-63 for submit@debbugs.gnu.org; Fri, 24 Feb 2012 13:42:59 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S106c-0006qs-0p for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 13:42:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S106a-0003E4-Rs for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 13:42:57 -0500 Received: from mail-pw0-f41.google.com ([209.85.160.41]:60225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S106a-0003Dx-JT for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 13:42:56 -0500 Received: by pbcwz17 with SMTP id wz17so3099561pbc.0 for ; Fri, 24 Feb 2012 10:42:55 -0800 (PST) Received-SPF: pass (google.com: domain of lekktu@gmail.com designates 10.68.135.34 as permitted sender) client-ip=10.68.135.34; Authentication-Results: mr.google.com; spf=pass (google.com: domain of lekktu@gmail.com designates 10.68.135.34 as permitted sender) smtp.mail=lekktu@gmail.com; dkim=pass header.i=lekktu@gmail.com Received: from mr.google.com ([10.68.135.34]) by 10.68.135.34 with SMTP id pp2mr10187818pbb.106.1330108975278 (num_hops = 1); Fri, 24 Feb 2012 10:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=hs2CVJ4QAs1J6IuRm4BpT0UJoMP3PAXmYnvdr3ewZ3c=; b=u8N7GuhukgaAbzSGMYVzTfcHL6vGsg7XFT3gvkDCwkccA3Tqoo8R35+GBHKxTe9CXQ dWsj5GopxUtUUc1fkA+M5TFqJbCPFJuNnsdwmu9b4QTtnwmE7CTyC5+z2t5HQ+2zE+0G NyliMLQngdpWkQYDmUbVjJqcouv0k9wFitUoQ= Received: by 10.68.135.34 with SMTP id pp2mr8411086pbb.106.1330108975238; Fri, 24 Feb 2012 10:42:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.241.5 with HTTP; Fri, 24 Feb 2012 10:42:15 -0800 (PST) From: Juanma Barranquero Date: Fri, 24 Feb 2012 19:42:15 +0100 Message-ID: Subject: bs cannot recover from error splitting To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.1 (-) Package: emacs Severity: minor emacs -Q C-x 2 C-x b test M-: (setq window-size-fixed 'height) ;; in buffer "test" M-x bs-show =3D> Window # too small for spli= tting ;; ok, let's kill that window C-x 0 ;; now the only window shows "*scrach*" M-x bs-show =3D> we're back to the old config and the "too small" e= rror. The problem is that bs--show-with-configuration errs out, so bs-show ends and the saved configuration is never reset to nil. Each new attempt to use bs-show finds a saved configuration and restores it before anything else. The simplest way to fix it is using ignore-errors to protect against split-window-below failing, so the code acts as if the window was too small in the first place. It causes no harm because, once bs-show is exited normally, the current window configuration is restored. OK to install now? =C2=A0 =C2=A0 Juanma =3D=3D=3D modified file 'lisp/bs.el' --- lisp/bs.el 2012-01-19 07:21:25 +0000 +++ lisp/bs.el 2012-02-24 18:37:28 +0000 @@ -1415,5 +1415,5 @@ (setq bs--window-config-coming-from (current-window-configuration)) (when (> (window-height (selected-window)) 7) - (select-window (split-window-below)))) + (ignore-errors (select-window (split-window-below))))) (bs-show-in-buffer liste) (bs-message-without-log "%s" (bs--current-config-message))))) ------------=_1330212723-18140-1--