From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 12:10:35 2012 Received: (at submit) by debbugs.gnu.org; 24 Feb 2012 17:10:35 +0000 Received: from localhost ([127.0.0.1]:54396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0yfD-0003v9-GV for submit@debbugs.gnu.org; Fri, 24 Feb 2012 12:10:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48186) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0yfA-0003uw-FM for submit@debbugs.gnu.org; Fri, 24 Feb 2012 12:10:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0ycW-0004FJ-2e for submit@debbugs.gnu.org; Fri, 24 Feb 2012 12:07:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:40514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0ycV-0004FF-UD for submit@debbugs.gnu.org; Fri, 24 Feb 2012 12:07:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0ycR-0008K4-L1 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0ycL-0004EY-QV for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:07:43 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:24866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0ycL-0004EM-Jq for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:07:37 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q1OH7XFh009259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Feb 2012 17:07:34 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q1OH7XYn000735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 24 Feb 2012 17:07:33 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q1OH7W3N012123 for ; Fri, 24 Feb 2012 11:07:32 -0600 Received: from dradamslap1 (/10.159.39.252) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Feb 2012 09:07:32 -0800 From: "Drew Adams" To: Subject: 24.0.93; doc for `find-file' et al is missing the return value Date: Fri, 24 Feb 2012 09:07:28 -0800 Message-ID: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AczzFsm0l10TEXtQQcuKZY1JVTFUew== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-CT-RefId: str=0001.0A090207.4F47C3D6.0116,ss=1,re=0.000,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) There are several places in the Emacs source code where `find-file' and similar commands are used programmatically - typically when defining other commands, such as `find-file-read-only'. Similarly, 3rd-party code can sometimes use such a command programmatically, for similar reasons. Code such as the definition of `find-file-read-only' uses the return value of `find-file'. The bug is that this return value is not documented - it should be. The return value is documented only for `find-file-noselect'. It would be sufficient for the `find-file' et al doc to say that the return value of the function is the same as for `find-find-noselect'. Please add this info to the doc strings and the Elisp manual doc for the `find-file' family of commands. In GNU Emacs 24.0.93.1 (i386-mingw-nt5.1.2600) of 2012-02-15 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 22:57:05 2012 Received: (at 10879) by debbugs.gnu.org; 25 Feb 2012 03:57:05 +0000 Received: from localhost ([127.0.0.1]:54880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S18kq-0006km-TD for submit@debbugs.gnu.org; Fri, 24 Feb 2012 22:57:05 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:52757) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S18ko-0006kf-M8 for 10879@debbugs.gnu.org; Fri, 24 Feb 2012 22:57:03 -0500 Received: from bb116-14-103-36.singnet.com.sg ([116.14.103.36]:55275 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S18iG-0007CD-Ql; Fri, 24 Feb 2012 22:54:25 -0500 From: Chong Yidong To: "Drew Adams" Subject: Re: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> Date: Sat, 25 Feb 2012 11:54:17 +0800 In-Reply-To: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> (Drew Adams's message of "Fri, 24 Feb 2012 09:07:28 -0800") Message-ID: <87wr7by3di.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10879 Cc: 10879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) "Drew Adams" writes: > There are several places in the Emacs source code where `find-file' and > similar commands are used programmatically - typically when defining > other commands, such as `find-file-read-only'. > > Similarly, 3rd-party code can sometimes use such a command > programmatically, for similar reasons. > > Code such as the definition of `find-file-read-only' uses the return > value of `find-file'. The bug is that this return value is not > documented - it should be. I think we've been through this before. We don't want to have to commit ourselves to crap like (defun foo () "The return value is nil." ... (message "Some message we added later") nil) If the return value of a function is not documented, don't rely on it---doing so is a bug in your code. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 01:06:26 2012 Received: (at 10879) by debbugs.gnu.org; 25 Feb 2012 06:06:26 +0000 Received: from localhost ([127.0.0.1]:54979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1Am1-0003cw-Ms for submit@debbugs.gnu.org; Sat, 25 Feb 2012 01:06:26 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:42010) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1Aly-0003co-Op for 10879@debbugs.gnu.org; Sat, 25 Feb 2012 01:06:24 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q1P63hq8005720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 25 Feb 2012 06:03:44 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q1P63g6m016022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 25 Feb 2012 06:03:42 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q1P63fpg011504; Sat, 25 Feb 2012 00:03:41 -0600 Received: from dradamslap1 (/10.159.40.183) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Feb 2012 22:03:41 -0800 From: "Drew Adams" To: "'Chong Yidong'" References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> <87wr7by3di.fsf@gnu.org> Subject: RE: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value Date: Fri, 24 Feb 2012 22:03:34 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87wr7by3di.fsf@gnu.org> Thread-Index: AczzcSx6/w53LPBUT+2uqVV7HuNLvQAEM0FQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-CT-RefId: str=0001.0A090203.4F4879C0.007E,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 10879 Cc: 10879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > There are several places in the Emacs source code where > > `find-file' and similar commands are used programmatically > > - typically when defining other commands, such as > > `find-file-read-only'. > > > > Similarly, 3rd-party code can sometimes use such a command > > programmatically, for similar reasons. > > > > Code such as the definition of `find-file-read-only' uses the return > > value of `find-file'. The bug is that this return value is not > > documented - it should be. > > I think we've been through this before. We don't want to > have to commit ourselves to crap like > > (defun foo () > "The return value is nil." > ... > (message "Some message we added later") > nil) > > If the return value of a function is not documented, don't rely on > it---doing so is a bug in your code. Maybe you didn't notice the part about the Emacs sources doing this - and why they do so? The same context in which Emacs source code might do such a thing applies to 3rd-party code. The same reasons apply. Or are you arguing that there are never any such reasons, and that all such occurrences in the Emacs source code are "crap" and bugs? If so, then please change this bug to a code bug from a doc bug. I don't think that the return value of these particular functions (yes, commands) is fortuitous. Do you? Would you like to change the code of these particular commands so they do not take advantage of the return value? Even mapping over it when a list of buffers is returned due to wildcards? You cannot legitimately have it both ways: it is useful for Emacs source coders but not for 3rd-party coders. Either it is "crap" for both or useful for both. In the former case, please correct the source code. In the latter case, please document the return value. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 04:51:23 2012 Received: (at 10879) by debbugs.gnu.org; 25 Feb 2012 09:51:23 +0000 Received: from localhost ([127.0.0.1]:55123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1EHj-0000wx-Ns for submit@debbugs.gnu.org; Sat, 25 Feb 2012 04:51:23 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:8128) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1EHi-0000wr-KK for 10879@debbugs.gnu.org; Sat, 25 Feb 2012 04:51:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAKU/KE9MCodT/2dsb2JhbACBX5x7eYhwnhmGGQSGUJRJhAs X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="164543859" Received: from 76-10-135-83.dsl.teksavvy.com (HELO pastel.home) ([76.10.135.83]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Feb 2012 04:48:43 -0500 Received: by pastel.home (Postfix, from userid 20848) id 37EB259673; Sat, 25 Feb 2012 04:48:43 -0500 (EST) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value Message-ID: References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> <87wr7by3di.fsf@gnu.org> Date: Sat, 25 Feb 2012 04:48:43 -0500 In-Reply-To: (Drew Adams's message of "Fri, 24 Feb 2012 22:03:34 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10879 Cc: 10879@debbugs.gnu.org, 'Chong Yidong' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > but not for 3rd-party coders. Either it is "crap" for both or useful > for both. It's crap. > In the former case, please correct the source code. Patches welcome, Even better if you install them yourself, Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 11:40:08 2012 Received: (at 10879) by debbugs.gnu.org; 25 Feb 2012 16:40:08 +0000 Received: from localhost ([127.0.0.1]:56381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1KfI-0003lZ-DO for submit@debbugs.gnu.org; Sat, 25 Feb 2012 11:40:08 -0500 Received: from acsinet15.oracle.com ([141.146.126.227]:49085) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1KfF-0003lP-Hu for 10879@debbugs.gnu.org; Sat, 25 Feb 2012 11:40:06 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q1PGbKuQ029319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 25 Feb 2012 16:37:23 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q1PGbIuX029587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 25 Feb 2012 16:37:18 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q1PGbIm2016314; Sat, 25 Feb 2012 10:37:18 -0600 Received: from dradamslap1 (/10.159.40.183) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 25 Feb 2012 08:37:17 -0800 From: "Drew Adams" To: "'Stefan Monnier'" References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com><87wr7by3di.fsf@gnu.org> Subject: RE: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value Date: Sat, 25 Feb 2012 08:37:10 -0800 Message-ID: <0A371FF1256B461F9D58E0D784C4751F@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Aczzoqs8MXymi0RQRsCOKLWas3houAANNAVQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4F490E44.0016,ss=1,re=0.000,fgs=0 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 10879 Cc: 10879@debbugs.gnu.org, 'Chong Yidong' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > but not for 3rd-party coders. Either it is "crap" for both > > or useful for both. > > It's crap. Interesting view. I guess the original Emacs coders were crap, then, since *each* of the `find-file-*' commands makes a point of returning the buffer(s). And this has been true since at least Emacs 20. And each time the code was rewritten/updated, the maintainers again made sure to return the buffer(s). Not just some inadvertent mistake, this crap. Here, for instance, is `find-file-read-only' for Emacs 20 & Emacs 24. The other `find-file-*' commands are all similar. 20: (defun find-file-read-only (filename &optional wildcards) "Edit file FILENAME but don't allow changes. Like \\[find-file] but marks buffer as read-only. Use \\[toggle-read-only] to permit editing." (interactive "fFind file read-only: \np") (find-file filename wildcards) (toggle-read-only 1) (current-buffer)) ; <==== make sure we return the buffer 24: (defun find-file-read-only (filename &optional wildcards) "Edit file FILENAME but don't allow changes. Like \\[find-file], but marks buffer as read-only. Use \\[toggle-read-only] to permit editing." (interactive (find-file-read-args "Find file read-only: " (confirm-nonexistent-file-or-buffer))) (unless (or (and wildcards find-file-wildcards (not (string-match "\\`/:" filename)) (string-match "[[*?]" filename)) (file-exists-p filename)) (error "%s does not exist" filename)) (let ((value (find-file filename wildcards))) ; <=== use return (mapc (lambda (b) (with-current-buffer b (toggle-read-only 1))) (if (listp value) value (list value))) value)) ; <============ make sure we return the buffer In the latter, the function not only takes pains to return the buffer(s). It also takes advantage of the fact that `find-file' does likewise. Maybe you also think it's crap for `switch-to-buffer' & compagnie to return the buffer, and that mention of that fact should be removed from the doc? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 00:11:11 2014 Received: (at 10879) by debbugs.gnu.org; 9 Feb 2014 05:11:11 +0000 Received: from localhost ([127.0.0.1]:58906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCMfe-00064V-V0 for submit@debbugs.gnu.org; Sun, 09 Feb 2014 00:11:11 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:58346) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCMfd-00064N-PN for 10879@debbugs.gnu.org; Sun, 09 Feb 2014 00:11:10 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCMfK-0005lv-UD; Sun, 09 Feb 2014 06:10:51 +0100 From: Lars Ingebrigtsen To: "Drew Adams" Subject: Re: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> <87wr7by3di.fsf@gnu.org> <0A371FF1256B461F9D58E0D784C4751F@us.oracle.com> Date: Sat, 08 Feb 2014 21:09:35 -0800 In-Reply-To: <0A371FF1256B461F9D58E0D784C4751F@us.oracle.com> (Drew Adams's message of "Sat, 25 Feb 2012 08:37:10 -0800") Message-ID: <87y51kc1o0.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WCMfK-0005lv-UD X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392527451.94312@PozrHlmNqOPl8oMBvAklVw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10879 Cc: 10879@debbugs.gnu.org, 'Chong Yidong' , 'Stefan Monnier' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) "Drew Adams" writes: > And each time the code was rewritten/updated, the maintainers again made sure to > return the buffer(s). Not just some inadvertent mistake, this crap. `find-file' now apparently returns either a list or a buffer now, so the missing return value is correct. Closing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 00:11:14 2014 Received: (at control) by debbugs.gnu.org; 9 Feb 2014 05:11:14 +0000 Received: from localhost ([127.0.0.1]:58909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCMfh-00064l-Ay for submit@debbugs.gnu.org; Sun, 09 Feb 2014 00:11:13 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:58352) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCMfg-00064d-9Y for control@debbugs.gnu.org; Sun, 09 Feb 2014 00:11:12 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCMfS-0005m6-MY for control@debbugs.gnu.org; Sun, 09 Feb 2014 06:10:59 +0100 Date: Sat, 08 Feb 2014 21:09:47 -0800 Message-Id: <87wqh4c1no.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #10879 X-MailScanner-ID: 1WCMfS-0005m6-MY X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392527459.18332@VaTfBJ3AbfAG/N/fi8rm/A X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 10879 wontfix close 10879 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 18:30:40 2014 Received: (at 10879) by debbugs.gnu.org; 10 Feb 2014 23:30:40 +0000 Received: from localhost ([127.0.0.1]:42099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WD0JB-0000hF-0u for submit@debbugs.gnu.org; Mon, 10 Feb 2014 18:30:37 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33369) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WD0J7-0000Wh-C7 for 10879@debbugs.gnu.org; Mon, 10 Feb 2014 18:30:33 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1ANUQux002930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Feb 2014 23:30:27 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1ANUOv9027653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 10 Feb 2014 23:30:25 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s1ANUOmv007784; Mon, 10 Feb 2014 23:30:24 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 10 Feb 2014 15:30:23 -0800 (PST) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> <87wr7by3di.fsf@gnu.org> <0A371FF1256B461F9D58E0D784C4751F@us.oracle.com> <87y51kc1o0.fsf@building.gnus.org> In-Reply-To: <87y51kc1o0.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 10879 Cc: 10879@debbugs.gnu.org, Chong Yidong , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > And each time the code was rewritten/updated, the maintainers > > again made sure to return the buffer(s). Not just some inadvertent > > mistake, this crap. >=20 > `find-file' now apparently returns either a list or a buffer now, so > the missing return value is correct. Closing. Huh? It has _always_ returned a list of buffers or a buffer. That changes nothing. Look at the doc string of `find-file-noselect'. That's what returns the list or buffer. And we document its return value as that list or buffer. As we should. And as we should for `find-file' et al. =20 Nothing changed; nothing fixed. Reopening. From unknown Thu Aug 14 21:53:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Mon, 10 Feb 2014 23:31:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 06:27:14 2014 Received: (at control) by debbugs.gnu.org; 11 Feb 2014 11:27:14 +0000 Received: from localhost ([127.0.0.1]:45854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WDBUf-0006Tm-Rk for submit@debbugs.gnu.org; Tue, 11 Feb 2014 06:27:14 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:39478) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WDBUe-0006Tc-82 for control@debbugs.gnu.org; Tue, 11 Feb 2014 06:27:12 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WDBUO-00069D-P4 for control@debbugs.gnu.org; Tue, 11 Feb 2014 12:26:57 +0100 Date: Tue, 11 Feb 2014 03:25:41 -0800 Message-Id: <87y51hlwlm.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #10879 X-MailScanner-ID: 1WDBUO-00069D-P4 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392722818.74823@U5ufkSNrQxodxWxfUXWyFQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 10879 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 11 20:04:42 2014 Received: (at 10879) by debbugs.gnu.org; 12 Feb 2014 01:04:42 +0000 Received: from localhost ([127.0.0.1]:48024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WDOFl-0000Fw-ON for submit@debbugs.gnu.org; Tue, 11 Feb 2014 20:04:42 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:2306) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WDOFi-0000Fe-J7 for 10879@debbugs.gnu.org; Tue, 11 Feb 2014 20:04:39 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpaAU/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgaxH5AOkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFFpaAU/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgaxH5AOkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="47363958" Received: from 69-165-160-20.dsl.teksavvy.com (HELO pastel.home) ([69.165.160.20]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Feb 2014 20:04:32 -0500 Received: by pastel.home (Postfix, from userid 20848) id 3D045602E2; Tue, 11 Feb 2014 20:04:31 -0500 (EST) From: Stefan Monnier To: Drew Adams Subject: Re: bug#10879: 24.0.93; doc for `find-file' et al is missing the return value Message-ID: References: <73CE0A02B9B0423CA105B7BF7417831B@us.oracle.com> <87wr7by3di.fsf@gnu.org> <0A371FF1256B461F9D58E0D784C4751F@us.oracle.com> <87y51kc1o0.fsf@building.gnus.org> Date: Tue, 11 Feb 2014 20:04:31 -0500 In-Reply-To: (Drew Adams's message of "Mon, 10 Feb 2014 15:30:23 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 10879 Cc: Lars Ingebrigtsen , Chong Yidong , 10879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > And as we should for `find-file' et al. No, find-file should basically never be called from Elisp, so there's no point documenting its return value. Stefan From unknown Thu Aug 14 21:53:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Mar 2014 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator