GNU bug report logs - #10878
"make dist" with read-only srcdir generates read-only tarball

Previous Next

Full log

View this message in rfc822 format

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Nick Bowler <nbowler <at> elliptictech.com>
Cc: 10878 <at> debbugs.gnu.org, Eric Blake <eblake <at> redhat.com>, automake-patches <at> gnu.org
Subject: bug#10878: "make dist" with read-only srcdir generates read-only tarball
Date: Sat, 25 Feb 2012 20:25:54 +0100

[Message part 1 (text/plain, inline)]

On 02/25/2012 07:10 PM, Nick Bowler wrote:
> Hi Stefano,
>
Hi Nick, and thanks for all the feedback.

> One comment below:
> 
> On 2012-02-25 14:39 +0100, Stefano Lattarini wrote:
> [...]
>> And here is the documentation about the fact that a dist-hook should be ready
>> to deal with read-only files.  I will apply the attached patch soonish to master
>> if there is no objection.
> [...]
>> +@noindent
>> +Note that the @code{dist-hook} recipe shouldn't assume that the
>> +regular files in the distribution directory are writable; this
>> +might not be the case if one is packaging from a read-only source
>> +tree, or when a @code{make distcheck} is being done.  So, if the
>> +@code{dist-hook} wants to modify the content of an existing file
>> +in the distribution directory, it should explicitly ensure to make
>> +it readable first:
>       ^^^^^^^^
>       writable
> 
> I also would drop the words "ensure to".
>
Good catches.

I've fixed that, started doing a couple of other improvements, and finally
basically re-wrote the patch (hopefully in a better way).  The new version
of the patch, that I've pushed, is attached.  This should settle the issue,
so I'll close this report by tomorrow if there are no further objection.

Thanks,
  Stefano

[0001-docs-improve-dist-hook-documentation.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.