GNU bug report logs - #10878
"make dist" with read-only srcdir generates read-only tarball

Previous Next

Full log

Message #77 received at 10878 <at> debbugs.gnu.org (full text, mbox):

From: Nick Bowler <nbowler <at> elliptictech.com>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 10878 <at> debbugs.gnu.org, Eric Blake <eblake <at> redhat.com>,
	automake-patches <at> gnu.org
Subject: Re: bug#10878: "make dist" with read-only srcdir generates read-only
	tarball
Date: Sat, 25 Feb 2012 13:10:03 -0500

Hi Stefano,

One comment below:

On 2012-02-25 14:39 +0100, Stefano Lattarini wrote:
[...]
> And here is the documentation about the fact that a dist-hook should be ready
> to deal with read-only files.  I will apply the attached patch soonish to master
> if there is no objection.
[...]
> +@noindent
> +Note that the @code{dist-hook} recipe shouldn't assume that the
> +regular files in the distribution directory are writable; this
> +might not be the case if one is packaging from a read-only source
> +tree, or when a @code{make distcheck} is being done.  So, if the
> +@code{dist-hook} wants to modify the content of an existing file
> +in the distribution directory, it should explicitly ensure to make
> +it readable first:
      ^^^^^^^^
      writable

I also would drop the words "ensure to".

Cheers,
-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.